Re: [PATCH 1/1] seccomp: Always "goto wait" if the list is empty

2021-04-13 Thread Rodrigo Campos
On Tue, Apr 13, 2021 at 7:54 PM Christian Brauner wrote: > > Fixes: 7cf97b1254550 > > Cc: sta...@vger.kernel.org # 5.9+ > > Signed-off-by: Rodrigo Campos > > --- > > So the agent will see the return value from > wait_for_completion_interruptible() and know that

Re: [PATCH 1/5] seccomp: Refactor notification handler to prepare for new semantics

2021-04-13 Thread Rodrigo Campos
This patch also fixes the bug I reported here: https://lore.kernel.org/lkml/20210413160151.3301-1-rodr...@kinvolk.io/T/ -- Rodrigo Campos --- Kinvolk GmbH | Adalbertstr.6a, 10999 Berlin | tel: +491755589364 Geschäftsführer/Directors: Alban Crequy, Chris Kühl, Iago López Galeiras

[PATCH 1/1] seccomp: Always "goto wait" if the list is empty

2021-04-13 Thread Rodrigo Campos
fd element on the list, we will add the fd before "goto wait". This issue is present since 5.9, when addfd was added. Fixes: 7cf97b1254550 Cc: sta...@vger.kernel.org # 5.9+ Signed-off-by: Rodrigo Campos --- kernel/seccomp.c | 19 ++- 1 file changed, 14 inserti

[PATCH 0/1] seccomp: Erroneous return on interrupted addfd ioctl()

2021-04-13 Thread Rodrigo Campos
kernels and applies cleany to 5.10.y, 5.11.y and current 5.12 (probably to others too, this part hasn't changed recently). Rodrigo Campos (1): seccomp: Always "goto wait" if the list is empty kernel/seccomp.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions

Re: [PATCH 0/5] Handle seccomp notification preemption

2021-03-23 Thread Rodrigo Campos
://lore.kernel.org/lkml/202012011322.26DCBC64F2@keescook/ > > Rodrigo Campos (1): > seccomp: Support atomic "addfd + send reply" > > Sargun Dhillon (4): > seccomp: Refactor notification handler to prepare for new semantics > seccomp: Add wait_killable semantic to seccomp

Re: seccomp: Delay filter activation

2021-03-19 Thread Rodrigo Campos
ers/runc/pull/2682/files#diff-f0214a0f16408fc7f168c6fc9837d189590025cc1813ebf7c1d751136936dfbfR172 -- Rodrigo Campos --- Kinvolk GmbH | Adalbertstr.6a, 10999 Berlin | tel: +491755589364 Geschäftsführer/Directors: Alban Crequy, Chris Kühl, Iago López Galeiras Registergericht/Court of registration: Amtsgericht Charlottenburg Regis

Re: [PATCH 5/5] selftests/seccomp: Add test for atomic addfd+send

2021-03-18 Thread Rodrigo Campos
On Thu, Mar 18, 2021 at 6:17 AM Sargun Dhillon wrote: > > This just adds a test to verify that when using the new introduced flag > to ADDFD, a valid fd is added and returned as the syscall result. > > Signed-off-by: Rodrigo Campos > Signed-off-by: Sargun Dhillon I think i

Re: [RFC PATCH 2/3] seccomp: Add wait_killable semantic to seccomp user notifier

2021-02-26 Thread Rodrigo Campos
/* Reset the waiting state */ > + if (knotif->wait_killable) { > + knotif->wait_killable = false; > + complete(&knotif->ready); > + } > + >

Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9)

2014-05-20 Thread Rodrigo Campos
On Tue, May 20, 2014 at 04:01:27PM +0200, Jiri Olsa wrote: > On Tue, May 20, 2014 at 01:00:17PM +0100, Rodrigo Campos wrote: > > On Tue, May 20, 2014 at 09:35:08AM +0200, Jiri Olsa wrote: > > > On Tue, May 20, 2014 at 04:06:43AM +0100, Rodrigo Campos wrote: > > > >

Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9)

2014-05-20 Thread Rodrigo Campos
On Tue, May 20, 2014 at 09:35:08AM +0200, Jiri Olsa wrote: > On Tue, May 20, 2014 at 04:06:43AM +0100, Rodrigo Campos wrote: > > On Tue, May 20, 2014 at 02:29:31AM +, Namhyung Kim wrote: > > > Hi Rodrigo, > > > > > > On Mon, May 19, 2014 at 3:11 PM, Rodr

Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9)

2014-05-19 Thread Rodrigo Campos
On Tue, May 20, 2014 at 02:29:31AM +, Namhyung Kim wrote: > Hi Rodrigo, > > On Mon, May 19, 2014 at 3:11 PM, Rodrigo Campos wrote: > > Is there something I can help to have this merged ? As far as I tested, this > > works fine here. Or is this ok, just waiting on the

Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9)

2014-05-19 Thread Rodrigo Campos
On Thu, Mar 20, 2014 at 02:36:25PM +0900, Namhyung Kim wrote: > Hello, > > This is a new attempt to implement cumulative hist period report. > This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely > rewrote it from scratch. > > This version depends on my previous percentage patch

Re: [PATCH 18/21] perf top: Convert to hist_entry_iter

2014-02-07 Thread Rodrigo Campos
On Fri, Feb 07, 2014 at 10:35:20AM +0900, Namhyung Kim wrote: > Reuse hist_entry_iter__add() function to share the similar code with > perf report. Note that it needs to be called with hists.lock so tweak > some internal functions not to deadlock or hold the lock too long. > > Tested-by: Arun Sha

Re: [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v8)

2014-02-06 Thread Rodrigo Campos
On Fri, Feb 07, 2014 at 10:35:02AM +0900, Namhyung Kim wrote: > > Currently the perf enables both of --call-graph and --children when it > finds callchains in the samples. While this is useful for TUI or GTK, > I'm not sure for stdio as it'd consume so much lines. > > It does not handle all kind

[tip:perf/core] perf tools: Remove unneeded include

2013-11-07 Thread tip-bot for Rodrigo Campos
Commit-ID: 8ce000e83848578a621d64eccdc88bd34c2fc70c Gitweb: http://git.kernel.org/tip/8ce000e83848578a621d64eccdc88bd34c2fc70c Author: Rodrigo Campos AuthorDate: Wed, 6 Nov 2013 22:20:54 + Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 7 Nov 2013 11:51:19 -0300 perf tools

[PATCH] perf: Remove unneeded include

2013-11-06 Thread Rodrigo Campos
by mistake on sort.h too. Signed-off-by: Rodrigo Campos --- tools/perf/util/sort.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h index f4cc147..43e5ff4 100644 --- a/tools/perf/util/sort.h +++ b/tools/perf/util/sort.h @@ -22,7 +22,6 @@ #inc

Re: [PATCH 01/10] perf hists: Consolidate __hists__add_*entry()

2013-11-06 Thread Rodrigo Campos
On Wed, Nov 06, 2013 at 05:16:04PM +0900, Namhyung Kim wrote: > Hi Rodrigo, > > On Tue, 5 Nov 2013 21:52:43 +, Rodrigo Campos wrote: > > On Tue, Nov 05, 2013 at 05:09:52PM -0300, Arnaldo Carvalho de Melo wrote: > >> @@ -486,15 +425,15 @@ struct hist_entry *__hists

Re: [PATCH 01/10] perf hists: Consolidate __hists__add_*entry()

2013-11-05 Thread Rodrigo Campos
On Tue, Nov 05, 2013 at 05:09:52PM -0300, Arnaldo Carvalho de Melo wrote: > @@ -486,15 +425,15 @@ struct hist_entry *__hists__add_entry(struct hists > *hists, > .ip = al->addr, > .level = al->level, > .stat = { > - .period = period

Re: [PATCH 08/14] perf report: Cache cumulative callchains

2013-11-01 Thread Rodrigo Campos
On Fri, Nov 01, 2013 at 04:07:22PM +0900, Namhyung Kim wrote: > Hi Rodrigo, > > On Thu, 31 Oct 2013 11:13:34 +, Rodrigo Campos wrote: > > On Thu, Oct 31, 2013 at 03:56:10PM +0900, Namhyung Kim wrote: > > I think the right fix is assigning "iter->priv = NULL&q

Re: [PATCH 08/14] perf report: Cache cumulative callchains

2013-11-01 Thread Rodrigo Campos
On Fri, Nov 01, 2013 at 04:07:22PM +0900, Namhyung Kim wrote: > Hi Rodrigo, > > On Thu, 31 Oct 2013 11:13:34 +, Rodrigo Campos wrote: > > On Thu, Oct 31, 2013 at 03:56:10PM +0900, Namhyung Kim wrote: > >> @@ -538,6 +586,7 @@ iter_finish_cumulative_entry(struct ad

Re: [PATCH 08/14] perf report: Cache cumulative callchains

2013-10-31 Thread Rodrigo Campos
On Thu, Oct 31, 2013 at 03:56:10PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > It is possble that a callchain has cycles or recursive calls. In that > case it'll end up having entries more than 100% overhead in the > output. In order to prevent such entries, cache each callchain node >

Re: State of "perf: Add a new sort order: SORT_INCLUSIVE"

2013-10-28 Thread Rodrigo Campos
On Mon, Oct 28, 2013 at 06:09:30PM +0900, Namhyung Kim wrote: > On Mon, 28 Oct 2013 08:42:44 +0000, Rodrigo Campos wrote: > > On Mon, Oct 28, 2013 at 02:09:49PM +0900, Namhyung Kim wrote: > >> Anyway, You can find the series and discussion on the link below: > >> > &

Re: State of "perf: Add a new sort order: SORT_INCLUSIVE"

2013-10-28 Thread Rodrigo Campos
On Mon, Oct 28, 2013 at 02:09:49PM +0900, Namhyung Kim wrote: > Hi Rodrigo, > > On Fri, 25 Oct 2013 16:07:21 +0100, Rodrigo Campos wrote: > > > > That will be useful for me and I was wondering if you are still working on > > that > > or if there is a newer

State of "perf: Add a new sort order: SORT_INCLUSIVE"

2013-10-25 Thread Rodrigo Campos
Hi Namhyung, Frederic Weisbecker and Arnaldo Carvalho de Melo told me on IRC that you were working to forward-port a patch that adds a new sort order to perf report, SORT_INCLUSIVE. That will be useful for me and I was wondering if you are still working on that or if there is a newer version than

Re: [PATCH] perf tools: Clarify error when running "perf lock record"

2013-09-05 Thread Rodrigo Campos
On Thu, Sep 05, 2013 at 08:29:10AM -0600, David Ahern wrote: > On 9/5/13 2:32 AM, Rodrigo Campos wrote: > >If you have the config options enabled in your kernel, you still need to be > >root > >to run perf lock. And is kind of misleading when you have that options > &

[PATCH] perf tools: Clarify error when running "perf lock record"

2013-09-05 Thread Rodrigo Campos
check if it's running as root or not, adding it to the error message is really simple and should be enough. Signed-off-by: Rodrigo Campos --- Please keep me in Cc: since I'm not subscribed --- tools/perf/builtin-lock.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di