Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-01-18 Thread Robin Schroer
> 1)); > + if ((spk_bleeps & 2) && (msg_id < edge_quiet)) { > + synth_printf("%s\n", > + spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1)); > + } > } > You do not actually need to add the braces as this remains a single statem

[PATCH -next] staging/goldfish/goldfish_audio: fix a sparse warning

2014-07-22 Thread Robin Schroer
Fix a pointer check to use NULL instead of 0 Warning: drivers/staging/goldfish/goldfish_audio.c:300:34: warning: Using plain integer as NULL pointer Signed-off-by: Robin Schroer --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 3/3] drivers/staging/bcm/Misc: style: removed void returns

2014-06-16 Thread Robin Schroer
Signed-off-by: Robin Schroer --- drivers/staging/bcm/Misc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c index a0637eb..a1c833c 100644 --- a/drivers/staging/bcm/Misc.c +++ b/drivers/staging/bcm/Misc.c @@ -21,7 +21,6 @@ static

[PATCH 1/3] drivers/staging/bcm/Misc: style: added blank lines after declarations

2014-06-16 Thread Robin Schroer
Signed-off-by: Robin Schroer --- drivers/staging/bcm/Misc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c index 7b2fa0f..f2bc699 100644 --- a/drivers/staging/bcm/Misc.c +++ b/drivers/staging/bcm/Misc.c @@ -28,6 +28,7

[PATCH 2/3] drivers/staging/bcm/Misc: style: removed duplicate parentheses

2014-06-16 Thread Robin Schroer
Signed-off-by: Robin Schroer --- drivers/staging/bcm/Misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c index f2bc699..a0637eb 100644 --- a/drivers/staging/bcm/Misc.c +++ b/drivers/staging/bcm/Misc.c @@ -284,7

[PATCH] drivers/staging/speakup/main: fixed jiffie comparison

2014-06-12 Thread Robin Schroer
speakup_key() used manual comparison of jiffies to determine the time since the last keypress, replaced it with time_after() Resend with kernel mailing list cc'ed (duh...) Signed-off-by: Robin Schroer --- drivers/staging/speakup/main.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [Intel-gfx] [PATCH] drivers/gpu/drm/i915/dma: style fixes

2014-06-02 Thread Robin Schroer
On Mon, Jun 02, 2014 at 05:21:32PM +0200, Daniel Vetter wrote: > On Mon, Jun 02, 2014 at 04:10:08PM +0100, Damien Lespiau wrote: > > On Mon, Jun 02, 2014 at 04:59:39PM +0200, Robin Schroer wrote: > > > Fixed several double space pointer notations, and added one newline > &g

[PATCH] drivers/gpu/drm/i915/dma: style fixes

2014-06-02 Thread Robin Schroer
Fixed several double space pointer notations, and added one newline Signed-off-by: Robin Schroer --- drivers/gpu/drm/i915/i915_dma.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915

[PATCH] driver/netfilter/nfnetlink: removed unused variable

2014-05-31 Thread Robin Schroer
Removes the unused struct net *net = sock_net(skb->sk); Signed-off-by: Robin Schroer --- net/netfilter/nfnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index c138b8f..5cc9db2 100644 --- a/net/netfilter/nfnetlink.c +++ b/

[PATCH] drivers/platform/chrome: coding style fixes

2014-05-29 Thread Robin Schroer
added blank lines after declarations in some places Signed-off-by: Robin Schroer --- drivers/platform/chrome/chromeos_laptop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c index 7f1a2e2..0e2785a

[PATCH] Staging/frontier/tranzport: coding style fixes

2014-05-28 Thread Robin Schroer
added newlines after declarations in two places Signed-off-by: Robin Schroer --- drivers/staging/frontier/tranzport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/frontier/tranzport.c b/drivers/staging/frontier/tranzport.c index 334ba04..2f86163 100644 --- a/drivers

[PATCH] drivers/gpu/drm/i915/intel_display: coding style fixes

2014-05-17 Thread Robin Schroer
Fixed several switch statements, curly braces, dereference operators and keywords. Signed-off-by: Robin Schroer --- drivers/gpu/drm/i915/intel_display.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu

[PATCH] drivers/hid/wacom: fixed coding style issues

2014-01-21 Thread Robin Schroer
Fixed some coding style issues regarding spaces before semicolons and closing parenthesis. Signed-off-by: Robin Schroer --- drivers/hid/hid-wacom.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c index 60c75dc