Re: restore splice and sendfile support on kernfs

2021-01-21 Thread Robert Karszniewicz
-- > 1 file changed, 24 insertions(+), 41 deletions(-) > Tested-by: Robert Karszniewicz Confirm that it fixes firmwared for me. Also, I am 100% sure that the commit that actually breaks firmwared for me is 4d03e3cc5982 ("fs: don't allow kernel reads and writes without ite

Re: Splicing to/from a tty

2021-01-21 Thread Robert Karszniewicz
On 1/20/21 5:44 AM, Linus Torvalds wrote: > On Tue, Jan 19, 2021 at 5:29 PM Oliver Giles wrote: >> >> Writing this from a kernel with those patches in; happily splice()ing >> to and from a pty. > > Ok, good. > > I have a couple of improvement patches on top of those, that I'm attaching > here.

Re: Splicing to/from a tty

2021-01-19 Thread Robert Karszniewicz
On 1/19/21 12:53 PM, Greg Kroah-Hartman wrote: > This looks sane, but I'm still missing what the goal of this is here. > It's nice from a "don't make the ldisc do the userspace copy", point of > view, but what is the next step in order to tie that into splice? > > I ask as I also have reports that

Re: Splicing to/from a tty

2021-01-19 Thread Robert Karszniewicz
On 1/19/21 5:56 PM, Robert Karszniewicz wrote: > Another case I've also noticed is writing to a serial connection: > kernel write not supported for file /ttymxc0 (pid: 252 comm: cat) Which is actually a TTY and I just failed to see the forest for all the trees... Cheers.