[PATCH] ccp: ccp - add support for Green Sardine

2021-04-16 Thread Rijo Thomas
From: Devaraj Rangasamy Add a new PCI device entry for Green Sardine APU. Signed-off-by: Devaraj Rangasamy Tested-by: Babulu Ellune Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/sp-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp

[PATCH v3] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-14 Thread Rijo Thomas
: 757cc3e9ff1d ("tee: add AMD-TEE driver") Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- v3: * Updated structure initialization list from {0} to preferred style {} v2: * Unload TA if get_ta_refcount() fails drivers/tee/amdtee/amdtee_private.h | 13 drivers/tee/amd

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-14 Thread Rijo Thomas
On 14/04/21 10:16 pm, Jens Wiklander wrote: > Hi Jiro, > > On Mon, Apr 12, 2021 at 12:20 PM Rijo Thomas wrote: >> >> >> >> On 12/04/21 1:06 pm, Jens Wiklander wrote: >>> On Mon, Apr 5, 2021 at 11:43 AM Rijo Thomas >>> wrote: >>>&g

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-12 Thread Rijo Thomas
On 12/04/21 1:06 pm, Jens Wiklander wrote: > On Mon, Apr 5, 2021 at 11:43 AM Rijo Thomas wrote: >> >> Same Trusted Application (TA) can be loaded in multiple TEE contexts. >> >> If it is a single instance TA, the TA should not get unloaded from AMD >> Secure Pr

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-12 Thread Rijo Thomas
On 09/04/21 2:15 pm, Dan Carpenter wrote: > On Mon, Apr 05, 2021 at 03:13:09PM +0530, Rijo Thomas wrote: >> @@ -340,7 +398,8 @@ int handle_open_session(struct >> tee_ioctl_open_session_arg *arg, u32 *info, >> >> int handle_load_ta(void *data, u32 size, struct

[PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-05 Thread Rijo Thomas
: 757cc3e9ff1d ("tee: add AMD-TEE driver") Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- v2: * Unload TA if get_ta_refcount() fails drivers/tee/amdtee/amdtee_private.h | 13 drivers/tee/amdtee/call.c | 94 ++--- drivers/tee/amd

Re: [PATCH] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-04 Thread Rijo Thomas
On 15/03/21 2:59 pm, Jens Wiklander wrote: > On Sun, Mar 07, 2021 at 12:05:01PM +0530, Rijo Thomas wrote: >> Same Trusted Application (TA) can be loaded in multiple TEE contexts. >> >> If it is a single instance TA, the TA should not get unloaded from AMD >> Secure P

Re: [PATCH v3 0/2] PSP TEE driver update and bug fixes

2021-04-04 Thread Rijo Thomas
On 26/03/21 2:59 pm, Herbert Xu wrote: > On Mon, Mar 15, 2021 at 01:55:27PM +0530, Rijo Thomas wrote: >> The first patch helps to improve the response time by reducing the >> polling time of the tee command status variable. >> >> Second patch is a bug fix to han

[PATCH v3 2/2] crypto: ccp - fix command queuing to TEE ring buffer

2021-03-15 Thread Rijo Thomas
TEE request from a client, then further command submission to queue will be disabled. Fixes: 33960acccfbd (crypto: ccp - add TEE support for Raven Ridge) Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/tee-dev.c | 49 +--- drivers

[PATCH v3 1/2] crypto: ccp - reduce tee command status polling interval from 5ms to 1ms

2021-03-15 Thread Rijo Thomas
The PSP TEE device driver polls the command status variable every 5ms to check for command completion. Reduce this time to 1ms so that there is an improvement in driver response time to clients which submit TEE commands. Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers

[PATCH v3 0/2] PSP TEE driver update and bug fixes

2021-03-15 Thread Rijo Thomas
helps to resolve that. v3: * Fixed checkpatch.pl warning v2: * Updated copyright year as a part of code change Rijo Thomas (2): crypto: ccp - reduce tee command status polling interval from 5ms to 1ms crypto: ccp - fix command queuing to TEE ring buffer drivers/crypto/ccp/tee-dev.c | 57

[PATCH v2 1/2] crypto: ccp - reduce tee command status polling interval from 5ms to 1ms

2021-03-09 Thread Rijo Thomas
The PSP TEE device driver polls the command status variable every 5ms to check for command completion. Reduce this time to 1ms so that there is an improvement in driver response time to clients which submit TEE commands. Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers

[PATCH v2 0/2] PSP TEE driver update and bug fixes

2021-03-09 Thread Rijo Thomas
helps to resolve that. v2: * Updated copyright year as a part of code change Rijo Thomas (2): crypto: ccp - reduce tee command status polling interval from 5ms to 1ms crypto: ccp - fix command queuing to TEE ring buffer drivers/crypto/ccp/tee-dev.c | 57

[PATCH v2 2/2] crypto: ccp - fix command queuing to TEE ring buffer

2021-03-09 Thread Rijo Thomas
TEE request from a client, then further command submission to queue will be disabled. Fixes: 33960acccfbd (crypto: ccp - add TEE support for Raven Ridge) Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/tee-dev.c | 49 +--- drivers/crypto/ccp/tee-dev.h | 20

Re: [PATCH 0/3] PSP TEE driver update and bug fixes

2021-03-09 Thread Rijo Thomas
On 09/03/21 10:06 pm, Tom Lendacky wrote: > On 3/9/21 2:11 AM, Rijo Thomas wrote: >> The first patch helps to improve the response time by reducing the >> polling time of the tee command status variable. >> >> Second patch is a bug fix to handle multi-threaded use-ca

Re: [PATCH 3/3] crypto: ccp - update copyright year for tee

2021-03-09 Thread Rijo Thomas
On 09/03/21 10:03 pm, Tom Lendacky wrote: > On 3/9/21 2:11 AM, Rijo Thomas wrote: >> Update the copyright year for PSP TEE driver files. >> >> Signed-off-by: Rijo Thomas > > The copyright updates really should occur as part of the changes in the > other pat

[PATCH 3/3] crypto: ccp - update copyright year for tee

2021-03-09 Thread Rijo Thomas
Update the copyright year for PSP TEE driver files. Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/tee-dev.c | 2 +- drivers/crypto/ccp/tee-dev.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/tee-dev.c b/drivers/crypto/ccp/tee-dev.c index

[PATCH 2/3] crypto: ccp - fix command queuing to TEE ring buffer

2021-03-09 Thread Rijo Thomas
TEE request from a client, then further command submission to queue will be disabled. Fixes: 33960acccfbd (crypto: ccp - add TEE support for Raven Ridge) Signed-off-by: Rijo Thomas --- drivers/crypto/ccp/tee-dev.c | 49 +--- drivers/crypto/ccp/tee-dev.h | 18

[PATCH 0/3] PSP TEE driver update and bug fixes

2021-03-09 Thread Rijo Thomas
helps to resolve that. Third patch is to update the copyright year for the tee driver files. Rijo Thomas (3): crypto: ccp - reduce tee command status polling interval from 5ms to 1ms crypto: ccp - fix command queuing to TEE ring buffer crypto: ccp - update copyright year for tee drivers

[PATCH 1/3] crypto: ccp - reduce tee command status polling interval from 5ms to 1ms

2021-03-09 Thread Rijo Thomas
The PSP TEE device driver polls the command status variable every 5ms to check for command completion. Reduce this time to 1ms so that there is an improvement in driver response time to clients which submit TEE commands. Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers

[PATCH] tee: amdtee: unload TA only when its refcount becomes 0

2021-03-06 Thread Rijo Thomas
: 757cc3e9ff1d ("tee: add AMD-TEE driver") Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers/tee/amdtee/amdtee_private.h | 13 + drivers/tee/amdtee/call.c | 73 +++-- drivers/tee/amdtee/core.c | 15 +++--- 3 files changed, 92

[PATCH 1/2] tee: amdtee: fix memory leak due to reset of global shm list

2020-11-03 Thread Rijo Thomas
("tee: add AMD-TEE driver") Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers/tee/amdtee/amdtee_private.h | 7 +++ drivers/tee/amdtee/core.c | 18 +++--- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/tee/amdtee/amdt

[PATCH 0/2] AMD-TEE driver bug fixes

2020-11-03 Thread Rijo Thomas
AMD-TEE driver keeps track of shared memory buffers and their corresponding buffer id's in a global linked list. These buffers are used to share data between x86 and AMD Secure Processor. This patchset fixes issues related to maintaining mapped buffers in a shared linked list. Rijo Thom

[PATCH 2/2] tee: amdtee: synchronize access to shm list

2020-11-03 Thread Rijo Thomas
Synchronize access to shm or shared memory buffer list to prevent race conditions due to concurrent updates to shared shm list by multiple threads. Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver") Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- drivers/tee/amdtee/amdtee