Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

2025-04-23 Thread Richard Fitzgerald
On 21/4/25 15:15, Charles Keepax wrote: On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add tristate prompt to allow codec selection. Signed-off-by: André Apitzsch --- Generally its good to say why one wants to make the symbol selectable, u

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-11 Thread Richard Fitzgerald
On 08/04/2025 10:25 am, Richard Fitzgerald wrote: On 19/03/2025 11:05 pm, Nico Pache wrote: FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit

[PATCH 3/3] firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it

2025-04-11 Thread Richard Fitzgerald
Signed-off-by: Richard Fitzgerald --- drivers/firmware/cirrus/Kconfig | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/firmware/cirrus/Kconfig b/drivers/firmware/cirrus/Kconfig index 0a883091259a..e3c2e38b746d 100644 --- a/drivers/firmware/cirrus/Kconfig +++ b/driver

[PATCH 1/3] kunit: configs: Add some Cirrus Logic modules to all_tests

2025-04-11 Thread Richard Fitzgerald
Add CONFIG_I2C and CONFIG_SND_SOC_CS35L56_I2C to all_tests.config so that Cirrus Logic modules with KUnit tests will be built. The CS35L56 driver doesn't currently have any KUnit tests itself, but it enables two other libraries that have KUnit tests: cs_dsp and cs-amp-lib. Signed-off-by: Ri

[PATCH 2/3] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB

2025-04-11 Thread Richard Fitzgerald
ned-off-by: Richard Fitzgerald --- sound/soc/codecs/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 870eb90116f1..c388676ce380 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -776

[PATCH 0/3] Fix up building KUnit tests for Cirrus Logic modules

2025-04-11 Thread Richard Fitzgerald
and 3 fixup the KConfig entries for cs_dsp and cs-amp-lib. Nico Pache (1): firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it Richard Fitzgerald (2): kunit: configs: Add some Cirrus Logic modules to all_tests ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB driver

[PATCH] kunit: configs: Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests

2025-04-11 Thread Richard Fitzgerald
Enable CONFIG_INIT_STACK_ALL_PATTERN in all_tests.config. This helps to detect use of uninitialized local variables. This option found an uninitialized data bug in the cs_dsp test. Signed-off-by: Richard Fitzgerald --- tools/testing/kunit/configs/all_tests.config | 1 + 1 file changed, 1

[PATCH] firmware: cs_dsp: test_bin_error: Fix uninitialized data used as fw version

2025-04-10 Thread Richard Fitzgerald
se of cs_dsp_mock_xm_header_get_fw_version_from_regmap() was cs_dsp_test_bin.c, but it doesn't need to use it. It already has a blob buffer containing the dummy XM header so it can use cs_dsp_mock_xm_header_get_fw_version() to read from that. Fixes: cd8c058499b6 ("firmware: cs_dsp: Add KUnit testing of bin error cases") Si

Re: [PATCH] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB

2025-04-09 Thread Richard Fitzgerald
On 09/04/2025 3:24 pm, Mark Brown wrote: On Wed, Apr 09, 2025 at 11:45:44AM +0100, Richard Fitzgerald wrote: Depend on SND_SOC_CS_AMP_LIB instead of selecting it. KUNIT_ALL_TESTS should only build tests for components that are already being built, it should not cause other stuff to be added to

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-08 Thread Richard Fitzgerald
On 19/03/2025 11:05 pm, Nico Pache wrote: FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling. Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KU

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-05 Thread Richard Fitzgerald
On 20/3/25 17:35, Nico Pache wrote: Sorry links got mangled Thanks. I'm on vacation right now but I'll take a look through all those when I have time. The unterminated string bugfix is this: https://lore.kernel.org/all/20250211-cs_dsp-kunit-strings-v1-1-d9bc2035d...@linutronix.de/ I got lucky

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-05 Thread Richard Fitzgerald
On 22/3/25 19:02, Richard Fitzgerald wrote: On 22/3/25 10:11, Richard Fitzgerald wrote: On 20/3/25 17:35, Nico Pache wrote: Sorry links got mangled Thanks. I'm on vacation right now but I'll take a look through all those when I have time. The unterminated string bugfix is t

[PATCH] firmware: cs_dsp: Ensure cs_dsp_load[_coeff]() returns 0 on success

2025-04-04 Thread Richard Fitzgerald
p_async_complete() wasn't necessary and was removed. It was overlooked that the ret here wasn't only to check the result of regmap_async_complete(), it also set the final return value of the function. Fixes: fe08b7d5085a ("firmware: cs_dsp: Remove async regmap writes") Si

[PATCH] clk: test: Forward-declare struct of_phandle_args in kunit/clk.h

2025-03-27 Thread Richard Fitzgerald
, void *data), Signed-off-by: Richard Fitzgerald --- include/kunit/clk.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/kunit/clk.h b/include/kunit/clk.h index 0afae7688157..f226044cc78d 100644 --- a/include/kunit/clk.h +++ b/include/kunit/clk.h @@ -6,6 +6,7 @@ struct clk; struct

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-22 Thread Richard Fitzgerald
On 22/3/25 10:11, Richard Fitzgerald wrote: On 20/3/25 17:35, Nico Pache wrote: Sorry links got mangled Thanks. I'm on vacation right now but I'll take a look through all those when I have time. The unterminated string bugfix is this: https://lore.kernel.org/all/20250211-cs_dsp-kun

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-22 Thread Richard Fitzgerald
On 21/3/25 15:01, Nico Pache wrote: I'm a little confused how the FW_CS_DSP config which was added in v5.16 is reliant (library code that is only used by KUNIT) on a config that was added in v6.14. Presumably the library is not just for the KUNIT test. What was the purpose of this config before t

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-20 Thread Richard Fitzgerald
On 19/3/25 23:11, Nico Pache wrote: On Wed, Mar 19, 2025 at 5:05 PM Nico Pache wrote: FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling.

Re: [RFC PATCH 1/2] ptp: add PTP_SYS_OFFSET_STAT for xtstamping with status

2025-01-02 Thread Richard Cochran
the VM host, right? In which case, the metrics do not provide any benefit to the guest. Or what am I missing? Thanks, Richard

Re: [RFC PATCH 1/2] ptp: add PTP_SYS_OFFSET_STAT for xtstamping with status

2024-12-25 Thread Richard Cochran
mined e.g. by virtualization host user space > software. The device driver would just expose the device metrics to user > space. Again, host user space shouldn't misuse the kernel to share random metrics with guest user space. Isn't there another way to share such info from host to guest? Thanks, Richard

Re: [RFC PATCH 1/2] ptp: add PTP_SYS_OFFSET_STAT for xtstamping with status

2024-12-20 Thread Richard Cochran
so only user space software can generate meaningful clock quality metrics. Putting some kind of hand wavy values into kernel drivers is just plain wrong IMO. Thanks, Richard

Re: [PATCH] rpmsg_ns: Work around TI non-standard message

2024-12-03 Thread Richard Weinberger
Andrew, Am Dienstag, 3. Dezember 2024, 16:19:31 CET schrieb Andrew Davis: > On 10/15/24 1:00 PM, Richard Weinberger wrote: > > Am Dienstag, 15. Oktober 2024, 19:56:08 CEST schrieb Mathieu Poirier: > >>>> In my opinion the real fix here is to get TI to use the standard mes

Re: [PATCH] rpmsg_ns: Work around TI non-standard message

2024-10-15 Thread Richard Weinberger
s an even better argument to adopt the standard structure as soon as > possible. Modifying the mainline kernel to adapt to vendors' quirks doesn't > scale. Well, I can't speak for TI. But I have little hope. Thanks, //richard -- ​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT UID/VAT Nr: ATU 66964118 | FN: 374287y

Re: [PATCH] rpmsg_ns: Work around TI non-standard message

2024-10-15 Thread Richard Weinberger
Mathieu, Am Dienstag, 15. Oktober 2024, 18:48:08 CEST schrieb Mathieu Poirier: > Good morning Richard, > > On Fri, Oct 11, 2024 at 02:39:22PM +0200, Richard Weinberger wrote: > > Texas Instruments ships a patch in their vendor kernels, > > which adds a new NS message that i

Re: [PATCH] rpmsg_ns: Work around TI non-standard message

2024-10-14 Thread Richard Weinberger
expected restricted __rpmsg32 > [assigned] [usertype] ns_flags >drivers/rpmsg/rpmsg_ns.c:56:26: sparse: got unsigned int [usertype] > flags sprase is right. I missed to replace u32 in the struct by __rpmsg32. Thanks, //richard -- ​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT UID/VAT Nr: ATU 66964118 | FN: 374287y

[PATCH] rpmsg_ns: Work around TI non-standard message

2024-10-11 Thread Richard Weinberger
jects/PUB/repos/linux-phytec-ti/commits/aeded1f439effc84aa9f4e341a6e92ce1844ab98#drivers/rpmsg/virtio_rpmsg_bus.c Cc: o...@wizery.com Cc: s-a...@ti.com Cc: t-kri...@ti.com Signed-off-by: Richard Weinberger --- FWIW, this is a forward port of a patch I'm using on v6.6. Thanks, //richard --

Re: [PATCH net-next v7] ptp: Add support for the AMZNC10C 'vmclock' device

2024-10-07 Thread Richard Cochran
as an optional part of that spec. In the > meantime, this driver supports the simple ACPI form of the device which > is being shipped in certain commercial hypervisors (and submitted for > inclusion in QEMU). > > Signed-off-by: David Woodhouse Acked-by: Richard Cochran

Re: [PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

2024-07-08 Thread Richard GENOUD
Le 01/07/2024 à 11:59, Hari Nagalla a écrit : On 6/21/24 10:00, Richard Genoud wrote: Richard Genoud (4):    remoteproc: k3-r5: Fix IPC-only mode detection    remoteproc: k3-r5: Introduce PM suspend/resume handlers    remoteproc: k3-r5: k3_r5_rproc_stop: code reorder    remoteproc: k3-r5

Re: [PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-07-01 Thread Richard GENOUD
Le 01/07/2024 à 18:35, Mathieu Poirier a écrit : On Mon, Jul 01, 2024 at 10:03:22AM +0200, Richard GENOUD wrote: Le 28/06/2024 à 23:18, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:57PM +0200, Richard Genoud wrote: In the next commit, a RP_MBOX_SHUTDOWN message will be sent in

Re: [PATCH 4/4] remoteproc: k3-r5: support for graceful stop of remote cores

2024-07-01 Thread Richard GENOUD
Le 29/06/2024 à 00:50, Andrew Davis a écrit : On 6/21/24 10:00 AM, Richard Genoud wrote: Introduce software IPC handshake between the K3-R5 remote proc driver and the R5 MCU to gracefully stop/reset the remote core. Upon a stop request, K3-R5 remote proc driver sends a RP_MBOX_SHUTDOWN mailbox

Re: [PATCH 4/4] remoteproc: k3-r5: support for graceful stop of remote cores

2024-07-01 Thread Richard GENOUD
[adding Vibhore in Cc] Le 28/06/2024 à 23:20, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:58PM +0200, Richard Genoud wrote: Introduce software IPC handshake between the K3-R5 remote proc driver and the R5 MCU to gracefully stop/reset the remote core. Upon a stop request, K3-R5

Re: [PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-07-01 Thread Richard GENOUD
Le 28/06/2024 à 23:18, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:57PM +0200, Richard Genoud wrote: In the next commit, a RP_MBOX_SHUTDOWN message will be sent in k3_r5_rproc_stop() to the remote proc (in lockstep on not) Thus, the sanity check "do not allow core 0 to stop b

Re: [PATCH 2/4] remoteproc: k3-r5: Introduce PM suspend/resume handlers

2024-07-01 Thread Richard GENOUD
Le 28/06/2024 à 22:48, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:56PM +0200, Richard Genoud wrote: This patch adds the support for system suspend/resume to the ti_k3_R5 remoteproc driver. In order to save maximum power, the approach here is to shutdown completely the cores that

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-26 Thread Richard Cochran
On Tue, Jun 25, 2024 at 11:34:24PM +0200, Thomas Gleixner wrote: > There is effort underway to expose PTP clocks to user space via > VDSO. That sounds interesting. Has anything been posted? Thanks, Richard

[PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-06-21 Thread Richard Genoud
PC-only mode instead of a mismatched mode. Fixes: 1168af40b1ad ("remoteproc: k3-r5: Add support for IPC-only mode for all R5Fs") Signed-off-by: Richard Genoud --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

[PATCH 4/4] remoteproc: k3-r5: support for graceful stop of remote cores

2024-06-21 Thread Richard Genoud
the remote core through device manager Based on work from: Hari Nagalla Signed-off-by: Richard Genoud --- drivers/remoteproc/omap_remoteproc.h | 9 +- drivers/remoteproc/ti_k3_r5_remoteproc.c | 40 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a

[PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-06-21 Thread Richard Genoud
de actions - !cluster_mode sanity check - !cluster_mode actions And now: - !cluster_mode sanity check - cluster_mode actions - !cluster_mode actions Signed-off-by: Richard Genoud --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletion

[PATCH 2/4] remoteproc: k3-r5: Introduce PM suspend/resume handlers

2024-06-21 Thread Richard Genoud
detached and processor control released. On resume, the reverse operation is done. Based on work from: Hari Nagalla Signed-off-by: Richard Genoud --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 123 ++- 1 file changed, 121 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

2024-06-21 Thread Richard Genoud
omap-mailbox 31f81000.mailbox: PM: failed to suspend: error -16 Patches 2 and 4 are based on work from Hari Nagalla . @Hari, please feel free to add your Co-developed-by:/Signed-off-by: Tested on J7200X SoM Series is based on v6.10-rc4 Richard Genoud (4): remoteproc: k3-r5: Fix IPC-only mode

[PATCH v2] mm: add alloc_contig_migrate_range allocation statistics

2024-02-27 Thread Richard Chang
was quite useful to understand CMA allocation latency. Signed-off-by: Richard Chang --- * from v1 - https://lore.kernel.org/linux-mm/20240226100045.2083962-1-richard...@google.com/ * Move the trace event int field to the end of the longs - rostedt * Do the calculation only when tracing is

[PATCH] mm: add alloc_contig_migrate_range allocation statistics

2024-02-26 Thread Richard Chang
was quite useful to understand CMA allocation latency. Signed-off-by: Richard Chang --- include/trace/events/kmem.h | 39 + mm/internal.h | 3 ++- mm/page_alloc.c | 30 +++- mm/page_isolation.c | 2

Re: Question about the ipi_raise filter usage and output

2024-02-06 Thread richard clark
On Wed, Feb 7, 2024 at 10:28 AM richard clark wrote: > > On Tue, Feb 6, 2024 at 5:39 PM Valentin Schneider wrote: > > > > You should have access to the generic fields which include the CPU from > > which the event happens. Any of "CPU", "cpu" or &quo

Re: Question about the ipi_raise filter usage and output

2024-02-06 Thread richard clark
On Tue, Feb 6, 2024 at 5:39 PM Valentin Schneider wrote: > > You should have access to the generic fields which include the CPU from > which the event happens. Any of "CPU", "cpu" or "common_cpu" would match > this. > > So if you're on a recent enough kernel (v6.6 or above AFAICT), you should > be

Re: Question about the ipi_raise filter usage and output

2024-02-06 Thread richard clark
On Tue, Feb 6, 2024 at 12:05 AM Valentin Schneider wrote: > > On 05/02/24 14:39, Mark Rutland wrote: > > [adding Valentin] > > > > Thanks! > > > On Mon, Feb 05, 2024 at 08:06:09AM -0500, Steven Rostedt wrote: > >> On Mon, 5 Feb 2024 10:28:57 + > >> Mark Rutland wrote: > >> > >> > > I try to w

Re: Question about the ipi_raise filter usage and output

2024-02-05 Thread richard clark
Hi Steve, On Mon, Feb 5, 2024 at 6:38 PM Steven Rostedt wrote: > > On Mon, 5 Feb 2024 17:57:29 +0800 > richard clark wrote: > > > I try to write below: > > echo 'target_cpus == 11 && reason == "Function call interrupts"' > > > events/

Question about the ipi_raise filter usage and output

2024-02-05 Thread richard clark
Hi guys, With the ipi_raise event enabled and filtered with: echo 'reason == "Function call interrupts"' > filter, then the 'cat trace' output below messages: ... insmod-3355[010] 1.. 24479.230381: ipi_raise: target_mask=,0bff (Function call interrupts) ... The above output is

Re: [PATCH 2/5] UML: remove unused cmd_vdso_install

2023-10-09 Thread Richard Weinberger
..@vger.kernel.org, "linux-um" , > "loongarch" , > "sparclinux" , "x86" , > "masahiroy" , "anton ivanov" > , "bp" , "dave hansen" > , "hpa" > , "mingo" , "Johannes Berg" >

Re: [PATCH] ptp: Don't print an error if ptp_kvm is not supported

2021-04-20 Thread Richard Cochran
by ARM platforms today if ptp_kvm is not supported. > > Fixes: 300bb1fe7671 ("ptp: arm/arm64: Enable ptp_kvm for arm/arm64") > Signed-off-by: Jon Hunter Acked-by: Richard Cochran

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
return type to void? Returning true or > false makes no difference. +1 Thanks, Richard

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
and pass them to the > - * switch driver > - */ > + /* Handle tx timestamp request if has */ "if has" what? > dsa_skb_tx_timestamp(p, skb); > > if (dsa_realloc_skb(skb, dev)) { > -- > 2.25.1 > Thanks, Richard

Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling

2021-04-18 Thread Richard Cochran
h into three for easier review. Thanks, Richard

Re: [PATCH 00/13] [RFC] Rust support

2021-04-17 Thread Richard Weinberger
. As someone who works a lot with long supported embedded systems I learned that as soon an application gains a hard dependency on clang or rust I'm in trouble. -- Thanks, //richard

Re: [PATCH v2] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-14 Thread Richard Cochran
On Wed, Apr 14, 2021 at 03:04:49AM +, Chen Jun wrote: > the correct error is covered by put_old_timex32. > > Fixes: 3a4d44b61625 ("ntp: Move adjtimex related compat syscalls to native > counterparts") > Signed-off-by: Chen Jun Reviewed-by: Richard Cochran

Re: [PATCH net-next v4 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-14 Thread Richard Cochran
o the above mentioned feature. Users will be > able to triggered capturing the time snapshot from user-space using > application such as testptp or any other applications that uses the > PTP_EXTTS_REQUEST ioctl request. > > Cc: Richard Cochran > Signed-off-by: Tan Tee Min > Co-de

RE: [PATCH] arm64: dts: imx8mq-evk: add one regulator used to power up pcie phy

2021-04-13 Thread Richard Zhu
487-3-git-send-email-hongxing@nxp.com/ https://patchwork.kernel.org/project/linux-pci/patch/1617091701-6444-2-git-send-email-hongxing@nxp.com/ Best Regards Richard Zhu > -Original Message- > From: Richard Zhu > Sent: Wednesday, April 14, 2021 10:26 AM > To: shawn...@kern

[PATCH] arm64: dts: imx8mq-evk: add one regulator used to power up pcie phy

2021-04-13 Thread Richard Zhu
1b'0. Thus, the internal 3v3 to 1v8 translator would be turned on. Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach --- arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freesc

[PATCH] arm64: dts: imx8mq-evk: add one regulator used to power up

2021-04-13 Thread Richard Zhu
The other two patches are accepted into PCIe tree. It's time to post it for Shawn to pick up into the imx DT tree. https://patchwork.kernel.org/project/linux-pci/patch/1616661882-26487-3-git-send-email-hongxing@nxp.com/ arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 1 + 1 file changed, 1 inser

[GIT PULL] MTD fixes for 5.12-rc7

2021-04-13 Thread Richard Weinberger
Linus, The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git tags/fixes-for-5.12-rc7 for you to fetch changes up to 2fb164f

Re: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region

2021-04-12 Thread Richard Gong
Hi Moritz, On 3/28/21 12:20 PM, Moritz Fischer wrote: Tom, On Sun, Mar 28, 2021 at 08:40:24AM -0700, Tom Rix wrote: On 3/27/21 11:09 AM, Moritz Fischer wrote: Hi Richard, Russ, On Thu, Feb 25, 2021 at 01:07:14PM +, Gong, Richard wrote: Hi Moritz, Sorry for asking. When you have

Re: [PATCH] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-12 Thread Richard Cochran
On Mon, Apr 12, 2021 at 02:52:11PM +, chenjun (AM) wrote: > 在 2021/4/12 22:20, Richard Cochran 写道: > > On Mon, Apr 12, 2021 at 12:45:51PM +, Chen Jun wrote: > >> the correct error is covered by put_old_timex32. > > > > Well, the non-negative return co

Re: [PATCH] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-12 Thread Richard Cochran
ERNEL_DS); ret = sys_clock_adjtime(which_clock, (struct timex __user *) &txc); set_fs(oldfs); err = compat_put_timex(utp, &txc); if (err) return err; return ret;

Re: [PATCH net-next v3 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-11 Thread Richard Cochran
> index b164ae22e35f..d668c33a0746 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c > @@ -135,9 +135,13 @@ static int stmmac_enable(struct ptp_clock_info *ptp, > { > struct stmmac_priv *priv = > container_of(ptp, struct stmmac_priv, ptp_clock_ops); > + void __iomem *ptpaddr = priv->ptpaddr; > + void __iomem *ioaddr = priv->hw->pcsr; > struct stmmac_pps_cfg *cfg; > int ret = -EOPNOTSUPP; > unsigned long flags; > + u32 intr_value; > + u32 acr_value; Please group same types together. Thanks, Richard

Re: [PATCH] ubifs: default to zstd compression

2021-04-08 Thread Richard Weinberger
hange the default compressor only for the default filesystem as created by UBIFS itself. Queued for the merge window. :-) -- Thanks, //richard

Re: [PATCH 4/6] fs/jffs2: Delete obsolete TODO file

2021-04-07 Thread Richard Weinberger
Did you check whether all items in this list are really outdated? Nobody shall ever blindly follow a TODO list without checking first which points are still valid or not. Removing that file does not magically solve the issues it describes. -- Thanks, //richard

Re: [PATCH] ubifs: fix read fail but return ok

2021-04-07 Thread Richard Weinberger
so vfs will emit -EIO. At least this is the theory. :-) -- Thanks, //richard

Re: [PATCH v1 1/1] ubifs: only check replay with inode type to judge if inode linked

2021-04-07 Thread Richard Weinberger
- if (key_inum(c, &r->key) == key_inum(c, &rino->key)) > + if (key_inum(c, &r->key) == key_inum(c, &rino->key) && > + key_type(c, &r->key) == UBIFS_INO_KEY) This change makes sense. Thanks a lot for hunting this down. It will be part of the merge window. -- Thanks, //richard

Re: [PATCH v19 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent

2021-04-07 Thread Richard Cochran
into a new arch-specific file in the same directory, > > and rename the arch-independent file to ptp_kvm_common.c. > > > > Reviewed-by: Andre Przywara > > Signed-off-by: Jianyong Wu > > Signed-off-by: Marc Zyngier > > Link: https://lore.kernel.org/r/202012090609

[PATCH] audit: drop /proc/PID/loginuid documentation Format field

2021-04-01 Thread Richard Guy Briggs
Reported-by: Mauro Carvalho Chehab Signed-off-by: Richard Guy Briggs --- .../ABI/stable/procfs-audit_loginuid | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Richard Weinberger
ed to > have other backends available at runtime as well? I thought about devices with a TPM-Chip and CAAM. IMHO allowing only one backend at the same time is a little over simplified. Thanks, //richard

Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

2021-04-01 Thread Richard Guy Briggs
On 2021-04-01 09:57, Paul Moore wrote: > On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab > wrote: > > Em Thu, 18 Mar 2021 15:19:10 -0400 > > Richard Guy Briggs escreveu: > > > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that > >

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Richard Weinberger
dmcrypt decryption. > > This will mean we have to part ways with features such as having multiple > keys, but I think it's worth it to have a plug and play solution for > trusted keys. Ah, now I can follow your thoughts! Yes, that would be nice to have. :) I kind of assumed you want to use LUKS with passphrases and CAAM blobs. Thanks, //richard

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Richard Weinberger
s until it's actually needed. >> What can be done now is adopting a format for the exported keys that would >> make this extension seamless in future. >> > > +1 As long we don't make multiple backends at runtime impossible I'm fine and will happily add support for it when needed. :-) Thanks, //richard

Re: [PATCH v5] audit: log nftables configuration change events once per table

2021-04-01 Thread Richard Guy Briggs
On 2021-04-01 15:24, Phil Sutter wrote: > On Fri, Mar 26, 2021 at 01:38:59PM -0400, Richard Guy Briggs wrote: > > Reduce logging of nftables events to a level similar to iptables. > > Restore the table field to list the table, adding the generation. > > > > Indicate the

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Richard Weinberger
lain disc encryption key material? This would be a no-go for many systems out there, key material must not accessible to userspace. I know, distrusting userspace root is not easy, but doable. :) Thanks, //richard

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Richard Weinberger
hassle with crypto/system reviewers, etc... I don't want you to force to use cryptsetup. The only goal was pointing out that it can be done with cryptsetup and that there is already code such that no work is done twice. One the kernel side it does not matter. Thanks, //richard

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Richard Weinberger
o you see with this over direct dmsetup? cryptsetup is the de-facto standard to setup encrypted block devices. There is a lot of existing tooling around cryptsetup already (systemd, etc..), so being able to use CAAM keys for dm-crypt with cryptsetup seems natural to me. Plain mode allows setting up dm-crypt without LUKS. Thanks, //richard

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Richard Weinberger
he CAAM blob with a key modifier of their own choice. Thanks, //richard

Re: [PATCH v5] audit: log nftables configuration change events once per table

2021-03-31 Thread Richard Guy Briggs
On 2021-03-31 22:46, Pablo Neira Ayuso wrote: > On Fri, Mar 26, 2021 at 01:38:59PM -0400, Richard Guy Briggs wrote: > > @@ -8006,12 +7966,65 @@ static void nft_commit_notify(struct net *net, u32 > > portid) > > WARN_ON_ONCE(!list_empty(&net->nft.notify_list));

Re: [PATCH v5] audit: log nftables configuration change events once per table

2021-03-31 Thread Richard Guy Briggs
On 2021-03-31 22:22, Pablo Neira Ayuso wrote: > On Fri, Mar 26, 2021 at 01:38:59PM -0400, Richard Guy Briggs wrote: > > Reduce logging of nftables events to a level similar to iptables. > > Restore the table field to list the table, adding the generation. > > > >

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-31 Thread Richard Weinberger
dea. Ahmad, what do you think? That way we could also get rid off the kernel parameter and all the fall back logic, given that we find a way to reliable detect TEE blobs too... Thanks, //richard

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-31 Thread Richard Weinberger
ce you're simply loading an already created key, the > trusted key subsystem should be able to figure what to do on its own. So you have some kind of container format in mind which denotes the type of the blob? Thanks, //richard

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-31 Thread Richard Weinberger
es "SECURE_KEY" as default modifier. -- Thanks, //richard

RE: Re: [PATCH] clk: imx8mp: Remove the none exist pcie clocks

2021-03-31 Thread Richard Zhu
> -Original Message- > From: Stephen Boyd > Sent: Wednesday, March 31, 2021 10:17 AM > To: Richard Zhu ; Abel Vesa ; > Jacky Bai ; shawn...@kernel.org > Cc: dl-linux-imx ; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-...@vger.ke

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-30 Thread Richard Weinberger
d $(cat ~/kmk.blob)" @s -- Thanks, //richard

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-30 Thread Richard Weinberger
yptsetup? David and I have added (rough) support for our CAAM/DCP based keyrings to cryptsetup: https://github.com/sigma-star/cryptsetup/tree/rw/plain I'm pretty sure with minimal changes it will work with your recent approach too. -- Thanks, //richard

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-30 Thread Richard Weinberger
recent kernel which will also hook in there. Out driver adds trusted keys support (with caam alike blobs) for i.mx SoCs that come with DCP instead of CAAM. Patches will hopefully materialize soon. -- Thanks, //richard

Re: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version

2021-03-30 Thread Richard Gong
Hi Moritz, On 3/30/21 11:15 AM, Moritz Fischer wrote: Hi Richard, On Tue, Mar 30, 2021 at 09:33:05AM -0500, richard.g...@linux.intel.com wrote: From: Richard Gong Extend Intel service layer driver to get the firmware version running at FPGA device. Therefore FPGA manager driver, one of

Re: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version

2021-03-30 Thread Richard Gong
rvice layer driver in a 64-bit value at the register. Intel service layer driver runs at EL1. Regards, Richard David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

[PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version

2021-03-30 Thread richard . gong
From: Richard Gong Extend Intel service layer driver to get the firmware version running at FPGA device. Therefore FPGA manager driver, one of Intel service layer driver's client, can decide whether to handle the newly added bitstream authentication function based on the retrieved fir

[PATCH] A patch for Intel service layer driver

2021-03-30 Thread richard . gong
From: Richard Gong Hi Greg, Please take this stratix10-svc patch, which has been reviewed on the mailing list and applied cleanly on current linux-next and char-misc-testing. Thanks, Richard Richard Gong (1): firmware: stratix10-svc: extend SVC driver to get the firmware version drivers

[PATCH v8 1/4] lib: vsprintf: scanf: Negative number must have field width > 1

2021-03-30 Thread Richard Fitzgerald
umber field to have a field width of 1 if it starts with a digit. In that case the single digit can be converted. Signed-off-by: Richard Fitzgerald Reviewed-by: Petr Mladek Acked-by: Andy Shevchenko --- lib/vsprintf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/

[PATCH v8 2/4] lib: vsprintf: Fix handling of number field widths in vsscanf

2021-03-30 Thread Richard Fitzgerald
;i); Will not produce the correct result because the value obviously overflows INT_MAX. But sscanf will report a successful conversion. Note that where a very large number is used to mean "unlimited", the value INT_MAX is used for consistency with the behaviour of vsnprintf(). Signed-off-

[PATCH v8 4/4] selftests: lib: Add wrapper script for test_scanf

2021-03-30 Thread Richard Fitzgerald
Adds a wrapper shell script for the test_scanf module. Signed-off-by: Richard Fitzgerald Reviewed-by: Petr Mladek Acked-by: Andy Shevchenko --- Changed since v6: Fixed typo in tools/testing/selftests/lib/config: -CONFIG_TEST_SCANTF=m +CONFIG_TEST_SCANF=m As this is a trivial

[PATCH v8 3/4] lib: test_scanf: Add tests for sscanf number conversion

2021-03-30 Thread Richard Fitzgerald
Adds test_sscanf to test various number conversion cases, as number conversion was previously broken. This also tests the simple_strtoxxx() functions exported from vsprintf.c. Signed-off-by: Richard Fitzgerald Acked-by: Andy Shevchenko --- Changed since v6: Use the KSTM_MODULE_GLOBALS define

[RESEND v4 2/2] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3

2021-03-30 Thread Richard Zhu
1b'0. Thus, the internal 3v3 to 1v8 translator would be turned on. Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach --- drivers/pci/controller/dwc/pci-imx6.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/cont

[RESEND v4 0/2] add one regulator used to power up pcie phy

2021-03-30 Thread Richard Zhu
Changes: Only add "Reviewed-by: Lucas Stach " in the first patch. No other changes. Make it easier to be integrated later. [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to [RESEND v4 2/2] PCI: imx: clear vreg bypass when pcie vph voltage is

[RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy

2021-03-30 Thread Richard Zhu
1b'0. Thus, the internal 3v3 to 1v8 translator would be turned on. Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach --- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-p

Re: [PATCH v7 2/4] lib: vsprintf: Fix handling of number field widths in vsscanf

2021-03-29 Thread Richard Fitzgerald
On 29/03/2021 14:36, Andy Shevchenko wrote: On Mon, Mar 29, 2021 at 01:08:22PM +0100, Richard Fitzgerald wrote: The existing code attempted to handle numbers by doing a strto[u]l(), ignoring the field width, and then repeatedly dividing to extract the field out of the full converted value. If

Re: [Bug 212265] New: clock_gettime(CLOCK_TAI, ...) should return an error when TAI has not been configured

2021-03-29 Thread Richard Cochran
On Mon, Mar 29, 2021 at 04:57:55PM +0200, Thomas Gleixner wrote: > I think adjtimex is the right place and not yet another random file > somewhere. Something like the below. Perfect. Acked-by: Richard Cochran > --- > include/uapi/linux/timex.h |7 +-- > ke

Re: [Bug 212265] New: clock_gettime(CLOCK_TAI, ...) should return an error when TAI has not been configured

2021-03-29 Thread Richard Cochran
e another way, sysfs or something else. Thanks, Richard

Re: [Bug 212265] New: clock_gettime(CLOCK_TAI, ...) should return an error when TAI has not been configured

2021-03-29 Thread Richard Cochran
On Mon, Mar 29, 2021 at 11:16:48AM +0200, Miroslav Lichvar wrote: > On Fri, Mar 26, 2021 at 08:28:59PM -0700, Richard Cochran wrote: > > Using ntpd on Debian, the service will set the offset, but only after > > synchronization with the upstream server has been established, and >

  1   2   3   4   5   6   7   8   9   10   >