Re: [RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-13 Thread René van Dorst
Quoting DENG Qingfang : On Mon, Apr 12, 2021 at 11:08:36PM +0800, DENG Qingfang wrote: On Mon, Apr 12, 2021 at 07:04:49AM +, René van Dorst wrote: > Hi Qingfang, > > +static void mtk_phy_config_init(struct phy_device *phydev) > > +{ > > + /* Disable EEE */ &g

Re: [RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-12 Thread René van Dorst
Hi Qingfang, Quoting DENG Qingfang : Add support for MediaTek PHYs found in MT7530 and MT7531 switches. The initialization procedure is from the vendor driver, but due to lack of documentation, the function of some register values remains unknown. Signed-off-by: DENG Qingfang --- RFC v3 -> RF

Re: [RFC v3 net-next 0/4] MT7530 interrupt support

2021-04-09 Thread René van Dorst
Quoting Andrew Lunn : On Thu, Apr 08, 2021 at 11:00:08PM +0800, DENG Qingfang wrote: Hi René, On Thu, Apr 8, 2021 at 10:02 PM René van Dorst wrote: > > Tested on Ubiquiti ER-X-SFP (MT7621) with 1 external phy which uses irq=POLL. > I wonder if the external PHY's IRQ can

Re: [RFC v3 net-next 0/4] MT7530 interrupt support

2021-04-08 Thread René van Dorst
mdio-bus:1f eth4 (uninitialized): PHY [mt7530-0:04] driver [MediaTek MT7530 PHY] (irq=28) [ 13.785656] mt7530 mdio-bus:1f eth5 (uninitialized): PHY [mdio-bus:07] driver [Qualcomm Atheros AR8031/AR8033] (irq=POLL) Tested-by: René van Dorst Greats, René

Re: [PATCH net,v2] net: dsa: mt7530: setup core clock even in TRGMII mode

2021-03-19 Thread René van Dorst
) with and without TRGMII mode enabled. Tested-by: René van Dorst Greats, René

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-19 Thread René van Dorst
Quoting Landen Chao : On Wed, 2020-08-19 at 00:09 +0800, Andrew Lunn wrote: On Tue, Aug 18, 2020 at 03:14:10PM +0800, Landen Chao wrote: > Add new support for MT7531: > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > 5 giga embedded phys, 2 cpu ports, and the same

Re: [PATCH net,v2 2/2] arm: dts: mediatek: Fix mt7629 dts to reflect the latest dt-binding

2019-10-07 Thread René van Dorst
compatible = "mediatek,mt7629-sgmiisys", "syscon"; reg = <0x1b13 0x3000>; #clock-cells = <1>; - mediatek,physpeed = "2500"; }; }; }; -- 2.17.1 Reviewed-by: René van Dorst

Re: [PATCH net,v2 1/2] net: ethernet: mediatek: Fix MT7629 missing GMII mode support

2019-10-07 Thread René van Dorst
case PHY_INTERFACE_MODE_REVMII: -- 2.17.1 Reviewed-by: René van Dorst

Re: [PATCH net 2/2] arm: dts: mediatek: Fix mt7629 dts to reflect the latest dt-binding

2019-10-01 Thread René van Dorst
Hi MarkLee, Quoting MarkLee : * Removes mediatek,physpeed property from dtsi that is useless in PHYLINK * Set gmac0 to fixed-link sgmii 2.5Gbit mode * Set gmac1 to gmii mode that connect to a internal gphy Signed-off-by: MarkLee --- arch/arm/boot/dts/mt7629-rfb.dts | 13 - arch/a

Re: [PATCH v2 -next] net: mediatek: remove set but not used variable 'status'

2019-08-26 Thread René van Dorst
Let's add Stefan to the conversation. He is the author of this commit. Quoting Mao Wenan : Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function mtk_handle_irq: drivers/net/ethernet/mediatek/mtk_eth_soc.c:1951:6: warning: variable status set b

Re: [PATCH net-next v7 2/3] net: phy: add support for clause 37 auto-negotiation

2019-08-19 Thread René van Dorst
ternal Auto-negotiation: off Supports Wake-on: g Wake-on: d Link detected: yes Tested-by: René van Dorst Greats, René [0] https://github.com/vDorst/linux-1/blob/1d8cb01bc8047bda94c076676e47b09d2f31069d/drivers/net/phy/at803x.c Cheers, Tao --- Changes