On Tuesday, July 07/07/20, 2020 at 23:33:26 +0200, Pavel Machek wrote:
> Hi!
>
> > From: Rahul Lakkireddy
> >
> > [ Upstream commit f286dd8eaad5a2758750f407ab079298e0bcc8a5 ]
> >
> > Use correct type to check for all-mask exact match IP addresses.
> >
is often because vmcore_add_device_dump lacks a __init
annotation or the annotation of get_vmcore_size.constprop.5 is wrong.
Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes")
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
fs/proc/vmcore.c |
igned address.
Incorporate device dump size into the total vmcore size. Also update
offsets for other program headers after the device dumps are added.
Suggested-by: Eric Biederman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v8:
- No changes.
v7:
- No changes.
v6:
- No changes
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available as elf notes in /proc/vmcore in second kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v8:
- No changes.
v7
.
Suggested by Eric Biederman .
- Added new crashdd module that exports /proc/crashdd/ containing
driver's registered hardware/firmware logs in patch 1.
- Replaced the API to allow drivers to register their hardware/firmware
log collect routine in crash recovery kernel in patch 1.
- Up
erman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v8:
- Added missing linux/types.h header include.
- Removed __vmcore_add_device_dump().
v7:
- Removed "CHELSIO" vendor identifier in Elf Note name. Instead,
writing "LINUX".
- Moved vmcoredd_header to ne
/ containing
driver's registered hardware/firmware logs in patch 1.
- Replaced the API to allow drivers to register their hardware/firmware
log collect routine in crash recovery kernel in patch 1.
- Updated patch 2 to use the new API in patch 1.
Rahul Lakkireddy (3):
vmcore: add API to col
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available as elf notes in /proc/vmcore in second kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v7:
- Removed "CH
erman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v7:
- Removed "CHELSIO" vendor identifier in Elf Note name. Instead,
writing "LINUX".
- Moved vmcoredd_header to new file include/uapi/linux/vmcore.h
- Reworked vmcoredd_header to include Elf Note as pa
igned address.
Incorporate device dump size into the total vmcore size. Also update
offsets for other program headers after the device dumps are added.
Suggested-by: Eric Biederman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v7:
- No changes.
v6:
- No changes.
v5:
- No changes
igned address.
Incorporate device dump size into the total vmcore size. Also update
offsets for other program headers after the device dumps are added.
Suggested-by: Eric Biederman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v6:
- No changes.
v5:
- No changes.
v4:
- No changes
atch 2 to use the new API in patch 1.
Rahul Lakkireddy (3):
vmcore: add API to collect hardware dump in second kernel
vmcore: append device dumps to vmcore as elf notes
cxgb4: collect hardware dump in second kernel
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 +
drivers/n
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available as elf notes in /proc/vmcore in second kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v6:
- Added "CHELSIO&qu
erman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v6:
- Reworked device dump elf note name to contain vendor identifier.
- Added vmcoredd_header that precedes actual dump in the Elf Note.
- Device dump's name is moved inside vmcoredd_header.
v5:
- Remove
in patch 1.
- Updated patch 2 to use the new API in patch 1.
Rahul Lakkireddy (3):
vmcore: add API to collect hardware dump in second kernel
vmcore: append device dumps to vmcore as elf notes
cxgb4: collect hardware dump in second kernel
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 +
d
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available as elf notes in /proc/vmcore in second kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v5:
- No changes.
v4:
- No
erman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v5:
- Removed enabling CONFIG_PROC_VMCORE_DEVICE_DUMP by default and
updated help message to indicate that the driver must be present
in second kernel's initramfs to collect the underlying device
snapshot.
igned address.
Incorporate device dump size into the total vmcore size. Also update
offsets for other program headers after the device dumps are added.
Suggested-by: Eric Biederman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v5:
- No changes.
v4:
- No changes.
v3:
- Patch add
On Friday, April 04/20/18, 2018 at 19:06:09 +0530, Eric W. Biederman wrote:
> Rahul Lakkireddy writes:
>
> > On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman
> > wrote:
> >> Rahul Lakkireddy writes:
> >>
> >> > On Thursd
On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman wrote:
> Rahul Lakkireddy writes:
>
> > On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote:
> >> On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote:
> >> > On Wednesday, April
On Thursday, April 04/19/18, 2018 at 13:54:56 +0530, Greg KH wrote:
> On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote:
> > +config PROC_VMCORE_DEVICE_DUMP
> > + bool "Device Hardware/Firmware Log Collection"
> > + depends on PROC_VMCORE
> >
On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote:
> On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote:
> > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote:
> > > Hi Rahul,
> > > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote:
&g
On Wednesday, April 04/18/18, 2018 at 19:58:01 +0530, Eric W. Biederman wrote:
> Rahul Lakkireddy writes:
>
> > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote:
> >> Hi Rahul,
> >> On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote:
> >>
On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote:
> Hi Rahul,
> On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote:
> > On production servers running variety of workloads over time, kernel
> > panic can happen sporadically after days or even months. It is
> &
igned address.
Incorporate device dump size into the total vmcore size. Also update
offsets for other program headers after the device dumps are added.
Suggested-by: Eric Biederman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v4:
- No changes.
v3:
- Patch added in this ve
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available as elf notes in /proc/vmcore in second kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v4:
- No changes.
v3
- Updated patch 2 to use the new API in patch 1.
Rahul Lakkireddy (3):
vmcore: add API to collect hardware dump in second kernel
vmcore: append device dumps to vmcore as elf notes
cxgb4: collect hardware dump in second kernel
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 +
drivers/ne
erman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v4:
- Made __vmcore_add_device_dump() static.
- Moved compile check to define vmcore_add_device_dump() to
crash_dump.h to fix compilation when vmcore.c is not compiled in.
- Convert ---help--- to help in Kconfig as indicat
On Monday, April 04/02/18, 2018 at 14:41:43 +0530, Jiri Pirko wrote:
> Fri, Mar 30, 2018 at 08:42:00PM CEST, ebied...@xmission.com wrote:
> >Rahul Lakkireddy writes:
> >
> >> On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote:
> >>>
erman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v3:
- Dropped sysfs crashdd module.
- Added CONFIG_PROC_VMCORE_DEVICE_DUMP to allow configuring device
dump support.
- Moved logic related to adding dumps from crashdd to vmcore module.
- Rename all crashdd* to vmcoredd*
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available as elf notes in /proc/vmcore in second kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v3:
- Replaced all crashdd
igned address.
Incorporate device dump size into the total vmcore size. Also update
offsets for other program headers after the device dumps are added.
Suggested-by: Eric Biederman .
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v3:
- Patch added in this version.
- Exported dumps a
e in crash recovery kernel in patch 1.
- Updated patch 2 to use the new API in patch 1.
Rahul Lakkireddy (3):
vmcore: add API to collect hardware dump in second kernel
vmcore: append device dumps to vmcore as elf notes
cxgb4: collect hardware dump in second kernel
drivers/net/ethernet/che
On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote:
> Sat, Mar 24, 2018 at 11:56:33AM CET, rahul.lakkire...@chelsio.com wrote:
> >Add a new module crashdd that exports the /sys/kernel/crashdd/
> >directory in second kernel, containing collected hardware/firmware
> >dumps.
> >
> >Th
On Tuesday, March 03/27/18, 2018 at 18:47:34 +0530, Eric W. Biederman wrote:
> Rahul Lakkireddy writes:
>
> > On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman
> > wrote:
> >>
> >> Rahul Lakkireddy writes:
> >>
> >>
On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman wrote:
>
> Rahul Lakkireddy writes:
>
> > On production servers running variety of workloads over time, kernel
> > panic can happen sporadically after days or even months. It is
> > important to co
ggested-by: Eric Biederman .
Suggested-by: Stephen Hemminger
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v2:
- Added ABI Documentation for crashdd.
- Directly use octal permission instead of macro.
Changes since rfc v2:
- Moved exporting crashdd from procfs to sysfs. Su
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available under /sys/kernel/crashdd/cxgb4/ directory in second
kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v2:
- No
ch 1.
- Updated patch 2 to use the new API in patch 1.
Rahul Lakkireddy (2):
fs/crashdd: add API to collect hardware dump in second kernel
cxgb4: collect hardware dump in second kernel
Documentation/ABI/testing/sysfs-kernel-crashdd | 34
drivers/net/ethernet/chelsio/cxgb4/cxgb
ggested-by: Eric Biederman .
Suggested-by: Stephen Hemminger
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
Changes since rfc v2:
- Moved exporting crashdd from procfs to sysfs. Suggested by
Stephen Hemminger
- Moved code from fs/proc/crashdd.c to fs/crashdd/ directory.
- Re
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available under /sys/kernel/crashdd/cxgb4/ directory in second
kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
Changes since
oc/crashdd/ containing
driver's registered hardware/firmware logs in patch 1.
- Replaced the API to allow drivers to register their hardware/firmware
log collect routine in crash recovery kernel in patch 1.
- Updated patch 2 to use the new API in patch 1.
Rahul Lakkireddy (2):
fs/cras
On Tuesday, March 03/20/18, 2018 at 20:12:15 +0530, Alexander Duyck wrote:
> On Tue, Mar 20, 2018 at 6:32 AM, Rahul Lakkireddy
> wrote:
> > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote:
> >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote:
> >&
On Tuesday, March 03/20/18, 2018 at 20:10:19 +0530, David Laight wrote:
> From: Rahul Lakkireddy
> > Sent: 20 March 2018 13:32
> ...
> > On High Availability Server, the logs of the failing system must be
> > collected as quickly as possible. So, we're concerned with
On Tuesday, March 03/20/18, 2018 at 19:14:46 +0530, Andy Shevchenko wrote:
> On Tue, Mar 20, 2018 at 3:32 PM, Rahul Lakkireddy
> wrote:
> > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote:
> >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote:
>
> &
On Monday, March 03/19/18, 2018 at 20:57:22 +0530, Christoph Hellwig wrote:
> On Mon, Mar 19, 2018 at 07:50:33PM +0530, Rahul Lakkireddy wrote:
> > This series of patches add support for 256-bit IO read and write.
> > The APIs are readqq and writeqq (quad quadword - 4 x 64), th
On Monday, March 03/19/18, 2018 at 20:52:11 +0530, Stephen Hemminger wrote:
> On Mon, 19 Mar 2018 13:25:56 +0530
> Rahul Lakkireddy wrote:
>
> > On Friday, March 03/16/18, 2018 at 16:42:03 +0530, Rahul Lakkireddy wrote:
> > > On production servers running variety of wor
On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote:
> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote:
>
> > Use VMOVDQU AVX CPU instruction when available to do 256-bit
> > IO read and write.
>
> That's not what the patch does. See below.
>
>
adds 256-bit read and write to x86 via VMOVDQU AVX CPU
instructions.
Patch 3 updates cxgb4 driver to use the readqq API to speed up
reading on-chip memory 256-bits at a time.
Feedback and suggestions will be much appreciated.
Thanks,
Rahul
Rahul Lakkireddy (3):
include/linux: add 256-bit IO
Use VMOVDQU AVX CPU instruction when available to do 256-bit
IO read and write.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
arch/x86/include/asm/io.h | 57 ++-
1 file changed, 56 insertions(+), 1 deletion(-)
diff --git a/arch
Add readqq and writeqq (quad quadword - 4 x 64) IO non-atomic
accessors. Also add byteorder conversions for 256-bit.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
include/linux/byteorder/generic.h | 48
include/linux/io-64-nonatomic-hi-lo.h
Use readqq() to read on-chip memory 256-bits at a time.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 16
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 6 ++
2 files changed, 14 insertions(+), 8
On Friday, March 03/16/18, 2018 at 16:42:03 +0530, Rahul Lakkireddy wrote:
> On production servers running variety of workloads over time, kernel
> panic can happen sporadically after days or even months. It is
> important to collect as much debug logs as possible to root cause
>
Register callback to collect hardware/firmware dumps in second kernel
before hardware/firmware is initialized. The dumps for each device
will be available under /proc/crashdd/cxgb4/ directory in second
kernel.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
v2:
- Updated dump
uffer with requested size and invokes the
device driver's registered callback function.
3. Device driver collects all hardware/firmware logs into the buffer
and returns control back to crashdd.
4. Crashdd exposes the buffer as a file via
/proc/crashdd//.
Signed-off-by: Rahul Lakkireddy
Sig
ew crashdd module that exports /proc/crashdd/ containing
driver's registered hardware/firmware logs in patch 1.
- Replaced the API to allow drivers to register their hardware/firmware
log collect routine in crash recovery kernel in patch 1.
- Updated patch 2 to use the new API in
On Friday, March 03/02/18, 2018 at 18:52:45 +0530, Eric W. Biederman wrote:
> Rahul Lakkireddy writes:
>
> > On production servers running variety of workloads over time, kernel
> > panic can happen sporadically after days or even months. It is
> > important to colle
Pre-allocate dump buffer and register callback to collect hardware/
firmware logs in kernel panic. Free dump buffer on driver unload.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 6 ++
drivers/net/ethernet/chelsio/cxgb4
crash:
crash> help -D | grep DRIVERDUMP
DRIVERDUMP=(cxgb4_:02:00.4, b131090bd000, 37782968)
crash> rd b131090bd000 37782968 -r hardware.log
37782968 bytes copied from 0xb131090bd000 to hardware.log
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
include
cxgb4 driver example using the API to collect
hardware/firmware logs during kernel panic.
Suggestions and feedback will be much appreciated.
Thanks,
Rahul
Rahul Lakkireddy (2):
kernel/crash_core: add API to collect hardware dump in kernel panic
cxgb4: collect hardware dump in kernel panic
d
Hi all,
We have a requirement to collect firmware/hardware state of the
underlying NIC during kernel panic. We are doing this in cxgb4
driver, using panic notifier list [1]. cxgb4 registers a callback
function to the panic notifier list, which gets invoked during kernel
panic. In the callback fu
61 matches
Mail list logo
