Re: [PATCH v2 0/6] [PATCH 0/6] KUnit test moves / renames

2024-12-02 Thread Rae Moar
! This series looks good to me. Tests are passed both built-in and as modules. One comment: The second patch in the series "[PATCH v2 2/6] lib/math: Add int_log test suite" applies with a warning of an extra EOF blank line. Other than that small nit, Reviewed-by: Rae Moar Tha

[PATCH] kunit: tool: add ability to parse test metadata

2024-11-20 Thread Rae Moar
test_suite Signed-off-by: Rae Moar --- lib/kunit/attributes.c| 23 -- lib/kunit/debugfs.c | 2 +- lib/kunit/test.c | 9 +-- tools/testing/kunit/kunit_parser.py | 79 +-- tools/testing/kunit

[PATCH v2 2/2] kunit: tool: print failed tests only

2024-11-13 Thread Rae Moar
converting to/from KTAP to this pretty-print output. Signed-off-by: Rae Moar --- tools/testing/kunit/kunit.py | 14 -- tools/testing/kunit/kunit_parser.py| 25 + tools/testing/kunit/kunit_tool_test.py | 6 +++--- 3 files changed, 40 insertions(+), 5

[PATCH v2 1/2] kunit: tool: Only print the summary

2024-11-13 Thread Rae Moar
From: David Gow Allow only printing the summary at the end of a test run, rather than all individual test results. This summary will list a few failing tests if there are any. To use: ./tools/testing/kunit/kunit.py run --summary Signed-off-by: Rae Moar Signed-off-by: David Gow --- Changes

Re: [PATCH v2] kunit: Introduce autorun option

2024-10-29 Thread Rae Moar
trusive tests. > > The option is set to true by default to preserve the existent behavior. It > can be overridden by either the corresponding module option or by the > corresponding config build option. > > Signed-off-by: Stanislav Kinsburskii Hello, This looks good to m

[PATCH 1/2] kunit: tool: Only print the summary

2024-10-28 Thread Rae Moar
From: David Gow Allow only printing the summary at the end of a test run, rather than all individual test results. This summary will list a few failing tests if there are any. To use: ./tools/testing/kunit/kunit.py run --summary Signed-off-by: Rae Moar Signed-off-by: David Gow --- tools

[PATCH 2/2] kunit: tool: print failed tests only

2024-10-28 Thread Rae Moar
converting to/from KTAP to this pretty-print output. Signed-off-by: Rae Moar --- tools/testing/kunit/kunit.py | 14 -- tools/testing/kunit/kunit_parser.py| 25 + tools/testing/kunit/kunit_tool_test.py | 6 +++--- 3 files changed, 40 insertions(+), 5

Re: [PATCH] kunit: Introduce autorun option

2024-10-22 Thread Rae Moar
On Thu, Oct 17, 2024 at 5:34 PM Stanislav Kinsburskii wrote: > > The new option controls tests run on boot or module load. With the new > debugfs "run" dentry allowing to run tests on demand, an ability to disable > automatic tests run becomes a useful option in case of intrusive tests. > > The op

Re: [PATCH v3 1/1] lib/llist_kunit.c: add KUnit tests for llist

2024-10-02 Thread Rae Moar
dd the lib/tests directory hasn't landed in the kselftest/kunit branch so this patch doesn't apply cleanly. Since we are planning on taking this patch through that branch, could you switch the files to be lib/Makefile and lib/llist_kunit.c for now. And we can move them in the great migrat

Re: [PATCH v2 1/1] lib/tests/kfifo_kunit.c: add tests for the kfifo structure

2024-10-01 Thread Rae Moar
On Tue, Sep 3, 2024 at 5:38 PM Diego Vieira wrote: > > Add KUnit tests for the kfifo data structure. > They test the vast majority of macros defined in the kfifo > header (include/linux/kfifo.h). > > These are inspired by the existing tests for the doubly > linked list in lib/tests/list-test.c (pr

Re: [PATCH v2 1/1] lib/llist_kunit.c: add KUnit tests for llist

2024-09-05 Thread Rae Moar
On Tue, Sep 3, 2024 at 5:40 PM Artur Alves wrote: > > Add KUnit tests for the llist data structure. They test the vast > majority of methods and macros defined in include/linux/llist.h. > > These are inspired by the existing tests for the 'list' doubly > linked in lib/list-test.c [1]. Each test ca