eanup lustre_lib.h")
Signed-off-by: Quentin Lambert
---
v2: fixes the referenced sha
drivers/staging/lustre/lustre/include/obd.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -88
eanup lustre_lib.h")
Signed-off-by: Quentin Lambert
---
drivers/staging/lustre/lustre/include/obd.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_cli
On 12/07/2016 04:33 PM, Dan Carpenter wrote:
Lustre is kind of a mess with regards to keeping user and kernel
pointers separate. It's not going to be easy to fix.
Fair enough.
I am trying to make a contribution to drivers/staging using sparse.
With that in mind, do you still fill I should kee
Hi all,
I am looking at the drivers/staging/lustre/lustre/llite/dir.c:
1469 /* Call mdc_iocontrol */
1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp,
sizeof(fid), &fid,
1471&index);
1472 if (rc)
and sparse says
On 12/05/2016 11:58 PM, Oleg Drokin wrote:
I guess it's a false positive?
Yes, probably.
Thank you for the explanation though, I don't fully understand all this yet,
I am still learning.
Sorry for the noise.
Quentin
lnet_ipif_enumerate was assigning a pointer from kernel space to user
space. This patch uses copy_to_user to properly do that assignment.
Signed-off-by: Quentin Lambert
---
shouldn't we be using ifc_req instead of ifc_buf?
drivers/staging/lustre/lnet/lnet/lib-socket.c |8 +++-
1
HBA memories,
we should also free the HBA memories.
- We should free shost memory at the end of hisi_sas_remove().
- sha->core.shost is set twice, so remove extra set.
Signed-off-by: Xiaofei Tan
Signed-off-by: John Garry
Reviewed-by: Quentin Lambert
diff --git a/drivers/scsi/hisi_
Most error branches following the call to kzalloc contain
a call to kfree. This patch add these calls where they are
missing and set the relevant pointers to NULL.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
v2: set the point to NULL after having freed it
drivers
On 11/21/2016 03:16 PM, John Garry wrote:
On 21/11/2016 13:20, Quentin Lambert wrote:
On 11/21/2016 01:53 PM, John Garry wrote:
However I have noticed that we should do a call to hisi_sas_free() for
this failure, and later failures in the probe.
I don't understand why, and would we
On 11/21/2016 01:53 PM, John Garry wrote:
However I have noticed that we should do a call to hisi_sas_free() for
this failure, and later failures in the probe.
I don't understand why, and would welcome the opportunity to learn
something.
Quentin
On 11/21/2016 08:32 AM, Alexander Shishkin wrote:
Quentin Lambert writes:
Most error branches following the call to class_find_device contain
a call to put_device. This patch add calls to put_device where
they are missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
On 11/19/2016 07:22 PM, Quentin Lambert wrote:
On 11/19/2016 06:41 PM, Quentin Lambert wrote:
Most error branches following the call to alloc_event_data contain a
call to
etm_free_aux. This patch add a call to etm_free_aux to an error branch
that does not call it.
This issue was found with
On 11/19/2016 06:41 PM, Quentin Lambert wrote:
Most error branches following the call to alloc_event_data contain a call to
etm_free_aux. This patch add a call to etm_free_aux to an error branch
that does not call it.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
Most error branches following the call to kmalloc contain
a call to kfree. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/scsi/xen-scsifront.c |1 +
1 file changed, 1 insertion(+)
--- a/drivers/scsi/xen
Most error branches following the call to class_find_device contain
a call to put_device. This patch add calls to put_device where
they are missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/hwtracing/stm/core.c |4 +++-
1 file changed, 3 insertions
Most error branches following the call to kzalloc contain
a call to kfree. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/scsi/dpt_i2o.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers
Most error branches following the call to alloc_event_data contain a call to
etm_free_aux. This patch add a call to etm_free_aux to an error branch
that does not call it.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/hwtracing/coresight/coresight-etm-perf.c
Most error branches following the call to pci_map_biosrom contain
a call to pci_unmap_biosrom. This patch add these calls where
they are missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/scsi/isci/probe_roms.c |1 +
1 file changed, 1 insertion(+)
--- a
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/scsi/pmcraid.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3787,11 +3787,11 @@ static long pmcraid_ioctl_passthrough
Most error branches following the call to hisi_sas_shost_alloc contain
a call to kfree. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/scsi/hisi_sas/hisi_sas_main.c |6 --
1 file changed, 4 insertions
Most error branches following the call to dst_neigh_lookup contain
a call to neigh_release. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |2 +-
1 file changed, 1 insertion(+), 1
Most error branches following the call to pci_enable_device contain
a call to pci_disable_device. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/pci/hotplug/cpqphp_core.c |3 ++-
1 file changed, 2 insertions
Most error branches following the call to kzalloc contain
a call to kfree. This patch add these calls where they are
missing.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/scsi/aic94xx/aic94xx_hwi.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion
Checkpatch printed a style ERROR concerning a missing space before '('.
This patch fixes this issue.
Signed-off-by: Quentin Lambert
Acked-by: Viresh Kumar
---
v2: fixes typos in commit message
drivers/staging/greybus/manifest.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
On 27/09/2016 11:31, Viresh Kumar wrote:
On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
wrote:
Checkpatch printed a style ERROR concerning a missing space befire '('.
This patch fix this issue.
Signed-off-by: Quentin Lambert
---
drivers/staging/greybus/manifest.c |2 +
Checkpatch printed a style ERROR concerning a missing space befire '('.
This patch fix this issue.
Signed-off-by: Quentin Lambert
---
drivers/staging/greybus/manifest.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/greybus/manifest.c
+++ b/drive
On 13/09/2016 14:40, Herbert Xu wrote:
On Tue, Sep 06, 2016 at 11:18:51AM +0100, Giovanni Cabiddu wrote:
---8<---
Subject: [PATCH] crypto: qat - fix leak on error path
Fix a memory leak in an error path in uc loader.
Signed-off-by: Giovanni Cabiddu
Patch applied. Thanks.
Sorry, I complet
On 09/09/2016 10:31, Quentin Lambert wrote:
I have been trying to build and boot the last version available on linux-next.
During the build I am being prompted with "has no CRC!" warnings for a bunch
of modules.
Has a result I get the following lines in the Modu
I have been trying to build and boot the last version available on linux-next.
During the build I am being prompted with "has no CRC!" warnings for a bunch
of modules.
Has a result I get the following lines in the Module.symvers:
[qlambert@sloth linux-next]$ grep 0x0 Module.symvers
0x00
In certain cases qat_uclo_parse_uof_obj used to return with an error code
before releasing all resources. This patch add a jump to the appropriate label
ensuring that the resources are properly released before returning.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
Most error code used to jump to a label that lead to a "return -EFAULT"
statement. This patch introduces a variable that stores the error code
so that other error branches can use the same label to exit.
Signed-off-by: Quentin Lambert
---
drivers/crypto/qat/qat_common/qat_ucl
The first patch introduces a variable to handle different error codes and be
able to reuse the same clean up code. The second add an omitted release by
jumping to the clean code having set the returned value to the proper error
code.
-changes since v1
I failed to send the first version properly an
Most error code used to jump to a label that lead to a "return -EFAULT"
statement. This patch introduces a variable that stores the error code
so that other error branches can use the same label to exit.
Signed-off-by: Quentin Lambert
---
drivers/crypto/qat/qat_common/qat_ucl
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/crypto/qat/qat_common/qat_uclo.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/crypto/qat/qat_common/qat_uclo.c
+++ b/drivers/crypto/qat/qat_common/qat_uclo.c
@@ -981,7 +981,8 @@ static int
Most error code used to jump to a label that lead to a "return -EFAULT"
statement. This patch introduces a variable that stores the error code
so that other error branches can use the same label to exit.
Signed-off-by: Quentin Lambert
---
drivers/crypto/qat/qat_common/qat_ucl
The first patch introduces a variable to handle different error codes and be
able to reuse the same clean up code. The second add an omitted release by
jumping to the clean code having set the returned value to the proper error
code.
---
drivers/crypto/qat/qat_common/qat_uclo.c | 16 +++
In certain cases qat_uclo_parse_uof_obj used to return with an error code
before releasing all resources. This patch add a jump to the appropriate label
ensuring that the resources are properly released before returning.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
The first patch introduces a variable to handle different error codes and be
able to reuse the same clean up code. The second add an omitted release by
jumping to the clean code having set the returned value to the proper error
code.
---
drivers/crypto/qat/qat_common/qat_uclo.c | 16 +++
ccp_dmaengine_register used to return with an error code before
releasing all resource. This patch adds a jump to the appropriate label
ensuring that the resources are properly released before returning.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers/crypto/ccp
mg_get_local_EKB and mg_get_ICV used to return with an error code before
releasing all resources. This patch add a jump to the appropriate label
ensuring that the resources are properly released before returning.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers
This patch changes label names using camel case to snake case as well as giving
a new name representing what will be done after the label.
Signed-off-by: Quentin Lambert
---
v2: add a commit message
drivers/staging/rts5208/ms.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions
The first patch is a style fix, the second add calls to kfree.
The reason for me thinking that they are necessary is that every other branches
leading to an error return are jumping to the same destination.
v2: add a commit message to the first patch
---
drivers/staging/rts5208/ms.c | 18 +
mg_get_local_EKB and mg_get_ICV used to return with an error code before
releasing all resources. This patch add a jump to the appropriate label
ensuring that the resources are properly released before returning.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
drivers
The first patch is a style fix, the second add calls to kfree.
The reason for me thinking that they are necessary is that every other branches
leading to an error return are jumping to the same destination.
---
drivers/staging/rts5208/ms.c | 18 ++
1 file changed, 10 insertions(
Signed-off-by: Quentin Lambert
---
drivers/staging/rts5208/ms.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -4313,7 +4313,7 @@ int mg_get_local_EKB(struct scsi_cmnd *s
if (retval
Most error branches following the call to npe_request contain a call to
npe_request. This patch add a call to npe_release to error branches
following the call to npe_request that do not have it.
This issue was found with Hector.
Signed-off-by: Quentin Lambert
---
If I am right in thinking that
Signed-off-by: Quentin Lambert
---
drivers/crypto/ixp4xx_crypto.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/crypto/ixp4xx_crypto.c
+++ b/drivers/crypto/ixp4xx_crypto.c
@@ -447,9 +447,8 @@ static int init_ixp_crypto(struct device
if (!npe_running(npe_c
The first patch is a style fix, the second add calls to npe_release.
The reason for me thinking that they are necessary is that every other branches
leading to an error return are calling this function.
---
drivers/crypto/ixp4xx_crypto.c |9 +
1 file changed, 5 insertions(+), 4 deleti
On 12/06/2015 11:59, Andreas Schwab wrote:
Quentin Lambert writes:
The dev_attrs field of struct bus_type is going away, sue dev_groups instead.
s/sue/use/
I meant use do you need to fix something else or should I resend with
the typo correction ?
Quentin
--
To unsubscribe from this
The dev_attrs field of struct bus_type is going away, use dev_groups
instead. This converts the soundbus code to use the correct field.
These modifications were made using Coccinelle.
Signed-off-by: Quentin Lambert
---
drivers/sh/superhyway/superhyway-sysfs.c | 26
The dev_attrs field of struct bus_type is going away, sue dev_groups instead.
This converts the soundbus code to use the correct field.
These modifications were made using Coccinelle.
Signed-off-by: Quentin Lambert
---
Changes since v2:
- Revert to the version of the patch where the files
On 11/06/2015 14:25, Takashi Iwai wrote:
At Thu, 11 Jun 2015 14:04:45 +0200,
Quentin Lambert wrote:
On 11/06/2015 12:02, Takashi Iwai wrote:
At Thu, 11 Jun 2015 10:03:38 +0200,
Quentin Lambert wrote:
The dev_attrs field of struct bus_type is going away, use dev_groups instead.
This
On 11/06/2015 13:55, walter harms wrote:
Am 11.06.2015 10:03, schrieb Quentin Lambert:
The dev_attrs field of struct bus_type is going away, use dev_groups instead.
This converts the soundbus code to use the correct field.
Given that all other usages of the macro define the struct attribute
On 11/06/2015 12:02, Takashi Iwai wrote:
At Thu, 11 Jun 2015 10:03:38 +0200,
Quentin Lambert wrote:
The dev_attrs field of struct bus_type is going away, use dev_groups instead.
This converts the soundbus code to use the correct field.
Given that all other usages of the macro define the
into core.c.
These modifications were made using Coccinelle.
Signed-off-by: Quentin Lambert
---
Changes since v1:
- Fix the commit message to actually talk about soundbus rather than MDIO
- This version attempt to fix a problem resulting from the macro
ATTRIBUTE_GROUPS declaring the
On 28/05/2015 17:01, Takashi Iwai wrote:
Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into
soundbus/sysfs.c, and make it this global instead of
soundbus_dev_attrs[].
Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS
declares the
structure as static.
If it resul
On 28/05/2015 16:09, Takashi Iwai wrote:
At Thu, 28 May 2015 15:59:50 +0200,
Quentin Lambert wrote:
On 28/05/2015 15:52, Takashi Iwai wrote:
At Thu, 28 May 2015 14:48:27 +0200,
Quentin Lambert wrote:
You should use dev_groups instead of the dev_attrs field of struct
bus_type. This converts
On 28/05/2015 15:52, Takashi Iwai wrote:
At Thu, 28 May 2015 14:48:27 +0200,
Quentin Lambert wrote:
You should use dev_groups instead of the dev_attrs field of struct
bus_type. This converts the MDIO bus code to use the correct field.
These modifications were made using Coccinelle.
Signed
On 28/05/2015 15:52, Takashi Iwai wrote:
At Thu, 28 May 2015 14:48:27 +0200,
Quentin Lambert wrote:
You should use dev_groups instead of the dev_attrs field of struct
bus_type. This converts the MDIO bus code to use the correct field.
These modifications were made using Coccinelle.
Signed
You should use dev_groups instead of the dev_attrs field of struct
bus_type. This converts the MDIO bus code to use the correct field.
These modifications were made using Coccinelle.
Signed-off-by: Quentin Lambert
---
sound/aoa/soundbus/core.c |3 ++-
sound/aoa/soundbus/soundbus.h
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
sound/pci/ad1889.c |4 ++--
sound/
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
drivers/memstick/host/jmb38x_ms.c | 12 ++--
drivers
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
Changes since v1:
- fold the two patches into one, GFP_ATOM
On 09/04/2015 16:50, Dan Carpenter wrote:
Sorry, my last email was bad.
Splitting patches into logical parts is a bit tricky. Let me try
explain better.
Every patch should sort of make sense on its own. In the original code
it's using GFP_ATOMIC but that's because the original API was bad a
On 09/04/2015 14:36, Dan Carpenter wrote:
Oh. They're not GFP_ATOMIC.
Fold these two patches together into one patch and resend.
The reason I did it that way is because I feel that the two patches
really are different.
The first one do not change the execution of the code but the second one
Both pmac_ide_init_dma and ide_dma_sgiioc4 are stored in the init_dma field of
an ide_port_info structure. This field seems to only be called from contexts
where sleep is allowed. Therefore, this patch replaces uses of GFP_ATOMIC by
GFP_KERNEL.
Signed-off-by: Quentin Lambert
---
drivers/ide
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
drivers/ide/cs5520.c|2 +-
drivers/ide/pmac.c
The first patch removes deprecated use of the pci api.
The second patch depends on the first, it replaces uses of GFP_ATOMIC
with GFP_KERNEL. I could not find evidence that the concerned functions
were called from a context were sleep is not allowed.
---
cs5520.c|2 +-
pmac.c |
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
drivers/ata/acard-ahci.c| 10 +-
drivers/ata/a
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
Changes since v1:
- Replaces GFP_ATOMIC by GFP_KERNEL s
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
drivers/staging/vt66
On 18/03/2015 14:54, Dan Carpenter wrote:
On Wed, Mar 18, 2015 at 02:43:01PM +0100, Quentin Lambert wrote:
On 18/03/2015 14:36, Dan Carpenter wrote:
This changelog still doesn't make sense so I took a look at the code.
tty_ldisc_deref() is an unlock function. So this is a lock ord
On 18/03/2015 14:36, Dan Carpenter wrote:
This changelog still doesn't make sense so I took a look at the code.
tty_ldisc_deref() is an unlock function. So this is a lock ordering
bug. What makes you think the original ordering was correct? Who
reported this bug? What are the effects of th
release before
return")
Signed-off-by: Quentin Lambert
---
Changes since v1:
- the commit message details the point of the patch
- remove a blank line between the Fixes line and the signed-off line.
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before
return")
Signed-off-by: Quentin Lambert
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_t
On 12/03/2015 10:27, Dan Carpenter wrote:
On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius Statkevičius wrote:
It's still not in staging-testing for some reason :(
It can take several weeks to get merged. Relax.
regards,
dan carpenter
What should i do concerning that ?
I need to send a
s
return ...;
}
...when any
if@p2(...) {...}
...when any
}
@depends on good1@
identifier candidates.f, candidates.label;
position candidates.p1, candidates.p3;
@@
f@p1(...) {
...when any
* return@p3 ...;
}
Signed-off-by: Quentin Lambert
---
drivers/staging
spin_unlock_irqrestore() is called at several
different places before exiting. This patch uses a goto statement
to factorize these calls.
Coccinelle was used to generate this patch.
Signed-off-by: Quentin Lambert
---
drivers/staging/dgnc/dgnc_tty.c | 48
This function is called on the previous and the next failure branches.
This patch adds the call on the branch where it seems to be missing.
Signed-off-by: Quentin Lambert
---
drivers/staging/dgnc/dgnc_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/dgnc
important or the changes felt more complex.
Quentin Lambert (3):
Staging: dgnc: dgnc_driver: Add a missing call to dgnc_tty_uninit
Staging: dgnc: Use goto for error handling
Staging: dgnc: Use goto for spinlock release before return
drivers/staging/dgnc/dgnc_cls.c| 19
\|devm_kzalloc\|devm_kmalloc\)(...);
if (e == NULL) {
<+...
- print(...,c,...);
... when any
(
goto l;
|
return ...;
)
...+> }
Signed-off-by: Quentin Lambert
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8 ++--
drivers/staging/rtl8723au/hal/rtl8723a_hal_init
\|devm_kzalloc\|devm_kmalloc\)(...);
if (e == NULL) {
<+...
- print(...,c,...);
... when any
(
goto l;
|
return ...;
)
...+> }
Signed-off-by: Quentin Lambert
---
drivers/staging/rtl8192e/rtllib_module.c | 10 +++---
drivers/staging/rtl8192e/rtllib_rx.c | 11 ---
2
On 05/03/2015 11:28, Julia Lawall wrote:
It's i2o, not io, and it is on the way out of the kernel.
sorry about that,
since it is on its way out I guess there is no need for me to submit a
correct version of this patch?
Are there resources to know whether or not a driver will be dropped or
This patch reduces the kernel size by removing error messages that duplicate
the normal OOM message.
Signed-off-by: Quentin Lambert
---
drivers/staging/i2o/i2o_block.c | 1 -
drivers/staging/i2o/i2o_config.c | 7 +--
drivers/staging/i2o/iop.c| 10 ++
3 files changed, 3
Ignore this I made a mistake.
My apologies,
Quentin
On 04/03/2015 11:29, Quentin Lambert wrote:
Bcc:
Subject: [PATCH 1/2] staging: rts5208: Convert non-returned local variable to
boolean when relevant
Reply-To:
This patch was produced using Coccinelle. A simplified version of the
semantic
This patch convert local variables declared as int into booleans.
It also propagates the conversion when these variables were used
as function parameters.
Coccinelle was used to generate this patch.
Signed-off-by: Quentin Lambert
---
drivers/staging/rts5208/ms.c| 9
drivers
expression e1 != {0, 1}, e2;
@@
f(...) {
...when any
(
x = e1;
|
x + e2
)
...when any
}
@depends on !bad@
identifier r.f;
local idexpression u8 r.x;
identifier r.xname;
@@
f(...) {
...
++ bool xname;
- int xname;
<...
(
x =
- 1
+ true
|
x =
- -1
+ false
)
...>
}
Signed-off-by: Quentin L
(...) {
...
++ bool xname;
- int xname;
<...
(
x =
- 1
+ true
|
x =
- -1
+ false
)
...>
}
Signed-off-by: Quentin Lambert
---
drivers/staging/rts5208/ms.c| 14 +++---
drivers/staging/rts5208/rtsx_chip.c | 56 ---
drivers/staging/rts5208/rtsx_scsi.
. It therefore propagates the
conversion to the concerned parameters.
Quentin Lambert (2):
staging: rts5208: Convert non-returned local variable to boolean when
relevant
staging: rts5208: Convert variable from int to bool and propagate the
change to function parameters
drivers/staging
\|devm_kzalloc\|devm_kmalloc\)(...);
if (e == NULL) {
<+...
- print(...,c,...);
... when any
(
goto l;
|
return ...;
)
...+> }
Signed-off-by: Quentin Lambert
---
drivers/staging/unisys/uislib/uislib.c | 2 --
drivers/staging/unisys/virthba/virthba.c
osition deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert
---
Changes since v1:
- replace cast from pci enum to dma
This patch reduces the kernel size by removing error messages that duplicate
the normal OOM message.
Signed-off-by: Quentin Lambert
---
drivers/staging/lustre/lustre/llite/llite_close.c | 4 +---
drivers/staging/lustre/lustre/llite/xattr_cache.c | 5 +
2 files changed, 2 insertions(+), 7
On 11/02/2015 11:23, Dan Carpenter wrote:
On Wed, Feb 11, 2015 at 06:26:27AM +0800, Greg Kroah-Hartman wrote:
On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote:
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Again, who
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert
---
The second of version of this patch fix the checkpatch warning of
line over 80 char by rewriting the size argument of kmalloc as suggested by
Sudip
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++---
drivers/staging/unisys/visorutil/charqueue.c| 3 ++-
drivers/staging/unisys
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert
---
drivers/staging/android/ion/ion_page_pool.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion
On 10/02/2015 12:04, Dan Carpenter wrote:
On Tue, Feb 10, 2015 at 11:42:08AM +0100, Quentin Lambert wrote:
The original version was success handling rather than error handling,
therefore this patch reduces nesting.
Signed-off-by: Quentin Lambert
Fantastic. :) Thanks!
regards,
dan
The original version was success handling rather than error handling,
therefore this patch reduces nesting.
Signed-off-by: Quentin Lambert
---
drivers/staging/ozwpan/ozhcd.c | 18 +++---
drivers/staging/ozwpan/ozpd.c | 53 +-
2 files changed, 37
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert
---
Changes since v1:
- Remove the blank line between allocation and NULL check
drivers/staging/ozwpan/ozhcd.c | 5 +++--
drivers/staging/ozwpan/ozpd.c | 8
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert
---
This patch was inspired by http://www.spinics.net/lists/linux-usb/msg44389.html
and https://lkml.org/lkml/2015/2/7/47 but I am not sure the argument is
1 - 100 of 156 matches
Mail list logo
