Re: [PATCH] Input - wacom: update the ABI doc according to latest changes

ility (the user space will be broken anyway). I proposed it a while ago [1] [1] http://www.gossamer-threads.com/lists/linux/kernel/1593583 Regards, Przemo Firszt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

Dnia 2014-07-31, czw o godzinie 08:56 -0700, Ping Cheng pisze: [..] Hi Ping, > I'd like to see Przemo's Tested-by tag here as well. Przemo, are you > done with your testing? Whole series: Tested-by: Przemo Firszt Tested on two Intuos4 Wireless (usb + bt) tablets. Everything w

Re: [PATCH v3 7/7] HID: remove hid-wacom Bluetooth driver

gt; -OLED_INIT(1); > -OLED_INIT(2); > -OLED_INIT(3); > -OLED_INIT(4); > -OLED_INIT(5); > -OLED_INIT(6); > -OLED_INIT(7); > - > - wdata->features = 0; > - wacom_set_features(hdev, 1); > - > - if (hdev->product == USB_DEVICE_ID_WACOM_INTUOS4_BLUETOOTH) { > - sprintf(hdev->name, "%s", "Wacom Intuos4 WL"); > - ret = wacom_initialize_leds(hdev); > - if (ret) > - hid_warn(hdev, > - "can't create led attribute, err: %d\n", ret); > - } > - > - wdata->battery.properties = wacom_battery_props; > - wdata->battery.num_properties = ARRAY_SIZE(wacom_battery_props); > - wdata->battery.get_property = wacom_battery_get_property; > - wdata->battery.name = "wacom_battery"; > - wdata->battery.type = POWER_SUPPLY_TYPE_BATTERY; > - wdata->battery.use_for_apm = 0; > - > - > - ret = power_supply_register(&hdev->dev, &wdata->battery); > - if (ret) { > - hid_err(hdev, "can't create sysfs battery attribute, err: %d\n", > - ret); > - goto err_battery; > - } > - > - power_supply_powers(&wdata->battery, &hdev->dev); > - > - wdata->ac.properties = wacom_ac_props; > - wdata->ac.num_properties = ARRAY_SIZE(wacom_ac_props); > - wdata->ac.get_property = wacom_ac_get_property; > - wdata->ac.name = "wacom_ac"; > - wdata->ac.type = POWER_SUPPLY_TYPE_MAINS; > - wdata->ac.use_for_apm = 0; > - > - ret = power_supply_register(&hdev->dev, &wdata->ac); > - if (ret) { > - hid_err(hdev, > - "can't create ac battery attribute, err: %d\n", ret); > - goto err_ac; > - } > - > - power_supply_powers(&wdata->ac, &hdev->dev); > - return 0; > - > -err_ac: > - power_supply_unregister(&wdata->battery); > -err_battery: > - wacom_destroy_leds(hdev); > - device_remove_file(&hdev->dev, &dev_attr_oled0_img); > - device_remove_file(&hdev->dev, &dev_attr_oled1_img); > - device_remove_file(&hdev->dev, &dev_attr_oled2_img); > - device_remove_file(&hdev->dev, &dev_attr_oled3_img); > - device_remove_file(&hdev->dev, &dev_attr_oled4_img); > - device_remove_file(&hdev->dev, &dev_attr_oled5_img); > - device_remove_file(&hdev->dev, &dev_attr_oled6_img); > - device_remove_file(&hdev->dev, &dev_attr_oled7_img); > - device_remove_file(&hdev->dev, &dev_attr_speed); > - hid_hw_stop(hdev); > -err_free: > - kfree(wdata); > - return ret; > -} > - > -static void wacom_remove(struct hid_device *hdev) > -{ > - struct wacom_data *wdata = hid_get_drvdata(hdev); > - > - wacom_destroy_leds(hdev); > - device_remove_file(&hdev->dev, &dev_attr_oled0_img); > - device_remove_file(&hdev->dev, &dev_attr_oled1_img); > - device_remove_file(&hdev->dev, &dev_attr_oled2_img); > - device_remove_file(&hdev->dev, &dev_attr_oled3_img); > - device_remove_file(&hdev->dev, &dev_attr_oled4_img); > - device_remove_file(&hdev->dev, &dev_attr_oled5_img); > - device_remove_file(&hdev->dev, &dev_attr_oled6_img); > - device_remove_file(&hdev->dev, &dev_attr_oled7_img); > - device_remove_file(&hdev->dev, &dev_attr_speed); > - hid_hw_stop(hdev); > - > - power_supply_unregister(&wdata->battery); > - power_supply_unregister(&wdata->ac); > - kfree(hid_get_drvdata(hdev)); > -} > - > -static const struct hid_device_id wacom_devices[] = { > - > - { } > -}; > -MODULE_DEVICE_TABLE(hid, wacom_devices); > - > -static struct hid_driver wacom_driver = { > - .name = "hid-wacom", > - .id_table = wacom_devices, > - .probe = wacom_probe, > - .remove = wacom_remove, > - .raw_event = wacom_raw_event, > - .input_mapped = wacom_input_mapped, > -}; > -module_hid_driver(wacom_driver); > - > -MODULE_DESCRIPTION("Driver for Wacom Graphire Bluetooth and Wacom Intuos4 > WL"); > -MODULE_LICENSE("GPL"); -- Kind regards, Przemo Firszt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

; + len = 256; > + xfer_id = WAC_CMD_ICON_BT_XFER; > + } else { > + len = 1024; > + xfer_id = WAC_CMD_ICON_XFER; > + } > + > + if (count != len) > return -EINVAL; > > mutex_lock(&wacom->lock); > &

[PATCH 2/2] Input - wacom: Remove passing id for wacom_set_report

Every call of wacom_set_report was passing "id" as a separate parameter and buffer also passed the same information. We can use first u8 of the buffer instead of "id" Signed-off-by: Przemo Firszt --- drivers/hid/wacom_sys.c | 27 +-- 1 file changed,

Re: [PATCH 11/10] Input - wacom: Check for bluetooth protocol while setting OLEDs

Whole series (after including bt image fix): Tested-By: Przemo Firszt Dnia 2014-07-25, pią o godzinie 19:20 -0400, Benjamin Tissoires pisze: > Bluetooth Intuos 4 use 1-bit definition while the USB ones use a 4-bits > definition. This changes the size of the raw image we receive, and thus

[PATCH 1/2] Input - Wacom: Fix transfer header problem

Header of transfer of image is different depending on connection type. That patch should be probably merged with 462c52a8cbcc62c Input - wacom: Check for bluetooth protocol while setting OLEDs Signed-off-by: Przemo Firszt --- drivers/hid/wacom_sys.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

ications) #define WAC_CMD_ICON_TRANSFER 0x26 wacom_sys.c: (after modifications) #define WAC_CMD_ICON_XFER 0x23 Changing it fixes the problem. Patches to follow soon. -- Kind regards, Przemo Firszt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

range of brightness might be different over usb and over bluetooth. TL;DR: the only thing that needs to be fixed is image-over-bluetooth, probably caused by not setting or incorrect setting of OLED brightness. -- Kind regards, Przemo Firszt -- To unsubscribe from this list: send the line &quo

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

you send me that set of 23 patches using git-send-email that I should apply on top of linux-next? I got it from lkml, but there is still something messed (fails on patch 09/23). Of course, if it's not a problem for you :-) -- Kind regards, Przemo Firszt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

Dnia 2014-07-25, pią o godzinie 08:58 -0400, Benjamin Tissoires pisze: > Hi Przemo, Hi Benjamin, > On Jul 25 2014 or thereabouts, Przemo Firszt wrote: > > Dnia 2014-07-24, czw o godzinie 14:13 -0400, Benjamin Tissoires pisze: > > [..] > > > Hi Przemo, > > Hi Benj

Re: [PATCH v2 00/10] Input - wacom: conversion to HID driver, series 2

ly apply your set yet to test it, so: Acked-by: Przemo Firszt What's your plan about LED/OLED API? > Benjamin Tissoires (9): > Input - wacom: put a flag when the led are initialized > Input - wacom: enhance Wireless Receiver battery reporting > Input - wacom: use

Re: [PATCH 0/5] Input - wacom: battery enhancements and unifying hid-wacom and wacom

power_supply/wacom_battery so sysfs is not happy about attempts to create duplicates. We need to distinguish between devices using consecutive numbers or something else. [1] https://sourceforge.net/p/linuxwacom/bugs/248/ -- Kind regards, Przemo Firszt -- To unsubscribe from this list: send the lin

Re: [PATCH 0/5] Input - wacom: battery enhancements and unifying hid-wacom and wacom

POWER_SUPPLY_PRESENT=1 POWER_SUPPLY_ONLINE=1 POWER_SUPPLY_SCOPE=Device bash-4.2$ cat /sys/class/power_supply/wacom_battery/uevent POWER_SUPPLY_NAME=wacom_battery POWER_SUPPLY_PRESENT=1 POWER_SUPPLY_CAPACITY=85 POWER_SUPPLY_SCOPE=Device POWER_SUPPLY_STATUS=Charging -- Kind regards, Przemo Firszt

Re: [Linuxwacom-devel] [PATCH 00/15] Input - Wacom: switch from an USB to a HID driver

Hi Benjamin, I'm having some problems to cleanly apply your patches - can you double check that they are OK? -- Regards, Przemo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [Linuxwacom-devel] [PATCH 06/15] Input - wacom: install LED/OLED sysfs files in the HID device instead of USB

/gnome-settings-daemon/tree/plugins/wacom/gsd-wacom-oled-helper.c Regards, Przemo Firszt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html P

[PATCH] hid: wacom: Intuos4 battery charging changes

, but it's not in use - the battery/ac status will be incorrect. Currently there is no mechanism to ask the device to send a report containing battery/ac status. Signed-off-by: Przemo Firszt --- drivers/hid/hid-wacom.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-)

[PATCH 1/9] rtl8712: code clean up

Clean some trivial formating problems in rtl8712 from staging tree. This patch also changes the way preprocessor macros are defined to keep checkpatch.pl quiet. Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/ieee80211.h| 2 +- drivers/staging/rtl8712/rtl871x_cmd.h | 2

[PATCH 5/9] rtl8712: remove unused macros

Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/usb_ops_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c index 9e28ef0..dca398a 100644 --- a/drivers/staging/rtl8712/usb_ops_linux.c +++ b

[PATCH 3/9] rtl8712: replace printk with better solutions

Replace printk with netdev_printk helpers, dev_printk helpers or pr_err/warn/info if there is no device info available. Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/hal_init.c| 17 - drivers/staging/rtl8712/os_intfs.c| 3 +- drivers/staging/rtl8712

[PATCH 4/9] rtl8712: replace min with min_t

I've changed the ugly casting here and used min_t() instead. I also changed the u16 to a u32 because ->network.Ssid.SsidLength is 32 bits. It doesn't make a difference, but truncating the upper bits away is sloppy. Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/rtl871x_

[PATCH 7/9] rtl8712: remove unused definitions from ethernet.h

Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/ethernet.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8712/ethernet.h b/drivers/staging/rtl8712/ethernet.h index 9095420..fad173f 100644 --- a/drivers/staging/rtl8712/ethernet.h +++ b/drivers/staging

[PATCH 2/9] rtl8712: remove unused macros from rtl8712/wifi.h

Those definitions are not used anywhere in the kernel. If you know any reason why they should stay in the code please speak up! Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/wifi.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging

Re: [PATCH 4/5] rtl8712: replace min with min_t

0x10001. The cast to u16 changes it to 0x0001 which > is less than 32 so we would say the minimum is 1 when actually we > want to say 32 is the min. > Dan, Thank you! That was the thing that I missed... New set of patches on the way. -- Kind regards, Przemo Firszt -- To unsubscribe fr

Re: [PATCH 4/5] rtl8712: replace min with min_t

Dnia 2012-12-10, pon o godzinie 12:41 +0300, Dan Carpenter pisze: > On Sun, Dec 09, 2012 at 10:15:09AM +0000, Przemo Firszt wrote: > > A clean up change suggested by checkpatch.pl > > > > Signed-off-by: Przemo Firszt > > --- > > drivers/staging/rtl8712/rtl871

[PATCH 1/5] rtl8712: code clean up

Clean some trivial formating problems in rtl8712 from staging tree. This patch also changes the way preprocessor macros are defined to keep checkpatch.pl quiet. Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/ieee80211.h| 2 +- drivers/staging/rtl8712/rtl871x_cmd.h | 2

[PATCH 2/5] rtl8712: remove unused macros from rtl8712/wifi.h

Those definitions are not used anywhere in the kernel. If you know any reason why they should stay in the code please speak up! Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/wifi.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging

[PATCH 4/5] rtl8712: replace min with min_t

A clean up change suggested by checkpatch.pl Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c

[PATCH 3/5] rtl8712: replace printk with better solutions

Replace printk with netdev_printk helpers, dev_printk helpers or pr_err/warn/info if there is no device info available. Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/hal_init.c| 17 ++- drivers/staging/rtl8712/os_intfs.c| 3 +- drivers/staging/rtl8712

[PATCH 5/5] rtl8712: replace leading spaces with tab

Replace leading spaces with tab Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index b131b61

Re: [PATCH] USB: input: wacom_sys.c: format OLED image in kernel

Dnia 4 Października 2012, 8:25 am, Cz, Dmitry Torokhov napisał(a): > Hi Przemo, Hi Dmitry, > > On Sun, Sep 09, 2012 at 03:37:18PM -0400, Przemo Firszt wrote: >> This patch adds a new way of handling Wacom Intuos4 family OLEDs. >> Previously the images had to be 'scramble

[PATCH] USB: input: wacom_sys.c: format OLED image in kernel

reaking API. Signed-off-by: Przemo Firszt --- Documentation/ABI/testing/sysfs-driver-wacom | 7 drivers/input/tablet/wacom_sys.c | 60 +--- 2 files changed, 62 insertions(+), 5 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-wacom

[PATCH 1/2] HID: wacom: Use half of brightness for low state

of that value as low. Signed-off-by: Przemo Firszt --- drivers/hid/hid-wacom.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c index fe23a1e..848842e 100644 --- a/drivers/hid/hid-wacom.c +++ b/drivers/hid/hid-wacom.c

[PATCH 2/2] HID: wacom: OLEDs control over sysfs for Intuos4

bytes (64x32px 1 bit). More detailed description in Documentation/ABI/testing/sysfs-driver-wacom Signed-off-by: Przemo Firszt --- Documentation/ABI/testing/sysfs-driver-wacom | 13 +++ drivers/hid/hid-wacom.c | 143 ++ 2 files changed, 156 insertions