On 28-01-2025 03:03, Weinan Liu wrote:
Since SFrame is considered as reliable stacktrace, enable livepatch in
arch/arm64/Kconfig
Signed-off-by: Weinan Liu
---
arch/arm64/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 100570a048c
ntry_data {
bool (*consume_entry)(void *cookie, u64 ip, u64 sp, u64 fp);
void *cookie;
Why not fold the previous patch and this into one?
But the code looks good to me.
Reviewed-by: Prasanna Kumar T S M .
NDER
+ .cfa = 0,
+#endif
},
};
Looks good to me.
Reviewed-by: Prasanna Kumar T S M .
On 30-01-2025 15:52, Prasanna Kumar T S M wrote:
On 28-01-2025 03:03, Weinan Liu wrote:
This change introduces a kernel space unwinder using sframe table for
architectures without ORC unwinder support.
The implementation is adapted from Josh's userspace sframe unwinder
proposal[1] acco
+ sftbl.sfhdr_p->fdes_off);
+ sftbl.fre_p = __start_sframe_header + SFRAME_HDR_SIZE(*sftbl.sfhdr_p)
+ + sftbl.sfhdr_p->fres_off;
+ sframe_init = true;
+}
Other than the minor suggestion, the code looks good to me.
Reviewed-by: Prasanna Kumar T S M .
klp_update_patch_state(current);
+
if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
do_signal(regs);
Looks good to me.
Reviewed-by: Prasanna Kumar T S M .
"
Looks good to me.
Reviewed-by: Prasanna Kumar T S M .
& 0x1) << 7) | ((fre_info) & 0x7f))
+
+#define SFRAME_FRE_CFA_BASE_REG_ID(data) ((data) & 0x1)
+#define SFRAME_FRE_OFFSET_COUNT(data)(((data) >> 1) & 0xf)
+#define SFRAME_FRE_OFFSET_SIZE(data) (((data) >> 5) & 0x3)
+#define SFRAME_FRE_MANGLED_RA_P(data)(((data) >> 7) & 0x1)
+
+#endif /* _SFRAME_H */
Looks good to me.
Reviewed-by: Prasanna Kumar T S M .
_index : AT(ADDR(.printk_index) - LOAD_OFFSET) { \
Looks good to me.
Reviewed-by: Prasanna Kumar T S M .
9 matches
Mail list logo
