[[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-24 Thread Pranay Kr. Srivastava
speakup_allocate used GFP_ATOMIC for allocations even while during initialization due to it's use in notifier call. Pass GFP_ flags as well to speakup_allocate depending on the context it is called in. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 8 1

[PATCH staging/speakup v3 2/3] remove unnecessary initial allocation of vc

2017-03-21 Thread Pranay Kr. Srivastava
This patch removes the unnecessary allocation of current foreground vc during initialization. This initialization is already handled in the loop that follows it for all available virtual consoles. Signed-off-by: Pranay Kr. Srivastava Reviewed-by: Samuel Thibault --- drivers/staging/speakup

[PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-21 Thread Pranay Kr. Srivastava
speakup_allocate used GFP_ATOMIC for allocations even while during initialization due to it's use in notifier call. Pass GFP_ flags as well to speakup_allocate depending on the context it is called in. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 8 1

[PATCH staging/speakup v3 0/3] cleanup error and initilization

2017-03-21 Thread Pranay Kr. Srivastava
Changelog from v2: Fixed the message subject line. Changelog from v1: 1. fixed kbuild warning for i386 build as reported by kbuild robot 2. split initialization code in two patches. Pranay Kr. Srivastava (3): return same error value from spk_set_key_info remove

[PATCH staging/speakup v3 1/3] return same error value from spk_set_key_info

2017-03-21 Thread Pranay Kr. Srivastava
This patch makes spk_set_key_info return -EINVAL in case of failure instead of returning 4 different values for the type of error that occurred. Print the offending values instead as debug message. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 27

[PATCH SPEAKUP v2 2/3] remove unecessary initial allocation of vc

2017-02-28 Thread Pranay Kr. Srivastava
This patch removes the unnecessary allocation of current foreground vc during initialization. This initialization is already handled in the loop that follows it for all available virtual consoles. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 11 --- 1 file

[PATCH SPEAKUP v2 3/3] use spkeaup_allocate as per required context

2017-02-28 Thread Pranay Kr. Srivastava
speakup_allocate used GFP_ATOMIC for allocations even while during initialization due to it's use in notifier call. Pass GFP_ flags as well to speakup_allocate depending on the context it is called in. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 8 1

[PATCH SPEAKUP v2 0/3] cleanup error and initilization

2017-02-28 Thread Pranay Kr. Srivastava
Changelog from v1: 1. fixed kbuild warning for i386 build as reported by kbuild robot 2. split initialization code in two patches. Pranay Kr. Srivastava (3): return same error value from spk_set_key_info remove unecessary initial allocation of vc use spkeaup_allocate as per

[PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info

2017-02-28 Thread Pranay Kr. Srivastava
This patch makes spk_set_key_info return -EINVAL in case of failure instead of returning 4 different values for the type of error that occurred. Print the offending values instead as debug message. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 27

[PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info

2017-02-21 Thread Pranay Kr. Srivastava
This patch makes spk_set_key_info return -EINVAL in case of failure instead of returning 4 different values for the type of error that occurred. Print the offending values instead as debug message. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 27

[PATCH-SPEAKUP 2/2] remove unecessary initial allocation of vc

2017-02-21 Thread Pranay Kr. Srivastava
requiring GFP_ATOMIC during initialization. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index 6667cf2..f81a936 100644

[no subject]

2017-02-21 Thread Pranay Kr. Srivastava
Sending both patches as series instead. Made the required changes as suggessted in earlier versions and fixed the warnings reported from kbuild test robot.

[PATCH] remove unnecessary initial allocation of vc

2017-02-21 Thread Pranay Kr. Srivastava
This patch removes the unnecessary allocation of current foreground vc during initialization. Also change the prototype of speakup_allocate to take extra argument of gfp_* flags. Thus not requiring GFP_ATOMIC during initialization. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging

[PATCH Speakup v2] return same error value from spk_set_key_info

2017-02-21 Thread Pranay Kr. Srivastava
This patch makes spk_set_key_info return -EINVAL in case of failure instead of returning 4 different values for the type of error that occurred. Print the offending values instead as debug message. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 28

[PATCH] return same error value from spk_set_key_info

2017-02-21 Thread Pranay Kr. Srivastava
This patch makes spk_set_key_info return -EINVAL in case of failure instead of returning 4 different values for the type of error that occurred. Retain the previous error values as debug messages instead. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 24

[PATCH v5 3/4] make nbd device wait for its users

2016-07-16 Thread Pranay Kr Srivastava
, however there are "other" user processes which currently have this nbd device opened. Signed-off-by: Pranay Kr Srivastava --- drivers/block/nbd.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/drivers/block/nbd.c b

[PATCH v5 2/4] nbd: fix might_sleep warning on socket shutdown.

2016-07-16 Thread Pranay Kr Srivastava
From: "Pranay Kr. Srivastava" spinlocked ranges should be small and not contain calls into huge subfunctions. Fix my mistake and just get the pointer to the socket instead of doing everything with spinlock held. Reported-by: Mikulas Patocka Signed-off-by: Markus Pargmann Changelog:

[no subject]

2016-07-16 Thread Pranay Kr Srivastava
Hi Markus, Can you take a look at this. Let me know if this looks ok, I'll resend the whole series again. Regards,

[PATCH 0/1]ext4: Fix for WARN_ON_ONCE when marking buffer dirty

2016-06-30 Thread Pranay Kr. Srivastava
from being uptodate. If the buffer uptodate is not set while calling mark_buffer_dirty, it throws a WARN_ON_ONCE. This patch fixes it by locking the buffer while marking the buffer uptodate and then marking it dirty while holding the buffer head lock. Pranay Kr. Srivastava (

[PATCH 1/1]ext4: Fix WARN_ON_ONCE when marking buffer dirty

2016-06-30 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- fs/ext4/super.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 3822a5a..8f10715 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4327,20 +4327,6 @@ static

[PATCH v4 3/5]nbd: make nbd device wait for its users

2016-06-30 Thread Pranay Kr. Srivastava
bdev open closes this bdev. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 106 ++-- 1 file changed, 87 insertions(+), 19 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index e362d44..fb56dd2 100644 --- a/dri

[PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown

2016-06-30 Thread Pranay Kr. Srivastava
spinlocked ranges should be small and not contain calls into huge subfunctions. Fix my mistake and just get the pointer to the socket instead of doing everything with spinlock held. Reported-by: Mikulas Patocka Signed-off-by: Markus Pargmann Changelog: Pranay Kr. Srivastava: 1) Use spin_lock

[PATCH v4 4/5]nbd: use i_size_write to assign nbd device size

2016-06-30 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index fb56dd2..7126878 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -128,7 +128,7 @@ static const char

[PATCH v4 0/4] nbd: nbd fixes

2016-06-30 Thread Pranay Kr. Srivastava
e for modification. Pranay Kr. Srivastava (4): cleanup nbd_set_socket fix might_sleep warning on socket shutdown make nbd device wait for its users use i_size_write to assign nbd device size drivers/block/nbd.c | 168 ++-- 1 file changed

[PATCH v4 1/5]nbd: cleanup nbd_set_socket

2016-06-30 Thread Pranay Kr. Srivastava
From: "Pranay Kr. Srivastava" This patch 1) uses spin_lock instead of irq version. 2) removes the goto statement in case a socket is already assigned with simple if-else statement. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 15 +-- 1 file

[PATCH v3 2/3]nbd: cleanup nbd_set_socket

2016-06-24 Thread Pranay Kr. Srivastava
This patch 1) uses spin_lock instead of irq version. 2) removes the goto statement in case a socket is already assigned with simple if-else statement. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff

[PATCH 3/3]nbd: make nbd device wait for its users

2016-06-24 Thread Pranay Kr. Srivastava
aving this bdev open closes this bdev. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 124 1 file changed, 96 insertions(+), 28 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 9223b09..0587bbd 10064

[PATCH v3 1/3]nbd: fix might_sleep warning on socket shutdown

2016-06-24 Thread Pranay Kr. Srivastava
spinlocked ranges should be small and not contain calls into huge subfunctions. Fix my mistake and just get the pointer to the socket instead of doing everything with spinlock held. Reported-by: Mikulas Patocka Signed-off-by: Markus Pargmann Changelog: Pranay Kr. Srivastava: 1) Use spin_lock

[PATCH v3 0/3] nbd: resolve bugs and limitations

2016-06-24 Thread Pranay Kr. Srivastava
tdown, depending on either a timeout/error occured or a disconnect was issued. Also avoid scheduling the work_fn in case a timeout for a request has already occured. Pranay Kr. Srivastava (3): fix might_sleep warning on socket shutdown cleanup nbd_set_socket make nbd device wait fo

[PATCH v2 0/5] nbd: fixes for nbd

2016-06-02 Thread Pranay Kr. Srivastava
ed a check of the internal atomic counter of kref which was ugly. v2 of this patch make this more readable and doesn't do manual check of the internal counter used by kref. 5) use device_attr macros for sysfs attribute No Change. Pranay Kr. Srivastava (5): fix might_sleep

[PATCH v2 1/5] nbd: fix might_sleep warning on socket shutdown.

2016-06-02 Thread Pranay Kr. Srivastava
spinlocked ranges should be small and not contain calls into huge subfunctions. Fix my mistake and just get the pointer to the socket instead of doing everything with spinlock held. Reported-by: Mikulas Patocka Signed-off-by: Markus Pargmann Changelog: Pranay Kr. Srivastava: 1) Use spin_lock

[PATCH v2 4/5]nbd: make nbd device wait for its users.

2016-06-02 Thread Pranay Kr. Srivastava
refcounted, while the userland program [nbd-client] doing the NBD_DO_IT ioctl would now wait for any other users of this device before invalidating the nbd device. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 58 + 1 file c

[PATCH v2 5/5]nbd: use device_attr macros for sysfs attribute

2016-06-02 Thread Pranay Kr. Srivastava
This patch changes the pid sysfs device attribute to use DEVICE_ATTR_* macro. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 4da40dc..323ab26 100644 --- a

[PATCH v2 2/5]nbd: cleanup nbd_set_socket

2016-06-02 Thread Pranay Kr. Srivastava
This patch 1) uses spin_lock instead of irq version. 2) removes the goto statement in case a socket is already assigned with simple if-else statement. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[PATCH v2 3/5]nbd: fix various coding standard warnings

2016-06-02 Thread Pranay Kr. Srivastava
warning 12) nbd: fix checkpatch no extra line after decleration warning 13) nbd: fix checkpatch printk warning to pr_info 14) nbd: fix checkpatch no new line after decleration warning 15) nbd: fix checkpatch printk warning to pr_info Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c

[PATCH 3/4] make nbd device wait for its users.

2016-05-24 Thread Pranay Kr. Srivastava
this. The device will be released for kref count of 2, not less or more. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index af86c9

[PATCH 1/4] fix might_sleep warning on socket shutdown.

2016-05-24 Thread Pranay Kr. Srivastava
spinlocked ranges should be small and not contain calls into huge subfunctions. Fix my mistake and just get the pointer to the socket instead of doing everything with spinlock held. Reported-by: Mikulas Patocka Signed-off-by: Markus Pargmann Changelog: Pranay Kr. Srivastava: 1) Use spin_lock

[PATCH 2/4] fix various coding standard warnings

2016-05-24 Thread Pranay Kr. Srivastava
warning 12) nbd: fix checkpatch no extra line after decleration warning 13) nbd: fix checkpatch printk warning to pr_info 14) nbd: fix checkpatch no new line after decleration warning 15) nbd: fix checkpatch printk warning to pr_info Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c

[PATCH 0/4]nbd: fixes for nbd

2016-05-24 Thread Pranay Kr. Srivastava
s for sysfs attribute use DEVICE_ATTR_RO for sysfs pid attribute. Pranay Kr. Srivastava (4): fix might_sleep warning on socket shutdown. fix various coding standard warnings make nbd device wait for its users. use device_attr macros for sysfs attribute drivers/block/nbd.c |

[PATCH 4/4] use device_attr macros for sysfs attribute

2016-05-24 Thread Pranay Kr. Srivastava
This patch changes the pid sysfs device attribute to use DEVICE_ATTR_* macro. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 59db890..d6ab9c9 100644

[PATCH v4 03/18] nbd: fix checkpatch warning use linux/uaccess.h

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 82aac42..c7ccde7 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -35,7 +35,7 @@ #include #include

[PATCH v4 06/18] nbd: fix checkpatch warning no newline after decleration.

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 2192c0e..6a4dc3a 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -355,6 +355,7 @@ static inline int sock_recv_bvec(struct

[PATCH v4 04/18] nbd : fix checkpatch pointer declaration warning

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c7ccde7..786aaac 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -42,7 +42,7 @@ struct nbd_device

[PATCH v4 09/18] nbd: fix checkpatch trailing whitespace warning.

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 224b44eb..2f1e5d0 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -627,7 +627,7 @@ static void

[PATCH v4 13/18] nbd : fix checkpatch printk warning

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 4fd3016..690e734 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1018,7 +1018,7 @@ static int __init

[PATCH v4 10/18] nbd: fix checkpatch trailing whitespace warning.

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 2f1e5d0..0bc73dd 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -745,7 +745,7 @@ static int __nbd_ioctl

[PATCH v4 16/18] nbd: fix checkpatch no new line after decleration warning

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 9ce350b..e308f8b 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1086,6 +1086,7 @@ static int __init nbd_init(void

[PATCH v4 15/18] nbd: fix checkpatch printk warning to pr_info

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 6633ab2..9ce350b 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1080,7 +1080,7 @@ static int __init

[PATCH v4 17/18] nbd: fix checkpatch printk warning to pr_info

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index e308f8b..482a3c0 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1134,7 +1134,7 @@ static void __exit

[PATCH v4 18/18] make nbd device wait for its users in case of timeout

2016-05-11 Thread Pranay Kr. Srivastava
: a) Add a users count to nbd_device structure. b) Add a bit flag to nbd_device structure of unsigned long. If the current user count is not 1 then make nbd-client wait for the in_use bit to be cleared. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c

[PATCH v4 14/18] nbd: fix checkpatch no extra line after decleration warning

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 690e734..6633ab2 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1049,6 +1049,7 @@ static int __init nbd_init(void

[PATCH v4 11/18] nbd : fix checkpatch structure declaration braces on next line warning.

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 0bc73dd..a6f11c3 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -870,8 +870,7 @@ static int nbd_ioctl

[PATCH v4 05/18] nbd: fix checkpatch warning no newline after decleration.

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 786aaac..2192c0e 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -257,6 +257,7 @@ static inline int sock_send_bvec(struct

[PATCH v4 07/18] nbd: fix checkpatch split string warning.

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 6a4dc3a..7a5b8ef 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -587,8 +587,7 @@ static int

[PATCH v4 08/18] nbd : fix checkpatch line over 80 char warning

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 7a5b8ef..224b44eb 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -617,8 +617,8 @@ static int

[PATCH v4 12/18] nbd : fix checkpatch trailing whitespace warning

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index a6f11c3..4fd3016 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1005,7 +1005,7 @@ static void

[PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

2016-05-11 Thread Pranay Kr. Srivastava
ld it anymore. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 65 - 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 31e73a7..c79bcd7 100644 --- a/drivers/block/nbd.c

[PATCH v4 00/18] nbd: fixes for might_sleep warning, checkpatch warning and device wait.

2016-05-11 Thread Pranay Kr. Srivastava
. Changes in v2 - add checkpatch changes in a single patch. Changes in v1 - fix might_sleep warning on xmit_timeout. Pranay Kr. Srivastava (18): nbd: Fix might_sleep warning on xmit timeout nbd: fix checkpatch trailing space warning. nbd: fix checkpatch warning use linux

[PATCH v4 02/18] nbd: fix checkpatch trailing space warning.

2016-05-11 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c79bcd7..82aac42 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -3,7 +3,7 @@ * * Note that you can

[PATCH v3 05/17] nbd: fix checkpatch warning no newline after decleration.

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 786aaac..2192c0e 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -257,6 +257,7 @@ static inline int sock_send_bvec(struct

[PATCH v3 06/17] nbd: fix checkpatch warning no newline after decleration.

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 2192c0e..6a4dc3a 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -355,6 +355,7 @@ static inline int sock_recv_bvec(struct

[PATCH v3 02/17] nbd: fix checkpatch trailing space warning.

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c79bcd7..82aac42 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -3,7 +3,7 @@ * * Note that you can

[PATCH v3 07/17] nbd: fix checkpatch split string warning.

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 6a4dc3a..7a5b8ef 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -587,8 +587,7 @@ static int

[PATCH v3 03/17] nbd: fix checkpatch warning use linux/uaccess.h

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 82aac42..c7ccde7 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -35,7 +35,7 @@ #include #include

[PATCH v3 09/17] nbd: fix checkpatch trailing whitespace warning.

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 224b44eb..2f1e5d0 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -627,7 +627,7 @@ static void

[PATCH v3 11/17] nbd : fix checkpatch structure declaration braces on next line warning.

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 0bc73dd..a6f11c3 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -870,8 +870,7 @@ static int nbd_ioctl

[PATCH v3 14/17] nbd: fix checkpatch no extra line after decleration warning

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 690e734..6633ab2 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1049,6 +1049,7 @@ static int __init nbd_init(void

[PATCH v3 15/17] nbd: fix checkpatch printk warning to pr_info

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 6633ab2..9ce350b 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1080,7 +1080,7 @@ static int __init

[PATCH v3 12/17] nbd : fix checkpatch trailing whitespace warning

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index a6f11c3..4fd3016 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1005,7 +1005,7 @@ static void

[PATCH v3 13/17] nbd : fix checkpatch printk warning

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 4fd3016..690e734 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1018,7 +1018,7 @@ static int __init

[PATCH v3 16/17] nbd: fix checkpatch no new line after decleration warning

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 9ce350b..e308f8b 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1086,6 +1086,7 @@ static int __init nbd_init(void

[PATCH v3 10/17] nbd: fix checkpatch trailing whitespace warning.

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 2f1e5d0..0bc73dd 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -745,7 +745,7 @@ static int __nbd_ioctl

[PATCH v3 17/17] nbd: fix checkpatch printk warning to pr_info

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index e308f8b..482a3c0 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1134,7 +1134,7 @@ static void __exit

[PATCH v3 08/17] nbd : fix checkpatch line over 80 char warning

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 7a5b8ef..224b44eb 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -617,8 +617,8 @@ static int

[PATCH v3 04/17] nbd : fix checkpatch pointer declaration warning

2016-05-06 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c7ccde7..786aaac 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -42,7 +42,7 @@ struct nbd_device

[PATCH v3 00/17] nbd : fix might sleep warning and checkpatch errors.

2016-05-06 Thread Pranay Kr. Srivastava
Changes in v3 - Split checkpatch changes into single patch per change. Changes in v2 - add checkpatch changes in a single patch. Changes in v1 - fix might_sleep warning on xmit_timeout. Pranay Kr. Srivastava (17): nbd: Fix might_sleep warning on xmit timeout nbd: fix

[PATCH v3 01/17] nbd: Fix might_sleep warning on xmit timeout

2016-05-06 Thread Pranay Kr. Srivastava
ld it anymore. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 65 - 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 31e73a7..c79bcd7 100644 --- a/drivers/block/nbd.c

[PATCH v2 2/2] nbd: Fix checkpatch errors.

2016-05-03 Thread Pranay Kr. Srivastava
Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c79bcd7..9ab3a27 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -3,7

[PATCH v2 0/2] nbd: fix might_sleep warning and checkpatch fixes.

2016-05-03 Thread Pranay Kr. Srivastava
This patch series fixes 01) might_sleep warning generated on a xmit_timeout as the socket is shutdown while holding the spin_lock. Instead now the socket is shutdown in the sender kernel thread. 02) checkpatch errors. Pranay Kr. Srivastava (2): nbd: Fix might_sleep warning on xmit

[PATCH v2 1/2] nbd: Fix might_sleep warning on xmit timeout

2016-05-03 Thread Pranay Kr. Srivastava
ld it anymore. Signed-off-by: Pranay Kr. Srivastava --- drivers/block/nbd.c | 65 - 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 31e73a7..c79bcd7 100644 --- a/drivers/block/nbd.c

[RESEND PATCH]nbd: fix might_sleep warning on socket shutdown

2016-04-29 Thread Pranay Kr. Srivastava
This patch fixes the warning generated when a timeout occurs on the request and socket is closed from a non-sleep context by 1. Moving the socket closing on a timeout to nbd_thread_send 2. Make sock lock to be a mutex instead of a spin lock, since nbd_xmit_timeout doesn't need to hold it anymo

[RESEND PATCH]nbd: Fix might sleep warning.

2016-04-29 Thread Pranay Kr. Srivastava
When an nbd request times out then the nbd_xmit_timeout tries to close the socket by taking a spin_lock over the socket. This however generates a warning on kernel_sock_shutdown. This patch fixes this issue. Pranay Kr. Srivastava (1): fix might_sleep warning on socket shutdown drivers/block

[PATCH] Fix might sleep warning.

2016-04-27 Thread Pranay Kr. Srivastava
When an nbd request times out then the nbd_xmit_timeout tries to close the socket by taking a spin_lock over the socket. This however generates a warning on kernel_sock_shutdown. This patch fixes this issue. Pranay Kr. Srivastava (1): fix might_sleep warning on socket shutdown drivers/block

[PATCH] fix might_sleep warning on socket shutdown

2016-04-27 Thread Pranay Kr. Srivastava
This patch fixes the warning generated when a timeout occurs on the request and socket is closed from a non-sleep context by 1. Moving the socket closing on a timeout to nbd_thread_send 2. Make sock lock to be a mutex instead of a spin lock, since nbd_xmit_timeout doesn't need to hold it anymo

[PATCH] make affs root lookup from blkdev logical size

2015-07-07 Thread Pranay Kr. Srivastava
This patch resolves Bug 16531. When logical blkdev size > 512 then sector numbers become larger than the device can support. Make affs start lookup based on the device's logical sector size instead of 512. Reported By: Mark Fix Suggessted By: Mark --- fs/affs/super.c |8 +--- 1 file ch