Re: [PATCH v2 1/3] iio: accel: adxl372: Fix/remove limitation for FIFO samples

2019-09-17 Thread Popa, Stefan Serban
On Du, 2019-09-15 at 14:27 +0100, Jonathan Cameron wrote: > > > > On Tue, 10 Sep 2019 17:43:32 +0300 > Stefan Popa wrote: > > > > > > > > > > > Currently, the driver sets the FIFO_SAMPLES register with the number of > > sample sets (maximum of 170 for 3 axis data, 256 for 2-axis and 512 fo

Re: [PATCH v5 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL

2019-06-12 Thread Popa, Stefan Serban
Hi Rob, I'm sorry I forgot to include your Reviewed-by in this patch series. However, I realized this mistake and added it to v6 which in the meantime Jonathan has applied. I will fix your remark bellow regarding clock-names in the next patch series for this device. Thank you, -Stefan On Ma, 20

Re: [PATCH] dt-bindings: iio: accel: adxl372: switch to YAML bindings

2019-05-24 Thread Popa, Stefan Serban
On Sb, 2019-05-18 at 18:55 -0300, Lucas Oshiro wrote: > [External] > > > Convert the old device tree documentation to yaml format. > > Signed-off-by: Lucas Oshiro > Signed-off-by: Rodrigo Ribeiro > Co-developed-by: Rodrigo Ribeiro > --- > > Hello, > We've added Stefan Popa as maintainer of t

Re: [PATCH] iio: adc: fix indentation issue, remove extra tab

2019-03-15 Thread Popa, Stefan Serban
On Jo, 2019-03-14 at 23:26 +, Colin King wrote: > [External] > > > From: Colin Ian King > > A return statement is indented one level too deeply; clean this > up by removing a tab. > > Signed-off-by: Colin Ian King Acked-by: Stefan Popa Thanks! > --- >  drivers/iio/adc/ad7124.c | 2 +- >

Re: [PATCH 2/6] iio: imu: adis16480: Add support for configurable drdy indicator

2019-02-20 Thread Popa, Stefan Serban
On Mi, 2019-02-20 at 10:29 +, Jonathan Cameron wrote: > [External] > > > On Tue, 19 Feb 2019 19:12:14 +0200 > Stefan Popa wrote: > > > > > The FNCTIO_CTRL register provides configuration control for each I/O > > pin > > (DIO1, DIO2, DIO3 and DIO4). > > > > This patch adds the option to co

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-02-14 Thread Popa, Stefan Serban
On Mi, 2019-02-13 at 22:25 -0200, Rodrigo Ribeiro wrote: > [External] > > > Em ter, 29 de jan de 2019 às 07:10, Alexandru Ardelean l.com> escreveu: > > > > On Sat, Jan 26, 2019 at 8:13 PM Jonathan Cameron > wrote: > > > > > > On Fri, 25 Jan 2019 22:14:32 -0200 > > > Rodrigo Ribeiro wrote: > >

Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

2019-02-01 Thread Popa, Stefan Serban
On Vi, 2019-02-01 at 12:55 -0200, Renato Lui Geh wrote: > On 01/30, Popa, Stefan Serban wrote: > > > > On Du, 2019-01-27 at 18:30 -0200, Renato Lui Geh wrote: > > > > > > Previously, the AD7780 driver only supported gpio for the 'powerdown' > > &g

Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

2019-01-30 Thread Popa, Stefan Serban
On Du, 2019-01-27 at 18:30 -0200, Renato Lui Geh wrote: > Previously, the AD7780 driver only supported gpio for the 'powerdown' > pin. This commit adds suppport for the 'gain' and 'filter' pin. > > Signed-off-by: Renato Lui Geh > Signed-off-by: Giuliano Belinassi > Co-developed-by: Giuliano Beli

Re: [PATCH v2 1/2] iio: adc: Add AD7768-1 ADC basic support

2019-01-21 Thread Popa, Stefan Serban
On Sb, 2019-01-19 at 17:55 +, Jonathan Cameron wrote: > Use caution when clicking links or attachments as this email originated > outside of Analog Devices. > > > On Tue, 15 Jan 2019 14:33:11 +0200 > Stefan Popa wrote: > > > > > The ad7768-1 is a single channel, precision 24-bit analog to

Re: [PATCH 05/11] staging: iio: adc: ad7606: Add support for threaded irq

2018-12-17 Thread Popa, Stefan Serban
On Du, 2018-12-16 at 13:49 +, Jonathan Cameron wrote: > On Thu, 13 Dec 2018 14:46:17 +0200 > Stefan Popa wrote: > > > > > This patch replaces the use of a polling ring buffer with a threaded > > interrupt. > > > > Enabling the buffer sets the CONVST signal to high. When the rising > > edge

Re: [PATCH 1/2] staging: iio: ad7780: Add gain & filter gpio support

2018-11-29 Thread Popa, Stefan Serban
On Mi, 2018-11-28 at 16:15 -0200, Giuliano Belinassi wrote: > Previously, the AD7780 driver only supported gpio for the 'powerdown' > pin. This commit adds suppport for the 'gain' and 'filter' pin. > > Signed-off-by: Giuliano Belinassi > --- > Changes in v2: > - Now this patch is part of the

Re: [PATCH] staging: iio: ad7780: Add gain & filter gpio support

2018-11-27 Thread Popa, Stefan Serban
On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote: Hi, please see bellow > Hi, thank you for the review > > > > > On Thu, 22 Nov 2018 11:01:00 + > > "Popa, Stefan Serban" wrote: > > > > > > I think that instead o

Re: [PATCH] staging: iio: ad7780: Add gain & filter gpio support

2018-11-22 Thread Popa, Stefan Serban
On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote: > Previously, the AD7780 driver only supported gpio for the 'powerdown' > pin. This commit adds suppport for the 'gain' and 'filter' pin. Hey, Comments inline. > > Signed-off-by: Giuliano Belinassi > --- >  drivers/staging/iio/adc/ad778

Re: [PATCH v4 4/4] dt-bindings: iio: adc: Add docs for ad7124

2018-11-12 Thread Popa, Stefan Serban
On Du, 2018-11-11 at 12:19 +, Jonathan Cameron wrote: > > On Fri, 9 Nov 2018 17:43:00 +0200 > Stefan Popa wrote: > > > > > > > Add support for Analog Devices AD7124 4-channels and 8-channels ADC. > > > > Signed-off-by: Stefan Popa > Your example still includes the other things that I thi

Re: [PATCH v3 2/3] iio: adc: Add ad7124 support

2018-11-08 Thread Popa, Stefan Serban
On Jo, 2018-11-08 at 10:34 -0600, Rob Herring wrote: > On Thu, Nov 8, 2018 at 9:02 AM Popa, Stefan Serban > wrote: > > > > > > On Sb, 2018-11-03 at 12:16 +, Jonathan Cameron wrote: > > > > > > On Mon, 29 Oct 2018 18:38:31 +0200 > > > Stefa

Re: [PATCH v3 2/3] iio: adc: Add ad7124 support

2018-11-08 Thread Popa, Stefan Serban
On Sb, 2018-11-03 at 12:16 +, Jonathan Cameron wrote: > On Mon, 29 Oct 2018 18:38:31 +0200 > Stefan Popa wrote: > > > > > The ad7124-4 and ad7124-8 are a family of 4 and 8 channel sigma-delta > > ADCs > > with 24-bit precision and reference. > > > > Three power modes are available which in

Re: [PATCH v4 3/6] regmap: Add regmap_noinc_read API

2018-08-06 Thread Popa, Stefan Serban
On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote: > > > > > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) > > { > > + ret = -EINVAL; > > + goto out_unlock; > > + } > I suggested having an ex

Re: [PATCH v2 1/6] iio: adxl372: New driver for Analog Devices ADXL372 Accelerometer

2018-08-02 Thread Popa, Stefan Serban
On Jo, 2018-08-02 at 14:05 +0100, Jonathan Cameron wrote: > On Wed, 1 Aug 2018 18:13:09 +0300 > Stefan Popa wrote: > > > > > This patch adds basic support for Analog Devices ADXL372 SPI-Bus > > Three-Axis Digital Accelerometer. > > > > The device is probed and configured the with some initial d

Re: [PATCH v4 1/2] iio: dac: Add AD5758 support

2018-07-04 Thread Popa, Stefan Serban
On Du, 2018-07-01 at 00:26 +0300, Andy Shevchenko wrote: > On Fri, Jun 29, 2018 at 11:38 AM, Stefan Popa wrote: > > > > The AD5758 is a single channel DAC with 16-bit precision which uses the > > SPI interface that operates at clock rates up to 50MHz. > > > > The output can be configured as volt