Re: [PATCH net 4/4] virtio_net: Update rss when set queue

2024-11-05 Thread Philo Lu
On 2024/11/6 04:31, Joe Damato wrote: On Mon, Nov 04, 2024 at 04:57:06PM +0800, Philo Lu wrote: RSS configuration should be updated with queue number. In particular, it should be updated when (1) rss enabled and (2) default rss configuration is used without user modification. During rss

[PATCH net 3/4] virtio_net: Sync rss config to device when virtnet_probe

2024-11-04 Thread Philo Lu
confuse the user. If the command committing fails, driver rss will be disabled. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Philo Lu Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 9 + 1 file changed, 9 insertions(+) di

[PATCH net 1/4] virtio_net: Support dynamic rss indirection table size

2024-11-04 Thread Philo Lu
used if !vi->has_rss, and then we don't need to alloc indirection_table for hash_report only uses. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Philo Lu Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 39 +

[PATCH net 4/4] virtio_net: Update rss when set queue

2024-11-04 Thread Philo Lu
drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Philo Lu Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 65 +++- 1 file changed, 51 insertions(+), 14 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c in

[PATCH net 0/4] virtio_net: Make RSS interact properly with queue number

2024-11-04 Thread Philo Lu
Patch 1 and 2 fix possible out of bound errors for indir_table and key. Patch 3 and 4 add RSS update in probe() and set_queues(). Please review, thanks. Philo Lu (4): virtio_net: Support dynamic rss indirection table size virtio_net: Add hash_key_length check virtio_net: Sync rss config to

[PATCH net 2/4] virtio_net: Add hash_key_length check

2024-11-04 Thread Philo Lu
Add hash_key_length check in virtnet_probe() to avoid possible out of bound errors when setting/reading the hash key. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Philo Lu Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 6

Re: [RFC PATCH 3/3] bpf: Add sk_lookup test to use ORIGDSTADDR cmsg.

2024-09-13 Thread Philo Lu
Hi Tiago, On 2024/9/13 17:39, Tiago Lam wrote: This patch reuses the framework already in place for sk_lookup, allowing it now to send a reply from the server fd directly, instead of having to create a socket bound to the original destination address and reply from there. It does this by passing