it_str[] __initdata=s;
> __tmp_init_str;})
I think this would fail if used in structure initialisations ?
Philipp Rumpf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Thu, Mar 22, 2001 at 01:14:41AM -0700, Eric W. Biederman wrote:
> Rik van Riel <[EMAIL PROTECTED]> writes:
> Is there ever a case where killing init is the right thing to do?
There are cases where panic() is the right thing to do. Broken init
is such a case.
> My impression is that if init i
On Wed, Mar 21, 2001 at 08:48:54PM -0300, Rik van Riel wrote:
> On Wed, 21 Mar 2001, Patrick O'Rourke wrote:
>
> > Since the system will panic if the init process is chosen by
> > the OOM killer, the following patch prevents select_bad_process()
> > from picking init.
>
> One question ... has th
On Fri, Mar 09, 2001 at 09:09:13PM +0100, Jamie Lokier wrote:
> Rik van Riel wrote:
> > > Just raise the priority whenever the task's in kernel mode. Problem
> > > solved.
> >
> > Remember that a task schedules itself out at the timer interrupt,
> > in kernel/sched.c::schedule() ... which is ker
On Mon, Mar 12, 2001 at 06:03:22PM +1100, Keith Owens wrote:
> In 2.4.2-ac18 there are 130 CONFIG options that are always derived from
> other options, the user has no control over them. It is useful for the
> kernel build process to know which variables are derived and which
> variables the user
On Thu, Mar 08, 2001 at 06:10:16PM -0300, Rik van Riel wrote:
> --- linux-2.4.2-doc/include/linux/mm.h.orig Wed Mar 7 15:36:32 2001
> +++ linux-2.4.2-doc/include/linux/mm.hThu Mar 8 09:54:22 2001
> @@ -39,32 +39,37 @@
> * library, the executable area etc).
> */
> struct vm_area_st
With the current rd.c code, we can get into a situation where there is
a buffer-only page for data which is also in a page cache page with
page->buffers != NULL. The current vmscan.c code never frees the page
cache page in this scenario, effectively doubling ramdisk memory
requirements.
Linus, I
On Sun, Mar 04, 2001 at 10:34:31PM +, Alan Cox wrote:
> > Does kmalloc() make any guarantees of the alignment of allocated
> > blocks? Will the returned block always be 4-, 8- or 16-byte
> > aligned, for example?
>
> There are people who assume 16byte alignment guarantees. I dont think anyon
On Mon, Mar 05, 2001 at 03:37:04PM +0300, Andrey Panin wrote:
> Attached patch (2.4.2-ac11) makes some changes in serial driver:
> adds ioremap() return code checks, removes panic() calls
> and adds better error handling in start_pci_pnp_board() function.
Did you test it ?
> diff -u /linux.vanil
On Sun, Mar 04, 2001 at 12:19:07AM +0100, Francis Galiegue wrote:
> Well, from reading the source, I don't see how this can break APM... What am I
> missing?
apm_bios_call must not be called with two identical pointers for
two different registers.
-
To unsubscribe from this list: send the line "u
On Fri, Mar 02, 2001 at 10:55:39AM +, Tigran Aivazian wrote:
> On Fri, 2 Mar 2001, Tigran Aivazian wrote:
> > On Thu, 1 Mar 2001, Alan Cox wrote:
> > > 2.4.2-ac8
> > > o Stop two people claiming the same misc dev id (Philipp Rumpf)
> >
> > is this wh
On Fri, Mar 02, 2001 at 03:05:32PM +0900, tachino Nobuhiro wrote:
>
> Hello,
>
> At Fri, 02 Mar 2001 00:42:28 -0500,
> <[EMAIL PROTECTED]> wrote:
> >
> > actually, its not just ps/2 mice -- it seems to be something generic to char
> > devices. agpgartis failing to register itself, too.
> >
>
On Sat, Feb 24, 2001 at 10:25:42AM -0700, Jeff Lessem wrote:
> In your message of: Sat, 24 Feb 2001 09:54:47 CST, you write:
> >Jeff, are you using the e820 memory map at all ? In particular, are you
> >using grub or some other buggy bootloader that insists on specifying a
> >mem= option on the k
On Sat, Feb 24, 2001 at 05:36:47AM -0800, Linus Torvalds wrote:
> On Sat, 24 Feb 2001, Jeff Lessem wrote:
> >
> > >Also, how much memory does this machine have? That "13ff" does worry
> > >me a bit..
> >
> > The comptuer has 320MB. At this point I am ready to conclude that the
> > computer
On Thu, Feb 22, 2001 at 10:22:56AM +, Alan Cox wrote:
> > > We can take page faults in interrupt handlers in 2.4 so I had to use a
> > > spinlock, but that sounds the same
> >
> > We can? Woah, please explain.
>
> vmalloc does a lazy load of the tlb. That can lead to the exception table
>
While misc_register() semantics are different in 2.0 from 2.[24], and the
2.[24] code would actually work in 2.0, the 2.0 code doesn't.
This fixes (I think) the case where you have softdog and a hardware
watchdog driver on the same box (and obviously want to use the hardware
watchdog).
diff -ur
misc_register() overrides misc devices with the same minor that have been
registered earlier, so if you enable both softdog and a hardware watchdog
the current initialization order will leave you with softdog only.
Should be fixed by (untested, 2.2):
diff -ur linux/drivers/char/misc.c linux-prum
On Tue, 20 Feb 2001, Keith Owens wrote:
> On Mon, 19 Feb 2001 16:04:07 + (GMT),
> Alan Cox <[EMAIL PROTECTED]> wrote:
> Using wait_for_at_least_one_schedule_on_every_cpu() has no penalty
> except on the process running rmmod. It does not require yet more
> spinlocks and is architecture indep
> diff -urN linux-2.4.1/arch/i386/kernel/entry.S
> linux-2.4.1-setprocuid/arch/i386/kernel/entry.S
> --- linux-2.4.1/arch/i386/kernel/entry.SThu Nov 9 02:09:50 2000
> +++ linux-2.4.1-setprocuid/arch/i386/kernel/entry.S Mon Feb 19
> 22:12:00 2001
> @@ -645,6 +645,7 @@
> .long S
On Mon, 19 Feb 2001, Russell King wrote:
> Philipp Rumpf writes:
> > That still won't catch keventd oopsing though - which I think might happen
> > quite easily in real life.
>
> Maybe we should panic in that case? For example, what happens if kswapd
> oopses?
On Mon, 19 Feb 2001, Alan Cox wrote:
> > So you fixed the nonexistent race only. The real race is that the module
>
> Umm I fixed the small race. You are right that there is a second race.
There's just one race. The small race is nonexistent since
put_mod_name always acts as a memory barrier.
On Mon, 19 Feb 2001, Alan Cox wrote:
> > so you hold a spinlock during copy_from_user ? Or did you change
> > sys_init_module/sys_create_modules semantics ?
>
> The only points I need to hold a spinlock are editing the chain and
> walking it in a case where I dont hold the kernel lock.
>
> So I
On Mon, 19 Feb 2001, Alan Cox wrote:
> > Rusty had a patch that locked the module list properly IIRC.
>
> So does -ac now. I just take a spinlock for the modify cases that race
> against faults (including vmalloc faults from irq context)
so you hold a spinlock during copy_from_user ? Or did you
On Mon, 19 Feb 2001, Andrew Morton wrote:
> David Woodhouse wrote:
> > [EMAIL PROTECTED] said:
> > > Why bother ? It looks like a leftover debugging message which
> > > doesn't make a lot of sense once the code is stable (what might make
> > > sense is checking keventd is still around, but that'
On Tue, 20 Feb 2001, Keith Owens wrote:
> On Mon, 19 Feb 2001 06:15:22 -0600 (CST),
> Philipp Rumpf <[EMAIL PROTECTED]> wrote:
> No need for a callin routine, you can get this for free as part of
> normal scheduling. The sequence goes :-
>
> if (use_count == 0)
On Mon, 19 Feb 2001, Keith Owens wrote:
> On Mon, 19 Feb 2001 11:35:08 + (GMT),
> Alan Cox <[EMAIL PROTECTED]> wrote:
> >The problem isnt running module code. What happens in this case
> >
> >mod->next = module_list;
> >module_list = mod; /* link it in */
> >
> >Note no w
On Mon, 19 Feb 2001, Alan Cox wrote:
> mod->next = module_list;
put_mod_name() here.
> module_list = mod; /* link it in */
>
> Note no write barrier.
put_mod_name calls free_page which always implies a memory barrier. This
isn't beautiful but it won't blow up either.
Act
On Sun, 18 Feb 2001, Kenn Humborg wrote:
> in the .config, I can get schedule_task() to fail with:
>
>schedule_task(): keventd has not started
This shouldn't be a failure case, just a (bogus) printk.
> When starting bdflush and kupdated, bdflush_init() uses a semaphore to
> make sure that t
On Thu, 15 Feb 2001, Alan Cox wrote:
> Question of the day for the VM folks:
> If CPU1 is loading the exception tables for a module and
> CPU2 faults.. what happens 8)
"loading" == in sys_create_module ?
The module list is modified atomically, so either we search the new table
On Wed, 14 Feb 2001, Grant Grundler wrote:
> Philipp Rumpf wrote:
> > Jeff Garzik wrote:
> > > Looks ok, but I wonder if we should include this list in the docs.
> > > These is stuff defined by the PCI spec, and this list could potentially
> > > get lo
On Wed, 14 Feb 2001, Jeff Garzik wrote:
> On Wed, 14 Feb 2001, Tim Waugh wrote:
> > +/**
> > + * pci_find_capability - query for devices' capabilities
> > + * @dev: PCI device to query
> > + * @cap: capability code
> > + *
> > + * Tell if a device supports a given PCI capability.
> > + * Returns
On Wed, 14 Feb 2001, Tim Waugh wrote:
> + * pci_find_subsys - begin or continue searching for a PCI device by
>vendor/subvendor/device/subdevice id
> + * @vendor: PCI vendor id to match, or %PCI_ANY_ID to match all vendor ids
> + * @device: PCI device id to match, or %PCI_ANY_ID to match all vend
On Wed, Jan 10, 2001 at 05:55:05PM +0100, Daniel Phillips wrote:
> Mark Hindley wrote:
> > I am running 2.4.0 final. I got the following failed paging request which
> > produced a complete freeze.
> >
> > As you can see it was precipitated by cron starting to run some
> > housekeeping stuff overn
On Wed, Dec 27, 2000 at 03:41:04PM -0800, Linus Torvalds wrote:
> It must be wrong.
>
> If we have a dirty page on the LRU lists, that page _must_ have a mapping.
What about pages with a mapping but without a writepage function ? or pages
whose writepage function fails ? The current code seems
ncode);
}
}
If we want to rely solely on the add_timer_randomness checks, we should
remove the autorepeat check completely.
Philipp Rumpf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
On Sun, Dec 17, 2000 at 12:52:59AM -0800, Drew Hess wrote:
> It also contains an experimental patch to drivers/pci/quirks.c that forces
> standby mode for pool C RDRAM devices. I've seen some benchmarks
> comparing the Intel D850GB motherboard to the ASUS P4T and attributing the
> better performa
On Fri, Dec 08, 2000 at 10:47:46AM +0100, Willy Tarreau wrote:
> |Bus 0, device 2, function 1:
> | Unknown class: Intel OEM MegaRAID Controller (rev 5).
> |Medium devsel. Fast back-to-back capable. BIST capable. IRQ 10. Master
> Capable. Latency=64.
> |Prefetchable 32 bit memor
On Fri, Dec 01, 2000 at 08:04:52PM -0500, Jeff Dike wrote:
> boot memory allocator (see mm/bootmem.c). In the arch that I'm most familiar
> with (arch/um), that is usable from the beginning of start_kernel. I don't
> know about the other arches.
setup_arch does the necessary initialization on
On Mon, Nov 27, 2000 at 10:36:34AM -0800, H. Peter Anvin wrote:
> Followup to: <[EMAIL PROTECTED]>
> By author:Philipp Rumpf <[EMAIL PROTECTED]>
> In newsgroup: linux.dev.kernel
> >
> > I hope count isn't provided by userspace here ?
> >
>
On Sun, Nov 26, 2000 at 02:21:31PM +0100, Anders Torger wrote:
> memcpy_toio(iobase, user_space_src, count);
I hope count isn't provided by userspace here ?
> 1. What happens if the user space memory is swapped to disk? Will
> verify_area() make sure that the memory is in physical RAM whe
On Sun, Nov 26, 2000 at 10:37:07AM +, Tigran Aivazian wrote:
> On Sat, 25 Nov 2000, Tim Waugh wrote:
> > Why doesn't the compiler just leave out explicit zeros from the
> > 'initial data' segment then? Seems like it ought to be tought to..
>
> yes, taught to, _BUT_ never let this to be a def
On Sun, Nov 26, 2000 at 04:25:05AM +, Alan Cox wrote:
> static int a=0;
>
> says 'I thought about this. I want it to start at zero. I've written it this
> way to remind of the fact'
>
> Sure it generates the same code
I agree it would be best if gcc would generate the same code; unfo
On Sat, Nov 25, 2000 at 08:03:49PM +0100, Roger Larsson wrote:
> > _trylock functions return 0 for success.
>
> Not spin_trylock
Argh, I missed the (recent ?) change to make x86 spinlocks use 1 to mean
unlocked. You're correct, and obviously this should be fixed.
-
To unsubscribe from this li
On Sat, Nov 25, 2000 at 03:49:25PM -0200, Rik van Riel wrote:
> On Sat, 25 Nov 2000, Roger Larsson wrote:
>
> > Questions:
> > What are _trylocks supposed to return?
>
> It depends on the type of _trylock ;(
>
> > Does spin_trylock and down_trylock behave differently?
> > Why isn't the e
On Fri, Nov 10, 2000 at 02:21:28AM -0500, Jeff Garzik wrote:
> The following is a piece of code from the latter half of
> schedule_timeout, in kernel/sched.c. Is it possible that
> schedule_timeout could return an incorrect value, if the jiffy value
> wraps between the first and last lines shown
On Sun, Nov 05, 2000 at 06:19:21PM +0100, Heusden, Folkert van wrote:
> I wrote a daemon that fetches (as root-user) random numbers from the RNG in
> the i82808 (found on 815-chipsets).
> You can download it from http://www.vanheusden.com/Linux/random.php3 .
> Currently, I'm trying to rewrite thin
>
> 3. Security
>
> * Fix module remove race bug (still to be done: TTY, ldisc, I2C,
>video_device - Al Viro) (Rogier Wolff will handle ATM)
TBD: sysctl, kernel_thread
* drivers/input/mousedev.c dereferences userspace pointers directly. We
should make this fail for a bit to catch
On Sat, Oct 28, 2000 at 11:50:22AM -0400, Brian Gerst wrote:
> Philipp Rumpf wrote:
> >
> > On Sat, Oct 28, 2000 at 09:55:21AM -0400, Brian Gerst wrote:
> > > Yes, but they can be called (and sleep) with module refcount == 0. This
> > > is because the file des
On Sat, Oct 28, 2000 at 09:55:21AM -0400, Brian Gerst wrote:
> Yes, but they can be called (and sleep) with module refcount == 0. This
> is because the file descripter used to perform the ioctl isn't directly
> associated with the network device, thereby not incrementing the
> refcount on open.
On Sat, Oct 28, 2000 at 09:37:28AM -0400, Brian Gerst wrote:
> Philipp Rumpf wrote:
> > - you can't copy_(from|to)_user in the module exit function (which would
> > be copies from/to rmmod anyway)
>
> Unfortunately, you need to be able to use copy_*_user() from the net
On Fri, Oct 27, 2000 at 10:49:53PM +1100, Andrew Morton wrote:
> Look, this modules stuff is really bad. Phillip Rumpf proposed
> a radical alternative a while back which I felt was not given
While it might be a "radical alternative", it doesn't require any changes
to the subsystems that have be
On Fri, Oct 20, 2000 at 10:47:45AM -0700, Linus Torvalds wrote:
> On Fri, 20 Oct 2000, Philipp Rumpf wrote:
> >
> > Single Unix specifies that 0-byte reads, as well as 0-byte writes, should
> > "return 0 and have no other results". Our current implementation vio
Single Unix specifies that 0-byte reads, as well as 0-byte writes, should
"return 0 and have no other results". Our current implementation violates
the first requirement and makes it very easy to violate the second one.
read(page_cache_fd, invalid_ptr, 0) returns -EFAULT; IMHO, this is a
clear
ve, or reduce the size
> of the system page table.
> How much space tends to be vmalloc()-ed in a running system?
See the discussion for alpha a week or so ago. It tends to not be very much
but for some applications (TUX, for example), it's expected to be most of
physical memory.
Philipp Rumpf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
I don't know how much of a problem this is going to be yet,
> but I'm sure it's going to be fun :-)
512 byte pages, 4 bytes per pte ? Ouch. Can you fill the TLB manually ?
OTOH, I think mapping all physical memory makes sense with the three page
table setup.
Phili
On Tue, Oct 10, 2000 at 12:30:51PM -0300, Rik van Riel wrote:
> Not killing init when we "should" definately prevents
> embedded systems from auto-rebooting when they should
> do so.
>
> (OTOH, I don't think embedded systems will run into
> this OOM issue too much)
but when they do, they're hard
On Tue, Oct 10, 2000 at 12:06:07PM -0300, Rik van Riel wrote:
> On Tue, 10 Oct 2000, Philipp Rumpf wrote:
> > > > The algorithm you posted on the list in this thread will kill
> > > > init if on 4Mbyte machine without swap init is large 3 Mbytes
> > > > an
> If init dies the kernel hangs solid anyway
Init should never die. If we get to do_exit in init we'll panic which is
the right thing to do (reboot on critical systems).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please
> (but I'd be curious if somebody actually manages to
> trick the OOM killer into killing init ... please
> test a bit more to see if this really happens ;))
In a non-real-world situation, yes. (mem=3500k, many drivers, init=/bin/bash,
tried to enter a command). Since the process in question (b
ONFIG_MY_DRIVER */
>
> in .c files?
The idea isn't bad, but I'm not sure magic comments are really the way to
go. special macros should work just as well, shouldn't they ?
Also you're missing a very important item here: Documentation for the
config option.
Philipp Ru
On Fri, Oct 06, 2000 at 12:32:35PM +0300, Petko Manolov wrote:
> It is not so difficult as it looks.
I don't see it being difficult at all ...
> The master pgd looking as:
>
> .org 0x1000
> ENTRY(swapper_pg_dir)
> .long 0x00102007
> .long 0x00103007
> .fill BOOT_USER_PGD
e what is the limit but am curious
> as to the reason. The last thing I see is Uncompressing linux... Maybe the
> code in arch/i386/kernel/head.S which clears BSS is broken at "large
> values"?
That code would indeed be what causes the page faults we cannot handle,
if my theory is c
y ?
Putting all tests for smp_call_function in the timer interrupt code doesn't
make any sense at all to me.
Philipp Rumpf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
On Wed, Sep 27, 2000 at 12:18:11PM +, Pavel Machek wrote:
> Hi!
>
> > Well, I'm finally getting around to sending out this announcement.
> > As can be seen on www.alphanews.net, we've managed to boot Linux on an
> > AlphaServer GS320. The only caveats are that one of the CPUs was out of
On Sat, Sep 30, 2000 at 03:26:53AM +0100, Philipp Rumpf wrote:
> This patch (against 2.4.0-test9-pre7) makes all watchdog drivers use
> module_init, rather than explicit init calls; as a side-effect, it fixes a
> presumed bug that would cause the softdog driver to be used if i81
drivers to a directory of
their own soon. drivers/char names aren't as obvious as they could be, and
removing 10 files should help this situation a bit. Linus ?
Philipp Rumpf
diff -ur linux/drivers/char/Config.in linux-prumpf/drivers/char/Config.in
--- linux/drivers/char/Config.in
On Fri, Sep 29, 2000 at 01:22:15AM -0500, Jeff Garzik wrote:
> > The stuff that is written in the kernel by printk() can be configured
> > to go to an RS-232C port. This has to be compiled into the kernel.
> > You use append="console=ttyS0,BAUDRATE" in LILO configuration. This
> > keeps it off the
On Thu, Sep 28, 2000 at 11:06:47PM +0100, Alan Cox wrote:
> > is nothing wrong).
> >
> > Anyone know how other than changing the kernel code?
>
> You need to change the initial kernel message logging level to be higher
> yes
lower, actually. putting "quiet" in the command line should work for
is often justified to share
> device numbers and device nodes.
Could this go into the next revision of Documentation/devices.txt ? There
certainly doesn't seem to be a good place to point people to right now.
Philipp Rumpf
-
To unsubscribe from this list: send the line "unsu
On Mon, Sep 04, 2000 at 12:24:02PM +0200, Werner Almesberger wrote:
> Philipp Rumpf wrote:
> > Most architectures can boot ELF images -- defining section names for
> > .config.gz and the version string in the ELF file can be done in an
> > architecture-independent fashion.
&g
On Fri, Sep 01, 2000 at 02:27:39PM +0200, Andi Kleen wrote:
> On Fri, Sep 01, 2000 at 02:23:57PM +0200, [EMAIL PROTECTED] wrote:
> > I don't see the advantage over Alan's proposal of simply adding the
> > config data to the bzImage or whatever is the most common format on
> > the respective platfo
're probably already beyond the point of having a
> fully-featured /proc/config.gz, complexity-wise (which, after all,
> would be completely architecture-independent).
Most architectures can boot ELF images -- defining section names for
.config.gz and the version string in the ELF fil
On Fri, Sep 01, 2000 at 01:28:08PM +0100, Alan Cox wrote:
> > On Fri, Sep 01, 2000 at 02:23:57PM +0200, [EMAIL PROTECTED] wrote:
> > > I don't see the advantage over Alan's proposal of simply adding the
> > > config data to the bzImage or whatever is the most common format on
> > > the respective
On Thu, Aug 31, 2000 at 11:49:34AM +1100, Keith Owens wrote:
> Before Rusty tells me that not everybody uses modules,
> /lib/modules/ can exist even if the kernel has no modules, it
> just needs a simple Makefile change. Think of /lib/modules/
> as a standard place to store information about kern
On Wed, Aug 30, 2000 at 10:04:12AM -0700, Linus Torvalds wrote:
> return copy_to_user(dst, src, size) ? -EFAULT : 0;
>
> is fine and quite readable. Fits on a simple line.
I agree so far. But when it's really
if (put_user(..>)
return -EFAULT;
if (
hink it is faster to read and understand.
Same here. Linus, I didn't actually interpret your mail on the subject as
proposing changes like the one above. Care to enlighten this a bit ?
Philipp Rumpf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
76 matches
Mail list logo
