[PATCH] [sound/i2c/cs8427] Fix int to char conversion

427_REG_CORU_DATABUF; ~ ~~~^ Because CS8427_REG_AUTOINC is defined as 128, it is too big for a char field. So change data from char to unsigned char, that it can hold the value. This patch does not change the generated code. Signed-off-by: Philipp Klocke --- sound/i2c/cs8427.c | 2 +- 1 file change

[RESEND] drbd: avoid clang warning about pointless switch statement

The drbd code causes warnings that we cannot easily disable when building with clang: In file included from drivers/block/drbd/drbd_debugfs.c:10: In file included from drivers/block/drbd/drbd_int.h:48: In file included from include/linux/drbd_genl_api.h:53: In file included from include/linux/genl

Re: [PATCH] drbd: avoid clang warning about pointless switch statement

Hello, I've also stumbled across the "warning: no case matching constant switch condition '0'" and wanted to fix it. As your suggestion is probably the best way, I wanted to ask why it didn't get merged yet. Maybe the patch got lost? Best regards, Philipp

Re: [PATCH] sched/fair: Change sched_feat(x) in !CONFIG_SCHED_DEBUG case

On 20.04.2018 09:57, Peter Zijlstra wrote: > On Mon, Apr 16, 2018 at 10:54:26AM +0200, Philipp Klocke wrote: > >> This patch is motivated by the clang warning Wconstant-logical-operand, >> issued when logically comparing a variable to a constant integer that is >> neither

[PATCH] sched/fair: Change sched_feat(x) in !CONFIG_SCHED_DEBUG case

~^~ This resolves the warning, leaves the code base largely as is. Tested with gcc 7.3.1 and clang 6.0.0 on x86_64, comparing resulting binaries with diff. Applicable to all modern compilers and architectures Signed-off-by: Philipp Klocke Suggested-by: Lukas Bu