Re: [PATCH v5 0/7] Fifth revision of the performance improvement patch to the VMware balloon driver

2015-08-14 Thread Philip Moltmann
Hi, will v5 1/7 - 7/7 be considered for Linux 4.2 ? Philip From: Philip P. Moltmann Sent: Thursday, August 6, 2015 3:17 PM To: gre...@linuxfoundation.org Cc: Philip Moltmann; dmitry.torok...@gmail.com; linux-kernel@vger.kernel.org; Xavier Deguillard; a

Re: [PATCH v4 3/9] VMware balloon: add batching to the vmw_balloon.

2015-08-05 Thread Philip Moltmann
Hi, > what changed? I added the include: #include Nothing else changes. None of v3 step 4-9 changed and they should still cleanly apply (and build). PhilipN�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a��� 0��h�

Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

2015-08-05 Thread Philip Moltmann
Hi, > > MODULE_AUTHOR("VMware, Inc."); > > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver"); > > -MODULE_VERSION("1.3.2.0-k"); > > +MODULE_VERSION("1.3.3.0-k"); > > This constant change of module version is annoying, is it really even > needed? > > I'll take this, but seriously con

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

2015-06-12 Thread Philip Moltmann
Hi, > > > > Three improvements contribute to the overall faster speed: > > - batched operations reduce the hypervisor overhead per page > > - 2m instead of 4k buffer reduce the hypervisor overhead per page > > - removing the rate-limiting for non-sleep allocations allows the > > guest > > operati

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

2015-06-12 Thread Philip Moltmann
Hi, thanks for taking so much interest in this driver. It is quite good that our design choices get scrutinized by non-current VMware employees. > I understand that you negotiate the capabilities between hypervisor > and > the balloon driver, however that was not my concern (and I am sorry > t

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

2015-06-11 Thread Philip Moltmann
Hi, sorry for taking so long to address your concerns. > What happens if you run this new driver on an older hypervisor that > does not support batched operations? When the driver starts or when it gets reset the driver checks for the capabilities of the hypervisor in vmballoon_send_start. Then