Am 8. November 2018 16:15:04 MEZ schrieb Jarkko Sakkinen
:
>On Thu, Nov 08, 2018 at 03:16:03PM +0100, Roberto Sassu wrote:
>> On 11/8/2018 3:04 PM, Jarkko Sakkinen wrote:
>> > On Tue, Nov 06, 2018 at 04:01:57PM +0100, Roberto Sassu wrote:
>> > > Currently the TPM driver allows other kernel subs
eventlog present.
By turning it from 'select' to 'imply' it still gets selected per
default, but enables users who want to save some kb of ram by turning
SECURITYFS off.
Signed-off-by: Peter Huewe
---
drivers/char/tpm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 delet
Hi,
Am Freitag, 29. September 2017 22:23:13 CEST schrieb Jarkko Sakkinen:
On Fri, Sep 29, 2017 at 08:29:09AM +, peter.hu...@infineon.com wrote:
...
Spinics is archiving us at
https://www.spinics.net/lists/linux-integrity/
It would be good to add this to the vger page + documented on
the
Am 25. Oktober 2017 20:53:49 MESZ schrieb Jarkko Sakkinen
:
>On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote:
>> On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen
>> wrote:
>> > I'm implementing a fix for CVE-2017-15361 that simply blacklists
>> > vulnerable FW versions. I think
Am 24. Oktober 2017 20:15:12 MESZ schrieb Jarkko Sakkinen
:
>On Tue, Oct 24, 2017 at 10:02:00AM -0700, Dmitry Torokhov wrote:
>> On Tue, Oct 24, 2017 at 9:11 AM, Jason Gunthorpe
>> wrote:
>> > On Tue, Oct 24, 2017 at 09:37:33PM +0530, PrasannaKumar
>Muralidharan wrote:
>> >> Hi Jason,
>> >>
>>
Will do.
Peter
Am 4. Oktober 2017 09:27:08 MESZ schrieb Jarkko Sakkinen
:
>On Fri, Sep 29, 2017 at 08:31:30PM +0200, Peter Huewe wrote:
>>
>>
>>
>>
>> Gesendet: Freitag, 29. September 2017 um 18:59 Uhr
>> Von: "Jarkko Sakkinen"
>> A
Gesendet: Freitag, 29. September 2017 um 18:59 Uhr
Von: "Jarkko Sakkinen"
An: "Mimi Zohar" , peterhu...@gmx.de
Cc: linux-kernel@vger.kernel.org, linux-integr...@vger.kernel.org
Betreff: Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes
On Tue, Sep 26, 2017 at 12:16:20PM -0400
Am 15. September 2017 13:07:58 GMT-07:00 schrieb Ken Goldman
:
>Newbie question: Do I have to subscribe, or are email addresses being
>migrated
You have to subscribe yourself.
Due to the new privacy regulations I do not have access to any member
information anymore on the old list.
Just se
Am 15. September 2017 10:40:14 GMT-07:00 schrieb Joe Perches :
>On Fri, 2017-09-15 at 10:36 -0700, Jarkko Sakkinen wrote:
>> On Fri, Sep 15, 2017 at 10:25:36AM -0700, Joe Perches wrote:
>> > On Fri, 2017-09-15 at 10:18 -0700, Jarkko Sakkinen wrote:
>[]
>> > > We decided to create a new mailing li
Am 15. September 2017 10:18:25 GMT-07:00 schrieb Jarkko Sakkinen
:
>Hi
>
>Many people were kicked out from the SourceForge mailing list in the
>July because SF required a resubscription, including non-human users,
>such as patchwork.
>
>We decided to create a new mailing list linux-integ...@vger
Am 13. September 2017 11:52:12 GMT-07:00 schrieb Ken Goldman
:
>On 9/6/2017 12:12 PM, Jason Gunthorpe wrote:
>>
>> The problem with this approach is that the TPM could totally block
>> the CPU for very long periods of time.
>>
>> It seems very risky to enable..
>>
>
>How would you characteriz
Am 12. September 2017 17:45:08 GMT-07:00 schrieb Jarkko Sakkinen
:
>On Wed, Sep 06, 2017 at 08:56:36AM -0400, Nayna Jain wrote:
>> The TPM burstcount status indicates the number of bytes that can
>> be sent to the TPM without causing bus wait states. Effectively,
>> it is the number of empty by
Hi Ken,
(again speaking only on my behalf, not my employer)
> Does anyone know of platforms where this occurs?
> I suspect (but not sure) that the days of SuperIO connecting floppy
> drives, printer ports, and PS/2 mouse ports on the LPC bus are over, and
> such legacy systems will not have a TPM.
Hi Ken,
(speaking on behalf of myself here, not my employer :) )
> On Mon, Aug 07, 2017 at 01:52:34PM +0200, Peter Huewe wrote:
>> Imho: NACK from my side.
> After these viewpoints definitive NACK from my side too...
> I responded to the thread comments separately. However, ass
Am 7. August 2017 13:46:32 MESZ schrieb Nayna Jain :
>The TPM burstcount status indicates the number of bytes that can
>be sent to the TPM without causing bus wait states. Effectively,
>it is the number of empty bytes in the command FIFO. Further,
>some TPMs have a static burstcount, when the va
sparse complains that tpmrm_write can be made static, and since it is
right we make it static.
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpmrm-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpmrm-dev.c b/drivers/char/tpm/tpmrm-dev.c
index
> Removed struct tpm_pcrextend_in as it is not used for anything anymore.
>
> Signed-off-by: Jarkko Sakkinen
LGTM.
Reviewed-by: Peter Huewe
> ---
> drivers/char/tpm/tpm.h | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm.h b/driver
> The memory copy from rodata to stack is useless.
>
> Signed-off-by: Jarkko Sakkinen
After review, yes that should work.
Reviewed-by: Peter Huewe
> ---
> drivers/char/tpm/tpm_infineon.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff
Am 17. Mai 2017 21:35:52 MESZ schrieb Alexander Sverdlin
:
>Hello Peter!
>
>On 23/03/17 14:03, Peter Huewe wrote:
>> This patch replaces the old, deprecated call to hwmon_device_register
>> with the new hwmon_device_register_with_info and converts the whole
>> driver
ed-off-by: Enric Balletbo i Serra
>> ---
>> This is a reworked version of the original patch based on the
>> suggestion made by Wolfram Sang to simply fall back to a sane minimum
>> when the maximum fails.
>>
>> Changes since v2:
>> - Do not remove faster
Am 23. März 2017 19:43:39 MEZ schrieb Guenter Roeck :
>On Thu, Mar 23, 2017 at 02:03:04PM +0100, Peter Huewe wrote:
>> This patch replaces the old, deprecated call to hwmon_device_register
>> with the new hwmon_device_register_with_info and converts the whole
>> dr
As indicated by checkpatch it makes sense to not use the FSFE Template
about GPLv2+
Signed-off-by: Peter Huewe
---
drivers/hwmon/w83627ehf.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index
As indicated by checkpatch, use the octal representation for the access
rights.
S_IWUSR | S_IRUGO => 0644
S_IRUGO => 0444
Signed-off-by: Peter Huewe
---
drivers/hwmon/w83627ehf.c | 52 ---
1 file changed, 22 insertions(+), 30 deletions(-)
diff
nymore)
- NUM_REG_TEMP changed to ARRAY_SIZE(W83627EHF_REG_TEMP)
(different number of max temp sensors)
- removal of intrusion1_alarm (nct6776 specific)
v2: Updated Kconfig, Documentation and removed unused temp_sensors (5-9)
Tested on NCT6776F (not probed anymore)
Signed-off-by: Peter Huewe
---
Documen
just some cosmetics for better readability, proposed by
Lindent/checkpatch
Signed-off-by: Peter Huewe
---
drivers/hwmon/w83627ehf.c | 39 +++
1 file changed, 15 insertions(+), 24 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
6776F chip.
v2:
- converted to proper is_visible methods
- applied minor feedback of v1
Signed-off-by: Peter Huewe
---
drivers/hwmon/w83627ehf.c | 1536 +++--
1 file changed, 778 insertions(+), 758 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/dri
nymore)
- NUM_REG_TEMP changed to ARRAY_SIZE(W83627EHF_REG_TEMP)
(different number of max temp sensors)
- removal of intrusion1_alarm (nct6776 specific)
Tested with NCT6776F that it does not get probed anymore.
Signed-off-by: Peter Huewe
---
Please apply after my conversion patch series.
drivers
t; than it used to be, but
still not completely.
The conversion saves about 20k in the resulting .ko
Tested with a NCT6776F chip.
Signed-off-by: Peter Huewe
---
Target-Branch: groeck/hwmon
Please cherry-pick
46dc4a97 hwmon: Constify str parameter of hwmon_ops->read_string
before this
As indicated by checkpatch, use the octal representation for the access
rights.
S_IWUSR | S_IRUGO => 0644
S_IRUGO => 0444
Signed-off-by: Peter Huewe
---
drivers/hwmon/w83627ehf.c | 52 ---
1 file changed, 22 insertions(+), 30 deletions(-)
diff
just some cosmetics for better readability, proposed by Lindent/checkpatch
Signed-off-by: Peter Huewe
---
drivers/hwmon/w83627ehf.c | 41 +++--
1 file changed, 15 insertions(+), 26 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon
As indicated by checkpatch it makes sense to not use the FSFE Template
about GPLv2+
Signed-off-by: Peter Huewe
---
drivers/hwmon/w83627ehf.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index
Unfortunately the HWMON_T_ALARM define was missing,
although the associated entry was present in hwmon_temp_attributes.
This is needed to convert drivers to the new interface which use channel
based alarms.
Signed-off-by: Peter Huewe
---
include/linux/hwmon.h | 1 +
1 file changed, 1 insertion
Am 14. März 2017 19:18:15 MEZ schrieb Ken Goldman :
>On 3/13/2017 3:10 AM, Peter Huewe wrote:
>
>> And yes you are right there is currently no way, except for trial and
>> error, for the userspace to determine this. So an interface to get
>> this information makes sense
Hi,
Thanks for your patch.
Am 13. März 2017 06:21:57 MEZ schrieb meng...@windriver.com:
>From: Limeng
>
>So far, there is not a sysfs interface for user space code to
>check the TPM hardware version(TPM1.x or TPM2). So, add a
>file named description in /sys/class/tpm/tpmX/ to show it.
It's not re
hat case, what about the following change?
>
>Subject: hwmon: Constify str parameter of hwmon_ops->read_string
>
>The read_string callback is supposed to retrieve a pointer to a
>constant string.
I would think that clarifies the situation and also gets rid warnings about
dr
Wait states are signaled in the last byte received from the TPM in
response to the header, not the first byte. Check rx_buf[3] instead of
rx_buf[0].
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
R
8 for the length.
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
Reviewed-by: Jarkko Sakkinen
Tested-by: Benoit Houyere
---
drivers/char/tpm/tpm_tis_spi.c | 87 ---
Am 2. März 2017 13:55:43 MEZ schrieb Jarkko Sakkinen
:
>On Wed, Mar 01, 2017 at 04:36:17PM +0100, Enric Balletbo i Serra wrote:
>> From: Bryan Freed
>>
>> When the I2C Infineon part is attached to an I2C adapter that imposes
>> a size limitation, large requests will fail with -EOPNOTSUPP. Retr
ned-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
Reviewed-by: Jarkko Sakkinen
Tested-by: Benoit Houyere
---
drivers/char/tpm/tpm_tis_spi.c | 107 ++---
1 file changed, 58 insertions(+), 49 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/dr
Alexander Steffen
Signed-off-by: Peter Huewe
Reviewed-by: Jarkko Sakkinen
Tested-by: Benoit Houyere
---
drivers/char/tpm/tpm_tis_spi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index 062799e04f04..639614f2d415 100644
---
Am 27. Februar 2017 20:12:45 MEZ schrieb Wolfram Sang :
>Hi,
>
>> >> > Rather than trying small and smaller transfers, would it not be
>better
>> >> > to get the i2c core to expose the quirk info about transfer
>limits?
>> >> >
>> >>
>> >> Sounds a good idea to me, I guess the quirk info can be a
negligible performance penalty.
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
Reviewed-by: Jarkko Sakkinen
Tested-by: Benoit Houyere
---
drivers/char/tpm/tpm_tis_spi.c | 1 +
1 file changed, 1 insertio
Am 1. März 2017 12:51:16 MEZ schrieb Enric Balletbo i Serra
:
>From: Sonny Rao
>
>The suspend/resume behavior of the TPM can be controlled
>by setting "powered-while-suspended" in the DTS.
>
>Signed-off-by: Sonny Rao
>Signed-off-by: Enric Balletbo i Serra
>---
>Documentation/devicetree/bindin
This adds another select to avoid the warning, consistent with other
>users
>of the crypto code.
>
>Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
>multiple banks")
>Signed-off-by: Arnd Bergmann
Lgtm
Reviewed-by: Peter Huewe
>---
> drivers/char/tpm
Am 22. Februar 2017 22:19:24 MEZ schrieb Jarkko Sakkinen
:
>On Thu, Feb 16, 2017 at 04:08:21PM +0000, Peter Huewe wrote:
>> During our testing it showed that unfortunately the whole native spi
>tpm driver
>> was more or less non-functional since it was merged, e.g. t
Am 21. Februar 2017 17:29:48 MEZ schrieb Andrew Lunn :
>On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote:
>> From: Bryan Freed
>>
>> When the I2C Infineon part is attached to an I2C adapter that imposes
>> a size limitation, large requests will fail -EINVAL.
>> Retry them
r now however the priority is to make the tpm_tis_spi driver work reliably
also on the rpi, and this is what this workaround does.
We can simply remove it once the rpi spi master is fixed.
Peter
>
>
>On 16/02/2017 08:09, Peter Huewe wrote:
>> Testing the implementation with a Raspbe
nce the splitting loop went missing during the merge.
At least with our tpms that's the case.
(I think we are signalling a higher burstcount value than 64, which is allowed)
>Or is this because of TIS vs PTP differences ?
>
>To be honest, this is a little behind me now :-)
>
&g
quash #1 and #3 - but reviewing it merged with #1 is quite hard since
it "obfuscates" the problem - since too much stuff moves around.
That's why I decided to split it - for easier review.
Peter
>
>
>On 16/02/2017 08:08, Peter Huewe wrote:
>> Wait states are signal
negligible performance penalty.
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis_spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/driver
e for other fixes in this series]
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis_spi.c | 87 --
1 file changed, 24 insertions(+), 63 deletions
Wait states are signaled in the last byte received from the TPM in
response to the header, not the first byte. Check rx_buf[3] instead of
rx_buf[0].
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
--
write function was consolidated to one
transfer function, so we do not have to apply the same fix at two locations.
Maybe consider squashing it - we splitted it for easier review.
Affected Kernels: 4.8, 4.9, 4.10
Patchset was tested on Raspberry Pi2 with SLB9670 (TPM1.2 and TPM2.0)
Peter Hue
Alexander Steffen
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis_spi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index 6e1a3c43f621..d782b9974c14 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/driver
Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper
layers, as tpm_tis has no such limitation. Add a loop to hide that
limitation.
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
--
ned-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index c0f296b5d413..fc0e9a2734ed 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/driver
Hi
Am 11. Oktober 2016 19:13:13 MESZ, schrieb Jason Gunthorpe
:
>On Tue, Oct 11, 2016 at 03:01:01PM +0300, Jarkko Sakkinen wrote:
>> From: Peter Huewe
>>
>> In some weird cases it might be possible that the TPM does not set
>> STS.VALID within the given time
Hi Andrey,
thanks for the update.
> This patchset adds support for H1 Secure Microcontroller running
> Cr50 firmware. It implements several functions, including TPM-like
> functionality, and communicates over SPI using the FIFO protocol
> described in the PTP Spec, section 6.
> H1 is a proprietar
Am 14. Juli 2016 19:20:16 GMT-07:00, schrieb Andrey Pronin
:
>This patchset adds a TCG TPM2.0 PTP FIFO compliant interface for
>Cr50 chip on SPI.
>
>Depends on the following patches by Andrey Pronin
>
>that add new members to phy_ops in tpm_tis_core:
> - tpm: support driver-specific sysfs attrs
Faster suspend/resume is always appreciated.
--
Sent from my mobile
Reviewed-by: Peter Huewe
--
Sent from my mobile
Am 2. Dezember 2015 00:14:23 PST, schrieb Jarkko Sakkinen
:
>On Tue, Dec 01, 2015 at 05:15:14PM -0800, Peter Huewe wrote:
>>
>>
>> Am 1. Dezember 2015 14:22:23 PST, schrieb Jason Gunthorpe
>:
>> >On Tue, Dec 01, 2015 at 11:33:51PM +0200, Jarkko Sakkinen wro
Am 1. Dezember 2015 14:22:23 PST, schrieb Jason Gunthorpe
:
>On Tue, Dec 01, 2015 at 11:33:51PM +0200, Jarkko Sakkinen wrote:
>
>> I went through the patches and didn't see anything that would shock
>me
>> enough not to apply the patches in the current if they also work when
>> tested *but* are
> > >That fixes tpm_tis, but there are other ancient TPM drivers that use
> > >the old, now broken way.
> > >
> > >So, we still need to do something here. Either fixup b8b2c7d845d5 as
> > >you have proposed, remove the now broken obsolete TPM drivers, or try
> > >and fix them..
> >
> > How broken a
Am 1. Dezember 2015 09:25:37 PST, schrieb Jason Gunthorpe
:
>On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote:
>> > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e.
>the return value
>> > > > of platform_device_register_simple above) isn't bound. It is
>not allowed
Hi,
is this for stable as well?
Since when?
I'll take care of all the patches next week when coming back to germany.
Peter
--
Sent from my mobile
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
Will look at it as soon as possible - relocating to the us is quite
stressful.sorry about that.
But since we are already at v9 i think it is in a good shape.
Peter
Am 25. August 2015 19:03:27 MESZ, schrieb Jarkko Sakkinen
:
>Does this start be in the shape that there would be chance to pull th
Am 10. August 2015 18:23:52 MESZ, schrieb Geert Uytterhoeven
:
>
>I'd like the individual subsystem maintainers to apply the respective
>patches. Sorry for being unclear.
Okay, thanks for the clarification.
I'll apply the TPM patch.
Peter
--
Sent from my mobile
--
To unsubscribe from this li
If DEBUG is set dumpVGAReg is called and tries to access
XGISR which is defined as (xgifb_info->dev_info.P3c4)
which is not known within this function.
-> add as parameter to dumpVGAReg so xgifb_info becomes known
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26
docproc.c was moved in 2011 from scripts/basic to scripts
-> updated the references accordingly
Signed-off-by: Peter Huewe
---
Documentation/kernel-doc-nano-HOWTO.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/kernel-doc-nano-HOWTO.txt
b/Documentat
ned-off-by: Jarkko Sakkinen
Reviewed-by: Peter Huewe
Acked-by: Peter Huewe # for TPM subsystem
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-i
Am 9. Juni 2015 13:39:13 MESZ, schrieb Jarkko Sakkinen
:
>On Tue, Jun 09, 2015 at 12:32:57PM +0200, Peter Huewe wrote:
>>
>>
>> Hi
>>
>> >> > +static inline void tpm_buf_store(struct tpm_buf *buf,
>> >&g
Hi
>> > +static inline void tpm_buf_store(struct tpm_buf *buf,
>> > + unsigned int pos,
>> > + const unsigned char *data,
>> > + unsigned int len)
>> > +{
>> > + BUG_ON((pos + len) > TPM_BUF_SIZE);
>> > +
>> > + memc
Hi
>Betreff: [PATCH] tpm, tpm_crb: migrate to struct acpi_table_tpm2 and
>acpi_tpm2_control
> Migrate to struct acpi_table_tpm2 and struct acpi_tpm2_control defined
> in include/acpi/actbl3.h from the internal structures.
I definitely do like the idea! Thanks for spotting this!
However one small
Hi,
> Betreff: [PATCH] tpm: introduce struct tpm_buf
> This patch introduces struct tpm_buf that provides a string buffer for
> constructing TPM commands. This allows to construct variable sized TPM
> commands. This feature is needed for TPM 2.0 commands in order to allow
> policy authentication an
Make the tpm_infineon driver define its PM callbacks through
a struct dev_pm_ops object rather than by using legacy PM hooks
in struct pnp_driver.
This allows the driver to use tpm_pm_suspend() as its suspend
callback directly, so we can remove the duplicated savestate code.
Signed-off-by: Peter
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/ata/pata_isapnp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/ata
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/media/rc/ene_ir.c | 13 +
drivers/media/rc/fintek-cir.c | 13 +
drivers/media/rc/ite
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/net/sb1000.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/net/sb1000.c
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/tty/serial/8250/8250_fintek.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/platform/x86/apple-gmux.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/ide/ide-pnp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/ide/ide
few lines of boilerplate code per PNP driver.
Based on work done by Lars-Peter Clausen for other
busses (i2c and spi) and Greg KH for PCI.
Cc: Lars-Peter Clausen
Cc: Greg Kroah-Hartman
Signed-off-by: Peter Huewe
---
include/linux/pnp.h | 12
1 file changed, 12 insertions(+)
diff
)
Peter Huewe (8):
pnp: Add helper macro for pnp_register_driver boilerplate
pnp: tpm/tpm_infineon: Use module_pnp_driver to register driver
pnp: ata/pata_isapnp: Use module_pnp_driver to register driver
pnp: ide/ide-pnp: Use module_pnp_driver to register driver
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_infineon.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers
Jason does an excellent job reviewing the TPM stuff, so we add him to
the designated reviewer list (with his consent :)
Jason Gunthorpe
Signed-off-by: Peter Huewe
Signed-off-by: Peter Huewe
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
I got a lot of requests lately about whether the new TPM2.0 support
includes the FIFO interface for TPM2.0 as well.
The FIFO interface is handled by tpm_tis since FIFO=TIS (more or less).
-> Update the helptext and headline
Signed-off-by: Peter Huewe
---
drivers/char/tpm/Kconfig
Thanks for reporting.
>drivers/char/tpm/tpm_tis.c: In function ‘tpm_tis_pnp_init’:
>drivers/char/tpm/tpm_tis.c:912:45: error: invalid type argument of
>‘->’ (have ‘int’)
>acpi_dev_handle = pnp_acpi_device(pnp_dev)->handle;
>^
>make[3]: *** [drivers/char/tpm/tpm_tis.o] Error 1
I'll look into it
> So, what do you think? Are we now settled with this?
Meh...
It does not recognize my tpm20 with force=1 :( :( :(
Probably since I don't have a machine with bios integration -> no tpm startup,
and your startup is returned with RC_SIZE :(
rmmod tpm; modprobe tpm_tis force=1 ; dmesg
modprobe:
>
> > Am Donnerstag, 4. Dezember 2014, 06:55:18 schrieb Jarkko Sakkinen:
> > > From: Will Arthur
> > >
> > > Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
> > > instead of calling tpm_get_timeouts(), assign duration and timeout
> > > values defined in the TPM 2.0 PTP spec
Hi Jarkko,
>is it cool if I prepare a separate set of fixes for all issues
>in v9? I do not see any problem that could not be fixed without
>major structural changes.
to be honest - I would prefer a v10 with the fixes included, especially since
there were quite a few issues/remarks.
If you
Hi Jarkko,
> Jarkko Sakkinen (3):
> tpm: merge duplicate transmit_cmd() functions
> tpm: two-phase chip management functions
> tpm: fix multiple race conditions in tpm_ppi.c
the patchset introduces a sparse error:
CHECK /home/phuewe/linux-2.6-host/drivers/char/tpm/tpm_tis.c
/home/phuewe/linux
Hi,
we got an official slot at Monday 5.30pm in Room 01 (http://sched.co/1D5VKBL) :)
Peter
Gesendet: Sonntag, 12. Oktober 2014 um 23:16 Uhr
Von: "Peter Huewe"
An: "Jarkko Sakkinen"
Cc: keyri...@linux-nfs.org, jarkko.sakkin...@linux.intel.com,
"ksummit-disc...@
Hi
> apologies for top-posting but which day/time/place is this going to be held?
I'd suggest that we either meet tomorrow (Monday) during the other BoF Sessions
@ 5:30pm or afterwards.
Does one of the attendees have a conflict with the BOFs or the VIP Reception?
Personally, I think it's most imp
Hi,
I would like to 'invite' all interested parties in a short TPM minisummit where
we can discuss the following hot topics of the TPM subsystem over a beer or two:
- State of the TPM Subsystem
- De-/Initialization Mess
- Devm'ification
- Testing
- TPM 2.0 Support
- Dependencies / interacti
g ACPI_HANDLE.
Signed-off-by: Peter Huewe
---
drivers/i2c/i2c-acpi.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-acpi.c b/drivers/i2c/i2c-acpi.c
index 0dbc18c..c456b17 100644
--- a/drivers/i2c/i2c-acpi.c
+++ b/drivers/i2c/i2c
Unfortunately the tpm_tis driver did never call request_region for its
adress space - now since we've got devm_ioremap_resource we can simply
remove all the stuff and do everything in one call.
Cc:
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis.c | 10 --
1 file chang
Hi Derek,
Is this a regression?
Do you know since when?
Thanks
Peter
---
Sent from my mobile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please re
From: Peter Huewe
If
status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
fails for whatever reason and does not return AE_OK
if (strstr(buffer.pointer, context) != NULL) {
does dereference a null pointer.
-> Check the return value and return the status to the caller
F
From: Jason Gunthorpe
This builds on the last commit to use the ops structure in the core
and reduce the size of tpm_vendor_specific.
Signed-off-by: Jason Gunthorpe
Reviewed-by: Joel Schopp
Reviewed-by: Ashley Lai
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm-interface.c| 34
1 - 100 of 351 matches
Mail list logo
