Re: [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling

2018-09-20 Thread Peter Feuerer
This improves quality. I reviewed all 6 patches. Reviewed-by: Peter Feuerer Please also add CC: Boris Petkov for review. [...] -- kind regards, --peter;

Re: [PATCH] thermal: fix race condition when updating cooling device

2016-08-11 Thread Peter Feuerer
t; This may lead to a situation where a thermal governor never updates the > cooling > device. For example, this is the case for the step_wise governor: when calling > the function thermal_zone_trip_update(), the governor may always get a new > state > equal to the old one (which, ho

Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro

2016-08-11 Thread Peter Feuerer
ding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni Acked-by: Peter Feuerer > --- > drivers/platform/x86

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-07-03 Thread Peter Feuerer
x-kernel@vger.kernel.org >> Cc: linux-o...@vger.kernel.org >> Cc: platform-driver-...@vger.kernel.org >> Cc: linux...@vger.kernel.org >> Signed-off-by: Eduardo Valentin > > +Peter Feuerer > > Peter, any concerns regarding the acerhdf driver? Yes, please see below

Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary

2016-05-24 Thread Peter Feuerer
Hi, 24. Mai 2016 15:06 Uhr, "Javi Merino" schrieb: > Ccing Peter Feuerer, author of the bang bang governor. > > On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > >> From: Sascha Hauer >> >> With interrupt driven thermal zones we pass the

Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary

2016-05-24 Thread Peter Feuerer
Hi, 24. Mai 2016 15:06 Uhr, "Javi Merino" schrieb: > Ccing Peter Feuerer, author of the bang bang governor. thanks, will take care today in the evening. --peter; > > On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > >> From: Sascha Hauer >>

Re: [PATCH] thermal: check validity get_trip_hyst function pointer in bang-bang governor

2016-05-22 Thread Peter Feuerer
need to check whether the > function pointer is valid or not. > > If it is not available, we assume the hysteresis to be zero. Consequently, a > highly varying temperature will make the governor continuosly switch a cooling > device ON and OFF. > > CC: Zhang Rui > CC: E

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-08 Thread Peter Feuerer
org Cc: linux-kernel@vger.kernel.org Cc: Jean Delvare Cc: Peter Feuerer Cc: Heiko Stuebner Cc: Lukasz Majewski Cc: Stephen Warren Cc: Thierry Reding Cc: linux-a...@vger.kernel.org Cc: platform-driver-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-o...@vger.kernel.o

Re: [PATCH -next] platform/x86/acerhdf: still depends on THERMAL

2014-12-15 Thread Peter Feuerer
erence to `thermal_zone_device_register' drivers/built-in.o: In function `acerhdf_unregister_thermal': acerhdf.c:(.text.unlikely+0x3c67): undefined reference to `thermal_cooling_device_unregister' acerhdf.c:(.text.unlikely+0x3c91): undefined reference to `thermal_zone_device_unregist

Re: [RESEND PATCH v5 3/5] acerhdf: Use bang-bang thermal governor

2014-12-07 Thread Peter Feuerer
Hi Darren, I know you are busy and I don't want to stress you, but have you had time to look to this? I'd be really happy to solve all issues in time and have those patches finally applied. kind regards, --peter; Peter Feuerer writes: Hi again, Peter Feuerer writes: Hi Darr

Re: [RESEND PATCH v5 3/5] acerhdf: Use bang-bang thermal governor

2014-12-03 Thread Peter Feuerer
Hi again, Peter Feuerer writes: Hi Darren, thank you very much for your reply. Darren Hart writes: On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote: acerhdf has been doing an on-off fan control using hysteresis by post-manipulating the outcome of thermal subsystem trip point

Re: [RESEND PATCH v5 3/5] acerhdf: Use bang-bang thermal governor

2014-12-03 Thread Peter Feuerer
Hi Darren, thank you very much for your reply. Darren Hart writes: On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote: acerhdf has been doing an on-off fan control using hysteresis by post-manipulating the outcome of thermal subsystem trip point handling. This patch enables

Re: [RESEND PATCH v5 0/5] acerhdf: adding new models, appropriate governor and minor clean up

2014-12-03 Thread Peter Feuerer
Hi Darren / platform-driver-x86 list, Peter Feuerer writes: please apply this series of patches. did you find time for my patchseries already? Is there any problem with it? -- kind regards, --peter; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

[RESEND PATCH v5 1/5] acerhdf: Adding support for "manual mode"

2014-11-28 Thread Peter Feuerer
Morton Cc: Andreas Mohr Acked-by: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 186 ++--- 1 file changed, 102 insertions(+), 84 deletions(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c ind

[RESEND PATCH v5 4/5] acerhdf: added critical trip point

2014-11-28 Thread Peter Feuerer
added critical trip point which represents the temperature limit. Added return -EINVAL in case wrong trip point is provided. Cc: platform-driver-...@vger.kernel.org Cc: Darren Hart Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer

[RESEND PATCH v5 0/5] acerhdf: adding new models, appropriate governor and minor clean up

2014-11-28 Thread Peter Feuerer
- adding second trip point for critical temperature (Patch 4) - removing _t suffix from struct which isn't typedef and replace unsigned char by u8 (Patch 5) Thanks and kind regards, peter Peter Feuerer (5): acerhdf: Adding support for "manual mode" acerhdf:

[RESEND PATCH v5 3/5] acerhdf: Use bang-bang thermal governor

2014-11-28 Thread Peter Feuerer
Cc: Andrew Morton CC: Zhang Rui Cc: Andreas Mohr Cc: Javi Merino Acked-and-tested-by: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/Kconfig | 3 ++- drivers/platform/x86/acerhdf.c | 36 +++- 2 files changed, 33 insertions(+), 6

[RESEND PATCH v5 2/5] acerhdf: Adding support for new models

2014-11-28 Thread Peter Feuerer
-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index 2c58f10..f30767f 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers

[RESEND PATCH v5 5/5] acerhdf: minor clean up

2014-11-28 Thread Peter Feuerer
* renamed bios_settings_t to bios_settings, as it is no typedef * replaced "unsigned char" by u8 in bios_settings struct for better readability. Cc: platform-driver-...@vger.kernel.org Cc: Darren Hart Cc: Andrew Morton Cc: Andreas Mohr Acked-by: Borislav Petkov Signed-off

Re: [PATCH v5 3/6] thermal: Added Bang-bang thermal governor

2014-10-29 Thread Peter Feuerer
Hi Javi, Javi Merino writes: On Tue, Oct 28, 2014 at 07:33:39PM +, Peter Feuerer wrote: Hi Rui, I wonder whether you've had time to apply my set of patches already? Would you please be so kind to just send me a short reply? The bang-bang governor was merged and is part of v3.1

Re: [PATCH v5 3/6] thermal: Added Bang-bang thermal governor

2014-10-28 Thread Peter Feuerer
Hi Rui, I wonder whether you've had time to apply my set of patches already? Would you please be so kind to just send me a short reply? thanks and kind regards, --peter; Peter Feuerer writes: Hi Rui, Zhang Rui writes: On Sat, 2014-07-26 at 16:14 +0200, Peter Feuerer wrote: H

Re: [PATCH v5 3/6] thermal: Added Bang-bang thermal governor

2014-10-21 Thread Peter Feuerer
Hi Rui, Zhang Rui writes: On Sat, 2014-07-26 at 16:14 +0200, Peter Feuerer wrote: Hi Rui, Peter Feuerer writes: > The bang-bang thermal governor uses a hysteresis to switch abruptly on > or off a cooling device. It is intended to control fans, which can > not be throttled but just

Re: [PATCH v5 4/6] acerhdf: Use bang-bang thermal governor

2014-08-27 Thread Peter Feuerer
Zhang Rui writes: On Tue, 2014-07-22 at 17:37 +0200, Peter Feuerer wrote: acerhdf has been doing an on-off fan control using hysteresis by post-manipulating the outcome of thermal subsystem trip point handling. This patch enables acerhdf to use the bang-bang governor, which is intended for on

Re: [PATCH v5 5/6] acerhdf: added critical trip point

2014-07-26 Thread Peter Feuerer
Hi Boris, Peter Feuerer writes: added critical trip point which represents the temperature limit. Added return -EINVAL in case wrong trip point is provided. Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Any concerns regarding this patch? -- --peter; -- To unsubscribe from this

Re: [PATCH v5 3/6] thermal: Added Bang-bang thermal governor

2014-07-26 Thread Peter Feuerer
Hi Rui, Peter Feuerer writes: The bang-bang thermal governor uses a hysteresis to switch abruptly on or off a cooling device. It is intended to control fans, which can not be throttled but just switched on or off. Bang-bang cannot be set as default governor as it is intended for special

[PATCH v5 6/6] acerhdf: minor clean up

2014-07-22 Thread Peter Feuerer
* renamed bios_settings_t to bios_settings, as it is no typedef * replaced "unsigned char" by u8 in bios_settings struct for better readability. Cc: Andrew Morton Cc: Andreas Mohr Acked-by: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acer

[PATCH v5 3/6] thermal: Added Bang-bang thermal governor

2014-07-22 Thread Peter Feuerer
devices the driver needs to explicitely request it. Cc: Andrew Morton Cc: Zhang Rui Cc: Andreas Mohr Cc: Borislav Petkov Cc: Javi Merino Cc: linux...@vger.kernel.org Signed-off-by: Peter Feuerer --- drivers/thermal/Kconfig | 10 +++ drivers/thermal/Makefile| 1 + drivers/thermal

[PATCH v5 2/6] acerhdf: Adding support for new models

2014-07-22 Thread Peter Feuerer
added following new models: * Aspire 5755G * AO521 * AO751h * Aspire One 753 * Extensa 5420 * Aspire 5315 * Aspire 5739G * TravelMate TM8573T Cc: Andrew Morton Cc: Andreas Mohr Acked-by: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c

[PATCH v5 5/6] acerhdf: added critical trip point

2014-07-22 Thread Peter Feuerer
added critical trip point which represents the temperature limit. Added return -EINVAL in case wrong trip point is provided. Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 10 +- 1 file changed

[PATCH v5 4/6] acerhdf: Use bang-bang thermal governor

2014-07-22 Thread Peter Feuerer
: Javi Merino Acked-and-tested-by: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/Kconfig | 3 ++- drivers/platform/x86/acerhdf.c | 36 +++- 2 files changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/Kconfig b

[PATCH v5 0/6] acerhdf/thermal: adding new models, appropriate governor and minor clean up

2014-07-22 Thread Peter Feuerer
point for critical temperature (Patch 5) - removing _t suffix from struct which isn't typedef and replace unsigned char by u8 (Patch 6) Thanks and kind regards, peter Peter Feuerer (6): acerhdf: Adding support for "manual mode" acerhdf: Adding support for new

[PATCH v5 1/6] acerhdf: Adding support for "manual mode"

2014-07-22 Thread Peter Feuerer
ned-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 186 ++--- 1 file changed, 102 insertions(+), 84 deletions(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index f94467c..2c58f10 100644 --- a/drivers/platform/x86/acerh

Re: [PATCH v4 3/6] thermal: Added Bang-bang thermal governor

2014-07-22 Thread Peter Feuerer
Hi, Zhang Rui writes: On Mon, 2014-07-21 at 11:29 +0200, Borislav Petkov wrote: On Sun, Jul 20, 2014 at 02:51:17AM +0200, Peter Feuerer wrote: > The bang-bang thermal governor uses a hysteresis to switch abruptly on > or off a cooling device. It is intended to control fans, which can

Re: [PATCH v4 1/6] acerhdf: Adding support for "manual mode"

2014-07-20 Thread Peter Feuerer
Hi Andreas, Andreas Mohr writes: Hi On Sun, Jul 20, 2014 at 02:51:15AM +0200, Peter Feuerer wrote: @@ -127,105 +138,107 @@ struct bios_settings_t { unsigned char fanreg; unsigned char tempreg; struct fancmd cmd; + int mcmd_enable; }; + /* Register addresses

[PATCH v4 3/6] thermal: Added Bang-bang thermal governor

2014-07-19 Thread Peter Feuerer
devices the driver needs to explicitely request it. Cc: Andrew Morton Cc: Zhang Rui Cc: Andreas Mohr Cc: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer --- drivers/thermal/Kconfig | 10 +++ drivers/thermal/Makefile| 1 + drivers/thermal/gov_bang_bang.c | 131

[PATCH v4 5/6] acerhdf: added critical trip point

2014-07-19 Thread Peter Feuerer
added critical trip point which represents the temperature limit. Added return -EINVAL in case wrong trip point is provided. Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 10 +- 1 file changed

[PATCH v4 0/6] acerhdf/thermal: adding new models, appropriate governor and minor clean up

2014-07-19 Thread Peter Feuerer
point for critical temperature (Patch 5) - removing _t suffix from struct which isn't typedef and replace unsigned char by u8 (Patch 6) Thanks and kind regards, peter Peter Feuerer (6): acerhdf: Adding support for "manual mode" acerhdf: Adding support for new

[PATCH v4 6/6] acerhdf: minor clean up

2014-07-19 Thread Peter Feuerer
* renamed bios_settings_t to bios_settings, as it is no typedef * replaced "unsigned char" by u8 in bios_settings struct for better readability. Cc: Andrew Morton Cc: Andreas Mohr Acked-by: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acer

[PATCH v4 4/6] acerhdf: Use bang-bang thermal governor

2014-07-19 Thread Peter Feuerer
: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer --- drivers/platform/x86/Kconfig | 2 +- drivers/platform/x86/acerhdf.c | 36 +++- 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86

[PATCH v4 1/6] acerhdf: Adding support for "manual mode"

2014-07-19 Thread Peter Feuerer
ned-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 187 +++-- 1 file changed, 103 insertions(+), 84 deletions(-) diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index f94467c..dd63e93 100644 --- a/drivers/platform/x86/acerh

[PATCH v4 2/6] acerhdf: Adding support for new models

2014-07-19 Thread Peter Feuerer
added following new models: * Aspire 5755G * AO521 * AO751h * Aspire One 753 * Extensa 5420 * Aspire 5315 * Aspire 5739G * TravelMate TM8573T Cc: Andrew Morton Cc: Andreas Mohr Acked-by: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c

Re: [PATCH v3 2/6] acerhdf: Adding support for new models

2014-07-18 Thread Peter Feuerer
Borislav Petkov writes: The major 0 is just from the ages, when all cool projects used to have a 0 in front. Maybe it would be a good idea to go for 1.0 when I implemented a better handling for the huge bios table. Probably. You could at least increment it to 0.6 when you switch to the bang-ba

Re: [PATCH v3 3/6] thermal: Added Bang-bang thermal governor

2014-07-18 Thread Peter Feuerer
Borislav Petkov writes: On Sat, May 03, 2014 at 07:59:23PM +0200, Peter Feuerer wrote: The bang-bang thermal governor uses a hysteresis to switch abruptly on or off a cooling device. It is intended to control fans, which can not be throttled but just switched on or off. Bang-bang cannot be

Re: [PATCH v3 2/6] acerhdf: Adding support for new models

2014-07-18 Thread Peter Feuerer
Borislav Petkov writes: On Sat, May 03, 2014 at 07:59:22PM +0200, Peter Feuerer wrote: added following new models: * Aspire 5755G * AO521 * AO751h * Aspire One 753 * Extensa 5420 * Aspire 5315 * Aspire 5739G * TravelMate TM8573T Cc: Andrew Morton Cc: Andreas Mohr Cc

Re: [PATCH v3 0/6] acerhdf/thermal: adding new models, appropriate governor and minor clean up

2014-07-16 Thread Peter Feuerer
Hi Boris, nice to hear from you. Borislav Petkov writes: Hi Peter, On Sat, May 03, 2014 at 07:59:20PM +0200, Peter Feuerer wrote: This patch series is intended to: * Introduce "manual mode" support (Patch 1 & 2), which is needed to control the fan of a few new model

Re: [PATCH v3 0/6] acerhdf/thermal: adding new models, appropriate governor and minor clean up

2014-05-15 Thread Peter Feuerer
Hi Eduardo, Eduardo Valentin writes: Hello Peter, On Sat, May 03, 2014 at 07:59:20PM +0200, Peter Feuerer wrote: Hi, This patch series is intended to: * Introduce "manual mode" support (Patch 1 & 2), which is needed to control the fan of a few new models. * Add

Re: [PATCH v3 4/6] acerhdf: Use bang-bang thermal governor

2014-05-12 Thread Peter Feuerer
Hi Javi, Javi Merino writes: Hi Peter, On Sat, May 03, 2014 at 06:59:24PM +0100, Peter Feuerer wrote: acerhdf has been doing an on-off fan control using hysteresis by post-manipulating the outcome of thermal subsystem trip point handling. This patch enables acerhdf to use the bang-bang

[PATCH v3 5/6] acerhdf: added critical trip point

2014-05-03 Thread Peter Feuerer
added critical trip point which represents the temperature limit. Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform

[PATCH v3 3/6] thermal: Added Bang-bang thermal governor

2014-05-03 Thread Peter Feuerer
devices the driver needs to explicitely request it. Cc: Andrew Morton Cc: Zhang Rui Cc: Andreas Mohr Cc: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer --- drivers/thermal/Kconfig | 10 +++ drivers/thermal/Makefile| 1 + drivers/thermal/gov_bang_bang.c | 131

[PATCH v3 4/6] acerhdf: Use bang-bang thermal governor

2014-05-03 Thread Peter Feuerer
: Borislav Petkov Cc: Javi Merino Signed-off-by: Peter Feuerer --- drivers/platform/x86/Kconfig | 2 +- drivers/platform/x86/acerhdf.c | 34 +- 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86

[PATCH v3 0/6] acerhdf/thermal: adding new models, appropriate governor and minor clean up

2014-05-03 Thread Peter Feuerer
point for critical temperature (Patch 5) - removing _t suffix from struct which isn't typedef and replace unsigned char by u8 (Patch 6) Thanks and kind regards, peter Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Cc: Zhang Rui Cc: Javi Merino Peter Feuerer

[PATCH v3 1/6] acerhdf: Adding support for "manual mode"

2014-05-03 Thread Peter Feuerer
Some Acer models require an additional command to turn off the fan after bios mode has been enabled. Adding new section in bios table to allow support for those models, by writing an extra "manual mode" register. Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Signed-off

[PATCH v3 2/6] acerhdf: Adding support for new models

2014-05-03 Thread Peter Feuerer
added following new models: * Aspire 5755G * AO521 * AO751h * Aspire One 753 * Extensa 5420 * Aspire 5315 * Aspire 5739G * TravelMate TM8573T Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 25

[PATCH v3 6/6] acerhdf: minor clean up

2014-05-03 Thread Peter Feuerer
* renamed bios_settings_t to bios_settings, as it is no typedef * replaced "unsigned char" by u8 in bios_settings struct for better readability. Cc: Andrew Morton Cc: Andreas Mohr Cc: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 12 +

Re: [PATCH v2 0/4] acerhdf/thermal: adding new models and appropriate governor

2014-05-01 Thread Peter Feuerer
Hi all, Peter Feuerer writes: This patch series is intended to: * Introduce "manual mode" support (Patch 1 & 2), which is needed to control the fan of a few new models. * Add an appropriate thermal governor (Patch 3 & 4). Manipulating and fiddling around

Re: [PATCH v2 3/4] thermal: Added Bang-bang thermal governor

2014-04-29 Thread Peter Feuerer
Hi Javi, Peter Feuerer writes: > Javi Merino writes: [...] >>> diff --git a/drivers/thermal/gov_bang_bang.c >>> b/drivers/thermal/gov_bang_bang.c >>> new file mode 100644 >>> index 000..328dde0 >>> --- /dev/null >>>

Re: [PATCH v2 4/4] acerhdf: Use bang-bang thermal governor

2014-04-29 Thread Peter Feuerer
Javi Merino writes: > On Tue, Apr 29, 2014 at 10:17:57AM +0100, Peter Feuerer wrote: >> acerhdf has been doing an on-off fan control using hysteresis by >> post-manipulating the outcome of thermal subsystem trip point handling. >> This patch enables acerhdf to use the bang-ba

Re: [PATCH v2 3/4] thermal: Added Bang-bang thermal governor

2014-04-29 Thread Peter Feuerer
Javi Merino writes: > On Tue, Apr 29, 2014 at 10:17:56AM +0100, Peter Feuerer wrote: >> The bang-bang thermal governor uses a hysteresis to switch abruptly on >> or off a cooling device. It is intended to control fans, which can >> not be throttled but just switched on

[PATCH v2 3/4] thermal: Added Bang-bang thermal governor

2014-04-29 Thread Peter Feuerer
devices the driver needs to explicitely request it. Cc: Zhang Rui Cc: Andreas Mohr Cc: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/thermal/Kconfig | 10 drivers/thermal/Makefile| 1 + drivers/thermal/gov_bang_bang.c | 124

[PATCH v2 2/4] acerhdf: Adding support for new models

2014-04-29 Thread Peter Feuerer
added following new models: * Aspire 5755G * AO521 * AO751h * Aspire One 753 * Extensa 5420 * Aspire 5315 * Aspire 5739G * TravelMate TM8573T Cc: Andreas Mohr Cc: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 25

[PATCH v2 1/4] acerhdf: Adding support for "manual mode"

2014-04-29 Thread Peter Feuerer
Some Acer models require an additional command to turn off the fan after bios mode has been enabled. Adding new section in bios table to allow support for those models, by writing an extra "manual mode" register. Cc: Andreas Mohr Cc: Borislav Petkov Signed-off-by: Peter Feuerer --

[PATCH v2 4/4] acerhdf: Use bang-bang thermal governor

2014-04-29 Thread Peter Feuerer
Signed-off-by: Peter Feuerer --- drivers/platform/x86/Kconfig | 2 +- drivers/platform/x86/acerhdf.c | 48 +++--- 2 files changed, 41 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 27df2c5..0c15d89

[PATCH v2 0/4] acerhdf/thermal: adding new models and appropriate governor

2014-04-29 Thread Peter Feuerer
. Thanks and kind regards, peter Cc: Andreas Mohr Cc: Borislav Petkov Cc: Zhang Rui Peter Feuerer (4): acerhdf: Adding support for "manual mode" acerhdf: Adding support for new models thermal: Added Bang-bang thermal governor acerhdf: Use bang-bang thermal governor drivers/p

Re: [PATCH 0/4] acerhdf/thermal: adding new models and appropriate governor

2014-04-27 Thread Peter Feuerer
Hi, Andreas Mohr writes: > On Sun, Apr 27, 2014 at 03:23:31AM +0200, Peter Feuerer wrote: >> This patch series is intended to: >> >> * Introduce "manual mode" support (Patch 1 & 2), which is needed to control >> the fan of a few new models.

Re: [PATCH 1/4] acerhdf: Adding support for "manual mode"

2014-04-27 Thread Peter Feuerer
Borislav Petkov writes: On Sun, Apr 27, 2014 at 03:23:32AM +0200, Peter Feuerer wrote: From: Peter Feuerer Some Acer models require an additional command to turn off the fan after bios mode has been enabled. Adding new section in bios table to allow support for those models, by writing an

[PATCH 2/4] acerhdf: Adding support for new models

2014-04-26 Thread Peter Feuerer
From: Peter Feuerer added following new models: * Aspire 5755G * AO521 * AO751h * Aspire One 753 * Extensa 5420 * Aspire 5315 * Aspire 5739G * TravelMate TM8573T Cc: Andreas Mohr Cc: Borislav Petkov Signed-off-by: Peter Feuerer --- drivers/platform/x86/acerhdf.c | 24

[PATCH 0/4] acerhdf/thermal: adding new models and appropriate governor

2014-04-26 Thread Peter Feuerer
egards, peter Cc: Andreas Mohr Cc: Borislav Petkov Cc: Zhang Rui Peter Feuerer (4): acerhdf: Adding support for "manual mode" acerhdf: Adding support for new models thermal: Added Bang-bang thermal governor acerhdf: Use bang-bang thermal governor drivers/platform/x86/Kconfig|

[PATCH 4/4] acerhdf: Use bang-bang thermal governor

2014-04-26 Thread Peter Feuerer
From: Peter Feuerer acerhdf has been doing an on-off fan control using hysteresis by post-manipulating the outcome of thermal subsystem trip point handling. This patch enables acerhdf to use the bang-bang governor, which is intended for on-off controlled fans. CC: Zhang Rui Cc: Andreas Mohr

[PATCH 1/4] acerhdf: Adding support for "manual mode"

2014-04-26 Thread Peter Feuerer
From: Peter Feuerer Some Acer models require an additional command to turn off the fan after bios mode has been enabled. Adding new section in bios table to allow support for those models, by writing an extra "manual mode" register. Cc: Andreas Mohr Cc: Borislav Petkov Signed-off

[PATCH 3/4] thermal: Added Bang-bang thermal governor

2014-04-26 Thread Peter Feuerer
From: Peter Feuerer The bang-bang thermal governor uses a hysteresis to switch abruptly on or off a cooling device. It is intended to control fans, which can not be throttled but just switched on or off. Bang-bang cannot be set as default governor as it is intended for special devices only

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-07 Thread Peter Feuerer
Hi Boris, Borislav Petkov writes: On Mon, Feb 25, 2013 at 01:16:08PM +0100, Borislav Petkov wrote: On Mon, Feb 25, 2013 at 11:25:26AM +0100, Borislav Petkov wrote: > > has anybody checked if the patch at lkml.org/lkml/2012/12/30/47 fixes > > the problem, without any other patch? > > Ok, let m

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-25 Thread Peter Feuerer
Hi, sorry for not answering to earlier mails, but sitting in front of the computer and writing English mails is still very exhausting for me. Borislav Petkov writes: On Mon, Feb 25, 2013 at 11:06:40AM +0800, Zhang Rui wrote: when the temperature goes up to 50C, will the fan be turned on or

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Peter Feuerer
design of acerhdf where we want to turn off the fan if we go under the 'fanoff' temperature and to turn it on only after exceeding the 'fanon' temperature. Do that by looking at the current fan state and return the temperature accordingly. Suggested-by: Zhang Rui Cc: Peter

Re: thermal governor: does it actually work??

2013-02-21 Thread Peter Feuerer
Adding Boris, sorry, I can't do anything currently, I'm down with influenza. kind regards, --peter; Zhang Rui writes: On Thu, 2013-02-14 at 16:32 +0100, Andreas Mohr wrote: For me after having loaded acerhdf the fan never stops (with kernelmode active), despite staying safely below trip poin

Re: thermal governor: does it actually work??

2013-02-18 Thread Peter Feuerer
Hi Boris, Hi Rui, @Rui, would be great, if you could review the patch and verify, whether everything I'm telling is the truth, thanks. Borislav Petkov writes: On Sun, Feb 17, 2013 at 04:41:57PM +0100, Peter Feuerer wrote: Don't think so, I think this was already in since 2.6. an

Re: thermal governor: does it actually work??

2013-02-17 Thread Peter Feuerer
Hi, Borislav Petkov writes: On Sun, Feb 17, 2013 at 03:43:13AM +0100, Peter Feuerer wrote: From 7b39bd8837de6dc5658ac3e54ac5d4df9d351528 Mon Sep 17 00:00:00 2001 From: Peter Feuerer Date: Sun, 17 Feb 2013 03:29:19 +0100 Subject: [PATCH] added two more trip points to acerhdf, this allows

Re: thermal governor: does it actually work??

2013-02-16 Thread Peter Feuerer
Hi Boris, Alex, Andreas, what do you think about this acerhdf patch? I think it makes things straight and implements the two-point regulation of acerhdf to be for correctly handled by the thermal layer: >From 7b39bd8837de6dc5658ac3e54ac5d4df9d351528 Mon Sep 17 00:00:00 2001 From: Peter Feue

Re: [PATCH 1/1] x86: Added support for Acer Aspire 5755G fan control.

2012-09-29 Thread Peter Feuerer
Hi, Borislav Petkov writes: Adding Peter. Just wanted to say, that I've got currently very less spare time. I think I'll be fully available again in about 2 weeks. I'll catch up then. -- Thanks and kind regards, --peter; -- To unsubscribe from this list: send the line "unsubscribe linux-ke