[PATCH v2] hwmon: pmbus: pxe1610: don't bail out when not all pages are active

2021-04-16 Thread Paul Fertser
Certain VRs might be configured to use only the first output channel and so the mode for the second will be 0. Handle this gracefully. Fixes: b9fa0a3acfd8 ("hwmon: (pmbus/core) Add support for vid mode detection per page bases") Signed-off-by: Paul Fertser --- Notes: Chan

[PATCH] arm: dts: aspeed: tiogapass: add hotplug controller

2021-04-15 Thread Paul Fertser
The ADM1278 IC is accessible on I2C bus and on both Wiwynn and Quanta Tioga Pass implementations a pair of parallel 0.5 mOhm resistors is used for current measurement. Signed-off-by: Paul Fertser --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 5 + 1 file changed, 5 insertions

[PATCH] hwmon: pmbus: pxe1610: don't bail out when not all pages are active

2021-04-15 Thread Paul Fertser
Certain VRs might be configured to use only the first output channel and so the mode for the second will be 0. Handle this gracefully. Fixes: b9fa0a3acfd8 ("hwmon: (pmbus/core) Add support for vid mode detection per page bases") Signed-off-by: Paul Fertser --- drivers/hwmon/pmbus

Re: [PATCH v29 0/6] JTAG driver introduction

2021-04-06 Thread Paul Fertser
Hi Andy, On Tue, Apr 06, 2021 at 04:22:04PM +0300, Andy Shevchenko wrote: > On Fri, Jan 15, 2021 at 01:46:35PM +0300, Paul Fertser wrote: > > I have to note that the current v29 version of the series is broken in > > several aspects: > > Is it correct that this series is

Re: [PATCH v29 4/6] Documentation: jtag: Add ABI documentation

2021-01-19 Thread Paul Fertser
Hello, This review of the proposed API was written after independently developing and testing on hardware (only SVF playback to configure a CPLD) support for OpenOCD[0]. I also include points that come to mind from my prior experience using wide range of JTAG adapters with different targets. On M

Re: [PATCH v29 2/6] dt-binding: jtag: Aspeed 2400 and 2500 series

2021-01-19 Thread Paul Fertser
On Mon, Apr 13, 2020 at 03:29:16PM -0700, Ernesto Corona wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.yaml > +examples: > + - | > +#include > +#include > + > + jtag: jtag@1e6e4000 { > + compatible = "aspeed,ast2500-jtag"; > + re

Re: [PATCH v29 3/6] Add Aspeed SoC 24xx and 25xx families JTAG master driver

2021-01-15 Thread Paul Fertser
Please note that JTAG_XFER_HW_MODE seems to be broken, at least it doesn't work in my testing with exactly the same userspace and hardware so I wasn't properly evaluating it. On Mon, Apr 13, 2020 at 03:29:17PM -0700, Ernesto Corona wrote: > --- /dev/null > +++ b/drivers/jtag/jtag-aspeed.c ... > +/

Re: [PATCH v29 1/6] drivers: jtag: Add JTAG core driver

2021-01-15 Thread Paul Fertser
On Mon, Apr 13, 2020 at 03:29:15PM -0700, Ernesto Corona wrote: > --- /dev/null > +++ b/drivers/jtag/jtag.c > + case JTAG_SIOCFREQ: > + if (!jtag->ops->freq_set) > + return -EOPNOTSUPP; > + > + if (get_user(value, (__u32 __user *)arg)) > +

Re: [PATCH v29 0/6] JTAG driver introduction

2021-01-15 Thread Paul Fertser
Hello, This is a multi-part review of the series, with general notes inline in this message, and specific points raised as replies to the individual patches. On Mon, Apr 13, 2020 at 03:29:14PM -0700, Ernesto Corona wrote: > We propose to implement general JTAG interface and infrastructure > to co

[PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"

2016-10-25 Thread Paul Fertser
e. Acked-by: Marc Dietrich Signed-off-by: Paul Fertser --- drivers/staging/nvec/nvec_ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c index a324322..c83eeb4 100644 --- a/drivers/staging/nvec/nvec_ps2.c ++

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-09 Thread Paul Fertser
Hi, On Fri, May 09, 2014 at 09:07:00AM +, suresh.gu...@freescale.com wrote: > > Are you really sure we can't get async VBUS state change notifications > > until controller has USB_CMD_RUN_STOP bit set (and the same bit actually > > controls internal 1.5k dataline pullup)? If yes, I guess it me

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread Paul Fertser
On Thu, May 08, 2014 at 06:42:53PM +, suresh.gu...@freescale.com wrote: > > > And Host might be attach after system bootup or after driver > > > initialization. So putting this check in probe will not help much. > > > > If the host is attached after the driver was initialised, the interrupt >

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread Paul Fertser
Hi, On Thu, May 08, 2014 at 02:30:39PM +, suresh.gu...@freescale.com wrote: > As per my limited knowledge, the purpose of > OTGSC_STS_B_SESSION_VALID bit is to tell either VBUS is above the B > session valid threshold and which comes only Host is attached. Yes, that matches the datasheet I've

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-30 Thread Paul Fertser
Hello, Thank you for the review. On Wed, Apr 30, 2014 at 11:06:25AM -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 12:54:13PM +0400, Paul Fertser wrote: > > If VBUS is already present during the driver initialisation, the > > s/initialisation/initialization If I

[PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-24 Thread Paul Fertser
If VBUS is already present during the driver initialisation, the corresponding IRQ never fires, so there is no way the gadget can get enumerated. This patch is real-life tested on an i.MX25 board with VBUS constantly hooked up. Signed-off-by: Paul Fertser --- drivers/usb/gadget/fsl_udc_core.c