[PATCH] ipw2200: Missing kmalloc check

2005-09-04 Thread Panagiotis Issaris
The ipw2200 driver code in current GIT contains a kmalloc() followed by a memset() without handling a possible memory allocation failure. Signed-off-by: Panagiotis Issaris <[EMAIL PROTECTED]> --- drivers/net/wireless/ipw2200.c |4 1 files changed, 4 insertions(+), 0 del

Re: Re: more git updates..

2005-04-12 Thread Panagiotis Issaris
Hi David, On Tue, Apr 12, 2005 at 06:36:23PM -0400, David Eger wrote: > > No. A tree is not the full data. A tree contains enough information > > to > > _recreate_ the full data, but the tree itself just tells you _how_ > > to do > > that. It doesn't contain very much of the data itself at all.

Re: Linux 2.6.11.5

2005-03-19 Thread Panagiotis Issaris
Hi Greg, The changelog states that the patches for the AMD8111e and VIA-Rhine originated from dilingerdebian.org although I was the one who they originated from. http://article.gmane.org/gmane.linux.kernel/282245 http://article.gmane.org/gmane.linux.kernel/282263 : o Possible AMD8111e free irq

[PATCH 2.6.11-mm1] acpiphp_ibm: add failure handling for memory allocation

2005-03-06 Thread Panagiotis Issaris
Hi, This patch adds failure handling for kmalloc in the ACPI PCI Hot Plug IBM Extension driver. Signed-off-by: <[EMAIL PROTECTED]> diff -pruN linux-2.6.11-orig/drivers/pci/hotplug/acpiphp_ibm.c linux-2.6.11-pi/drivers/pci/hotplug/acpiphp_ibm.c --- linux-2.6.11-orig/drivers/pci/hotplug/acpiphp_i

[PATCH 2.6.11-mm1] ibm_emac_core: add memory allocation failure handling

2005-03-06 Thread Panagiotis Issaris
Hi, This patch adds failure handling for a kmalloc() in the driver for the IBM 4xx PowerPC builtin ethernet. Signed-off-by: <[EMAIL PROTECTED]> diff -pruN linux-2.6.11-orig/drivers/net/ibm_emac/ibm_emac_core.c linux-2.6.11-pi/drivers/net/ibm_emac/ibm_emac_core.c --- linux-2.6.11-orig/drivers/ne

[PATCH 2.6.11-mm1] mtd: fix INFTL failure handling

2005-03-06 Thread Panagiotis Issaris
Hi, The INFTL mount code contains a kmalloc() followed by a memset() without handling a possible memory allocation failure. Signed-off-by: <[EMAIL PROTECTED]> diff -pruN linux-2.6.11-orig/drivers/mtd/inftlmount.c linux-2.6.11-pi/drivers/mtd/inftlmount.c --- linux-2.6.11-orig/drivers/mtd/inftlmo

Re: [PATCH 2.6.11-mm1] efi: fix failure handling

2005-03-06 Thread Panagiotis Issaris
Hi, On Sun, Mar 06, 2005 at 02:06:27AM -0800 or thereabouts, Andrew Morton wrote: > "Panagiotis Issaris" <[EMAIL PROTECTED]> wrote: > > > > The EFI driver allocates memory and writes into it without checking the > > success of the allocation. Furthermore, on

[PATCH 2.6.11-mm1] efi: fix failure handling

2005-03-06 Thread Panagiotis Issaris
ff-by: Panagiotis Issaris <[EMAIL PROTECTED]> diff -pruN linux-2.6.11-orig/drivers/firmware/efivars.c linux-2.6.11-pi/drivers/firmware/efivars.c --- linux-2.6.11-orig/drivers/firmware/efivars.c2005-03-05 02:23:29.0 +0100 +++ linux-2.6.11-pi/drivers/firmware/efivars.c 2005-

Re: [PATCH] EFI missing failure handling

2005-03-05 Thread Panagiotis Issaris
Hi, On Sat, Mar 05, 2005 at 07:06:29PM +0200 or thereabouts, Alexey Dobriyan wrote: > On Saturday 05 March 2005 17:38, Panagiotis Issaris wrote: > > > The EFI driver allocates memory and writes into it without checking the > > success of the allocation: > >

[PATCH] EFI missing failure handling

2005-03-05 Thread Panagiotis Issaris
Hi, The EFI driver allocates memory and writes into it without checking the success of the allocation: 668 efi_char16_t *variable_name = kmalloc(1024, GFP_KERNEL); ... 696 memset(variable_name, 0, 1024); The patch applies to 2.6.11-bk1. Signed-off-by: Panagiotis Issaris <[EM

[PATCH] qtronix missing failure handling

2005-03-05 Thread Panagiotis Issaris
Hi, The Qtronix keyboard driver doesn't handle the possible failure of memory allocation. Signed-off-by: Panagiotis Issaris <[EMAIL PROTECTED]> diff -pruN linux-2.6.11-mm1/drivers/char/qtronix.c linux-2.6.11-mm1-pi/drivers/char/qtronix.c --- linux-2.6.11-mm1/drivers/char/qtronix.c

[PATCH] Toshiba ACPI failure handling

2005-03-04 Thread Panagiotis Issaris
Hi, Adds the missing failure handling for a kmalloc in the Toshiba ACPI driver. Signed-off-by: Panagiotis Issaris <[EMAIL PROTECTED]> diff -pruN linux-2.6.11-orig/drivers/acpi/toshiba_acpi.c linux-2.6.11-pi/drivers/acpi/toshiba_acpi.c --- linux-2.6.11-orig/drivers/acpi/toshiba_

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Panagiotis Issaris
s > > I'll apply this to the 1394 tree and send it to Linus after testing if > you add a Signed-off-by: line per Documentation/SubmittingPatches . > Also, please cc [EMAIL PROTECTED] with ieee1394 > changes. Sure! Thanks! Adds the missing failure handling for a __copy_to_

Re: [PATCH] raw1394 missing failure handling

2005-03-03 Thread Panagiotis Issaris
call. Signed-off-by: Panagiotis Issaris <[EMAIL PROTECTED]> diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c linux-2.6.11-pi/drivers/ieee1394/raw1394.c --- linux-2.6.11/drivers/ieee1394/raw1394.c 2005-03-02 11:44:26.0 +0100 +++ linux-2.6.11-pi/drivers/ieee1394/raw1394.c 2005-

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, Dmitry Torokhov wrote: On Wed, 02 Mar 2005 13:28:23 +0100, Panagiotis Issaris <[EMAIL PROTECTED]> wrote: Oops. Thanks for replying! Any more problems with the updated patch? Formatting... Opening curly brace should go on the same line with "if". Thanks. Here's

Re: [PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, Anton Altaparmakov wrote: On Wed, 2005-03-02 at 12:10 +0100, Panagiotis Issaris wrote: In the raw1394 driver the failure handling for a __copy_to_user call is missing. Your patch is obviously incorrect as it doesn't free the request before it returns. Oops. Thanks for replying

[PATCH] raw1394 missing failure handling

2005-03-02 Thread Panagiotis Issaris
Hi, In the raw1394 driver the failure handling for a __copy_to_user call is missing. With friendly regards, Takis -- K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group http://people.mech.kuleuven.ac.be/~pissaris/ diff -pruN linux-2.6.11/drivers/ieee1394/raw1394.c linux-2.6.11-pi

Re: [PATCH] Possible AMD8111e free irq issue

2005-03-01 Thread Panagiotis Issaris
Hi, Jeff Garzik wrote: diff -uprN linux-2.6.11-rc5-bk2/drivers/net/amd8111e.c linux-2.6.11-rc5-bk2-pi/drivers/net/amd8111e.c --- linux-2.6.11-rc5-bk2/drivers/net/amd8111e.c2005-02-28 13:44:46.0 +0100 +++ linux-2.6.11-rc5-bk2-pi/drivers/net/amd8111e.c2005-02-28 13:45:09.0

[PATCH] SA9730 cleanup or fix

2005-02-28 Thread Panagiotis Issaris
Hi, In the SAA9730 driver the lan_saa9730_start() function always returns zero which makes the if/return code unnecessary. The first patch removes this check. In case it is suspected that the lan_saa9730_start() function might be modified in the future, causing it to be possible to return values

[PATCH] Possible ENI155P issues

2005-02-28 Thread Panagiotis Issaris
Hi, In the ENI155P device driver in six possible failure cases the requested irq is not being released. In three of the above possible failure cases additionally there seems to be a memory leak. The patch applies to 2.6.11-rc5-bk2. diff -uprN linux-2.6.11-rc5-bk2/drivers/atm/eni.c linux-2.6.11

[PATCH] Possible VIA-Rhine free irq issue

2005-02-28 Thread Panagiotis Issaris
Hi, It seems to me that in the VIA Rhine device driver the requested irq might not be freed in case the alloc_ring() function fails. alloc_ring() can fail with a ENOMEM return value because of possible pci_alloc_consistent() failures. This patch applies to 2.6.11-rc5-bk2. diff -uprN linux-2.6.11

[PATCH] Possible AMD8111e free irq issue

2005-02-28 Thread Panagiotis Issaris
Hi, It seems to me that if in the amd8111e_open() fuction dev->irq isn't zero and the irq request succeeds it might not get released anymore. Specifically, on failure of the amd8111e_restart() call the function returns -ENOMEM without releasing the irq. The amd8111e_restart() function can fail be

Re: prism54 not releasing region

2005-02-25 Thread Panagiotis Issaris
Andrew Morton wrote: Panagiotis Issaris <[EMAIL PROTECTED]> wrote: To my newbie eye it looked as if the region requested at line 154 weren't released in case of the line 166 failure handling. Is my assumption right? It is. I can take care of this patch for you, thank

prism54 not releasing region

2005-02-25 Thread Panagiotis Issaris
Hi, To my newbie eye it looked as if the region requested at line 154 weren't released in case of the line 166 failure handling. Is my assumption right? With friendly regards, Takis diff -uprN linux-2.6.11-rc5-orig/drivers/net/wireless/prism54/islpci_hotplug.c linux-2.6.11-rc5-pi/drivers/net/wi