Re: [PATCH 1/2] media/dvb-core: fix inverted check

Hi Max, Already in the tree: http://git.linuxtv.org/media_tree.git/commit/drivers/media/dvb-core?id=711f3fba6ffd3914fd1b5ed9faf8d22bab6f2203 Cheers, -olli On 18 March 2016 at 23:31, Max Kellermann wrote: > Breakage caused by commit f50d51661a > > Signed-off-by: Max Kellermann > --- > drivers/

Re: [PATCH] media: fix null pointer dereference in v4l_vb2q_enable_media_source()

Hi Shuah, Thanks for your quick reaction. This patch seems to fix the oops I got earlier. Tested-by: Olli Salonen Cheers, -olli On 4 March 2016 at 04:24, Shuah Khan wrote: > Fix the null pointer dereference in v4l_vb2q_enable_media_source(). > DVB only drivers don't have valid str

Re: [PATCHv2] si2157: Bounds check firmware

Reviewed-by: Olli Salonen Tested-by: Olli Salonen On 6 October 2015 at 01:33, Laura Abbott wrote: > > When reading the firmware and sending commands, the length > must be bounds checked to avoid overrunning the size of the command > buffer and smashing the stack if the firmware i

Re: [PATCH 2/2] si2157: Bounds check firmware

Hi Laura, While the patch itself does what it says, the return code for the si2157_init will be 0 even if there's a faulty firmware file. Wouldn't it be better to set the return code as -EINVAL like done a few lines earlier in the code (see below)? if (fw->size % 17 != 0) {