ew ports.
This patch aims to show how this can be changed:
- introduce structure port_params_ops that has callbacks for get/set/validate;
- if devlink has registered port_params_ops, then upon every devlink
port parameter get/set call invoke port parameters callback
Signed-off-by:
On 2/9/21 3:31 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
> Signed-off-by: Oleksandr Mazur
> ---
> applied to iproute2-next.
> In the
Add implementation for the port parameters
getting/setting.
Add bash completion for port param.
Add man description for port param.
Signed-off-by: Oleksandr Mazur
---
V4:
1) Rebase on top of master;
2) Add missed space in after else-if-clause bracket;
V3:
1) Add usage example;
2
#x27;t register callback for hard drop
statistics querying, 'dropped' field will be omitted and not filled.
Add trap_drop_counter_get callback implementation to the netdevsim.
Add new test cases for netdevsim, to test both the callback
functionality, as well as drop statistics alteration check.
#x27;t register callback for hard drop
statistics querying, 'dropped' field will be omitted and not filled.
Add trap_drop_counter_get callback implementation to the netdevsim.
Add new test cases for netdevsim, to test both the callback
functionality, as well as drop statistics alteration check.
"name": "test_port_parameter",
"type": "driver-specific",
"values": [ {
"cmode": "runtime",
"value": false
} ]
On Fri, 29 Jan 2021 11:15:43 + Oleksandr Mazur wrote:
> > >Thinking about it again - if the action can be changed wouldn't it
> > >be best for the user to actually get a "HW condition hit" counter,
> >> which would increment regardless of SW config
On Mon, 25 Jan 2021 14:38:56 +0200 Oleksandr Mazur wrote:
> + if (trap_item->action == DEVLINK_TRAP_ACTION_DROP &&
> + devlink->ops->trap_drop_counter_get) {
> + err = devlink->ops-&
drop_counter_get callback implementation to the netdevsim.
Add new test cases for netdevsim, to test both the callback
functionality, as well as drop statistics alteration check.
Signed-off-by: Oleksandr Mazur
---
V2:
1) Change commit description / subject.
2) Remove HARD_DROP action.
Thu, Jan 21, 2021 at 06:36:05PM CET, k...@kernel.org wrote:
>On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote:
>> On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote:
>> > Add new trap action HARD_DROP, which can be used by the
>> > drivers to register t
drop_counter_get callback implementation to the netdevsim.
Add new test cases for netdevsim, to test both the callback
functionality, as well as drop statistics alteration check.
Signed-off-by: Oleksandr Mazur
---
V3:
1) Mark subject as RFC instead of PATCH.
V2:
1) Change commit description
Add implementation for the port parameters getting/setting.
Add bash completion for port param.
Add man description for port param.
Signed-off-by: Oleksandr Mazur
---
V2:
1) Add bash completion for port param;
2) Add man decsription / examples for port param;
bash-completion/devlink
On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote:
> On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote:
> > Add new trap action HARD_DROP, which can be used by the
> > drivers to register traps, where it's impossible to get
> > packet reported to th
From: Ido Schimmel
Sent: Thursday, January 21, 2021 2:21 PM
To: Oleksandr Mazur
Cc: net...@vger.kernel.org ; j...@nvidia.com
; da...@davemloft.net ;
linux-kernel@vger.kernel.org ; k...@kernel.org
Subject: Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP
On Thu, Jan
Add implementation for the port (named) parameters
getting/setting.
Kernel-side already has implemented devlink port params
get / set commands handling.
Signed-off-by: Oleksandr Mazur
---
devlink/devlink.c | 275 +-
1 file changed, 269 insertions
must also register
additional devlink operation - callback that is used
to retrieve number of packets that have been dropped by
the device.
Signed-off-by: Oleksandr Mazur
---
include/net/devlink.h| 10
include/uapi/linux/devlink.h | 4
net/core/devlink.c
ystem to get track of traffic statistics.
Signed-off-by: Oleksandr Mazur
---
devlink/devlink.c| 4
include/uapi/linux/devlink.h | 4
2 files changed, 8 insertions(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index a2e06644..77185f7c 100644
--- a/devlink/devlink.c
17 matches
Mail list logo
