> On Feb 11, 2018, at 6:44 PM, NeilBrown wrote:
>
> On Thu, Feb 08 2018, Oleg Drokin wrote:
>>
>> Certain things that sound useless (like the debug subsystem in Lustre)
>> is very useful when you have a 10k nodes in a cluster and need to selectively
>>
> On Feb 11, 2018, at 6:50 PM, NeilBrown wrote:
>
> Maybe - as you suggest in another email - it is due to some
> client/server incompatibility. I guess it is unavoidable with an fs
> like lustre to have incompatible protocol changes. Is there any
> mechanism for detecting the version of other
> On Feb 8, 2018, at 10:10 PM, NeilBrown wrote:
>
> On Thu, Feb 08 2018, Oleg Drokin wrote:
>
>>> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote:
>>>
>>> On Tue, Aug 16 2016, James Simmons wrote:
>>
>> my that’s an old patch
>>
>>
> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote:
>
> On Tue, Aug 16 2016, James Simmons wrote:
my that’s an old patch
>
>>
>> +static inline bool
>> +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md
>> *lsm2)
>> +{
>> +int idx;
>> +
>> +if (lsm1->lsm_md_magic !=
On Jul 19, 2017, at 12:33 AM, NeilBrown wrote:
> On Tue, Jul 18 2017, Oleg Drokin wrote:
>
>> Unfortunately this patch causes insta-crash on first stat call after mount.
>> Sorry, I cannot dig into this deeper right this moment, but I will a bit
>> later.
>
>
Unfortunately this patch causes insta-crash on first stat call after mount.
Sorry, I cannot dig into this deeper right this moment, but I will a bit later.
I am adding Al that we discussed this code at some length and he found no
problems
here, so I am a bit surprised by your findings.
Also the re
On Jul 14, 2017, at 5:33 PM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in CERROR error message. Also
> clean up the grammar.
>
> Signed-off-by: Colin Ian King
Reviewed-by: Oleg Drokin
> ---
> drivers/staging/lustre/lustre/ptlrpc/
On Jul 14, 2017, at 9:26 AM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in CERROR error message
>
> Signed-off-by: Colin Ian King
> ---
> drivers/staging/lustre/lustre/ptlrpc/import.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dr
eturn -EFAULT;
>
> - if (tmp.next == head_up)
> - return 0;
> -
> next = tmp.next;
So the assignment is fine, but comparison is not? Strange.
I guess this is fine by me if that makes the warning go away.
Acked-by: Oleg Drokin
Hello!
On May 31, 2017, at 4:00 AM, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> cfs_wi_exit (acquire the lock by spin_lock)
> LASSERT
>lbug_with_loc
> libcfs_debug_dumplog
>schedule and kthread_run --> may sleep
>
> To fix it, al
Hello!
On May 31, 2017, at 3:57 AM, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> cfs_wi_deschedule (acquire the lock by spin_lock)
> LASSERT
>lbug_with_loc
> libcfs_debug_dumplog
>schedule and kthread_run --> may sleep
>
> To fix
On May 29, 2017, at 10:28 AM, Greg Kroah-Hartman wrote:
> On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote:
>> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
>> lov_user_md pointer from user- or kernel-space. This changes the
>> behavior o
/browse/LU-3221
Reviewed-by: Andreas Dilger
Reviewed-by: Li Wei
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c
b/drivers/staging/lustre/lustre/lov/lov_pack.c
index
On Mar 19, 2017, at 12:41 AM, Greg Kroah-Hartman wrote:
> On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote:
>> Ever since sysfs migration, class_process_proc_param stopped working
>> correctly as all the useful params were no longer present as lvars.
>> Replace al
On Mar 19, 2017, at 12:29 AM, Greg Kroah-Hartman wrote:
> On Sat, Mar 18, 2017 at 11:17:55AM -0400, Oleg Drokin wrote:
>>
>> On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote:
>>
>>> On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote:
&
On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote:
> On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote:
>> Ever since sysfs migration, class_process_proc_param stopped working
>> correctly as all the useful params were no longer present as lvars.
>> Replace al
Ever since sysfs migration, class_process_proc_param stopped working
correctly as all the useful params were no longer present as lvars.
Replace all the nasty fake proc writes with hopefully less nasty
kobject attribute search and then update the attributes as needed.
Signed-off-by: Oleg Drokin
On Mar 7, 2017, at 12:03 AM, Davidlohr Bueso wrote:
> This replaces the in-house version, which is also derived
> from Jan's interval tree implementation.
>
> Cc: oleg.dro...@intel.com
> Cc: andreas.dil...@intel.com
> Cc: jsimm...@infradead.org
> Cc: lustre-de...@lists.lustre.org
>
> Signed-off
On Mar 1, 2017, at 6:57 PM, Mario Bambagini wrote:
> fixed the following sparse warning by adding proper cast:
> drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning:
> incorrect type in argument 2 (different address spaces)
> drivers/staging//lustre/lustre/obdclass/obd_config.c
gt; time.
>>
>> Signed-off-by: Alex Zhuravlev
>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6838
>> Reviewed-on: https://review.whamcloud.com/18028
>> Reviewed-by: Andreas Dilger
>> Reviewed-by: wangdi
>> Reviewed-by: Mike Pershin
>> Review
gt; time.
>>
>> Signed-off-by: Alex Zhuravlev
>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6838
>> Reviewed-on: https://review.whamcloud.com/18028
>> Reviewed-by: Andreas Dilger
>> Reviewed-by: wangdi
>> Reviewed-by: Mike Pershin
>> Review
On Jan 13, 2017, at 3:48 PM, Guillermo O. Freschi wrote:
> Missing braces on `if` statement.
>
> Signed-off-by: Guillermo O. Freschi
>
> Reviewed-by: Andreas Dilger
Reviewed-by: Oleg Drokin
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 9 +
> 1 fi
On Jan 1, 2017, at 11:38 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 1 Jan 2017 16:26:36 +0100
>
> Some data were printed into a sequence by two separate function calls.
> Print the same data by a single function call instead.
>
> This issue was detected by using the Cocci
On Jan 1, 2017, at 11:35 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 1 Jan 2017 15:40:29 +0100
>
> Some data were printed into a sequence by two separate function calls.
> Print the same data by a single function call instead.
>
> This issue was detected by using the Cocci
On Dec 13, 2016, at 3:31 AM, Dan Carpenter wrote:
> It used to be that great swathes of Lustre were used in both user space
> and kernel space. We had huge unused modules in the kernel that were
> only used for user space.
Huh?
There was nothing of the sort.
There were huge parts of code that w
On Dec 7, 2016, at 6:46 PM, Al Viro wrote:
> On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote:
>> This set of fixes aims at sparse warnings.
>
> Speaking of the stuff sparse catches there: class_process_proc_param().
> I've tried to describe what I thin
It's not used anywhere out of this file.
Highlighted by sparse.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c
b/drivers/staging/lustre/lustre/llite/f
It's not used anywhere outside of this file.
Highlighted by sparse.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c
b/drivers/staging/lustre/lustr
ncies of root squash feature"
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/lproc_llite.c | 27 +--
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c
b/drivers/staging/lustre/lu
As per interval_search() prototype, the callback should return
enum, not int.
This fixes correspondign sparse warning.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre
This avoids frowned upon extern in the C file, and also
shuts down a sparse warning of
drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol 'osc_caches'
was not declared. Should it be static?
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_inte
Move it to obd.h, so that it's included from both the users and
the actual definition, making sure they never get out of sync.
This also silences a sparse warning.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h| 3 +++
drivers/staging/lustre/lustre/
Make the declaration in a header, not as an extern in a C file,
that is frowned upon.
This also makes sparse a little bit more happy.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h | 3 +++
drivers/staging/lustre/lustre/obdclass/cl_object.c | 3 +--
2 files
This set of fixes aims at sparse warnings.
Most of the patches are just moving declarations around
to deal with the
warning: symbol 'xxx' was not declared. Should it be static?
kind of messages.
Also a screwup with root_squash sysfs control is fixed.
Oleg Drokin (8):
staging/lustre/l
This avoids having an extern definition in a C file which is bad,
and also silences sparse complaint as well.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 ---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 3 +++
2 files changed, 3
On Dec 7, 2016, at 3:37 PM, Greg Kroah-Hartman wrote:
> On Wed, Dec 07, 2016 at 11:29:36AM -0500, Oleg Drokin wrote:
>>
>> On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote:
>>
>>> On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote:
>>>>
On Dec 7, 2016, at 10:20 AM, Quentin Lambert wrote:
> Hi all,
>
> I am looking at the drivers/staging/lustre/lustre/llite/dir.c:
>
> 1469 /* Call mdc_iocontrol */
> 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid),
> &fid,
> 1471
On Dec 7, 2016, at 10:33 AM, Dan Carpenter wrote:
> Lustre is kind of a mess with regards to keeping user and kernel
> pointers separate. It's not going to be easy to fix.
Actually I believe I made significant inroads in properly cleaning (almost?)
everything
in this area about a year ago (to
On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote:
> On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote:
>> I have been having a lot of unexplainable crashes in osc_lru_shrink
>> lately that I could not see a good explanation for and then I found
>> this patc
er is
not present.
Reported-by: Dan Carpenter
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/selftest/conctl.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c
b/drivers/staging/lustre/lnet/selftest/conctl.c
index 02847bf..9438302 1
Highlighted by checkpatch:
WARNING: 'attemps' may be misspelled - perhaps 'attempts'?
#20278: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3272:
+ * reconnection attemps.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |
Highlighted by relatively new checkpatch test, warnings like:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/lnet/lnetst.h | 6 +-
.../staging/lustre/lustre/include/lprocfs_status.h | 3 +-
dr
checkpatch highlighted there are 8 spaces that could be converted to a tab:
ERROR: code indent should use tabs where possible
+^I^I^I^I^I */$
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
These patches fix some more of the low hanging fruits
in the style problems highlighted by checkpatch.
Now only false positive ERRORs are left.
This also converts all bare unsigneds into unsigned ints
and a couple of spelling fixes.
Please consider.
Oleg Drokin (5):
staging/lustre/o2iblnd: Add
Highlighted by checkpatch:
+ if (!ps->ps_net) /* intialized? */
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
b/drivers/stag
checkpatch highlighted missing space before assignment
for lock variable.
+ spinlock_t *lock= &kiblnd_data.kib_connd_lock;
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
aging: lustre: osc: Use list_for_each_entry_safe")
CC: Bhaktipriya Shridhar
Signed-off-by: Oleg Drokin
---
I also do not see this patch in any of the mailing lists I am subscribed to.
I wonder if there's a way to subscribe to those Greg's
"This is a note to let you know that
On Dec 5, 2016, at 3:55 PM, Dan Carpenter wrote:
> On Fri, Dec 02, 2016 at 07:53:11PM -0500, James Simmons wrote:
>> @@ -3183,8 +3182,10 @@ static int discard_cb(const struct lu_env *env,
>> struct cl_io *io,
>> /* page is top page. */
>> info->oti_next_index = osc_index(ops) + 1;
>>
On Dec 2, 2016, at 12:33 PM, Quentin Lambert wrote:
> lnet_ipif_enumerate was assigning a pointer from kernel space to user
> space. This patch uses copy_to_user to properly do that assignment.
I guess it's a false positive?
While lnet_sock_ioctl()->kernel_sock_unlocked_ioctl() does call into t
nids'
> redeclared with different type...
>
> Signed-off-by: Sandeep Jain
Acked-by: Oleg Drokin
> ---
> drivers/staging/lustre/lustre/include/lprocfs_status.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lust
On Dec 4, 2016, at 9:21 PM,
wrote:
> From: Sandeep Jain
>
> Fix following sparse warning.
> mgc_request.c:376:1:
> warning: symbol 'llog_process_lock' was not declared. Should it be static?
>
> Signed-off-by: Sandeep Jain
Acked-by: Oleg Drokin
> ---
&
On Dec 3, 2016, at 7:52 AM, Pan Bian wrote:
> From: Pan Bian
>
> At the end of function lstcon_group_info(), "return 0" seems improper.
> It may be better to return the value of rc.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
>
> Signed
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 8a2f02f3
://jira.hpdd.intel.com/browse/LU-8645
Reviewed-by: Alex Zhuravlev
Reviewed-by: Fan Yong
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/recover.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/recover.c
b/drivers
make sure the known replied
XID is increased only on both server & client side.
Signed-off-by: Niu Yawei
Reviewed-on: http://review.whamcloud.com/16759
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5951
Reviewed-by: Gregoire Pichon
Reviewed-by: Alex Zhuravlev
Signed-off-by: Ole
With multiple metadata RPCs code in now, these two fixes
become important.
Please consider.
Niu Yawei (2):
staging/lustre/ptlrpc: track unreplied requests
staging/lustre/ptlrpc: update imp_known_replied_xid on resend-replay
.../staging/lustre/lustre/include/lustre_import.h | 5 +
drivers
On Nov 7, 2016, at 4:33 PM, Dilger, Andreas wrote:
> On Nov 6, 2016, at 10:26, Drokin, Oleg wrote:
>>
>> Hello!
>>
>> On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote:
>>
>>> 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM).
>>> Handle these errors and propagate the error code to the calle
Hello!
On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote:
> 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM).
> Handle these errors and propagate the error code to the callers.
>
> Error handling has been rearranged in 'lustre_process_log()' with the
> addition of a label in order to free some
The function becomes used again with the next patch, so bring it back
from dead, only this time make it static.
Reverts: bf2a033360f7 ("staging/lustre/ldlm: Remove unused ldlm_enqueue_pack()")
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_requ
-off-by: Jinshan Xiong
Reviewed-on: http://review.whamcloud.com/20254
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4257
Reviewed-by: Andreas Dilger
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 22 --
drivers/staging/lustre
://jira.hpdd.intel.com/browse/LU-8446
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c
b/drivers/staging/lustre/lustre/llite/namei.c
index 74d9b73..c268f32
re/ldlm: engage ELC for all ldlm enqueue req
Jinshan Xiong (2):
staging/lustre: Get rid of cl_env hash table
staging/lustre/llite: do not clear uptodate bit in page delete
Niu Yawei (1):
staging/lustre/llite: clear inode timestamps after losing UPDATE lock
Oleg Drokin (3):
staging/lust
blocking_refs is only used on the server, so drop it on the client.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm.h
b/drivers/staging/lustre/lustre/include
-id: https://jira.hpdd.intel.com/browse/LU-8175
Reviewed-by: Jinshan Xiong
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_support.h | 3 +++
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c| 20
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 4 ++-
http://review.whamcloud.com/22031
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8500
Reviewed-by: James Simmons
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 3 +++
drivers/staging/lustre/lustre/ptlrpc/import.c | 19 ++-
2 files ch
From: Bobi Jam
Need to check file's lli_clob object before calling
lov_read_and_clear_async_rc().
Signed-off-by: Bobi Jam
Reviewed-by: Jinshan Xiong
Reviewed-by: Oleg Drokin
Reviewed-on: http://review.whamcloud.com/23031
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8682
Signed-o
ine doesn't make the same assumption.
Signed-off-by: Jinshan Xiong
Reviewed-on: http://review.whamcloud.com/22827
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8633
Reviewed-by: Li Dongyang
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/vvp_page
8492
Reviewed-by: Liang Zhen
Reviewed-by: Doug Oucharek
Reviewed-by: James Simmons
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/service.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c
b/drivers/stagi
viewed-on: http://review.whamcloud.com/22856
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8658
Reviewed-by: Andreas Dilger
Reviewed-by: Bob Glossman
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/
This define only made sense in a userspace library client, not in the kernel.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_lib.h | 2 --
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 15 +--
2 files changed, 1 insertion(+), 16 deletions
window length later, the presumption does not hold.
This patch resets the stride IO as well in this case.
Signed-off-by: Bobi Jam
Reviewed-on: http://review.whamcloud.com/23032
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8683
Reviewed-by: wangdi
Reviewed-by: Jinshan Xiong
Signed-off-by: Oleg
: http://review.whamcloud.com/22745
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8509
Reviewed-by: Jinshan Xiong
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/rw26.c | 36 --
1 file changed, 19 insertions(+), 17
: Hongchao Zhang
Reviewed-on: http://review.whamcloud.com/21739
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8209
Reviewed-by: Andreas Dilger
Reviewed-by: Vitaly Fertman
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 21 -
1 file changed
It's multiple values per file, so it has no business being in sysfs,
besides it was assuming seqfile anyway.
Introduced by
commit d806f30e639b ("staging: lustre: osc: revise unstable pages accounting")
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/lpr
t;> Reviewed-on: http://review.whamcloud.com/10003
>> Reviewed-by: Andreas Dilger
>> Reviewed-by: Lai Siyao
>> Reviewed-by: Oleg Drokin
>> Signed-off-by: James Simmons
>> ---
>> drivers/staging/lustre/lustre/include/cl_object.h | 35 +++-
>> .../st
On Aug 31, 2016, at 5:31 PM, David Miller wrote:
> From: Oleg Drokin
> Date: Fri, 26 Aug 2016 23:14:06 -0400
>
>> %ul would print an unsigned with a letter l at the end which does
>> not seem to be desired here, on the other hand the value being printed
>> is u32 so
On Aug 27, 2016, at 12:18 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 8/27/2016 6:58 PM, Oleg Drokin wrote:
>
>>>> %ul would print an unsigned value and a letter l,
>>>> likely it was %lu that was meant to print the long int,
>>>> but in reality
On Aug 27, 2016, at 11:13 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 8/27/2016 6:10 AM, Oleg Drokin wrote:
>
>> %ul would print an unsigned value and a letter l,
>> likely it was %lu that was meant to print the long int,
>> but in reality the values printed
On Aug 26, 2016, at 11:18 PM, Joe Perches wrote:
> On Fri, 2016-08-26 at 23:05 -0400, Oleg Drokin wrote:
>> %ul was probably meant as %lu since the former would print
>> an unsigned value and a letter l.
>>
>> But in fact the whole value we are printing in u32 anyw
%ul would print an unsigned with a letter l at the end which does
not seem to be desired here, on the other hand the value being printed
is u32 so just drop the l instead of converting to %lu
Signed-off-by: Oleg Drokin
---
drivers/net/irda/vlsi_ir.c | 2 +-
1 file changed, 1 insertion(+), 1
%ul was likely meant as %lu to print an unsigned long,
not an unsigned with a letter l at the end.
But in fact the value printed is u32 anyway, so just drop
the l completely.
Signed-off-by: Oleg Drokin
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 6 +++---
1 file changed, 3
%ul would print an unsigned value and a letter l,
likely it was %lu that was meant to print the long int,
but in reality the values printed there are just regular signed
ints, so just dropping the l altogether.
Signed-off-by: Oleg Drokin
---
net/bridge/br_stp_bpdu.c | 2 +-
1 file changed, 1
%ul was probably meant as %lu since the former would print
an unsigned value and a letter l.
But in fact the whole value we are printing in u32 anyway, so
we don't need the format to be long. Therefore just drop the l
altogether.
Signed-off-by: Oleg Drokin
---
Also do we really need 1
Hello!
On Aug 22, 2016, at 6:04 AM, Greg Kroah-Hartman wrote:
> On Mon, Aug 22, 2016 at 04:46:04PM +0800, Shawn Lin wrote:
>> We only need to zero it when repeating in order to
>> avoid old garbage. Let's improve it by moving this
>> before we repeat the calculation to save some cpu
>> cycle.
>>
%ul definitely was supposed to be %lu in the format string,
so we print long unsigned int value, not just unsigned int
with a letter l added at the end.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 5 +++--
1 file changed, 3 insertions(+), 2
L. Hammond
Reviewed-by: Bob Glossman
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_mmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c
b/drivers/staging/lustre/lustre/llite/llite_mmap.c
index 9d03e79..37f82ed 1
ago
Reviewed-by: James Simmons
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 3 ++-
drivers/staging/lustre/lustre/include/obd_class.h| 3 ++-
drivers/staging/lustre/lustre/llite/file.c | 2 +-
drivers/staging/lustre/lustre/llite/llite_i
wed-on: http://review.whamcloud.com/17495
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5282
Reviewed-by: Alex Zhuravlev
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/obd_support.h| 1 +
drivers/staging/lustre/lustre/mdc/mdc_request.c| 56 +
: Ashish Purkar
Reviewed-by: Andrew Perepechko
Tested-by: Parinay Vijayprakash Kondekar
Reviewed-on: http://review.whamcloud.com/17732
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7613
Reviewed-by: Niu Yawei
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 3
Weber
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 14 +++---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 13 ++---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 55 ++
3 files changed, 41 insertions(+), 41 deletions
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 72ff7c4..1ff788e 100644
--- a/drivers/staging/lustre
wrong
i_nlink value into st_nlink
Signed-off-by: Andrew Perepechko
Seagate-bug-id: MRP-3271
Reviewed-on: http://review.whamcloud.com/19164
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7925
Reviewed-by: Wally Wang
Reviewed-by: Lai Siyao
Signed-off-by: Oleg Drokin
---
drivers/staging
.intel.com/browse/LU-8297
Reviewed-by: Andreas Dilger
Reviewed-by: Mike Pershin
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c
b/drivers/stag
Here are some more recent Lustre fixes and a cleanup.
This resend fixes the "fix panic at mdc_free_open()" patch to actually work.
Please consider.
Alexander Boyko (1):
staging/lustre/mdc: fix panic at mdc_free_open()
Andrew Perepechko (1):
staging/lustre: avoid clearing i_nlink for inodes
Actually, please do not apply this one, there was a testing error
that made me not noticing there's a bug in this one that insta-crashes
everything on access.
I tested the rest nd the rest are good without this one too.
Sorry about this.
On Aug 23, 2016, at 5:11 PM, Oleg Drokin wrote:
&
wrong
i_nlink value into st_nlink
Signed-off-by: Andrew Perepechko
Seagate-bug-id: MRP-3271
Reviewed-on: http://review.whamcloud.com/19164
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7925
Reviewed-by: Wally Wang
Reviewed-by: Lai Siyao
Signed-off-by: Oleg Drokin
---
drivers/staging
L. Hammond
Reviewed-by: Bob Glossman
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_mmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c
b/drivers/staging/lustre/lustre/llite/llite_mmap.c
index 9d03e79..37f82ed 1
.intel.com/browse/LU-8297
Reviewed-by: Andreas Dilger
Reviewed-by: Mike Pershin
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c
b/drivers/stag
: Ashish Purkar
Reviewed-by: Andrew Perepechko
Tested-by: Parinay Vijayprakash Kondekar
Reviewed-on: http://review.whamcloud.com/17732
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7613
Reviewed-by: Niu Yawei
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 3
wed-on: http://review.whamcloud.com/17495
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5282
Reviewed-by: Alex Zhuravlev
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/obd_support.h| 1 +
drivers/staging/lustre/lustre/mdc/mdc_request.c| 50 +
1 - 100 of 544 matches
Mail list logo
