Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-04-01 Thread Norman Maurer
> On 1. Apr 2021, at 02:18, David Ahern wrote: > > On 3/31/21 7:10 AM, Norman Maurer wrote: >> Friendly ping… >> >> As this missing change was most likely an oversight in the original commit I >> do think it should go into 5.12 and subsequently stable as

[PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

2021-04-01 Thread Norman Maurer
From: Norman Maurer Support for UDP_GRO was added in the past but the implementation for getsockopt was missed which did lead to an error when we tried to retrieve the setting for UDP_GRO. This patch adds the missing switch case for UDP_GRO Fixes: e20cf8d3f1f7 ("udp: implement GRO for plai

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-31 Thread Norman Maurer
a new feature. Thanks Norman > On 26. Mar 2021, at 13:22, Paolo Abeni wrote: > > On Fri, 2021-03-26 at 11:22 +0100, Norman Maurer wrote: >> On 26. Mar 2021, at 10:36, Paolo Abeni wrote: >>> One thing you can do to simplifies the maintainer's life, would be post

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed whic

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed whic

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed whic

udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

2021-03-25 Thread Norman Maurer
Signed-off-by: Norman Maurer --- net/ipv4/udp.c | 4 1 file changed, 4 insertions(+) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 4a0478b17243..99d743eb9dc4 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -2754,6 +2754,10 @@ int udp_lib_getsockopt(struct sock *sk, int level, in

[PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

2021-03-25 Thread Norman Maurer
From: Norman Maurer Support for UDP_GRO was added in the past but the implementation for getsockopt was missed which did lead to an error when we tried to retrieve the setting for UDP_GRO. This patch adds the missing switch case for UDP_GRO Fixes: e20cf8d3f1f7 ("udp: implement GRO for plai