Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Noriaki TAKAMIYA
k <[EMAIL PROTECTED]> > > Agreed. > > Acked-by: Masahide NAKAMURA <[EMAIL PROTECTED]> I also agreed. Acked-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]> -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: net-26.24 broken with XFRM off

2007-09-06 Thread Noriaki TAKAMIYA
atch to use "ifdef CONFIG_XFRM" > than changing kernel config depends. Does it make sense? > > Please review the attached patch. > > -- > Masahide NAKAMURA -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.

2007-03-27 Thread Noriaki TAKAMIYA
_get_serial_port_data() should check > > the argument for the other drivers. > > I don't think it is really necessary, do you? I see. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROT

Re: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.

2007-03-25 Thread Noriaki TAKAMIYA
lready fixed. > > Great, thanks for testing. So I guess both of these patches are no > longer necessary, right? I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send th

Re: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
-git snapshots that have come out > after 2.6.21-rc4. Can you test them to verify this? Yes, this problem was already fixed. Thanks. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

[PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.

2007-03-24 Thread Noriaki TAKAMIYA
if (!serial->port[i]) + continue; priv = usb_get_serial_port_data(serial->port[i]); if (priv) { pl2303_buf_free(priv->buf); -- 1.4.4 -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line

Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.

2007-03-24 Thread Noriaki TAKAMIYA
Sorry for resending. While booting, this entry is set to NULL in destroy_serial(), but serial->port is referred again in pl2303_shutdown() via serial->type->shutdown. Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]> --- drivers/usb/serial/pl2303.c |2 ++ 1 f

[PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
if (port) + return dev_get_drvdata(&port->dev); + else + return NULL; } static inline void usb_set_serial_port_data (struct usb_serial_port *port, void *data) -- 1.4.4 -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.

2007-03-24 Thread Noriaki TAKAMIYA
serial->num_ports; ++i) { + if (!serial->port[i]) + continue; priv = usb_get_serial_port_data(serial->port[i]); if (priv) { pl2303_buf_free(priv->buf); -- 1.4.4 -- Noriaki TAKAMIYA - To unsubscribe from thi

[PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
Hi, When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB serial device plugged in, the kernel crashes. The reason is struct usb_serial_port is referenced without checking whether it is NULL or not. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the

Re: (usagi-core 32634) [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
Sorry for resending. Hi, This patch fixes to skip serial->port[i] if it is set NULL. Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]> --- include/linux/usb/serial.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/linux/usb/serial.h b/include/