RE: [EXT] [PATCH 23/30] scsi: qla2xxx: qla_gs: Fix some incorrect formatting/spelling issues

2021-03-03 Thread Nilesh Javali
> -Original Message- > From: Lee Jones > Sent: Wednesday, March 3, 2021 8:16 PM > To: lee.jo...@linaro.org > Cc: linux-kernel@vger.kernel.org; Nilesh Javali ; GR- > QLogic-Storage-Upstream ; > James E.J. Bottomley ; Martin K. Petersen > ; linux-s...@vger.ke

RE: [EXT] [PATCH 19/30] scsi: qla4xxx: ql4_mbx: Fix kernel-doc formatting and misnaming issue

2021-03-03 Thread Nilesh Javali
> -Original Message- > From: Lee Jones > Sent: Wednesday, March 3, 2021 8:16 PM > To: lee.jo...@linaro.org > Cc: linux-kernel@vger.kernel.org; Nilesh Javali ; > Manish Rangankar ; GR-QLogic-Storage- > Upstream ; James E.J. > Bottomley ; Martin K. Petersen > ;

RE: [EXT] [PATCH 15/30] scsi: qla2xxx: qla_iocb: Replace __qla2x00_marker()'s missing underscores

2021-03-03 Thread Nilesh Javali
> -Original Message- > From: Lee Jones > Sent: Wednesday, March 3, 2021 8:16 PM > To: lee.jo...@linaro.org > Cc: linux-kernel@vger.kernel.org; Nilesh Javali ; GR- > QLogic-Storage-Upstream ; > James E.J. Bottomley ; Martin K. Petersen > ; linux-s...@vger.ke

RE: [EXT] [PATCH 12/30] scsi: qla4xxx: ql4_os: Fix formatting issues - missing '-' and '_'

2021-03-03 Thread Nilesh Javali
> -Original Message- > From: Lee Jones > Sent: Wednesday, March 3, 2021 8:16 PM > To: lee.jo...@linaro.org > Cc: linux-kernel@vger.kernel.org; Nilesh Javali ; > Manish Rangankar ; GR-QLogic-Storage- > Upstream ; James E.J. > Bottomley ; Martin K. Petersen > ;

RE: [EXT] [PATCH 0/5 REBASED to v5.9-rc4] Qlogic drivers: Convert to SPDX license identifiers

2020-09-09 Thread Nilesh Javali
org > Cc: linux-kernel@vger.kernel.org; Nilesh Javali > Subject: Re: [EXT] [PATCH 0/5 REBASED to v5.9-rc4] Qlogic drivers: Convert to > SPDX license identifiers > > > > > Igor, can you please ack these patches? > > > > Igor, please also let us know: > >

Re: [PATCH 2/5] scsi/qla2xxx: Convert to SPDX license identifiers

2020-09-09 Thread Nilesh Javali
Acked-by: Nilesh Javali

Re: [PATCH 1/5] scsi/qla4xxx: Convert to SPDX license identifiers

2020-09-09 Thread Nilesh Javali
Acked-by: Nilesh Javali

RE: [EXT] [PATCH] scsi: qla2xxx: Fix the return value

2020-08-31 Thread Nilesh Javali
Xianting Tian, Thanks for the patch. > -Original Message- > From: Xianting Tian > Sent: Saturday, August 29, 2020 1:28 PM > To: Nilesh Javali ; GR-QLogic-Storage-Upstream qlogic-storage-upstr...@marvell.com>; j...@linux.ibm.com; > martin.peter...@oracle

Re: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch fall-through

2018-12-24 Thread Nilesh Javali
ls_session *cls_sess, >chap_tbl.secret_len); >} >} >- /* allow fall-through */ >+ /* fall through */ >default: > return iscsi_session_get_param(cls_sess, param, buf); >} >-- >2.17.1 Thanks. Acked-by: Nilesh Javali

Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible

2016-09-01 Thread Nilesh Javali
return rval; > } > >-uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1, >+static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, >uint32_t addr1, > uint32_t addr3, uint32_t mask, uint32_t addr, > uint32_t *data_ptr) > { >-- >2.7.4 Acked-by: Nilesh Javali

Re: [patch] bnx2i: silence uninitialized variable warnings

2016-04-17 Thread Nilesh Javali
3,7 @@ bnx2i_find_ep_in_destroy_list(struct bnx2i_hba *hba, >u32 iscsi_cid) > { > struct list_head *list; > struct list_head *tmp; >- struct bnx2i_endpoint *ep; >+ struct bnx2i_endpoint *ep = NULL; > > read_lock_bh(&hba->ep_rdwr_lock); > list_for_each_safe(list, tmp, &hba->ep_destroy_list) { Acked-by: Nilesh Javali

Re: [PATCH 5/7] scsi: qla4xxx: shut up warning for rd_reg_indirect

2016-02-01 Thread Nilesh Javali
>@@ -46,11 +46,13 @@ int qla4_83xx_rd_reg_indirect(struct scsi_qla_host >*ha, uint32_t addr, > > ret_val = qla4_83xx_set_win_base(ha, addr); > >- if (ret_val == QLA_SUCCESS) >+ if (ret_val == QLA_SUCCESS) { > *data = qla4_83xx_rd_reg(ha, QLA83XX

RE: [PATCH] qla4xxx: pass timeout as HZ independent value

2015-06-07 Thread Nilesh Javali
y(struct > scsi_qla_host *ha, int pegtune_val) > (val == PHAN_INITIALIZE_ACK)) > return 0; > set_current_state(TASK_UNINTERRUPTIBLE); > - schedule_timeout(500); > + schedule_ti

RE: [PATCH 09/12] [SCSI] qla4xxx: Use DECLARE_BITMAP

2015-05-20 Thread Nilesh Javali
[MAX_DDB_ENTRIES / BITS_PER_LONG]; > + DECLARE_BITMAP(ddb_idx_map, MAX_DDB_ENTRIES); > #define SYSFS_FLAG_FW_SEL_BOOT 2 > struct iscsi_boot_kset *boot_kset; > struct ql4_boot_tgt_info boot_tgt; > -- > 2.1.2 Reviewed-by: Nilesh Javali -- To unsubscribe from

RE: [PATCH] scsi:qla4xxx: Fix typo in qla4xxx

2015-05-08 Thread Nilesh Javali
Acked-by: Nilesh Javali > -Original Message- > From: Masanari Iida [mailto:standby2...@gmail.com] > Sent: Thursday, May 07, 2015 7:58 PM > To: linux-kernel; Dept-Eng QLogic Storage Upstream; jbottom...@odin.com; > linux-scsi > Cc: triv...@kernel.org; Masanari Iida

RE: [PATCH] scsi: unnecessary double init_completion removed

2014-12-31 Thread Nilesh Javali
Acked-by: Nilesh Javali I will send the maintainer list update patch. Thanks, Nilesh -Original Message- From: Nicholas Mc Guire [mailto:der.h...@hofr.at] Sent: Tuesday, December 23, 2014 11:30 PM To: James E.J. Bottomley Cc: Dept-Eng iSCSI Driver; linux-scsi; linux-kernel; Nicholas Mc

RE: [PATCH] scsi: qla4xxx: ql4_mbx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-29 Thread Nilesh Javali
Acked-By: Nilesh Javali -Original Message- From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] Sent: Sunday, July 27, 2014 8:28 PM To: Vikas Chaudhary; Dept-Eng iSCSI Driver Cc: Rickard Strandqvist; James E.J. Bottomley; linux-scsi; linux-kernel Subject: [PATCH

RE: [PATCH] scsi: qla4xxx: ql4_os.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-29 Thread Nilesh Javali
Acked-By: Nilesh Javali -Original Message- From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] Sent: Saturday, July 26, 2014 8:20 PM To: Vikas Chaudhary; Dept-Eng iSCSI Driver Cc: Rickard Strandqvist; James E.J. Bottomley; linux-scsi; linux-kernel Subject: [PATCH