Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-03-22 Thread Nicolas Ferre
rivers/i2c/busses/i2c-at91-master.c | 2 +- drivers/i2c/busses/i2c-at91-slave.c| 8 [..] Acked-by: Nicolas Ferre # for at91 Probably file names themselves will need some care, in a second time. Thanks. Regards, Nicolas [..] -- 2.43.0

Re: [GIT PULL] ARM: at91: dt for 5.13

2021-04-12 Thread Nicolas Ferre
Arnd, On 08/04/2021 at 22:15, Arnd Bergmann wrote: On Thu, Apr 8, 2021 at 6:35 PM Nicolas Ferre wrote: On 08/04/2021 at 17:24, Arnd Bergmann wrote: Oh, got it: it's the upper case letter withing the etm hex address. I used this one to mach what was done in the reg property. I'm fixi

Re: [GIT PULL] ARM: at91: dt for 5.13

2021-04-08 Thread Nicolas Ferre
hema at the proper level of support for running "make dtbs_check W=1" and will do it before sending pull-requests in the future. Thanks for the heads-up. Best regards, Nicolas merge commit: e2b064fec8e49112f7dac779fcec12ded40728c2 Arnd -- Nicolas Ferre

Re: [PATCH 22/24] ARM: at91: sama7: introduce sama7 SoC family

2021-04-08 Thread Nicolas Ferre
sufficient. We can add such distinction in the future if the need arises. Regards, Nicolas -- Nicolas Ferre

Re: [PATCH 22/24] ARM: at91: sama7: introduce sama7 SoC family

2021-04-08 Thread Nicolas Ferre
and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -- Nicolas Ferre

Re: [PATCH 1/1] net: macb: restore cmp registers on resume path

2021-04-02 Thread Nicolas Ferre
On 02/04/2021 at 14:42, Claudiu Beznea wrote: Restore CMP screener registers on resume path. Fixes: c1e85c6ce57ef ("net: macb: save/restore the remaining registers and features") Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre Thanks for this fix Claudiu. Best regards,

Re: [PATCH] power: reset: at91-reset: free resources on exit path

2021-04-02 Thread Nicolas Ferre
ches, const struct of_device_id **match) { // ... of_node_put(from); // ... } Oh yes you're right Claudiu, I overlooked this one. Thanks for the in-depth explanation. Best regards, Nicolas -- Nicolas Ferre

Re: [RESEND PATCH 1/5] clk: at91: re-factor clocks suspend/resume

2021-03-31 Thread Nicolas Ferre
On 31/03/2021 at 10:47, Claudiu Beznea - M18063 wrote: On 30.03.2021 20:14, Nicolas Ferre wrote: On 24/03/2021 at 10:43, Claudiu Beznea wrote: SAMA5D2 and SAMA7G5 have a special power saving mode (backup mode) where most of the SoC's components are powered off (including PMC). Resuming

Re: [PATCH] power: reset: at91-reset: free resources on exit path

2021-03-31 Thread Nicolas Ferre
_get_drvdata(pdev); + int idx; unregister_restart_handler(&reset->nb); clk_disable_unprepare(reset->sclk); + iounmap(reset->rstc_base); + for (idx = 0; idx < ARRAY_SIZE(reset->ramc_base); idx++) + iounmap(reset->ramc_base[idx]); Ditto + return 0; } -- Nicolas Ferre

Re: [PATCH] clk: at91: Trivial typo fixes in the file sama7g5.c

2021-03-31 Thread Nicolas Ferre
On 13/03/2021 at 06:32, Bhaskar Chowdhury wrote: s/critial/critical/ ..two different places s/parrent/parent/ Signed-off-by: Bhaskar Chowdhury Acked-by: Nicolas Ferre --- drivers/clk/at91/sama7g5.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [RESEND PATCH 3/5] clk: at91: sama7g5: add securam's peripheral clock

2021-03-30 Thread Nicolas Ferre
On 24/03/2021 at 10:43, Claudiu Beznea wrote: Add SECURAM's peripheral clock. Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre --- drivers/clk/at91/sama7g5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c

Re: [RESEND PATCH 4/5] clk: at91: clk-master: add register definition for sama7g5's master clock

2021-03-30 Thread Nicolas Ferre
<< 16) +#defineAT91_PMC_MCR_V2_CSS_ETHPLL (10 << 16) +#defineAT91_PMC_MCR_V2_EN (1 << 28) + #define AT91_PMC_XTALF0x34/* Main XTAL Frequency Register [SAMA7G5 only] */ #define AT91_PMC_USB 0x38 /* USB Clock Register [some SAM9 only] */ Autherwise, it's fine. Thanks. Best regards, Nicolas -- Nicolas Ferre

Re: [RESEND PATCH 1/5] clk: at91: re-factor clocks suspend/resume

2021-03-30 Thread Nicolas Ferre
core_ops(&pmc_syscore_ops); diff --git a/drivers/clk/at91/pmc.h b/drivers/clk/at91/pmc.h index a49076c804a9..86580ebd9ad9 100644 --- a/drivers/clk/at91/pmc.h +++ b/drivers/clk/at91/pmc.h @@ -13,6 +13,8 @@ #include #include +#include + extern spinlock_t pmc_pcr_lock; struct pmc_data { @@ -98,6 +100,20 @@ struct clk_pcr_layout { u32 pid_mask; }; +/** + * struct at91_clk_pms - Power management state for AT91 clock + * @status: clock status (enabled or disabled) + * @parent: clock parent index + * @parent_rate: clock parent rate + * @rate: clock rate + */ +struct at91_clk_pms { + unsigned int status; + unsigned int parent; + unsigned long parent_rate; + unsigned long rate; +}; + #define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1)) #define field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask)) @@ -248,12 +264,4 @@ struct clk_hw * __init at91_clk_sama7g5_register_utmi(struct regmap *regmap, const char *name, const char *parent_name); -#ifdef CONFIG_PM -void pmc_register_id(u8 id); -void pmc_register_pck(u8 pck); -#else -static inline void pmc_register_id(u8 id) {} -static inline void pmc_register_pck(u8 pck) {} -#endif - #endif /* __PMC_H_ */ -- Nicolas Ferre

Re: [PATCH] ARM: boot: dts: Fix a typo

2021-03-30 Thread Nicolas Ferre
On 18/03/2021 at 10:52, Bhaskar Chowdhury wrote: s/conlicts/conflicts/ Signed-off-by: Bhaskar Chowdhury Acked-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d3.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts

Re: [PATCH] ARM: dts: at91-sama5d27_som1: fix phy address to 7

2021-03-23 Thread Nicolas Ferre
nternal pull-up forming PHYAD[2:0] = 7. Signed-off-by: Claudiu Beznea Fixes: 2f61929eb10a ("ARM: dts: at91: at91-sama5d27_som1: fix PHY ID") Cc: Ludovic Desroches Signed-off-by: Nicolas Ferre Cc: # 4.14+ --- arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 4 ++-- 1 file changed, 2 inse

Re: [PATCH 1/2] dt-bindings: mchp-eic: add bindings

2021-03-08 Thread Nicolas Ferre
1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mchp,eic.yaml [..] Regards, -- Nicolas Ferre

Re: [PATCH] ARM: configs: at91: enable drivers for sam9x60

2021-02-05 Thread Nicolas Ferre
. Should we have them as modules? That's fine with me if we keep them as built-in. Acked-by: Nicolas Ferre Regards, Nicolas And use "make savedefconfig". Signed-off-by: Claudiu Beznea With or without the Crypto IPs as modules: Reviewed-by: Tudor Ambarus --- a

Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend

2021-02-04 Thread Nicolas Ferre
instantiation at91_plla_enable Remove the extra '#' character that is not used for the 'ldr' instruction when doing an indirect load of a constant. Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60") Signed-off-by: Arnd Bergmann Looks good

Re: [PATCH] drivers: soc: atmel: fix type for same7

2021-02-04 Thread Nicolas Ferre
2.29.2 -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -- Nicolas Ferre

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-04 Thread Nicolas Ferre
and needs the clock initialized early. Postponing the timers caused the fail at boot. Signed-off-by: Tudor Ambarus Looks good to me: Acked-by: Nicolas Ferre Thanks for the fix Tudor! Best regards, Nicolas --- Tested on sama5d2_xplained. drivers/clk/at91/at91rm9200.c | 3 +-- drivers/cl

Re: [PATCH 0/7] drivers: soc: atmel: add support for sama7g5

2021-01-26 Thread Nicolas Ferre
soc id and version match masks dt-bindings: atmel-sysreg: add "microchip,sama7g5-chipid" drivers: soc: atmel: add support for sama7g5 For the rest: Acked-by: Nicolas Ferre I take the rest in at91-soc branch. It appears in at91-next right now. Once the license patch is done, I can

Re: [PATCH v2 1/7] drivers: soc: atmel: add spdx license identifier

2021-01-26 Thread Nicolas Ferre
On 26/01/2021 at 10:29, Claudiu Beznea wrote: Add SPDX-License-Identifier. Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre I remove license boilerplate text now that it's useless and queue this one on top of at91-soc. Thanks, best regards, Nicolas --- drivers/soc/atmel/

Re: [GIT PULL] ARM: at91: soc for 5.12

2021-01-22 Thread Nicolas Ferre
On 22/01/2021 at 17:35, Alexandre Belloni wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On 22/01/2021 16:25:47+0100, Arnd Bergmann wrote: On Fri, Jan 22, 2021 at 3:35 PM wrote: From: Nicolas Ferre Arnd, Olof, I'm taking back the

Re: [GIT PULL] ARM: at91: soc for 5.12

2021-01-22 Thread Nicolas Ferre
On 22/01/2021 at 16:25, Arnd Bergmann wrote: On Fri, Jan 22, 2021 at 3:35 PM wrote: From: Nicolas Ferre Arnd, Olof, I'm taking back the lead on sending the pull-requests for AT91 and hope that I didn't loose the knowledge in the meantime. Tell me if there's something I'

Re: [PATCH] ARM: dts: at91: sama5d2: remove atmel,wakeup-type references

2021-01-21 Thread Nicolas Ferre
On 05/01/2021 at 12:18, Claudiu Beznea wrote: atmel,wakeup-type DT property is not referenced anywhere in the current and previous version of the code thus remove it. Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre It's even not documented in any binding document. I take it now,

Re: [PATCH] ARM: dts: at91-sama5d27_wlsom1: add i2c recovery

2021-01-21 Thread Nicolas Ferre
On 17/01/2021 at 19:35, nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Add the i2c gpio pinctrls to support the i2c bus recovery on this board. Signed-off-by: Nicolas Ferre Reviewed-by: Codrin Ciubotariu added to at91-dt. Regards, Nicolas --- arch/arm/boot/dts/at91

Re: [PATCH 3/3] MAINTAINERS: add myself as maintainer for mcp16502

2021-01-08 Thread Nicolas Ferre
On 07/01/2021 at 15:15, Claudiu Beznea wrote: Andrei is no longer with Microchip. Add myself as maintainer for MCP16502. Along with this change the status from maintained to supported. Signed-off-by: Claudiu Beznea For the record: Acked-by: Nicolas Ferre Thanks Claudiu! Regards, Nicolas

Re: [PATCH] dt-bindings: rtc: at91rm9200: add sama7g5 compatible

2021-01-07 Thread Nicolas Ferre
these two in case tamper feature will be implemented in future. Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre --- Documentation/devicetree/bindings/rtc/atmel,at91rm9200-rtc.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91rm920

Re: [PATCH v3 0/8] net: macb: add support for sama7g5

2020-12-17 Thread Nicolas Ferre
ilure dt-bindings: add documentation for sama7g5 ethernet interface dt-bindings: add documentation for sama7g5 gigabit ethernet interface net: macb: add support for sama7g5 gem interface net: macb: add support for sama7g5 emac interface For the whole series: Acked-by: Nicolas Ferre

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Nicolas Ferre
-- drivers/net/ethernet/agere/Kconfig | 1 + drivers/net/ethernet/cadence/Kconfig| 1 + For Cadence macb driver: Acked-by: Nicolas Ferre drivers/net/ethernet/faraday/Kconfig| 1 + drivers/net/ethernet/freescale/Kconfig | 1 + drivers/net/ethernet/free

Re: [PATCH 2/2] ARM: dts: at91: sama5d2: map securam as device

2020-12-02 Thread Nicolas Ferre
("ARM: dts: at91: sama5d2: Add securam node") Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d2.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 2ddc85dff8ce..6d399ac03

Re: [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property

2020-12-02 Thread Nicolas Ferre
evice tree for soc and board") Cc: Marco Cardellini Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre --- arch/arm/boot/dts/at91-sam9x60ek.dts | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek

Re: [PATCH] rtc: at91rm9200: Add sam9x60 compatible

2020-11-17 Thread Nicolas Ferre
On 17/11/2020 at 14:39, Alexandre Belloni wrote: Handle the sam9x60 RTC. While it can work with the at91sam9x5 fallback, it has crystal correction support and doesn't need to shadow IMR. Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre --- drivers/rtc/rtc-at91rm9200.

Re: [PATCH] rtc: at91rm9200: add correction support

2020-11-10 Thread Nicolas Ferre
Alexandre, you know much more than me about the habits of RTC drivers writers. Even if I would like a little more documentation on values used, I absolutely won't hold this feature adoption, so here is my: Reviewed-by: Nicolas Ferre Thanks, best regards, Nicolas -- Nicolas Ferre

Re: [PATCH] pinctrl: pinctrl-at91-pio4: Set irq handler and data in one go

2020-11-10 Thread Nicolas Ferre
IRQ chip? I have the feeling it's out of scope for this (tiny) patch. Regards, -- Nicolas Ferre

Re: [RESEND PATCH] net: macb: fix NULL dereference due to no pcs_config method

2020-11-06 Thread Nicolas Ferre
On 05/11/2020 at 18:58, Parshuram Thombare wrote: This patch fixes NULL pointer dereference due to NULL pcs_config in pcs_ops. Reported-by: Nicolas Ferre Link: https://lore.kernel.org/netdev/2db854c7-9ffb-328a-f346-f68982723...@microchip.com/ Signed-off-by: Parshuram Thombare Acked-by

Re: [PATCH] net: macb: fix NULL dereference due to no pcs_config method

2020-11-05 Thread Nicolas Ferre
On 05/11/2020 at 16:48, Russell King - ARM Linux admin wrote: On Thu, Nov 05, 2020 at 04:22:18PM +0100, Nicolas Ferre wrote: On 05/11/2020 at 15:37, Parshuram Thombare wrote: This patch fixes NULL pointer dereference due to NULL pcs_config in pcs_ops. Fixes: e4e143e26ce8 ("net: macb

Re: [PATCH] net: macb: fix NULL dereference due to no pcs_config method

2020-11-05 Thread Nicolas Ferre
not refer to it like this. Reported-by: Nicolas Ferre Link: https://lkml.org/lkml/2020/11/4/482 You might need to change this to a "lore" link: https://lore.kernel.org/netdev/2db854c7-9ffb-328a-f346-f68982723...@microchip.com/ Signed-off-by: Parshuram Thombare This fix looks a bi

Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart

2020-10-30 Thread Nicolas Ferre
,6 +526,9 @@ usart2: serial@fc008000 { clocks = <&pmc PMC_TYPE_PERIPHERAL 29>; clock-names = "usart"; status = "disabled"; + serial { + compatible = "atmel,at91rm9200-usart-serial"; + }; }; usart3: serial@fc00c000 { @@ -532,6 +547,9 @@ usart3: serial@fc00c000 { clocks = <&pmc PMC_TYPE_PERIPHERAL 30>; clock-names = "usart"; status = "disabled"; + serial { + compatible = "atmel,at91rm9200-usart-serial"; + }; }; usart4: serial@fc01 { @@ -550,6 +568,9 @@ usart4: serial@fc01 { clocks = <&pmc PMC_TYPE_PERIPHERAL 31>; clock-names = "usart"; status = "disabled"; + serial { + compatible = "atmel,at91rm9200-usart-serial"; + }; }; ssc1: ssc@fc014000 { @@ -568,6 +589,9 @@ ssc1: ssc@fc014000 { clocks = <&pmc PMC_TYPE_PERIPHERAL 49>; clock-names = "pclk"; status = "disabled"; + serial { + compatible = "atmel,at91rm9200-usart-serial"; + }; }; spi1: spi@fc018000 { @@ -588,6 +612,9 @@ spi1: spi@fc018000 { clocks = <&pmc PMC_TYPE_PERIPHERAL 38>; clock-names = "spi_clk"; status = "disabled"; + serial { + compatible = "atmel,at91rm9200-usart-serial"; + }; }; spi2: spi@fc01c000 { @@ -794,6 +821,9 @@ dbgu: serial@fc069000 { clocks = <&pmc PMC_TYPE_PERIPHERAL 45>; clock-names = "usart"; status = "disabled"; + serial { + compatible = "atmel,at91rm9200-usart-serial"; + }; }; -- Nicolas Ferre

Re: [PATCH] clk: at91: sam9x60: support only two programmable clocks

2020-10-14 Thread Nicolas Ferre
; i < 2; i++) { char name[6]; snprintf(name, sizeof(name), "prog%d", i); -- Nicolas Ferre

Re: [PATCH 2/2] pinctrl: at91-pio4: add support for sama7g5 SoC

2020-09-17 Thread Nicolas Ferre
On 17/09/2020 at 15:12, Eugen Hristev wrote: Add support for sama7g5 pinctrl block, which has 5 PIO banks. Signed-off-by: Eugen Hristev Reviewed-by: Nicolas Ferre --- drivers/pinctrl/pinctrl-at91-pio4.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/pinctrl/pinctrl

Re: [PATCH net] net: macb: fix for pause frame receive enable bit

2020-09-07 Thread Nicolas Ferre
On 05/09/2020 at 10:21, Parshuram Thombare wrote: PAE bit of NCFGR register, when set, pauses transmission if a non-zero 802.3 classic pause frame is received. Fixes: 7897b071ac3b ("net: macb: convert to phylink") Signed-off-by: Parshuram Thombare For the record: Acked-by: Nic

Re: [PATCH v2] Replace HTTP links with HTTPS ones: Documentation/arm

2020-07-08 Thread Nicolas Ferre
| 30 +-- For Microchip changes, which is larger chunk: Acked-by: Nicolas Ferre Documentation/arm/sa1100/assabet.rst | 2 +- .../arm/samsung-s3c24xx/overview.rst | 4 +-- 5 files changed, 24 insertions(+), 24 deletions(-) diff --git a/Documentation/arm/arm.rst b/Document

Re: [PATCH] Replace HTTP links with HTTPS ones: ATMEL MACB ETHERNET DRIVER

2020-07-08 Thread Nicolas Ferre
K and serve the same content: Replace HTTP with HTTPS. Signed-off-by: Alexander A. Klimov The links go to Cadence. If people from Cadence want to change something, don't hesitate to speak out. On my side: Acked-by: Nicolas Ferre --- Continuing my work started at 93431e060

Re: [PATCH net-next v2 0/4] net: macb: few code cleanups

2020-07-02 Thread Nicolas Ferre
hweight32() to count set bits in queue_mask net: macb: do not initialize queue variable net: macb: remove is_udp variable drivers/net/ethernet/cadence/macb_main.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) You can add my: Acked-by: Nicolas Ferre For the whole

Re: [PATCH v2] net: macb: undo operations in case of failure

2020-06-18 Thread Nicolas Ferre
diu Beznea Acked-by: Nicolas Ferre Thanks Claudiu. Regards, Nicolas --- Changes in v2: - corrected fixes SHA1 drivers/net/ethernet/cadence/macb_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethern

Re: [PATCH] net: macb: undo operations in case of failure

2020-06-17 Thread Nicolas Ferre
It must be: Fixes: 7897b071ac3b ("net: macb: convert to phylink") -- Nicolas Ferre

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-25 Thread Nicolas Ferre
On 07/05/2020 at 12:03, Nicolas Ferre wrote: On 06/05/2020 at 22:18, Jakub Kicinski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Use the proper

Re: [PATCH v4 3/5] net: macb: fix macb_get/set_wol() when moving to phylink

2020-05-13 Thread Nicolas Ferre
Russell, Thanks for the feedback. On 13/05/2020 at 15:05, Russell King - ARM Linux admin wrote: On Wed, May 06, 2020 at 01:37:39PM +0200, nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Keep previous function goals and integrate phylink actions to them. phylink_ethtool_get_wol() is

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-07 Thread Nicolas Ferre
On 06/05/2020 at 22:18, Jakub Kicinski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Use the proper struct device pointer to check if the wakeup flag

Re: [PATCH net v2] net: macb: fix an issue about leak related system resources

2020-04-29 Thread Nicolas Ferre
remap_resource(pdev, 1); if (!mgmt->reg) Is your test valid then? Please use: if (IS_ERR(base)) return PTR_ERR(base); As advised by: lib/devres.c:156 Regards, Nicolas return -ENOMEM; -- 2.25.0 -- Nicolas Ferre

Re: [PATCH net v1] net: macb: fix an issue about leak related system resources

2020-04-28 Thread Nicolas Ferre
vice *pdev) if (!res) return -ENODEV; - mgmt->reg = ioremap(res->start, resource_size(res)); + mgmt->reg = devm_ioremap(&pdev->dev, res->start, resource_size(res)); if (!mgmt->reg) return -ENOMEM; -- Nicolas Ferre

[PATCH 2/2] mmc: sdhci-of-at91: add DT property to enable calibration on full reset

2019-10-08 Thread Nicolas Ferre
property to the DT as this feature can be used to adapt SDHCI behavior vs. how the SDCAL SoC pin is connected on the board. Note that managing properly this property would reduce power consumption on some SAMA5D2 SiP revisions. Signed-off-by: Nicolas Ferre --- drivers/mmc/host/sdhci-of-at91.c

[PATCH 1/2] dt-bindings: sdhci-of-at91: add the microchip,sdcal-inverted property

2019-10-08 Thread Nicolas Ferre
reduce power consumption. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/mmc/sdhci-atmel.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt b/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt index

[PATCH 2/3] USB: host: ohci-at91: suspend: delay needed before to stop clocks

2019-09-10 Thread Nicolas Ferre
In order to completely remove marginal power consumption in PM suspend, we need to let the controller settle down before being stopped. In ohci_hcd_at91_drv_suspend() function, one additional delay is needed before to stop the clocks. Reported-by: Boris Krasnovskiy Signed-off-by: Nicolas Ferre

[PATCH 3/3] USB: host: ohci-at91: resume: balance the clock start call

2019-09-10 Thread Nicolas Ferre
-off-by: Boris Krasnovskiy Signed-off-by: Nicolas Ferre --- drivers/usb/host/ohci-at91.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 85d67fe42d59..513e48397743 100644 --- a/drivers/usb/host/ohci-at91.c

[PATCH 1/3] USB: host: ohci-at91: completely shutdown the controller in at91_stop_hc()

2019-09-10 Thread Nicolas Ferre
procedure is just perfect for this. Signed-off-by: Boris Krasnovskiy Signed-off-by: Nicolas Ferre --- drivers/usb/host/ohci-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index fc35a7993b7b..cb63bcd5049a 100644

[PATCH 0/3] USB: host: ohci-at91: tailor power consumption

2019-09-10 Thread Nicolas Ferre
Krasnovskiy (2): USB: host: ohci-at91: completely shutdown the controller in at91_stop_hc() USB: host: ohci-at91: resume: balance the clock start call Nicolas Ferre (1): USB: host: ohci-at91: suspend: delay needed before to stop clocks drivers/usb/host/ohci-at91.c | 7 --- 1 file

[PATCH 3/3] mailmap: map old company name to new one @microchip.com

2019-08-23 Thread Nicolas Ferre
Map my old email address @atmel.com to my new company name. It happened 3 years ago but I realized the existence of this file recently. Signed-off-by: Nicolas Ferre --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 3e01b1e5d584..54fb6af3fa38 100644 --- a

[PATCH 2/3] MAINTAINERS: at91: remove the TC entry

2019-08-23 Thread Nicolas Ferre
ce/tcb_clksrc.c file is actually named timer-atmel-tcb.c. This new name is catches by AT91 entry regular expression. Signed-off-by: Nicolas Ferre --- MAINTAINERS | 7 --- 1 file changed, 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index da7630c727be..c28a28d4cac9 100644 --- a/MA

[PATCH 1/3] MAINTAINERS: at91: Collect all pinctrl/gpio drivers in same entry

2019-08-23 Thread Nicolas Ferre
Andrei's address is not valid anymore, collect all pinctrl/gpio entries in the common "PIN CONTROLLER - MICROCHIP AT91" one and remove the PIOBU specific one. Signed-off-by: Nicolas Ferre --- MAINTAINERS | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH] ARM: at91: Documentation: update the sama5d3 and armv7m datasheets

2019-08-19 Thread Nicolas Ferre
Update SAMA5D3 and SAM E70/S70/V70/V71 Family SoC Datasheets. URL are updated in Microchip documentation. Signed-off-by: Nicolas Ferre --- Documentation/arm/microchip.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/arm/microchip.rst b/Documentation/arm

[PATCH] net: macb: remove redundant struct phy_device declaration

2019-05-03 Thread Nicolas Ferre
While moving the chunk of code during 739de9a1563a ("net: macb: Reorganize macb_mii bringup"), the declaration of struct phy_device declaration was kept. It's not useful in this function as we alrady have a phydev pointer. Signed-off-by: Nicolas Ferre --- drivers/net/e

[PATCH v3 2/3] dmaengine: at_xdmac: enhance channel errors handling in tasklet

2019-04-03 Thread Nicolas Ferre
Complement the identification of errors with stopping the channel and dumping the descriptor that led to the error case. Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches --- v3: Typo in commit message, alignment in multi-line dev_dbg() v2: added Ludovic's tag address Vi

[PATCH v3 3/3] dmaengine: at_xdmac: only monitor overflow errors for peripheral xfer

2019-04-03 Thread Nicolas Ferre
x27;s based on the first descriptor which holds the configuration for the whole linked list transfer. Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches --- v3: no change v2: added Ludovic's tag drivers/dma/at_xdmac.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

[PATCH v3 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet

2019-04-03 Thread Nicolas Ferre
Even if this case shouldn't happen when controller is properly programmed, it's still better to avoid dumping a kernel Oops for this. As the sequence may happen only for debugging purposes, log the error and just finish the tasklet call. Signed-off-by: Nicolas Ferre Acked-by: Ludovic

[PATCH v2 2/3] dmaengine: at_xdmac: enhance channel errors handling in tasklet

2019-04-03 Thread Nicolas Ferre
Complement the identification of errors with stoping the channel and dumping the descriptor that led to the error case. Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches --- v2: added Ludovic's tag address Vinod's comments (typo, comment, empty line before logical blocks)

[PATCH v2 3/3] dmaengine: at_xdmac: only monitor overflow errors for peripheral xfer

2019-04-03 Thread Nicolas Ferre
x27;s based on the first descriptor which holds the configuration for the whole linked list transfer. Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches --- v2: added Ludovic's tag drivers/dma/at_xdmac.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v2 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet

2019-04-03 Thread Nicolas Ferre
Even if this case shouldn't happen when controller is properly programmed, it's still better to avoid dumping a kernel Oops for this. As the sequence may happen only for debugging purposes, log the error and just finish the tasklet call. Signed-off-by: Nicolas Ferre Acked-by: Ludovic

[PATCH] ARM: at91: remove HAVE_FB_ATMEL for sama5 SoC as they use DRM

2019-03-28 Thread Nicolas Ferre
SAMA5 devices use the newer DRM driver for LCD. They don't need the older FB driver: remove the Kconfig option for them. Signed-off-by: Nicolas Ferre --- arch/arm/mach-at91/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kc

[PATCH v2] clk: at91: fix programmable clock for sama5d2

2019-03-18 Thread Nicolas Ferre
From: Matthias Wieloch The prescaler formula of the programmable clock has changed for sama5d2. Update the driver accordingly. Fixes: a2038077de9a ("clk: at91: add sama5d2 PMC driver") Cc: # v4.20+ Signed-off-by: Nicolas Ferre [nicolas.fe...@microchip.com: adapt the presc

[PATCH] ARM: dts: at91: sama5d2: add labels to soc dtsi for derivative boards

2019-02-07 Thread Nicolas Ferre
This adds labels to commonly used device-tree nodes so that derivative boards can avoid ahb/apb hierarchy. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d2.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts

[PATCH v2 1/3] dt-bindings: arm: atmel: add missing samx7 to reset controller

2019-02-06 Thread Nicolas Ferre
Add this missing compatibility string to the Reset Controller compatible string chip list. Signed-off-by: Nicolas Ferre Reviewed-by: Rob Herring --- v2: split series and collect tag Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 3/3] power: reset: at91-reset: add support for sam9x60 SoC

2019-02-06 Thread Nicolas Ferre
Add support for additional reset causes and the proper compatibility string for sam9x60 SoC. The restart function is the same as the samx7. Signed-off-by: Nicolas Ferre Acked-by: Sebastian Reichel --- v2: split series and collect tag Sebastian, I add your Acked-by tag here but as I would like

[PATCH v2 2/3] dt-bindings: arm: atmel: add new sam9x60 reset controller binding

2019-02-06 Thread Nicolas Ferre
Update the Reset Controller's binding to add new SoC compatibility string. Signed-off-by: Nicolas Ferre Reviewed-by: Rob Herring --- v2: split series and collect tag Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Document

[RESEND PATCH] dt-bindings: arm: atmel: add new sam9x60 SFR binding

2019-02-06 Thread Nicolas Ferre
Add this SFR compatible definition for the sam9x60 SoC. Will be needed in OHCI driver: ohci-at91.c. Signed-off-by: Nicolas Ferre --- Hi Rob, It seems that this patch was lost in my series "[PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC". I split it and rese

[PATCH v2 1/3] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface

2019-02-06 Thread Nicolas Ferre
This removes a line left while adding the correct compatibility string for sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string. Signed-off-by: Nicolas Ferre Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/net/macb.txt | 3 +-- 1 file changed, 1 inser

[PATCH v2 3/3] net: macb: add sam9x60-macb compatibility string

2019-02-06 Thread Nicolas Ferre
Add a new compatibility string for this product. It's using at91sam9260-macb layout but has a newer hardware revision: it's safer to use its own string. Signed-off-by: Nicolas Ferre --- v2: applies on top of next-20190206 drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file

[PATCH v2 2/3] net/macb: bindings doc: add sam9x60 binding

2019-02-06 Thread Nicolas Ferre
Add the compatibility sting documentation for sam9x60 10/100 interface. Signed-off-by: Nicolas Ferre --- Hi Rob, Your tag is missing for this patch. Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net

[PATCH 2/3] dmaengine: at_xdmac: enhance channel errors handling in tasklet

2019-02-05 Thread Nicolas Ferre
Complement the identification of errors with stoping the channel and dumping the descriptor that led to the error case. Signed-off-by: Nicolas Ferre --- drivers/dma/at_xdmac.c | 43 -- 1 file changed, 37 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet

2019-02-05 Thread Nicolas Ferre
Even if this case shouldn't happen when controller is properly programmed, it's still better to avoid dumping a kernel Oops for this. As the sequence may happen only for debugging purposes, log the error and just finish the tasklet call. Signed-off-by: Nicolas Ferre --- drivers/dma/

[PATCH 3/3] dmaengine: at_xdmac: only monitor overflow errors for peripheral xfer

2019-02-05 Thread Nicolas Ferre
x27;s based on the first descriptor which holds the configuration for the whole linked list transfer. Signed-off-by: Nicolas Ferre --- drivers/dma/at_xdmac.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index ec7a29d

[PATCH] mmc: atmel-mci: enable 8 bits buswidth support

2019-01-29 Thread Nicolas Ferre
This patch adds support for 8-bit buswidth. Relevant SDCR value modified. Signed-off-by: Nicolas Ferre --- drivers/mmc/host/atmel-mci.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 47189f9ed4e2

[PATCH 1/8] dt-bindings: arm: atmel: add missing samx7 to reset controller

2019-01-16 Thread Nicolas Ferre
Add this missing compatibility string to the Reset Controller compatible string chip list. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/atmel

[PATCH 6/8] power: reset: at91-reset: add support for sam9x60 SoC

2019-01-16 Thread Nicolas Ferre
Add support for additional reset causes and the proper compatibility string for sam9x60 SoC. The restart function is the same as the samx7. Signed-off-by: Nicolas Ferre --- drivers/power/reset/at91-reset.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/power/reset

[PATCH 3/8] dt-bindings: arm: atmel: add new sam9x60 SFR binding

2019-01-16 Thread Nicolas Ferre
Add this SFR compatible definition for the sam9x60 SoC. Will be needed in OHCI driver: ohci-at91.c. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/atmel

[PATCH 2/8] dt-bindings: arm: atmel: add new sam9x60 reset controller binding

2019-01-16 Thread Nicolas Ferre
Update the Reset Controller's binding to add new SoC compatibility string. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Document

[PATCH 7/8] USB: host: ohci-at91: add sam9x60-sfr definition for ohci

2019-01-16 Thread Nicolas Ferre
Add this SFR compatible definition for the sam9x60 SoC and manage its use in ohci-at91.c driver. Signed-off-by: Nicolas Ferre --- drivers/usb/host/ohci-at91.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c

[PATCH 8/8] net: macb: add sam9x60-macb compatibility string

2019-01-16 Thread Nicolas Ferre
Add a new compatibility string for this product. It's using at91sam9260-macb layout but has a newer hardware revision: it's safer to use its own string. Signed-off-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH 4/8] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface

2019-01-16 Thread Nicolas Ferre
This removes a line left while adding the correct compatibility string for sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/net/macb.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC

2019-01-16 Thread Nicolas Ferre
: sounds okay to everyone? If okay, I'm ready to collect Ack tags... For the first batch, I send the whole series to everyone. I'll try my best to reduce subsequent message deliveries if one part of the serries needs rework. Best regards, Nicolas Nicolas Ferre (8): dt-bindings:

[PATCH 5/8] net/macb: bindings doc: add sam9x60 binding

2019-01-16 Thread Nicolas Ferre
Add the compatibility sting documentation for sam9x60 10/100 interface. Signed-off-by: Nicolas Ferre --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net

[PATCH] ARM: at91: add support in soc driver for new SAM9X60

2018-12-12 Thread Nicolas Ferre
From: Sandeep Sheriker Mallikarjun Add detection of new SAM9X60 by this soc.c driver. Signed-off-by: Nicolas Ferre [nicolas.fe...@microchip.com: split patch] Signed-off-by: Sandeep Sheriker Mallikarjun --- drivers/soc/atmel/soc.c | 2 ++ drivers/soc/atmel/soc.h | 3 +++ 2 files changed, 5

[PATCH] ARM: at91: add support in soc driver for LPDDR2 SiP

2018-11-28 Thread Nicolas Ferre
Add some more SiP components to be detected by this soc.c driver. Signed-off-by: Nicolas Ferre --- drivers/soc/atmel/soc.c | 8 drivers/soc/atmel/soc.h | 4 2 files changed, 12 insertions(+) diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c index 4dd03b099c89

Re: [PATCH] clocksource/drivers/timer-atmel-pit: properly handle error cases

2018-09-26 Thread Nicolas Ferre
nsure data is freed before exiting with an error. Reported-by: Dan Carpenter Signed-off-by: Alexandre Belloni --- Applied for 4.17-rc We don't see it in Mainline as of 4.19-rc neither in linux-next. Has it been forgotten? Thanks for your help. Best regards, -- Nicolas Ferre

Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected

2018-09-25 Thread Nicolas Ferre
. Then macb driver is reading DMACFG register back and only adding 64bit dma configuration but not cleaning it out. Signed-off-by: Michal Simek Acked-by: Nicolas Ferre Thanks Michal. Best regards, Nicolas --- Changes in v2: - Clean reg at the first place - Edgar - Update commit message

Re: linux-next: manual merge of the staging tree with the at91 tree

2018-09-18 Thread Nicolas Ferre
our tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. Resolution looks good to me. Thanks. Best regards, -- Nicolas Ferre

Re: [GIT PULL] Immutable branch between MFD, SPI and TTY due for the v4.20 merge window

2018-09-11 Thread Nicolas Ferre
ment. Best regards, -- Nicolas Ferre

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Nicolas Ferre
patch ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1. because linux/platform_device.h was included by linux/mfd/core.h that is present in this driver. This is why the issue was not identified beforehand. I'm building a tiny patch to address this right now. Thanks for your help. Best regards, -- Nicolas Ferre

Re: [PATCH v12 0/6] Driver for at91 usart in spi mode

2018-09-10 Thread Nicolas Ferre
hange the driver to work under at91-usart mfd -- Nicolas Ferre

  1   2   3   4   5   6   7   8   9   10   >