rhaps:
"The quantisation controls is therefore optional for decoding streams that uses
the default matrices."
A stack that would not handle the default, would have to read the control at
least once in order to avoid overriding valid values with 0s, not sure if that
is wort
Le mercredi 17 mars 2021 à 12:13 +0900, Alexandre Courbot a écrit :
> On Tue, Mar 16, 2021 at 6:45 AM Ezequiel Garcia
> wrote:
> >
> > Hi Alexandre,
> >
> > On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot
> > wrote:
> > >
> > > Hi Ezequiel, thanks for the feedback!
> > >
> > > On Thu, Mar 4,
Le lundi 15 mars 2021 à 20:28 +0900, Alexandre Courbot a écrit :
> Hi Ezequiel,
>
> On Thu, Mar 4, 2021 at 6:47 AM Ezequiel Garcia
> wrote:
> >
> > Hi Alex,
> >
> > Thanks for the patch.
> >
> > On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot
> > wrote:
> > >
> > > From: Yunfei Dong
> > >
Le lundi 15 mars 2021 à 20:28 +0900, Alexandre Courbot a écrit :
> Hi Ezequiel, thanks for the feedback!
>
> On Thu, Mar 4, 2021 at 6:30 AM Ezequiel Garcia
> wrote:
> >
> > Hello Alex,
> >
> > Thanks for the patch.
> >
> > On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot
> > wrote:
> > >
> >
Le jeudi 25 février 2021 à 19:16 +0900, Alexandre Courbot a écrit :
> Add Mediatek's non-compressed 8 bit block video mode. This format is
> produced by the MT8183 codec and can be converted to a non-proprietary
> format by the MDP3 component.
>
> Signed-off-by: Alexandre Courbot
> ---
> Documen
Le dimanche 28 février 2021 à 15:13 +0900, Alexandre Courbot a écrit :
> Hi Nicolas,
>
> On Thu, Feb 25, 2021 at 6:08 AM Nicolas Dufresne
> wrote:
> >
> > Le jeudi 10 septembre 2020 à 15:04 +0900, Alexandre Courbot a écrit :
> > > Hi Ezequiel, sorry for the late
Le jeudi 25 février 2021 à 18:34 +, John Cox a écrit :
> On Thu, 25 Feb 2021 19:05:55 +0100, you wrote:
>
> > Dne ?etrtek, 25. februar 2021 ob 18:34:48 CET je Ezequiel Garcia napisal(a):
> > > Hey Jernej,
> > >
> > > On Thu, 2021-02-25 at 18:01 +0100, Jernej Škrabec wrote:
> > > > Hi Ezequiel
Le jeudi 25 février 2021 à 10:09 -0300, Ezequiel Garcia a écrit :
> Hi Benjamin,
>
> Thanks for the good work.
>
> On Mon, 2021-02-22 at 13:23 +0100, Benjamin Gaignard wrote:
> > The H.265 ITU specification (section 7.4) define the general
> > slice segment header semantics.
> > Modified/added fi
Le jeudi 10 septembre 2020 à 15:04 +0900, Alexandre Courbot a écrit :
> Hi Ezequiel, sorry for the late review!
>
> On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia
> wrote:
> >
> > From: Boris Brezillon
> >
> > Add the VP9 stateless decoder controls plus the documentation that goes
> > with it
Le lundi 22 février 2021 à 16:00 -0500, Nicolas Dufresne a écrit :
Hi All,
Le lundi 02 novembre 2020 à 21:05 +0200, Adrian Ratiu a écrit :
> From: Boris Brezillon
>
> Add the VP9 stateless decoder controls plus the documentation that goes
> with it.
>
> Signed-off-by: Boris B
Hi All,
Le lundi 02 novembre 2020 à 21:05 +0200, Adrian Ratiu a écrit :
> From: Boris Brezillon
>
> Add the VP9 stateless decoder controls plus the documentation that goes
> with it.
>
> Signed-off-by: Boris Brezillon
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> ..
Le lundi 22 février 2021 à 17:28 +0100, Benjamin Gaignard a écrit :
>
> Le 22/02/2021 à 17:16, John Cox a écrit :
> > > The HEVC HANTRO driver needs to know the number of bits to skip at
> > > the beginning of the slice header.
> > > That is a hardware specific requirement so create a dedicated co
Hi John,
Le lundi 22 février 2021 à 17:39 +0100, Benjamin Gaignard a écrit :
>
> Le 22/02/2021 à 17:24, John Cox a écrit :
> > > The H.265 ITU specification (section 7.4) define the general
> > > slice segment header semantics.
> > > Modified/added fields are:
> > > - video_parameter_set_id: (7.4
Hi Robert,
not really a review, but I noticed
Le mercredi 17 février 2021 à 12:21 +0100, Robert Foss a écrit :
> Function name is comment is wrong, and was changed to be
in
> the same as the actual function name.
>
> The comment was changed to kerneldoc format.
>
> Signed
Le lundi 15 février 2021 à 13:10 +0100, Christian König a écrit :
>
>
> Am 15.02.21 um 13:00 schrieb Thomas Zimmermann:
> > Hi
> >
> > Am 15.02.21 um 10:49 schrieb Thomas Zimmermann:
> > > Hi
> > >
> > > Am 15.02.21 um 09:58 schrieb Christian König:
> > > > Hi guys,
> > > >
> > > > we are curr
Le lundi 15 février 2021 à 09:58 +0100, Christian König a écrit :
> Hi guys,
>
> we are currently working an Freesync and direct scan out from system
> memory on AMD APUs in A+A laptops.
>
> On problem we stumbled over is that our display hardware needs to scan
> out from uncached system memory
Hi Sven,
Le mercredi 03 février 2021 à 11:33 -0500, Sven Van Asbroeck a écrit :
> From: Sven Van Asbroeck
>
> We have observed that under certain repeatable circumstances, the CODA
> mem2mem device consistently generates corrupted frames. This happens only
> on an i.MX6qp (Plus) - the classic im
Le jeudi 04 février 2021 à 11:05 +0100, Hans Verkuil a écrit :
> On 04/02/2021 06:01, diksh...@codeaurora.org wrote:
> > On 2021-02-01 16:50, Hans Verkuil wrote:
> > > On 25/01/2021 06:51, Dikshita Agarwal wrote:
> > > > Long Term Reference (LTR) frames are the frames that are encoded
> > > > somet
: Nicolas Dufresne
---
.../userspace-api/media/v4l/ext-ctrls-codec-stateless.rst | 4 +++-
Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git
a/Documentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst
b
Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varbanov a écrit :
> Hi Tomasz,
>
> On 12/15/20 1:47 PM, Tomasz Figa wrote:
> > On Tue, Dec 15, 2020 at 8:16 PM Stanimir Varbanov
> > wrote:
> > >
> > > Hi,
> > >
> > > Cc: Robin
> > >
> > > On 12/14/20 2:57 PM, Alexandre Courbot wrote:
> > > >
Le mercredi 18 novembre 2020 à 00:06 -0800, Wendy Liang a écrit :
> Create AI engine device/partition hierarchical structure.
>
> Each AI engine device can have multiple logical partitions(groups of AI
> engine tiles). Each partition is column based and has its own node ID
> in the system. AI engi
Le mardi 17 novembre 2020 à 10:19 -0800, Minchan Kim a écrit :
> This patchset introduces a new dma heap, chunk heap that makes it
> easy to perform the bulk allocation of high order pages.
> It has been created to help optimize the 4K/8K HDR video playback
> with secure DRM HW to protect contents
Le mardi 17 novembre 2020 à 09:44 +0100, Neil Armstrong a écrit :
> The GE2D is a 2D accelerator with various features like configurable blitter
> with alpha blending, frame rotation, scaling, format conversion and colorspace
> conversion.
>
> The driver implements a Memory2Memory VB2 V4L2 streami
Le vendredi 13 novembre 2020 à 21:39 +0100, Daniel Vetter a écrit :
> On Thu, Nov 12, 2020 at 08:11:02PM -0800, John Stultz wrote:
> > On Thu, Nov 12, 2020 at 1:32 AM Daniel Vetter wrote:
> > > On Thu, Nov 12, 2020 at 11:09:04AM +0530, Sumit Semwal wrote:
> > > > On Tue, 10 Nov 2020 at 09:19, John
Le lundi 30 novembre 2020 à 11:08 +0200, Stanimir Varbanov a écrit :
> Add support for Access Unit Delimiter control into encoder.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/venus/core.h | 1 +
> drivers/media/platform/qcom/venus/venc.c | 14 +++
Le lundi 09 novembre 2020 à 19:31 +0200, Stanimir Varbanov a écrit :
> Hello,
>
> This patchset adds two HDR10 HEVC v4l2 controls for Content Light Level
> and Mastering display colour volume plus implenmentation in Venus encoder
> driver.
>
> Comments are welcome!
It is not a formal review, but
Le lundi 28 septembre 2020 à 17:14 -0300, Ezequiel Garcia a écrit :
> In preparation for making the interface public,
> document all the structures. Special care is taken to
> annotate those fields that depart from the H264 syntax.
>
> This commit only adds documentation and doesn't affect
> funct
Le jeudi 24 septembre 2020 à 10:29 +0200, Hans Verkuil a écrit :
> Hi Ezequiel,
>
> On 21/09/2020 21:38, Ezequiel Garcia wrote:
> > In preparation for making the interface public,
> > document all the structures. Special care is taken to
> > annotate those fields that depart from the H264 syntax.
Le lundi 21 septembre 2020 à 18:33 +0530, Dikshita Agarwal a écrit :
> This series adds frame specific min/max qp controls for hevc and layer
> wise bitrate control for h264.
Any chance you could append your driver changes with this set ? I don't
think new APIs ever make it without a driver using
Le jeudi 17 septembre 2020 à 20:27 -0400, Nicolas Dufresne a écrit :
> As per spec, the CAPTURE resolution should be automatically set based on
> the OTUPUT resolution. This patch properly propagate width/height to the
> capture when the OUTPUT format is set and override the user provide
.
This also prevents userspace from selecting a CAPTURE resolution that is
too small, avoiding kernel oops.
Signed-off-by: Nicolas Dufresne
Reviewed-by: Ezequiel Garcia
Acked-by: Paul Kocialkowski
Tested-by: Ondrej Jirman
---
.../staging/media/sunxi/cedrus/cedrus_video.c | 29
Le jeudi 17 septembre 2020 à 12:39 +0200, Hans Verkuil a écrit :
> On 14/05/2020 17:39, Nicolas Dufresne wrote:
> > As per spec, the CAPTURE resolution should be automatically set based on
> > the OTUPUT resolution. This patch properly propagate width/height to the
> > ca
Le jeudi 20 août 2020 à 04:32 -0300, Ezequiel Garcia a écrit :
> Hi Paul,
>
> On Wed, 2020-08-19 at 15:54 +0200, Paul Kocialkowski wrote:
> > Hi,
> >
> > On Fri 07 Aug 20, 11:44, Ezequiel Garcia wrote:
> > > On Thu, 2020-08-06 at 17:50 +0200, Paul Kocialkowski wrote:
> > > > Hi,
> > > >
> > > >
CCed Neil as Amlogic
codec do have VP9 support which may benefit of implementing this.
Reviewed-by: Nicolas Dufresne
> ---
> v2: Added links to webmproject in commit message and docs.
>
> .../media/v4l/ext-ctrls-codec.rst | 43 +++
>
Le mardi 25 août 2020 à 13:30 +0200, Mauro Carvalho Chehab a écrit :
> Em Tue, 25 Aug 2020 05:29:29 +1000
> Dave Airlie escreveu:
>
> > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart
> > wrote:
> > > Hi Mauro,
> > >
> > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:
Le mercredi 19 août 2020 à 19:56 +0300, Laurent Pinchart a écrit :
> Hi Vishal,
>
> (Hans, there's a question for you below)
>
> On Wed, Aug 19, 2020 at 01:47:49PM +, Vishal Sagar wrote:
> > On Thursday, July 16, 2020 3:03 AM Laurent Pinchart wrote:
> > > On Thu, Jun 25, 2020 at 11:43:01AM +0
Le mardi 21 juillet 2020 à 10:45 +0300, Stanimir Varbanov a écrit :
> Hello,
>
> Here is v2 with following changes:
>
> * 3/6 Added references for VBV size and h264 CPB size - requested by Nicolas
Thanks for this enhancement. No more comments on the doc from me.
> * 4/6 Fixed compile warning
Le samedi 25 juillet 2020 à 22:30 +0900, Alexandre Courbot a écrit :
> On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia
> wrote:
> > The prediction weight parameters are only required under
> > certain conditions, which depend on slice header parameters.
> >
> > The slice header syntax specifies
Le mardi 28 juillet 2020 à 14:44 +0200, Maxime Ripard a écrit :
> Hi,
>
> On Mon, Jul 27, 2020 at 11:39:12AM -0300, Ezequiel Garcia wrote:
> > On Sat, 2020-07-25 at 23:34 +0900, Alexandre Courbot wrote:
> > > On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia
> > > wrote:
> > > > The H.264 specific
s sense for us to split them into the decode params
> > > > (per-frame) control.
> > > >
> > > > They are really specified to be the same across all slices,
> > > > so even I'd say if a bitstream violates this, it's likely
> > >
Le mercredi 15 juillet 2020 à 18:42 +0300, Stanimir Varbanov a écrit :
> Hi Nicolas,
>
> On 7/7/20 11:53 PM, Nicolas Dufresne wrote:
> > Le dimanche 05 juillet 2020 à 15:11 +0300, Stanimir Varbanov a écrit :
> > > Adds encoders standard v4l2 control for frame-skip. The co
Le lundi 13 juillet 2020 à 11:15 +0300, Stanimir Varbanov a écrit :
> Add menu control for VP9 codec levels. A total of 14 levels are
> defined for Profile 0 (8bit) and Profile 2 (10bit). Each level
> is a set of constrained bitstreams coded with targeted resolutions,
> frame rates, and bitrates.
Le dimanche 12 juillet 2020 à 19:59 -0300, Ezequiel Garcia a écrit :
> On Sat, 2020-07-11 at 10:21 +, Jonas Karlman wrote:
> > On 2020-07-10 23:49, Nicolas Dufresne wrote:
> > > Le vendredi 10 juillet 2020 à 09:25 -0300, Ezequiel Garcia a écrit :
> > > > +Nicolas
Le samedi 11 juillet 2020 à 10:21 +, Jonas Karlman a écrit :
> On 2020-07-10 23:49, Nicolas Dufresne wrote:
> > Le vendredi 10 juillet 2020 à 09:25 -0300, Ezequiel Garcia a écrit :
> > > +Nicolas
> > >
> > > On Fri, 2020-07-10 at 14:05 +0200, Boris Brezillo
Le vendredi 10 juillet 2020 à 09:25 -0300, Ezequiel Garcia a écrit :
> +Nicolas
>
> On Fri, 2020-07-10 at 14:05 +0200, Boris Brezillon wrote:
> > On Fri, 10 Jul 2020 08:50:28 -0300
> > Ezequiel Garcia wrote:
> >
> > > On Fri, 2020-07-10 at 10:13 +0200, Boris Brezillon wrote:
> > > > On Fri, 10 J
Le mercredi 08 juillet 2020 à 17:57 +0200, Jernej Škrabec a écrit :
> Hi!
>
> Dne sreda, 08. julij 2020 ob 15:28:52 CEST je Ezequiel Garcia napisal(a):
> > Hello Jernej,
> >
> > I'd like to post a new H264 uAPI cleanup series soon,
> > would you mind resending this, or otherwise do you
> > mind i
Le dimanche 05 juillet 2020 à 15:11 +0300, Stanimir Varbanov a écrit :
> Adds encoders standard v4l2 control for frame-skip. The control
> is a copy of a custom encoder control so that other v4l2 encoder
> drivers can use it.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../media/v4l/ext-ctrls-c
Le jeudi 25 juin 2020 à 14:42 -0300, Ezequiel Garcia a écrit :
> (Adding Jernej, seems I haven't Cced him!)
>
> On Thu, 2020-06-25 at 10:53 -0400, Nicolas Dufresne wrote:
> > Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit :
> > > Align v4l2_h264_refe
der_cnt[0], and
> delta_pic_order_cnt[1] syntax elements contained in the slice.
>
> Signed-off-by: Philipp Zabel
> [Ezequiel: rebase]
> Signed-off-by: Ezequiel Garcia
Reviewed-by: Nicolas Dufresne
> ---
> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 4 +++-
&
s dec_ref_pic_marking_bit_size and pic_order_cnt_bit_size
> are also common to all slices.
>
> Signed-off-by: Ezequiel Garcia
This looks good to me. Perhaps drivers that don't need the slice_params
(hantro) should simply not implement it ?
Assuming this is/will be thoroughly tested
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit :
> Slice header syntax element 'first_mb_in_slice' can point
> to the last macroblock, currently the field can only reference
> 65536 macroblocks which is insufficient for 8K videos.
>
> DPB entry PicNum maximum value is 2*MaxFrameNum f
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit :
> The struct does not contain 64-bit types, and therefore
> doesn't suffer from compatibility issues.
>
> However, having it aligned to 64-bits is cleaner and
> has the advantage of allowing future extensions.
This one seems a bit ran
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit :
> Align v4l2_h264_reference to 32-bits, giving some room
> for future extensions.
>
> Signed-off-by: Ezequiel Garcia
> ---
> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 3 +++
> drivers/media/v4l2-core/v4l2-ctrls.c
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit :
> The recent patch posted by Jernej (which I'm including for context),
> encouraged me to address all the known issues in the uAPI.
>
> I hope we can finally make this uAPI interface
> public; it would be nice to address the other code
Le mardi 16 juin 2020 à 15:30 +0300, Stanimir Varbanov a écrit :
> This adds a new decoder control to instruct the decoders to
> produce on its output intra frames only. Usually in this mode
> decoders might lower the count of output decoder buffers and
> hence reduce memory usage.
Perhaps I misse
Le vendredi 12 juin 2020 à 12:05 +0200, Hans Verkuil a écrit :
> On 11/06/2020 17:06, Nicolas Dufresne wrote:
> > Le jeudi 28 mai 2020 à 22:08 -0400, Nicolas Dufresne a écrit :
> > > Le jeudi 28 mai 2020 à 13:24 +0200, Hans Verkuil a écrit :
> > > > On 28/05/2020
Le jeudi 28 mai 2020 à 22:08 -0400, Nicolas Dufresne a écrit :
> Le jeudi 28 mai 2020 à 13:24 +0200, Hans Verkuil a écrit :
> > On 28/05/2020 12:48, diksh...@codeaurora.org wrote:
> > > Hi Hans,
> > >
> > > Thanks for the review.
> > >
> > &g
Le jeudi 11 juin 2020 à 15:55 +0530, Dikshita Agarwal a écrit :
> LTR (Long Term Reference) frames are the frames that are encoded sometime in
> the past
> and stored in the DPB buffer list to be used as reference to encode future
> frames.
> One usage of LTR encoding is to reduce error propagati
Le mardi 09 juin 2020 à 07:28 -0300, Ezequiel Garcia a écrit :
> Adding Helen to the discussion.
>
> On Tue, 9 Jun 2020 at 04:43, Neil Armstrong wrote:
> > Hi Nicolas,
> >
> > On 08/06/2020 20:59, Nicolas Dufresne wrote:
> > > Le lundi 08 juin 2020
Le lundi 08 juin 2020 à 16:43 +0200, Hans Verkuil a écrit :
> On 08/06/2020 16:14, Neil Armstrong wrote:
> > On 08/06/2020 11:26, Hans Verkuil wrote:
> > > On 08/06/2020 10:16, Neil Armstrong wrote:
> > > > Hi Nicolas,
> > > >
> > > > On
Le dimanche 07 juin 2020 à 16:21 -0400, Nicolas Dufresne a écrit :
> Le samedi 06 juin 2020 à 09:46 -0300, Ezequiel Garcia a écrit :
> > Hi Jernej,
> >
> > On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote:
> > > Currently H264 interlaced content it's not prop
Le samedi 06 juin 2020 à 09:46 -0300, Ezequiel Garcia a écrit :
> Hi Jernej,
>
> On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote:
> > Currently H264 interlaced content it's not properly decoded on Cedrus.
> > There are two reasons for this:
> > 1. slice parameters control doesn't provide enough
Le vendredi 05 juin 2020 à 12:32 +0530, diksh...@codeaurora.org a écrit :
> Hi Hans, Nicolas,
>
> On 2020-05-29 13:01, Hans Verkuil wrote:
> > On 29/05/2020 04:18, Nicolas Dufresne wrote:
> > > Le jeudi 28 mai 2020 à 16:18 +0530, diksh...@codeaurora.org a écrit :
> >
ay hold both fields.
>
> Fix this by checking newly introduced flags in reference lists.
>
> Signed-off-by: Jernej Skrabec
Perhaps an additional patch could cleanup the miss-leading comment in
v4l2_h264_dpb_entry definition.
Reviewed-by: Nicolas Dufresne
> ---
> driv
Sorry, missed one thing.
Le vendredi 05 juin 2020 à 13:08 -0400, Nicolas Dufresne a écrit :
> Le jeudi 04 juin 2020 à 20:57 +0200, Jernej Skrabec a écrit :
> > When dealing with with interlaced frames, reference lists must tell if
> > each particular reference is meant for top
ill come in
> following commit.
>
> Signed-off-by: Jernej Skrabec
This looks like the right approach to me and is extensible if anything
else is needed for MVC and SVC special referencing (at least will be
enough for what H.264 actually supports in this regard).
Reviewed-by: Nicolas Dufr
Le vendredi 05 juin 2020 à 11:35 -0400, Nicolas Dufresne a écrit :
> Le jeudi 04 juin 2020 à 15:53 +0200, Neil Armstrong a écrit :
> > From: Maxime Jourdan
> >
> > Add two generic Compressed Framebuffer pixel formats to be used
> > with a modifier when imported back in
Le jeudi 04 juin 2020 à 15:53 +0200, Neil Armstrong a écrit :
> From: Maxime Jourdan
>
> Add two generic Compressed Framebuffer pixel formats to be used
> with a modifier when imported back in another subsystem like DRM/KMS.
>
> These pixel formats represents generic 8bits and 10bits compressed
Hi Andriy,
thanks for you patch.
Le samedi 02 mai 2020 à 15:40 -0400, Andriy Gelman a écrit :
> From: Andriy Gelman
>
> As per V4L2 api, the final buffer should set V4L2_BUF_FLAG_LAST flag.
>
> Signed-off-by: Andriy Gelman
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 +
> 1 file chan
Le jeudi 28 mai 2020 à 16:18 +0530, diksh...@codeaurora.org a écrit :
> > not allowed. So I need to know more about this.
> > Regards,
> >Hans
>
> we need this for use cases like HDR10+ where metadata info is part of
> the bitstream.
>
> To handle such frame specific data, support for req
Le jeudi 28 mai 2020 à 13:24 +0200, Hans Verkuil a écrit :
> On 28/05/2020 12:48, diksh...@codeaurora.org wrote:
> > Hi Hans,
> >
> > Thanks for the review.
> >
> > On 2020-05-26 16:27, Hans Verkuil wrote:
> > > Hi Dikshita,
> > >
> > > My apologies for the delay, this was (mostly) due to variou
ut I believe it make sense to move to
raster order as we know have the knowledge that this is what all the HW
we supports uses and is what one would pass to VAAPI, NVDEC and DXVA2
too.
Tested-by: Nicolas Dufresne
> ---
> drivers/staging/media/rkvdec/rkvdec-h264.c | 70 +++---
&
Le mercredi 20 mai 2020 à 23:01 +0200, Jernej Skrabec a écrit :
> VP8 in Cedrus shares same engine as H264.
>
> Note that it seems necessary to call bitstream parsing functions,
> to parse frame header, otherwise decoded image is garbage. This is
> contrary to what is driver supposed to do. Howeve
Le jeudi 14 mai 2020 à 11:39 -0400, Nicolas Dufresne a écrit :
> As per spec, the CAPTURE resolution should be automatically set based on
> the OTUPUT resolution. This patch properly propagate width/height to the
> capture when the OUTPUT format is set and override the user provided
>
.
This also prevents userspace from selecting a CAPTURE resolution that is
too small, avoiding unwanted page faults.
Signed-off-by: Nicolas Dufresne
---
drivers/staging/media/sunxi/cedrus/cedrus_video.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media
Le mardi 05 mai 2020 à 10:41 -0300, Ezequiel Garcia a écrit :
> The driver should only set the payload on .buf_prepare
> if the buffer is CAPTURE type, or if an OUTPUT buffer
> has a zeroed payload.
>
> Fix it.
>
> Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver")
> Signed-off-by: Eze
Le mardi 05 mai 2020 à 11:27 -0300, Ezequiel Garcia a écrit :
> On Tue, 2020-05-05 at 16:05 +0200, Tomasz Figa wrote:
> > On Tue, May 5, 2020 at 3:59 PM Ezequiel Garcia
> > wrote:
> > > On Tue, 2020-05-05 at 15:56 +0200, Tomasz Figa wrote:
> > > > Hi Ezequiel,
> > > >
> > > > On Tue, May 5, 2020
Le vendredi 08 mai 2020 à 15:16 +0200, Hans Verkuil a écrit :
> > I think this comes directly from the spec. The Rockchip VDEC doesn't
> > seem to use it.
> > Do you think we can drop it from here, and rely on the V4L2 colorspace
> > passed in the format negotiation?
>
>
> That would be preferred
Le lundi 04 mai 2020 à 14:01 -0400, Nicolas Dufresne a écrit :
> Le samedi 02 mai 2020 à 19:55 -0300, Ezequiel Garcia a écrit :
> > +Nicolas
> >
> > On Sat, 2020-05-02 at 20:37 +0200, Boris Brezillon wrote:
> > > On Fri, 01 May 2020 13:57:49 -030
Le samedi 02 mai 2020 à 19:55 -0300, Ezequiel Garcia a écrit :
> +Nicolas
>
> On Sat, 2020-05-02 at 20:37 +0200, Boris Brezillon wrote:
> > On Fri, 01 May 2020 13:57:49 -0300
> > Ezequiel Garcia wrote:
> >
> > > > > +
> > > > > +.. tabularcolumns:: |p{1.5cm}|p{6.3cm}|p{9.4cm}|
> > > > > +
> > >
Le jeudi 10 octobre 2019 à 16:23 +0900, Tomasz Figa a écrit :
> On Tue, Oct 8, 2019 at 11:12 PM Jonas Karlman wrote:
> > On 2019-10-08 15:53, Tomasz Figa wrote:
> > > On Tue, Oct 8, 2019 at 10:35 PM Tomasz Figa wrote:
> > > > On Tue, Oct 8, 2019 at 7:42 PM Tomasz Figa wrote:
> > > > > On Tue, Oc
Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit :
> Hello,
>
> This patch series aims to bring H.264 support as well as compliance update
> to the amlogic stateful video decoder driver.
>
> There is 1 issue that remains currently:
>
> - The following codepath had to be commented
Le mardi 08 octobre 2019 à 16:27 -0400, Nicolas Dufresne a écrit :
> Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit :
> > Add support for the H264 compressed format (V4L2_PIX_FMT_H264).
> >
> > Signed-off-by: Maxime Jourdan
> > ---
> > drivers/
Le lundi 07 octobre 2019 à 16:59 +0200, Maxime Jourdan a écrit :
> Add support for the H264 compressed format (V4L2_PIX_FMT_H264).
>
> Signed-off-by: Maxime Jourdan
> ---
> drivers/staging/media/meson/vdec/Makefile | 2 +-
> drivers/staging/media/meson/vdec/codec_h264.c | 482 +
Le vendredi 30 août 2019 à 07:48 +0200, Boris Brezillon a écrit :
> On Thu, 29 Aug 2019 21:04:28 +0200
> Jernej Škrabec wrote:
>
> > Dne ponedeljek, 26. avgust 2019 ob 20:28:31 CEST je Boris Brezillon
> > napisal(a):
> > > Hi Jernej,
> > >
> > > On Thu, 22 Aug 2019 21:44:57 +0200
> > >
> > > J
Le vendredi 19 juillet 2019 à 14:45 +0900, Tomasz Figa a écrit :
> On Wed, Jul 17, 2019 at 9:18 PM Nicolas Dufresne wrote:
> > Hello,
> >
> > there is one little detail/proposal, see inline .
> >
> > Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil
Hello,
there is one little detail/proposal, see inline .
Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit :
> From: Tomasz Figa
>
> Due to complexity of the video decoding process, the V4L2 drivers of
> stateful decoder hardware require specific sequences of V4L2 API calls
> to be foll
Le lundi 15 juillet 2019 à 14:12 +0200, Maxime Jourdan a écrit :
> On Tue, Jun 11, 2019 at 10:29 AM Hans Verkuil
> wrote:
> > On 6/10/19 9:54 PM, Nicolas Dufresne wrote:
> > > Hi Hans,
> > >
> > > I went through it, and I think we are close to re
__u16 padding;
> + __u32 flags;
> +};
> +
> +struct v4l2_vp8_quantization_header {
> + __u8 y_ac_qi;
> + __s8 y_dc_delta;
> + __s8 y2_dc_delta;
> + __s8 y2_ac_delta;
> + __s8 uv_dc_delta;
> + __s8 uv_ac_delta;
> + __u16 padding;
> +};
> +
> +struct v4l2_vp8_entropy_header {
> + __u8 coeff_probs[4][8][3][11];
> + __u8 y_mode_probs[4];
> + __u8 uv_mode_probs[3];
> + __u8 mv_probs[2][19];
> + __u8 padding[3];
> +};
> +
> +struct v4l2_vp8_entropy_coder_state {
> + __u8 range;
> + __u8 value;
> + __u8 bit_count;
> + __u8 padding;
> +};
> +
> +#define V4L2_VP8_FRAME_HEADER_FLAG_KEY_FRAME 0x01
> +#define V4L2_VP8_FRAME_HEADER_FLAG_EXPERIMENTAL 0x02
> +#define V4L2_VP8_FRAME_HEADER_FLAG_SHOW_FRAME0x04
> +#define V4L2_VP8_FRAME_HEADER_FLAG_MB_NO_SKIP_COEFF 0x08
> +#define V4L2_VP8_FRAME_HEADER_FLAG_SIGN_BIAS_GOLDEN 0x10
> +#define V4L2_VP8_FRAME_HEADER_FLAG_SIGN_BIAS_ALT 0x20
> +
> +#define VP8_FRAME_IS_KEY_FRAME(hdr) \
> + (!!((hdr)->flags & V4L2_VP8_FRAME_HEADER_FLAG_KEY_FRAME))
> +
> +struct v4l2_ctrl_vp8_frame_header {
> + struct v4l2_vp8_segment_header segment_header;
> + struct v4l2_vp8_loopfilter_header lf_header;
> + struct v4l2_vp8_quantization_header quant_header;
> + struct v4l2_vp8_entropy_header entropy_header;
> + struct v4l2_vp8_entropy_coder_state coder_state;
> +
> + __u16 width;
> + __u16 height;
> +
> + __u8 horizontal_scale;
> + __u8 vertical_scale;
> +
> + __u8 version;
> + __u8 prob_skip_false;
> + __u8 prob_intra;
> + __u8 prob_last;
> + __u8 prob_gf;
> + __u8 num_dct_parts;
> +
> + __u32 first_part_size;
> + __u32 macroblock_bit_offset;
> + __u32 dct_part_sizes[8];
> +
> + __u64 last_frame_ts;
> + __u64 golden_frame_ts;
> + __u64 alt_frame_ts;
> +
> + __u64 flags;
> +};
> +
> +#endif
I don't think any of my comments strictly requires a v3, could be later
enhancements. You told me you wrote and ran a test for 32/64
compatibility, so I on did a light visual check.
(even if you already got that from Tomasz)
Reviewed-by: Nicolas Dufresne
signature.asc
Description: This is a digitally signed message part
Le mercredi 03 juillet 2019 à 18:04 +0900, Tomasz Figa a écrit :
> On Wed, Jun 5, 2019 at 12:19 AM Nicolas Dufresne wrote:
> > Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit :
> > > Since Thomasz was very busy with other things, I've taken over this
> > >
Le vendredi 28 juin 2019 à 10:31 -0400, Nicolas Dufresne a écrit :
> Le vendredi 28 juin 2019 à 16:25 +0200, Hans Verkuil a écrit :
> > On 6/28/19 4:23 PM, Stanimir Varbanov wrote:
> > > Hi Hans,
> > >
> > > On 6/28/19 4:37 PM, Hans Verkuil wrote:
> >
Le vendredi 28 juin 2019 à 16:25 +0200, Hans Verkuil a écrit :
> On 6/28/19 4:23 PM, Stanimir Varbanov wrote:
> > Hi Hans,
> >
> > On 6/28/19 4:37 PM, Hans Verkuil wrote:
> > > On 6/28/19 2:59 PM, Stanimir Varbanov wrote:
> > > > Hello,
> > > >
> > > > Here is v2 of the Venus transition to statef
Le samedi 15 juin 2019 à 10:08 +0200, Hans Verkuil a écrit :
> On 6/14/19 3:09 AM, Nicolas Dufresne wrote:
> > Le jeudi 13 juin 2019 à 08:48 +0200, Hans Verkuil a écrit :
> > > On 6/3/19 1:28 PM, Hans Verkuil wrote:
> > > > Since Tomasz was very busy with othe
Le jeudi 13 juin 2019 à 08:48 +0200, Hans Verkuil a écrit :
> On 6/3/19 1:28 PM, Hans Verkuil wrote:
> > Since Tomasz was very busy with other things, I've taken over this
> > patch series. This v4 includes his draft changes and additional changes
> > from me.
> >
> > This series attempts to add t
Le mardi 11 juin 2019 à 20:58 -0400, Nicolas Dufresne a écrit :
> Le mardi 11 juin 2019 à 10:52 +0200, Philipp Zabel a écrit :
> > On Wed, 2019-06-05 at 15:39 +0200, Hans Verkuil wrote:
> > > Hi Maxime,
> > >
> > > I am wondering if this
Le mardi 11 juin 2019 à 10:52 +0200, Philipp Zabel a écrit :
> On Wed, 2019-06-05 at 15:39 +0200, Hans Verkuil wrote:
> > Hi Maxime,
> >
> > I am wondering if this flag shouldn't be inverted: you set
> > V4L2_FMT_FLAG_DYN_RESOLUTION if dynamic resolution is supported,
> > otherwise it isn't.
> >
Le mardi 11 juin 2019 à 10:35 +0200, Hans Verkuil a écrit :
> On 6/10/19 5:57 PM, Nicolas Dufresne wrote:
> > Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit :
> > > Since Thomasz was very busy with other things, I've taken over this
> > > patch series. Th
Le mardi 11 juin 2019 à 10:29 +0200, Hans Verkuil a écrit :
> On 6/10/19 9:54 PM, Nicolas Dufresne wrote:
> > Hi Hans,
> >
> > I went through it, and I think we are close to ready. Unfortunately, I
> > believe the SOURCE_CHANGE event is still under specified. There was
Hi Hans,
I went through it, and I think we are close to ready. Unfortunately, I
believe the SOURCE_CHANGE event is still under specified. There was a
post recently to try and add a new flag for changes in color space
which is not included here. We are also missing a workflow for changes
that don't
Le lundi 03 juin 2019 à 13:28 +0200, Hans Verkuil a écrit :
> Since Thomasz was very busy with other things, I've taken over this
> patch series. This v4 includes his draft changes and additional changes
> from me.
>
> This series attempts to add the documentation of what was discussed
> during Me
1 - 100 of 204 matches
Mail list logo
