On Mon, Jul 23, 2018 at 03:35:34PM -0700, Dmitry Torokhov wrote:
> On Fri, Jul 20, 2018 at 10:51:19PM +0100, Nick Dyer wrote:
> > From: Nick Dyer
> >
> > We use sscanf to parse the configuration file, so it's necessary to zero
> > terminate the configuration othe
From: Nick Dyer
If T9.CTRL DISAMP is set, then pressure is reported as zero. This means
some app layers (eg tslib) will ignore the contact.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/input/touchscreen
From: Nick Dyer
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index dcafb812ee7e..92661aa910ae 100644
--- a
From: Nick Dyer
input_mt_report_slot_state() ignores the tool when the slot is closed.
Remove the tool type from these function calls, which has caused a bit of
confusion.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 5 ++---
1 file changed, 2 insertions(+), 3
From: Nick Dyer
We use sscanf to parse the configuration file, so it's necessary to zero
terminate the configuration otherwise a truncated file can cause the
parser to run off into uninitialised memory.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c
From: Nick Dyer
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index c31af790ef84..9f296a66c94e 100644
--- a
From: Nick Dyer
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 108 ---
1 file changed, 56 insertions(+), 52 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index 560d4997ef8c
From: Nick Dyer
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index 9555947a2d46..dcafb812ee7e 100644
--- a/drivers/input
From: Nick Dyer
The driver only registers one input device, which uses the screen
parameters from the first T9 instance. The first T63 instance also uses
those parameters.
It is incorrect to send input reports from the second instances of these
objects if they are enabled: the input scaling
From: Nick Dyer
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 36
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index 48c5ccab00a0
From: Nick Dyer
On devices with the T71 object, the config CRC will start there, rather
than at T7.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 34 +++-
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/drivers/input/touchscreen
On Wed, Jul 18, 2018 at 06:21:30PM +0200, Paweł Chmiel wrote:
> On Tuesday, July 17, 2018 10:00:05 PM CEST Nick Dyer wrote:
> > On Tue, Jul 17, 2018 at 08:16:25PM +0200, Paweł Chmiel wrote:
> > > This patch adds optional regulators, which can be used to power
> > > up
On Tue, Jul 17, 2018 at 08:16:25PM +0200, Paweł Chmiel wrote:
> This patch adds optional regulators, which can be used to power
> up touchscreen. After enabling regulators, we need to wait 150msec.
> This value is taken from official driver.
>
> It was tested on Samsung Galaxy i9000 (based on Sams
The RMI4 touchscreen driver applied inversion and axis swap in the
wrong order, violating the DT binding for those properties. This was fixed in
645a397, so correct the RDU1 DT to apply the inversion to the
correct axis.
Tested on Zii RDU1 00-5105-30 rev B
Signed-off-by: Nick Dyer
---
arch/arm
.
Signed-off-by: Nick Dyer
Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
Cc: # 4.15+
Reviewed-by: Fabio Estevam
Tested-by: Chris Healy
---
Changes in v5:
- Add tested by Chris Healy
Changes in v4:
- Add reviewed by Fabio
Changes in v3:
- Update commit message to add source of
.
Signed-off-by: Nick Dyer
Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
Cc: # 4.15+
Reviewed-by: Fabio Estevam
---
Changes in v4:
- Add reviewed by Fabio
Changes in v3:
- Update commit message to add source of 0x4 value, fixes tag and CC stable
Changes in v2:
- Use hex, only
.
Signed-off-by: Nick Dyer
Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
Cc: # 4.15+
---
Changes in v3:
- Update commit message to add source of 0x4 value, fixes tag and CC stable
Changes in v2:
- Use hex, only alter IRQ line config
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2
The pinctrl settings were incorrect for the touchscreen interrupt line, causing
an interrupt storm. This change has been tested with both the atmel_mxt_ts and
RMI4 drivers on the RDU1 units.
[v2: Use hex, only alter IRQ line config]
Signed-off-by: Nick Dyer
---
arch/arm/boot/dts/imx51-zii-rdu1
The pinctrl settings were incorrect for the touchscreen interrupt line, causing
an interrupt storm. This change has been tested with both the atmel_mxt_ts and
RMI4 drivers on the RDU1 units.
Signed-off-by: Nick Dyer
---
arch/arm/boot/dts/imx51-zii-rdu1.dts | 4 ++--
1 file changed, 2 insertions
On Fri, Apr 20, 2018 at 09:42:07PM +0200, Sebastian Reichel wrote:
> On Fri, Apr 20, 2018 at 02:44:02PM -0300, Ezequiel Garcia wrote:
> > Hi Sebastian,
> >
> > On Fri, 2018-04-20 at 19:24 +0200, Sebastian Reichel wrote:
> > > The current reset-gpio support triggers an interrupt storm on platforms
should solve your issue.
It also has the benefit that by reading the information block and the
object table into a contiguous region of memory, we can verify the
checksum at probe time. This means we make sure that we are indeed
talking to a chip that supports object protocol correctly.
Signed-off-by
On Sat, Mar 17, 2018 at 10:42:40AM -0700, Dmitry Torokhov wrote:
> On Fri, Mar 16, 2018 at 08:40:02PM +0000, Nick Dyer wrote:
> > On Thu, Mar 15, 2018 at 04:56:21PM -0700, Dmitry Torokhov wrote:
> > > Ah, OK, I see. I would really like to drop this
> > > pdata->suspen
On Thu, Mar 15, 2018 at 04:56:21PM -0700, Dmitry Torokhov wrote:
> On Wed, Mar 14, 2018 at 08:51:24PM +0000, Nick Dyer wrote:
> > On Mon, Mar 12, 2018 at 12:08:54PM -0700, Dmitry Torokhov wrote:
> > > The way we are supposed to put controller to sleep and wake it up does not
&
On Thu, Mar 15, 2018 at 05:06:14PM -0700, Dmitry Torokhov wrote:
> On Wed, Mar 14, 2018 at 08:59:38PM +0000, Nick Dyer wrote:
> > On Mon, Mar 12, 2018 at 12:09:07PM -0700, Dmitry Torokhov wrote:
> > > - /*
> > > - * Ignore ACPI devices representing bootloader mode.
>
Hi Dmitry-
Thanks for sending these patches!
On Mon, Mar 12, 2018 at 12:08:54PM -0700, Dmitry Torokhov wrote:
> The way we are supposed to put controller to sleep and wake it up does not
> depend on the platform, but rather on controller itself. Controllers using
> T9 require manipulating T9 cont
move support for platform data later on, leaving only generic device
> properties in place.
>
> Signed-off-by: Dmitry Torokhov
Acked-by: Nick Dyer
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 63 +++-
> 1 file changed, 40 insertions(+), 23 deletion
On Mon, Mar 12, 2018 at 12:09:07PM -0700, Dmitry Torokhov wrote:
> Date: Mon, 12 Mar 2018 12:09:07 -0700
> From: Dmitry Torokhov
> To: linux-in...@vger.kernel.org, Benson Leung
> Cc: Nick Dyer , Olof Johansson ,
> linux-kernel@vger.kernel.org
> Subject: [PATCH 14/14] I
own
> the road.
>
> Signed-off-by: Dmitry Torokhov
Acked-by: Nick Dyer
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 59
> 1 file changed, 30 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
> b
On Wed, Jan 24, 2018 at 07:28:44PM +0100, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Signed-off-by: Nick Dyer
> ---
>
On Sun, Jan 21, 2018 at 10:33:50PM +0100, SF Markus Elfring wrote:
> Omit extra messages for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Thanks!
Signed-off-by: Nick Dyer
&
R_MM going to cause issues on this new
device?
I think you need to add this to
Documentation/devicetree/bindings/input/atmel,maxtouch.txt
Reviewed-by: Nick Dyer
> Signed-off-by: Emil Renner Berthing
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++--
> include/linux/platfo
On Sun, Oct 08, 2017 at 07:44:18PM +0100, Christos Gkekas wrote:
> Variable byte_offset is unsigned so checking whether it is greater or
> equal to zero is redundant.
>
> Signed-off-by: Christos Gkekas
Yep - looks sensible to me.
Signed-off-by: Nick Dyer
> ---
> drivers
On Tue, Jun 27, 2017 at 06:24:38PM +0200, Sebastian Reichel wrote:
> At least some of the Atmel Maxtouch touchscreen controllers have a reset
> pin. If this is not driven correctly the device will be held in reset
> and will not respond.
>
> Add support for driving the reset line via GPIO as is fo
with the I2C controller or touchpad were addressed in:
> commit 5b65c2a02966 ("HID: rmi: check sanity of the incoming report")
>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195949
> Signed-off-by: Andrew Duggan
Looks fine to me.
Reviewed-by: Nick Dyer
> ---
&g
> Reviewed-by: Benjamin Tissoires
>
> Hm, I just realized taht we'd go from upper to lowercase hex digits. I
> think it should be OK, but I'd like to hear interested parties (Nick).
>
> Or we'd need to introduce %pH I guess.
Hi Dmitry-
I can't see any issue wit
On Mon, Mar 13, 2017 at 10:10:22PM -0700, Cameron Gutman wrote:
> > Compared to hid-multitouch, the RMI stack seems to have
> > completely broken palm rejection and introduced some random
> > jumpiness during fine pointing motions. I don't know if these
> > issues are caused by the
On Sun, Feb 12, 2017 at 04:02:51PM -0800, Dmitry Torokhov wrote:
> On Sun, Feb 12, 2017 at 10:50:56PM +0000, Nick Dyer wrote:
> > On Thu, Feb 09, 2017 at 01:25:08PM -0800, Dmitry Torokhov wrote:
> > > There is no need to create sysfs attributes in the main driver core,
> >
On Thu, Feb 09, 2017 at 01:25:08PM -0800, Dmitry Torokhov wrote:
> There is no need to create sysfs attributes in the main driver core,
> let F34 implementation do that.
Hi Dmitry-
I haven't tested this yet, but I did try creating/removing the sysfs
entries in the f34 function probe/remove as you
On Sun, Dec 11, 2016 at 12:03:49AM -0800, Dmitry Torokhov wrote:
> On Sun, Dec 11, 2016 at 12:18:26AM +0000, Nick Dyer wrote:
> > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data
> > *f34,
> > +
Port firmware update code from Samsung Galaxy S7 driver into
mainline framework.
This patch has been tested on Synaptics S7813.
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
Changes in v9:
- Fix strangeness introduced in conversion to proper le32_to_cpu() APIs
- Various other minor
On Wed, Dec 07, 2016 at 06:14:18PM -0800, Dmitry Torokhov wrote:
> On Mon, Dec 05, 2016 at 01:02:49AM +0000, Nick Dyer wrote:
> > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data
> > *f34,
> > +
The debug would only ever output zero for the clip information.
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_f12.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index 8c5360c..e35c64b 100644
--- a
Port firmware update code from Samsung Galaxy S7 driver into
mainline framework.
This patch has been tested on Synaptics S7813.
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
Hi Dmitry-
Thanks for the useful review, here is an updated version.
This patch applies on top of dtor
Port firmware update code from Samsung Galaxy S7 driver into
mainline framework.
This patch has been tested on Synaptics S7813.
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
Hi Dmitry-
Here's an updated version of the F34 V7 support.
This patch applies on top of dtor/synaptics
On Wed, Nov 23, 2016 at 12:20:41PM +0100, Benjamin Tissoires wrote:
> On Nov 20 2016 or thereabouts, Nick Dyer wrote:
> > Add support for updating firmware, triggered by a sysfs attribute.
> >
> > This patch has been tested on Synaptics S7300.
> >
> > Signed
On Tue, Nov 22, 2016 at 05:51:11PM -0800, Dmitry Torokhov wrote:
> On Sun, Nov 20, 2016 at 07:04:02PM +0000, Nick Dyer wrote:
> > + /* query 7 */
> > + unsigned char f34_query7_b0:1;
> > + unsigned
Add support for updating firmware, triggered by a sysfs attribute.
This patch has been tested on Synaptics S7300.
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
drivers/input/rmi4/Kconfig | 11 +
drivers/input/rmi4/Makefile | 1 +
drivers/input/rmi4/rmi_bus.c| 3
Port firmware update code from Samsung Galaxy S7 driver into
mainline framework.
This patch has been tested on Synaptics S7813.
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
drivers/input/rmi4/Makefile |2 +-
drivers/input/rmi4/rmi_driver.c | 56 +-
drivers/input/rmi4/rmi_f34
Hi Dmitry-
Please find an updated set of patches to add F34 firmware update to the RMI4
driver.
Changes in v6:
- Properly free irq_memory in rmi_free_function_list()
- Split out the sysfs changes for now
- Various coding style improvements to the V7 patch (now checkpatch clean)
Changes in v5:
-
F54 to avoid
> corrupted output if not all electrodes are enabled.
>
> Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54
> ...")
> Cc: Nick Dyer
> Cc: Andrew Duggan
> Cc: Chris Healy
> Signed-off-by: Guenter Roeck
Tested-by: Nick Dye
: synaptics-rmi4 - add support for F54
> ...")
> Signed-off-by: Guenter Roeck
Hi Guenter-
I've tested this patch on s7813 and it works correctly.
Tested-by: Nick Dyer
> ---
> v2: Drop unnecessary include files
> Only read required number of query elements
> Ad
mi4 - f30/f03: Forward mechanical buttons on
> > buttonpads to PS/2 guest
> > Input: synaptics - allocate a Synaptics Intertouch device
> > Input: synaptics-rmi4 - add rmi_platform
> > Input: synaptics-rmi4 - smbus: call psmouse_deactivate before
> > binding/resume
> > Inp
We have encountered some RMI4 firmwares where there are blank pages in
between PDT pages which contain functions. This change makes them
correctly enumerate all functions on the device.
Tested on S7817 (has empty page 2).
Signed-off-by: Nick Dyer
[Tested successfully on S7817 and S7300
We have encountered some RMI4 firmwares where there are blank pages in
between PDT pages which contain functions. This change makes them
correctly enumerate all functions on the device.
Tested on S7817 (has empty page 2).
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_driver.c | 16
We have encountered some RMI4 firmwares where there are blank pages in between
PDT pages which contain functions. Add a device tree property which can be set
to force reading the first N pages.
Signed-off-by: Nick Dyer
---
Documentation/devicetree/bindings/input/rmi4/rmi_i2c.txt | 2
Port firmware update code from Samsung Galaxy S7 driver into
mainline framework.
This patch has been tested on Synaptics S7813.
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/Makefile |2 +-
drivers/input/rmi4/rmi_driver.c | 56 +-
drivers/input/rmi4/rmi_f34.c| 53 +-
drivers
Hi-
Please find attached patches to add F34 firmware update to the RMI4
driver.
Changes in v5:
- Improve split between for different versions (req. Bjorn Andersson)
- Address a couple of kbuild test robot issues
- Fix a bug with configuration ID on V7
Changes in v4:
- Add support for v7 bootload
The status is the percentage complete, or once complete, zero for
success or a negative return code.
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_f34.c | 34 ++
drivers/input/rmi4/rmi_f34.h | 4
drivers/input/rmi4/rmi_f34v7.c | 14
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_bus.c| 3 +++
drivers/input/rmi4/rmi_driver.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
index ef8c747..3c6a1b5 100644
--- a/drivers/input/rmi4/rmi_bus.c
+++ b/drivers
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_driver.h | 1 +
drivers/input/rmi4/rmi_f01.c| 24 +++-
drivers/input/rmi4/rmi_f34.c| 16
3 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers
Add support for updating firmware, triggered by a sysfs attribute.
This patch has been tested on Synaptics S7300.
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
drivers/input/rmi4/Kconfig | 11 +
drivers/input/rmi4/Makefile | 1 +
drivers/input/rmi4/rmi_bus.c| 3
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_driver.c | 2 +-
drivers/input/rmi4/rmi_driver.h | 5 +-
drivers/input/rmi4/rmi_f01.c| 23 -
drivers/input/rmi4/rmi_f34.c| 110
4 files changed, 137 insertions(+), 3 deletions
Signed-off-by: Nick Dyer
Signed-off-by: Benjamin Tissoires
---
drivers/input/rmi4/rmi_driver.c | 139 +---
1 file changed, 86 insertions(+), 53 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 4a88312..63c9e22
On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote:
> On Fri, Sep 30, 2016 at 08:22:47PM -0700, Guenter Roeck wrote:
> > Sensor tuning support is needed to determine the number of enabled
> > tx and rx electrodes for use in F54 functions.
> >
> > The number of enabled electrodes is not
Hi-
Apologies, I think I hit send too soon on the previous email.
Please find attached patches to add F34 firmware update to the RMI4
driver.
Changes in v4:
- Add support for v7 bootloaders and fix numerous issues
- Add sysfs attributes for retrieving various hardware IDs
- Add a couple of debug
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_driver.c | 2 +-
drivers/input/rmi4/rmi_driver.h | 5 +-
drivers/input/rmi4/rmi_f01.c| 23 -
drivers/input/rmi4/rmi_f34.c| 112
4 files changed, 139 insertions(+), 3 deletions
Port firmware update code from Samsung Galaxy S7 driver into
mainline framework.
This patch has been tested on Synaptics S7813.
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/Makefile |2 +-
drivers/input/rmi4/rmi_driver.c | 56 +-
drivers/input/rmi4/rmi_f34.c| 146
Add support for updating firmware, triggered by a sysfs attribute.
This patch has been tested on Synaptics S7300.
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
drivers/input/rmi4/Kconfig | 11 +
drivers/input/rmi4/Makefile | 1 +
drivers/input/rmi4/rmi_bus.c| 3
The status is the percentage complete, or once complete, zero for
success or a negative return code.
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_f34.c | 34 ++
drivers/input/rmi4/rmi_f34.h | 4
drivers/input/rmi4/rmi_f34v7.c | 14
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_bus.c| 3 +++
drivers/input/rmi4/rmi_driver.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
index ef8c747..3c6a1b5 100644
--- a/drivers/input/rmi4/rmi_bus.c
+++ b/drivers
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_driver.h | 1 +
drivers/input/rmi4/rmi_f01.c| 24 +++-
drivers/input/rmi4/rmi_f34.c| 16
3 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers
Signed-off-by: Nick Dyer
Signed-off-by: Benjamin Tissoires
---
drivers/input/rmi4/rmi_driver.c | 139 +---
1 file changed, 86 insertions(+), 53 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 4a88312..63c9e22
On Thu, Oct 13, 2016 at 03:52:45PM +0200, Benjamin Tissoires wrote:
> > > You could basically export rmi_fn_reset() which would call
> > > rmi_free_function_list(), rmi_scan_pdt (if initial reset),
> > > rmi_probe_interrupts() and rmi_init_functions, and this would allow you
> > > to have all this
Hi Benjamin-
Thanks for the review, I've answered in line.
On Mon, Oct 10, 2016 at 03:48:07PM +0200, Benjamin Tissoires wrote:
> On Sep 20 2016 or thereabouts, Nick Dyer wrote:
> > Signed-off-by: Nick Dyer
> > Tested-by: Chris Healy
> > ---
> > drive
Hi-
Please find attached patches to add F34 firmware update to the RMI4 driver.
Git tree here:
https://github.com/ndyer/linux/commits/synaptics-fw-update-v3-2016-09-20
Changes in v3:
- Only attempt to flash on F34 V0 (later versions have different register map)
Changes in v2:
- Resolved reliabi
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_driver.c | 139 +---
1 file changed, 86 insertions(+), 53 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index c83bce8..f17bfe0 100644
--- a/drivers/input/rmi4
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
drivers/input/rmi4/Kconfig | 11 +
drivers/input/rmi4/Makefile | 1 +
drivers/input/rmi4/rmi_bus.c| 3 +
drivers/input/rmi4/rmi_driver.c | 161 ++-
drivers/input/rmi4/rmi_driver.h | 7 +
drivers/input/rmi4
x27;s actually possible to call it.
>
> Signed-off-by: Arnd Bergmann
> Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54
> diagnostics")
Acked-by: Nick Dyer
> ---
> drivers/input/rmi4/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 d
Hi Hans-
Please could you apply this patch to your media_tree/touch branch before it
goes to v4.9 if possible.
Thanks
Add copyright lines for Zodiac who paid for the V4L touch work.
Signed-off-by: Nick Dyer
---
drivers/input/rmi4/rmi_f54.c | 1 +
drivers/input/touchscreen
mode unless it's actually possible to call it.
>
> Signed-off-by: Arnd Bergmann
> Fixes: ecfdd7e2660e ("[media] Input: atmel_mxt_ts - output diagnostic debug
> via V4L2 device")
Acked-by: Nick Dyer
> ---
> drivers/input/touchscreen/Kconfig | 3 ++-
> 1 file
[v2: Fix minor issues and document V4L2_INPUT_TYPE_TOUCH and V4L2_CAP_TOUCH]
Signed-off-by: Nick Dyer
---
Documentation/media/uapi/mediactl/media-types.rst | 24 +++--
Documentation/media/uapi/v4l/dev-touch.rst| 56 +++
Documentation/media/uapi/v4l/devices.rst | 1
Signed-off-by: Nick Dyer
On 12 August 2016 10:41:08 BST, Hans Verkuil wrote:
>Hi Nick,
>
>On 07/18/2016 11:10 PM, Nick Dyer wrote:
>> Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards
>> compatibility.
>>
>> Note: I have not tested these
There are different datatypes available from a maXTouch chip. Add
support to retrieve reference data as well.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 57 ++
1 file changed, 51 insertions(+), 6 deletions(-)
diff --git a/drivers/input
touch data
- V4L2_TCH_FMT_TU08 for unsigned 8-bit touch data
This support will be used by:
- Atmel maXTouch (atmel_mxt_ts)
- Synaptics RMI4.
- sur40
Signed-off-by: Nick Dyer
Tested-By: Chris Healy
---
drivers/media/media-entity.c |2 ++
drivers/media/v4l2-core/v4l2-dev.c | 16
Signed-off-by: Nick Dyer
---
utils/v4l2-compliance/v4l2-compliance.cpp| 51 +-
utils/v4l2-compliance/v4l2-compliance.h |1 +
utils/v4l2-compliance/v4l2-test-input-output.cpp |4 +-
3 files changed, 53 insertions(+), 3 deletions(-)
diff --git a
The mXT1386 family of chips have a different architecture which splits
the diagnostic data into 3 columns.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 31 +++---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/drivers/input
This is a series of patches to add output of raw touch diagnostic data via V4L2
to the Atmel maXTouch and Synaptics RMI4 drivers.
It's a rewrite of the previous implementation which output via debugfs: it now
uses a V4L2 device in a similar way to the sur40 driver.
We have a utility which can rea
I'm leaving ITDev, so change to my personal email. My understanding is
that someone at Atmel will take this on once their takeover by Microchip
has settled down.
Signed-off-by: Nick Dyer
---
MAINTAINERS |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAIN
Atmel maXTouch devices have a T37 object which can be used to read raw
touch deltas from the device. This consists of an array of 16-bit
integers, one for each node on the touchscreen matrix.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/Kconfig|6 ++
drivers/input
Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards
compatibility.
Note: I have not tested these changes (I have no access to the hardware)
so not signing off.
---
drivers/input/touchscreen/sur40.c | 122 +++--
1 file changed, 89 insertions(+), 33 d
Invert the diagnostic data to match the orientation of the input device.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers
Function 54 implements access to various RMI4 diagnostic features.
This patch adds support for retrieving this data. It registers a V4L2
device to output the data to user space.
Signed-off-by: Nick Dyer
Tested-by: Andrew Duggan
Tested-by: Chris Healy
---
drivers/input/rmi4/Kconfig
The touchscreen may have a margin where not all the matrix is used. Read
the parameters from T9 and T100 and take account of the difference.
Note: this does not read the XORIGIN/YORIGIN fields so it assumes that
the touchscreen starts at (0,0)
Signed-off-by: Nick Dyer
---
drivers/input
Register a video device to output T37 diagnostic data.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/Kconfig|6 +-
drivers/input/touchscreen/atmel_mxt_ts.c | 245 ++
2 files changed, 249 insertions(+), 2 deletions(-)
diff --git a/drivers/input
---
drivers/input/rmi4/rmi_driver.c | 139 ---
1 file changed, 86 insertions(+), 53 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index faa295e..543cf7a 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/in
Signed-off-by: Nick Dyer
Tested-by: Chris Healy
---
drivers/input/rmi4/Kconfig | 11 +
drivers/input/rmi4/Makefile |1 +
drivers/input/rmi4/rmi_bus.c|3 +
drivers/input/rmi4/rmi_driver.c | 157 +-
drivers/input/rmi4/rmi_driver.h |6 +
drivers/input/rmi4
Hi Dmitry/Andrew-
Please find attached patches to add F34 firmware update to the RMI4 driver.
Git tree here:
https://github.com/ndyer/linux/commits/synaptics-fw-update-v2-2016-07-08
Changes in v2:
- Resolved reliability issues with locking and teardown/re-probe
- Add #ifdefs for CONFIG_RMI4_F34
Invert the diagnostic data to match the orientation of the input device.
Signed-off-by: Nick Dyer
---
drivers/input/touchscreen/atmel_mxt_ts.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers
Signed-off-by: Nick Dyer
---
utils/v4l2-compliance/v4l2-compliance.cpp| 51 +-
utils/v4l2-compliance/v4l2-compliance.h |1 +
utils/v4l2-compliance/v4l2-test-input-output.cpp |4 +-
3 files changed, 53 insertions(+), 3 deletions(-)
diff --git a
I'm leaving ITDev, so change to my personal email. My understanding is
that someone at Atmel will take this on once their takeover by Microchip
has settled down.
Signed-off-by: Nick Dyer
---
MAINTAINERS |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAIN
1 - 100 of 487 matches
Mail list logo
