[PATCH] csiostor:Fix error handling in the function csio_hws_ready

2015-08-04 Thread Nicholas Krause
From: Nicholas Krause This fixes error handling in the function csio_hws_ready for when this function calls csio_scim_cleanup_io to cleanup outstanding commands by checking if it cleaned a error code to signal internal failure and if so tell the user we are unable to clean up the outstanding io

[PATCH] ipv6:Fix concurrent access issue in the function inet6_rtm_deladdr

2015-08-04 Thread Nicholas Krause
From: Nicholas Krause This fixes the issue with conncurrent access when calling the function inte6_addr_del due to this function using non locked wrapper versions of certain functions by locking the routing mutex before and after this call with rtnl_lock/unlock. After the unlocking just return

[PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume

2014-09-27 Thread Nicholas Krause
This removes the FIXME message and issue with reading in this driver before resuming in the function, sa_resume. Signed-off-by: Nicholas Krause --- arch/arm/common/sa.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c index

[PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c

2014-09-27 Thread Nicholas Krause
This removes the unnecessary overwrite of register 11 in the function, rt2800_config_channel as we are already writing a correct value to the register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). Signed-off-by: Nicholas Krause --- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed

Re: FIXMEs in rt2800lib.c

2014-09-26 Thread Nicholas Krause
On Fri, Sep 26, 2014 at 8:22 AM, Stanislaw Gruszka wrote: > On Thu, Sep 25, 2014 at 01:52:43PM -0400, nick wrote: >> I seem to be hitting to fix mes in the file I listed in the subject. Would >> someone tell me if it's Ok to remove >> the lines that over write certain registers. > > No, as long y

Re: [PATCH] parisc:Remove unnecessary FIXMES in init.c

2014-09-24 Thread Nicholas Krause
On Wed, Sep 24, 2014 at 8:42 AM, John David Anglin wrote: > On 24-Sep-14, at 7:42 AM, nick wrote: > >> >> >> On 14-09-24 01:30 AM, Guenter Roeck wrote: >>> >>> On Tue, Sep 23, 2014 at 09:49:43PM -0400, Nicholas Krause wrote: >>>> >>>

[PATCH] parisc:Remove unnecessary FIXMES in init.c

2014-09-23 Thread Nicholas Krause
This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints. Signed-off-by: Nicholas

Re: FIX Me in pgtable.h

2014-09-23 Thread Nicholas Krause
I don't have any hardware to test this over, however I can emulate a arm system over qemu if needed. I was just trying to help out if we need hardware I can't test and again I am sorry for the terrible patches. It was never my goal to be a nuisance. Nick On Tue, Sep 23, 2014 at 9:46 AM, Krzysztof K

[PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Nicholas Krause
This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Signed-off-by: Nicholas Krause --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nicholas Krause
This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order to avoid a bug with xhci dequence/enquence functions. Signed-off-by: Nicholas Krause --- include/linux/scatterlist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/scatterlist.h b

[PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-07-31 Thread Nicholas Krause
This adds checks for the stated modes as if they are crap we will return error not supported. Signed-off-by: Nicholas Krause --- fs/btrfs/file.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 1f2b99c..599495a 100644 --- a/fs

[PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Nicholas Krause
: Nicholas Krause --- fs/btrfs/compression.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 1daea0b..b55b0e1 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -1,4 +1,5

[PATCH] staging: Remove checkpatch errors in InterfaceMarcos.h

2014-07-23 Thread Nicholas Krause
This removes the two errors I get when running checkpatch on this file. The first being not to use C99 comments and the second to remove spacing issues with the define statement on line 7. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/InterfaceMacros.h | 4 ++-- 1 file changed, 2

[PATCH] staging: Join lines in IntefaceIdleMode.c

2014-07-23 Thread Nicholas Krause
This joins two lines that need to be joined as this improves the coding style and makes it much easier to read. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/InterfaceIdleMode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/bcm

[PATCH] staging: Fix space issues for header of headers.h

2014-07-23 Thread Nicholas Krause
This patch fixes the space errors checkpatch gives on this file for the header of this file. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/headers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/headers.h b/drivers/staging/bcm/headers.h index

[PATCH] staging: Add blank line in sync.c

2014-07-23 Thread Nicholas Krause
This patch adds a blank line after line 708 as declared when running checkpatch on this file. Signed-off-by: Nicholas Krause --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index e7b2e02

[PATCH] staging: Add blank lines in sw_sync.c

2014-07-23 Thread Nicholas Krause
This adds two blank lines as stated by checkpatch before lines, 100 and 159 respectively. Signed-off-by: Nicholas Krause --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index

[PATCH] staging: Remove checkpatch error from ion.c

2014-07-23 Thread Nicholas Krause
This patch removes a checkpatch error by adding a line below the definitions of the character array buf and the pointer path. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers

[PATCH] staging: Change kzalloc to kcalloc

2014-07-23 Thread Nicholas Krause
This changes the call to kzalloc to kcalloc in ion_dummy_driver for allocating the heap. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b

[PATCH] staging: Remove checkpatch errors in ion.c for android staging

2014-07-23 Thread Nicholas Krause
emory allocated in ion_dma_buf_kmap. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 389b8f6..934d55d 100644 --- a/drivers/staging/android/ion/ion.c

[PATCH] avr32: Remove unnessary variables from page.h

2014-07-22 Thread Nicholas Krause
This removes the unneeded variables memory_start and memory_end in order to fix this fix me message. Signed-off-by: Nicholas Krause --- arch/avr32/include/asm/page.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/avr32/include/asm/page.h b/arch/avr32/include/asm/page.h index f805d1c

[PATCH] microblaze: Add comment for defines

2014-07-22 Thread Nicholas Krause
This adds a comment for and removes a fix me by labeling these defines as memory cache definitions. Signed-off-by: Nicholas Krause --- arch/microblaze/include/asm/pvr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/include/asm/pvr.h b/arch/microblaze

[PATCH] m68k: Remove printk statement and add return statement in q40ints.c

2014-07-22 Thread Nicholas Krause
This removes the printk statement for irqs not defined by the hardware in function q40_irq_startup and instead returns -ENXIO as stated by the fix me message. Signed-off-by: Nicholas Krause --- arch/m68k/q40/q40ints.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch

[PATCH] x86: Remove Fix me in main.c and add include statement for kvm_para.h

2014-07-22 Thread Nicholas Krause
This patch removes a fix me by including linux/types.h in kvm_para.h as stated by the fix me in main.c and also removes the comment from main.c too. Signed-off-by: Nicholas Krause --- arch/x86/kernel/cpu/mtrr/main.c | 2 +- include/linux/kvm_para.h| 3 +-- 2 files changed, 2 insertions

[PATCH] drbd: Remove fix me statements

2014-07-22 Thread Nicholas Krause
This removes no longer needed fix me statements as the spinlocks are needed to protect against other users of the list accessing it when items on it are being moved off it. Signed-off-by: Nicholas Krause --- drivers/block/drbd/drbd_worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] s390: Fix me in dasd_eer.c

2014-07-21 Thread Nicholas Krause
This patch changes return type to EMEDUIMTYPE in function, dasd_eer_enable for when checking if the medium has no errors according to this function. Signed-off-by: Nicholas Krause --- drivers/s390/block/dasd_eer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390

[PATCH] edac: Remove fixmes in e7xxx_edac.c

2014-07-21 Thread Nicholas Krause
This removes two Page shift fixs me in this file and not checking if row is -1 in process_ce as it cannot be this value or be must exit this function by returning. Signed-off-by: Nicholas Krause --- drivers/edac/e7xxx_edac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH] arm: Fix me in bios32.c

2014-07-19 Thread Nicholas Krause
This fixs a fix me in bios32.c for pci_fixup_it8152 as this if statement is incorrect needs to be checked against the class bits not the whole address for the two or conditions and since they don't have define statements outside of their numeratical value. Signed-off-by: Nicholas K

[PATCH] mips: Remove uneeded line in cmp_smp_finish

2014-07-18 Thread Nicholas Krause
This patch removes a unneeded line from this file as stated by the fix me in this file. Signed-off-by: Nicholas Krause --- arch/mips/kernel/smp-cmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/mips/kernel/smp-cmp.c b/arch/mips/kernel/smp-cmp.c index fc8a515..61bfa20 100644 --- a

[PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nicholas Krause
The comment for size of frame not being needed is incorrect , the function called needs this parameter. Signed-off-by: Nicholas Krause --- arch/parisc/kernel/signal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c index 1cba8f2

[PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nicholas Krause
I am removing two fix mes in this file as after dicussing then it seems there is no reason to check against Null for usb_device as it can never be NULL and this is check is therefore not needed. Signed-off-by: Nicholas Krause --- drivers/usb/core/hcd.c | 4 1 file changed, 4 deletions

[PATCH] ia64: Fix me add register r8

2014-07-17 Thread Nicholas Krause
The function user_stack_pointer was not returning the correct value \ as stated by a Fix Me message before the function declaration. I fixed the return value to add register r8 as that register stores dirty pages. Signed-off-by: Nicholas Krause --- arch/ia64/include/asm/ptrace.h | 3 +-- 1 file

[PATCH] m68k: Remove unneeded FIXME message in sun3_pgalloc.h

2014-07-16 Thread Nicholas Krause
This removes a FIX ME message due to this file not compiling. Now that this message is no longer needed I am removing it from sun3_pgalloc.h. Signed-off-by: Nicholas Krause --- arch/m68k/include/asm/sun3_pgalloc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/m68k/include/asm

[PATCH 2/4] alpha: checkpatch errors in mkbb for if statements

2014-07-15 Thread Nicholas Krause
This patch fixes all errors related to no space between if and parthesises to remove this errors when running checkpatch against this file. --- arch/alpha/boot/tools/mkbb.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/alpha/boot/tools/mkbb.c b/arch/alpha/

[PATCH 3/4] alpha: Indent if Statements properly

2014-07-15 Thread Nicholas Krause
This patch removes the errors this file gets with checkpatch due to errors relating to if statements and their enclosing statements not being indented properly. --- arch/alpha/boot/tools/mkbb.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a

[PATCH 1/4] alpha: Converse all space errors into tabs in mkbb.c

2014-07-15 Thread Nicholas Krause
This patch fixes all the checkpatch errors I get when running it on mkbb.c for spaces at beginning of lines. I converted then all to tabs to fix these checkpatch warnings. --- arch/alpha/boot/tools/mkbb.c | 124 +-- 1 file changed, 61 insertions(+), 63 delet

[PATCH 4/4] alpha: Remove checkpatch error in mkk.b

2014-07-15 Thread Nicholas Krause
This removes a error I get when I run checkpatch on this file, relating to the asterisk for declaritations needing to be next to the name of the variable/structure and not the type of variable/structure. --- arch/alpha/boot/tools/mkbb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 6/6 v2] alpha: Join lines and merge strings for the two lines

2014-07-15 Thread Nicholas Krause
This patch merges lines 92 and 93. In addition it merges the strings on both lines by removing the quotes around the seperate strings. This is needed to remove the final checkpatch error I get from running it on bootpz.c Signed-off-by: Nicholas Krause --- arch/alpha/boot/bootpz.c | 3 +-- 1

[PATCH 2/5] alpha: Fix spacing in misc.c

2014-07-15 Thread Nicholas Krause
Due to errors with checkpatch in this file I am checking certain defintions spacing to pass checkpatch for spacing issues. --- arch/alpha/boot/misc.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index

[PATCH 5/5] alpha: Fix while statement

2014-07-15 Thread Nicholas Krause
This fixes the if statement on line 147 of misc.c to have parthesises around itself removing a checkpatch error on this line. --- arch/alpha/boot/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 886e469..56c3325 100644

[PATCH 4/5] alpha: Fix complex marco definitions

2014-07-15 Thread Nicholas Krause
This patch fixes all macro defintions that need parthesises as stated by checkpatch when run against this file. --- arch/alpha/boot/misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 174b7c6..886e469 100644 --- a/a

[PATCH 3/5] alpha: Remove whitespace errors that cleanfile missed

2014-07-15 Thread Nicholas Krause
This patch removes the whitespace error that cleanfile missed when I ran it on this file. --- arch/alpha/boot/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 119d500..174b7c6 100644 --- a/arch/alpha/boot/misc.c +++ b/

[PATCH 1/5] alpha: checkpatch whitespace errors in misc.c

2014-07-15 Thread Nicholas Krause
This patch runs cleanfile against this file in order to remove all outstanding whitespace errors caught when I ran checkpatch on it. --- arch/alpha/boot/misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/boot/misc.c b/arch/alpha/boot/misc.c index 3ff9a95..3

[PATCH 4/6] alpha: Remove bracket errors in bootpz.c

2014-07-15 Thread Nicholas Krause
This patch removes all errors related to brackets not being placed correctly in this file as declared when running checkpatch on it. --- arch/alpha/boot/bootpz.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootp

[PATCH 5/6] alpha: Add line below declartion on line 287

2014-07-15 Thread Nicholas Krause
This patch adds a line before the declartion of asm_sp in order to fix a checkpatch error I get when running it on this file. --- arch/alpha/boot/bootpz.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6dd34e4..6fc840d 100644 --- a/arc

[PATCH 3/6] alpha: Remove all errors for checkpatch foo* bar

2014-07-15 Thread Nicholas Krause
This patch changes all issues with checkpatch relating to the asterisk not being put next to the variable or structrue name and rather the type of the declaring statement. --- arch/alpha/boot/bootpz.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/alpha/boot/

[PATCH 6/6] alpha: Join lines 90 and 91

2014-07-15 Thread Nicholas Krause
This fixes the checkpatch error I get in this file relating to a quoted string needed to be joined to the line above it. --- arch/alpha/boot/bootpz.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 6fc840d..a9e127b 100

[PATCH 2/6] alpha: Fix spaces to tabs

2014-07-15 Thread Nicholas Krause
This patch fixes all errors for this file related to using spaces instead of tabs. --- arch/alpha/boot/bootpz.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch/alpha/boot/bootpz.c index 64a0da6..15c16fe 100644 --- a/arch/alpha/boot/bootpz

[PATCH 1/6] alpha: Remove whiterrors related to uneeded characters and lines

2014-07-15 Thread Nicholas Krause
This file has multipe cleanpatch errors. This patch is the first in a series to clean them up. This one removes uneeded characters and lines from this file. --- arch/alpha/boot/bootpz.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/alpha/boot/bootpz.c b/arch

[PATCH 2/5] alpha: Checkpatch warnings on lines 71 and 72

2014-07-14 Thread Nicholas Krause
In bootp.c I am hitting lots of warnings this fixes two on lines 71,72 in order to pass checkpatch and follow kernel coding style. --- arch/alpha/boot/bootp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c index 8eb821e..3e

[PATCH 3/5] alpha: Remove whitespace issues and turn spaces into tabs

2014-07-14 Thread Nicholas Krause
This patch removes all the whitespace an tab issues that this file has when running checkpatch --- arch/alpha/boot/bootp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c index 3ee529d..6227e4f 100644 --- a/arch/alpha

[PATCH 1/5] alpha: checkpatch gives errors and warnings in bootp.c

2014-07-14 Thread Nicholas Krause
When running checkpatch on this file I get lots of warnings and even a few errors. This patch cleans up the coding style warning I get on line 26. --- arch/alpha/boot/bootp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c index

[PATCH 5/5] alpha: Cleanpatch Remove Errors

2014-07-14 Thread Nicholas Krause
This patch removes errors on lines 205,206 to fit kernel coding style. --- arch/alpha/boot/bootp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c index 47e33cb..ac0351d 100644 --- a/arch/alpha/boot/bootp.c +++ b/arch/alpha/

[PATCH 4/5] alpha: Fix if statment in bootp.c

2014-07-14 Thread Nicholas Krause
This patch fixes the if statement on line 180 to be changed to having no brackets as defined by kernel coding style for one line if statements. --- arch/alpha/boot/bootp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/boot/bootp.c b/arch/alpha/boot/bootp.c index

[PATCH] title: no lookup_page for if statement

2014-07-14 Thread Nicholas Krause
This patch removes the if define statement for page_lookup in order to remove a fix me of this not being defined as of yet. Signed-off-by: Nicholas Krause --- 0001-title-no-lookup_page-for-if-statement.patch | 37 1 file changed, 37 insertions(+) create mode 100644

[PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks

2014-07-14 Thread Nicholas Krause
This patch addresses the fix me message in this file that states to remove all definitions not related to reg-clocks in this header file. Signed-off-by: Nicholas Krause --- arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +- 1 file changed, 1 insertion(+), 21 deletions

[PATCH] cpufreq: Fix latency for cpufreq_info

2014-07-13 Thread Nicholas Krause
This fixes the latency for the cpufreq policy to 1 million nanoseconds that calls the function pxa_cpu_init for the member of the structure called cpuinfo.transition_latency. Signed-off-by: Nicholas Krause --- drivers/cpufreq/pxa2xx-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] cpufreq: Fix latency for cpufreq_info

2014-07-13 Thread Nicholas Krause
This fixes the latency for the cpufreq policy to 1 million nanoseconds that calls the function pxa_cpu_init for the member of the structure called cpuinfo.transition_latency. Signed-off-by: Nicholas Krause --- drivers/cpufreq/pxa2xx-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Nicholas Krause
This patch removes a fixme message in this file for setting the usb 2 speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be shared for the other things on the board with the usb chipset. Signed-off-by: Nicholas Krause --- arch/arm/mach

[PATCH] Removes FIXME message in usb.c

2014-07-08 Thread Nicholas Krause
This patch removes a fixme message in this file:wq for setting the usb 2 speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be shared for the other things on the board with the usb chipset. Signed-off-by: Nicholas Krause --- arch/arm

powerpc allyesconfig fix

2014-07-07 Thread Nicholas Krause
powerpc:allmodconfig has been failing for some time with the following error. arch/powerpc/kernel/exceptions-64s.S: Assembler messages: arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1 A number of attempts to fix

[PATCH] tile: Add underscores to defintions

2014-07-04 Thread Nicholas Krause
In file drv_xgbe_impl.h I fixed the definitions for Size Small, Size Large, Size Jumbo to have underscores before and after to follow kernel coding style for internel defentions. Signed-off-by: Nicholas Krause --- arch/tile/include/hv/drv_xgbe_impl.h | 15 +++ 1 file changed, 3

[PATCH] parisc: Remove FIXME line in signal.c

2014-07-04 Thread Nicholas Krause
This frame removes a fix me line in signal.c that is no longer needed as function call is correct. Signed-off-by: Nicholas Krause --- arch/parisc/kernel/signal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c index 1cba8f2..1d550b5

[PATCH] parisc: Remove sizeof(frame) from call to get_sigframe

2014-07-04 Thread Nicholas Krause
This removes the sizeof(frame) from the call to get_sigframe on line 243 in order to fix the call to this function as the sizeof in not needed to call this function. Signed-off-by: Nicholas Krause --- arch/parisc/kernel/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] mips: Add #ifdef in file bridge.h

2014-07-04 Thread Nicholas Krause
This patch addes a #ifdef __ASSEMBLY__ in order to check if this part of the file is configured to fix this #ifdef block in bridge.h for mips. Signed-off-by: Nicholas Krause --- arch/mips/include/asm/netlogic/xlp-hal/bridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] mach-omap2: Change if statement in omap2_dflt_clk_enable

2014-07-04 Thread Nicholas Krause
. Signed-off-by: Nicholas Krause --- arch/arm/mach-omap2/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c index 591581a..626363d 100644 --- a/arch/arm/mach-omap2/clock.c +++ b/arch/arm/mach-omap2/clock.c @@ -379,7

[PATCH] mach-omap1: Fix call to omap_cfg_reg

2014-07-04 Thread Nicholas Krause
This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case that the cpu is a omap16xx and the nwires are not equal to 3. Signed-off-by: Nicholas Krause --- arch/arm/mach-omap1/usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm

[PATCH] m32r: subtract textlen instead of adding in function m32r_flat_get_addr_from_rp

2014-07-04 Thread Nicholas Krause
This patch fixes the message stating in this function to substract textlen for return value of case FLAT_M32R_LO16_DATA in the switch statement for this function. Signed-off-by: Nicholas Krause --- arch/m32r/include/asm/flat.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH] m68k: Remove define statement no longer needed

2014-07-04 Thread Nicholas Krause
In the file sun3_pgalloc.h we should remove #define_KERNPG_TABLE equals 0 as this define statement hasn't been used since kernel verison 2.15.8 and is now no longer needed. Signed-off-by: Nicholas Krause --- arch/m68k/include/asm/sun3_pgalloc.h | 4 1 file changed, 4 deletions(-)

[PATCH] microblaze: fixes includes in sigcontext.h

2014-07-03 Thread Nicholas Krause
This patch changes this file to use linux/ptrace.h instead of included file to fix this FIXME message in this file. Signed-off-by: Nicholas Krause --- arch/microblaze/include/uapi/asm/sigcontext.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/microblaze/include/uapi

[PATCH] alpha: Remove FIXME in file osf_sys.c

2014-07-03 Thread Nicholas Krause
Removes the FIXME message on line 891 for info.si_addr being NULL as according to alpha devolopers there is no good work around as of newest kernel verisons Signed-off-by: Nicholas Krause --- arch/alpha/kernel/osf_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

[PATCH 2/2] mach-spear: fixed spear1340.c file

2014-07-02 Thread Nicholas Krause
This is the fixed file after moving sata support to new file in spear1340_sata.c Signed-off-by: Nicholas Krause --- arch/arm/mach-spear/spear1340.c | 111 1 file changed, 111 deletions(-) diff --git a/arch/arm/mach-spear/spear1340.c b/arch/arm/mach

[PATCH 1/2] mach-spear: New file for 1340 for sata support

2014-07-02 Thread Nicholas Krause
Moves all sata support for mach-spear 1340 to new file called spear1340_sata.c as wanted in FIXME message. Signed-off-by: Nicholas Krause --- arch/arm/mach-spear/spear1340_sata.c | 120 +++ 1 file changed, 120 insertions(+) create mode 100644 arch/arm/mach-spear

[PATCH] M32Rz: FIXME add textlen in function m32r_flat_get_addr_from_rp

2014-07-02 Thread Nicholas Krause
This patch adds textlen in this function for case FLAT_M32R_LO16_DATA in the return statement verus subtracting it in order to fix this FIXME message. Signed-off-by: Nicholas Krause --- arch/m32r/include/asm/flat.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/m32r/include/asm

[PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-02 Thread Nicholas Krause
Removes a FIXME comment in this file due to it not compiling as it now compiles. Signed-off-by: Nicholas Krause --- arch/m68k/include/asm/sun3_pgalloc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index f868506

[PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()

2014-07-02 Thread Nicholas Krause
This removes the FIXME message above ocpi_enable being declared for proper locking in this function. As of the current kernel verisons there is no need for locking as only one driver uses this function currently and therefore there is no need for real locking requirements. Signed-off-by: Nicholas

[PATCH 1/2] Deletes arch/arm/mach-gemini/idle.c

2014-06-30 Thread Nicholas Krause
removing it. Signed-off-by: Nicholas Krause --- arch/arm/mach-gemini/idle.c | 30 -- 1 file changed, 30 deletions(-) delete mode 100644 arch/arm/mach-gemini/idle.c diff --git a/arch/arm/mach-gemini/idle.c b/arch/arm/mach-gemini/idle.c deleted file mode 100644 index 2880f5a

[PATCH] Remove memory start and memory end

2014-06-30 Thread Nicholas Krause
This patch removes the uneeded variables memory start and memory stated in FIXME message before declaring this variables as extern unsigned longs. Signed-off-by: Nicholas Krause --- arch/avr32/include/asm/page.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/avr32/include/asm/page.h

[PATCH] Remove FIXME messages in arch/powerpc/sysdev/uic.c

2014-06-30 Thread Nicholas Krause
This removes FIXME messages in the function uic_init_one as this FIXMEs are not valid due to the kernel being better to panic due to boards without these allocated not being able to service IRQs. Signed-off-by: Nicholas Krause --- arch/powerpc/sysdev/uic.c | 4 ++-- 1 file changed, 2 insertions

[PATCH] Remove FIXME messages in arch/powerpc/sysdev/uic.c

2014-06-30 Thread Nicholas Krause
This removes FIXME messages in the function uic_init_one as this FIXMEs are not valid due to the kernel being better to panic due to boards without these allocated not being able to service IRQs. Signed-off-by: Nicholas Krause --- arch/powerpc/sysdev/uic.c | 4 ++-- 1 file changed, 2 insertions

[PATCH v2] hid-appleir: Fix kernel panic due to null pointer

2014-06-30 Thread Nicholas Krause
Fixes a null pointer in appleir_input_configured due to reading into wrong size array. Changed the variable to input_dev->keycodemax. Signed-off-by: Nicholas Krause --- drivers/hid/hid-appleir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-appleir.

[PATCH] Fixes return issues in uic_init_one

2014-06-29 Thread Nicholas Krause
This patch fixes the FIXME messages for returning a ENOMEM error if uic is not allocated and if uic->irqhost is not allocated a IRQ domain that is linear returns EIO. Signed-off-by: Nicholas Krause --- arch/powerpc/sysdev/uic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH] Fixes q40_irq_startup to return -ENXIO

2014-06-29 Thread Nicholas Krause
Fixes q40_irq_startup to return -ENXIO for cases 11-13 in the switch statement of this function to handle these failure cases. Signed-off-by: Nicholas Krause --- arch/m68k/q40/q40ints.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40

[PATCH] Fixes gemmi_idle in file idle.c

2014-06-29 Thread Nicholas Krause
disables the IRQ line in gemmi_idle before calling cpu_do_idle. In addition, according to the Fixme message in this file fixes races that may occur due to not disabling the IRQ before calling cpu_do_idle. Signed-off-by: Nicholas Krause --- arch/arm/mach-gemini/idle.c | 3 +-- 1 file changed, 1

[PATCH] FIXME of file toploogy.h for alpha cpus

2014-06-27 Thread Nicholas Krause
This patch fixs the FIXME message in the function *cpumask_of_node for using this function multiple times and the issue with recaluting the cpu node mask when reusing this function. Signed-off-by: Nicholas Krause --- arch/alpha/include/asm/topology.h | 3 +++ 1 file changed, 3 insertions

[PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Nicholas Krause
Rewrites the wireless check for legacy checking in function halbtc_legacy to check for both Mode A and B. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/btcoexist

[PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-20 Thread Nicholas Krause
Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to returning true of false directly. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 --- 1 file changed

[PATCH] Fixes kernel panic with Null pointer in hid-appleir.c

2014-06-20 Thread Nicholas Krause
In for loop of function appleir_input_configured we hit a Null pointer after the for loop due to array_size not being correct needs to be changed to input_dev->keycodemax. Signed-off-by: Nicholas Krause --- drivers/hid/hid-appleir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nicholas Krause
Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to returning true of false directly. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 --- 1 file changed

[PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nicholas Krause
Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to returning true of false directly. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 --- 1 file changed

[PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Nicholas Krause
--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..d8a9427 100644 --- a/drivers/staging/rtl8192e/

[PATCH] Checks if dev_skb_alloc returns Null in function,

2014-06-19 Thread Nicholas Krause
--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..d8a9427 100644 --- a/drivers/staging/rtl8192e/

[PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Nicholas Krause
Checks if dev_skb_alloc returns Null in function, fw_download_code. If the return value of dev_skb_alloc is NULL return false and exit this function. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Nicholas Krause
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -61,6 +61,10 @@ static bool fw

[PATCH 1/2] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Nicholas Krause
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -61,6 +61,10 @@ static bool fw

[PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc

2014-06-18 Thread Nicholas Krause
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..fde17ff 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -62,12 +62,15 @@ static bool f

[PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers

[PATCH] Check for Null return of function of affs_bread in function affs_truncate

2014-06-18 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- fs/affs/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/affs/file.c b/fs/affs/file.c index a7fe57d..f26482d 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -923,6 +923,8 @@ affs_truncate(struct inode *inode) while (ext_key

[PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers

[PATCH] Checks for Null return of skb_alloc in function fw_download_code

2014-06-18 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..fde17ff 100644

  1   2   >