On Wed, Nov 04 2015, Arnd Bergmann wrote:
> The recent change of the raid5-cache code to use crc32c instead
> of crc32 causes link errors when CONFIG_LIBCRC32C is disabled:
>
> drivers/built-in.o: In function crc32c'
> core.c:(.text+0x1c6060): undefined reference to `crc32c'
>
> This adds an expli
On Mon, Nov 02 2015, Roman Gushchin wrote:
> The stripe_add_to_batch_list() function is called only if
> stripe_can_batch() returned true, so there is no need for double check.
>
> Signed-off-by: Roman Gushchin
> Cc: Neil Brown
> Cc: linux-r...@vger.kernel.org
> ---
>
On Tue, Nov 03 2015, Chris Mason wrote:
> On Mon, Nov 02, 2015 at 03:50:12PM -0500, J. Bruce Fields wrote:
>> On Wed, Oct 28, 2015 at 07:25:10AM +0900, Neil Brown wrote:
>> >
>> > If you create a subvolume in btrfs and access it (by name) without
>> > mounting
On Sat, Oct 31 2015, Oliver Neukum wrote:
> On Fri, 2015-10-30 at 14:47 +0100, Jiri Kosina wrote:
>> Basically the main argument why kthread freezer is not needed boils
>> down to
>> this: the only facility that is needed during suspend: "no persistent
>> fs
>> changes are allowed from now on".
>
The following changes since commit 25cb62b76430a91cc6195f902e61c2cb84ade622:
Linux 4.3-rc5 (2015-10-11 11:09:45 -0700)
are available in the git repository at:
git://neil.brown.name/md tags/md/4.4
for you to fetch changes up to 339421def582abb14c2217aa8c8f28bb2e299174:
MD: when RAID journ
they just keep coming in :-(
The following changes since commit 8bce6d35b308d73cdb2ee273c95d711a55be688c:
md/raid10: fix the 'new' raid10 layout to work correctly. (2015-10-24
16:24:25 +1100)
are available in the git repository at:
git://neil.brown.name/md tags/md/4.3-rc7-fixes
for you t
On Sat, Oct 31 2015, Shaohua Li wrote:
> On Fri, Oct 30, 2015 at 05:02:47PM +0300, Roman Gushchin wrote:
>> > Isn't the 4.1 fix just:
>> >
>> > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> > index e5befa356dbe..6e4350a78257 100644
>> > --- a/drivers/md/raid5.c
>> > +++ b/drivers/md/raid
On Fri, Oct 30 2015, Roman Gushchin wrote:
> 29.10.2015, 03:35, "Neil Brown" :
>> On Wed, Oct 28 2015, Roman Gushchin wrote:
>>
>>> After commit 566c09c53455 ("raid5: relieve lock contention in
>>> get_active_stripe()")
>>> __f
oduce this behavior on raid6 over 6 ssd disks.
> The devices_handle_discard_safely option should be set to enable trim
> support. The following script was used:
>
> for i in `seq 1 32`; do
> dd if=/dev/zero of=large$i bs=10M count=100 &
> done
>
> Signed-off-by: Roman Gushchin
&g
On Wed, Oct 28 2015, J. Bruce Fields wrote:
> On Mon, Oct 26, 2015 at 03:35:54PM +0900, Neil Brown wrote:
>> From c38784b876a181eda9a5687e618749157dc96a0e Mon Sep 17 00:00:00 2001
>> From: NeilBrown
>> Date: Sat, 25 Jul 2015 10:24:41 +1000
>> Subject: [PATCH] Documen
If you create a subvolume in btrfs and access it (by name) without
mounting it, then the subvolume looks like a separate mount to some
extent, returning a different st_dev to stat(), but it doesn't look like
a separate mount in that it isn't listed in /proc/mounts. This
inconsistency can confuse t
<https://lwn.net/Articles/650786/> A walk among the symlinks
+
+Written by Neil Brown with help from Al Viro and Jon Corbet.
+
+Introduction
+
+
+The most obvious aspect of pathname lookup, which very little
+exploration is needed to discover, is that it is complex. There are
+many ru
Kristen Accardi writes:
> On Oct 22, 2015 7:04 PM, "Neil Brown" wrote:
>>
>> Darren Hart writes:
>>
>> >
>> > Is there a good description of what is expected of a TAB member? How
> much time
>> > is involved? What makes a great TAB m
Nicolas Parpandet writes:
> Hello,
>
> I did some more investigations, (wireshark)
>
> The unlink of /tmp/crontab.vYPoHR/crontab is tranlated into a rename
> nfs call ? (.nfs file)
That happens if the file is still open.
>
> NFS 670 V3 READDIRPLUS Reply (Call In 731) crontab .. .
> NFS
Darren Hart writes:
>
> Is there a good description of what is expected of a TAB member? How much time
> is involved? What makes a great TAB member?
>
> I've found: http://www.linuxfoundation.org/programs/advisory-councils/tab
>
> I've read the charter and scanned some of the minutes, but I'd sti
Darren Hart writes:
>
> Is there a good description of what is expected of a TAB member? How much time
> is involved? What makes a great TAB member?
>
> I've found: http://www.linuxfoundation.org/programs/advisory-councils/tab
>
> I've read the charter and scanned some of the minutes, but I'd sti
Added dm-devel, which is probably the more appropriate list for dm
things.
NeilBrown
Austin S Hemmelgarn writes:
> I think I've stumbled upon a bug in DM-RAID. The primary symptom is that when
> creating a new DM-RAID based device (using either LVM or dmsetup) in a RAID1
> configuration, it v
Neil Armstrong writes:
> This patch is based on an earlier patch by NeilBrown which is based on
> a older patch from Grant Erickson which provided PWM devices using
> the 'legacy' interface.
>
> The pwm driver was renamed to not be confused with the OMAP4 PWM dedicated
> hardware and was cleaned
"J. Bruce Fields" writes:
> On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote:
>> Tatsukawa Kosuke wrote:
>> > J. Bruce Fields wrote:
>> >> Thanks for the detailed investigation.
>> >>
>> >> I think it would be worth adding a comment if that might help someone
>> >> having to rein
Arnd Bergmann writes:
> On Monday 12 October 2015 15:59:27 Neil Brown wrote:
>> > diff --git a/drivers/md/md.c b/drivers/md/md.c
>> > index 7fff1e6884d6..e13f72a3b561 100644
>> > --- a/drivers/md/md.c
>> > +++ b/drivers/md/md.c
>> > @@ -8987,9 +898
Arnd Bergmann writes:
> On 32-bit architectures, the md code produces this warning when CONFIG_LDAF
> is set:
>
> drivers/md/md.c: In function 'check_sb_changes':
> drivers/md/md.c:8990:10: warning: format '%lu' expects argument of type 'long
> unsigned int', but argument 4 has type 'sector_t {a
The following changes since commit da6fb7a9e5bd6f04f7e15070f630bdf1ea502841:
md/bitmap: don't pass -1 to bitmap_storage_alloc. (2015-10-02 17:24:13 +1000)
are available in the git repository at:
git://neil.brown.name/md tags/md/4.3-rc4-fix
for you to fetch changes up to a452744bcbf706eac65
Kosuke Tatsukawa writes:
> There are several places in net/sunrpc/svcsock.c which calls
> waitqueue_active() without calling a memory barrier. Add a memory
> barrier just as in wq_has_sleeper().
>
> I found this issue when I was looking through the linux source code
> for places calling waitqueu
Mikulas Patocka writes:
> The commit 55ce74d4bfe1b936264c637f39a152d1e5ac (md/raid1: ensure
> device failure recorded before write request returns) is causing crash in
> the LVM2 testsuite test shell/lvchange-raid.sh. For me the crash is 100%
> reproducible.
>
> The reason for the crash is
Hi Linus,
a few md bug fixes.
Thanks,
NeilBrown
The following changes since commit bcee19f424a0d8c26ecf2607b73c690802658b29:
Merge branch 'for-4.3-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup (2015-09-21 18:26:54
-0700)
are available in the git repository at:
git://
Pavel Machek writes:
> On Thu 2015-07-30 10:11:24, NeilBrown wrote:
>>
>> Add a 'continuous' option for usb charging which enables
>> the "linear" charging mode of the twl4030.
>>
>> Linear charging does a good job with not-so-reliable power sources.
>> Auto mode does not work well as it switch
David Sterba writes:
> On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote:
>> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as
>> that returned by encode_fh - it may be larger.
>>
>> With NFSv2, the filehandle is fixed length, so it may appear longer
>> than expected
Joe Perches writes:
> On Fri, 2015-09-04 at 18:00 -0700, John Stultz wrote:
>> On Fri, Sep 4, 2015 at 5:57 PM, John Stultz wrote:
>> > On Thu, Sep 3, 2015 at 4:26 AM, Miroslav Lichvar
>> > wrote:
>> >> On Wed, Sep 02, 2015 at 04:16:00PM -0700, John Stultz wrote:
>> >>> On Tue, Sep 1, 2015 at 6
Julia Lawall writes:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> //
>
> Signed-off-by: Julia Lawall
>
Please pull these updates. I've already merged with the 'block' tree
to resolve a few simple conflicts.
Thanks,
NeilBrown
The following changes since commit 1081230b748de8f03f37f80c53dfa89feda9b8de:
Merge branch 'for-4.3/core' of git://git.kernel.dk/linux-block (2015-09-02
13:10:25 -0700)
Kevin Hilman writes:
> ping... this boot failure has now landed in mainline
sorry, I'm on leave at the moment and travelling so I'm unlikely to be
able to look at this properly. I should be able to examine this issue
before the end of the month but cannot promise sooner than that (though
it is
On Wed, 10 Jun 2015 16:07:44 -0500
David Teigland wrote:
> On Thu, Jun 11, 2015 at 06:31:31AM +1000, Neil Brown wrote:
> > What is your interest in this? I'm always happy for open discussion and
> > varied input, but it would help to know to what extent you are a stake
&g
On Wed, 10 Jun 2015 10:01:51 -0500
David Teigland wrote:
> Isn't this process what staging is for?
No it isn't.
Staging is useful for code drops. i.e. multiple other developers want to
collaborate to improve some code that the maintainer doesn't want to accept.
So it goes into staging, "the com
On Tue, 9 Jun 2015 01:26:54 +0200
Rasmus Villemoes wrote:
> There's no point in starting over when we meet a '/'. This also
> eliminates a stack variable and a little .text.
>
> Signed-off-by: Rasmus Villemoes
> ---
> v2: no changes.
>
> drivers/md/md.c | 4 +---
> 1 file changed, 1 insertio
On Saturday February 23, [EMAIL PROTECTED] wrote:
> On Wed, 20 Feb 2008 15:46:10 +0100 Peter Zijlstra <[EMAIL PROTECTED]> wrote:
>
> > Another posting of the full swap over NFS series.
>
> Well I looked. There's rather a lot of it and I wouldn't pretend to
> understand it.
But pretending is fu
On Tuesday February 19, [EMAIL PROTECTED] wrote:
> On Mon, Feb 18, 2008 at 04:24:27PM +0300, Michael Tokarev wrote:
> > First, I still don't understand why in God's sake barriers are "working"
> > while regular cache flushes are not. Almost no consumer-grade hard drive
> > supports write barriers,
On Monday February 18, [EMAIL PROTECTED] wrote:
>
>
> I'll put it even more strongly. My experience is that disabling write
> cache plus disabling barriers is often much faster than enabling both
> barriers and write cache enabled, when doing metadata intensive
> operations, as long as you have
On Monday February 18, [EMAIL PROTECTED] wrote:
> On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > This patch makes the following needlessly global functions static:
> > - drop_pagecache()
> > - drop_slab()
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
..
>
On Sunday February 17, [EMAIL PROTECTED] wrote:
> Neil responding to Linus:
> > > "From:" is not a tag. It's a special marker at the *top*
> >
> > You may be right, but when I email patches to akpm
>
> Linus wasn't saying you don't need a 'From:' line in this case (as the
> *top* line of patches y
On Friday February 8, [EMAIL PROTECTED] wrote:
>
>
> On Fri, 8 Feb 2008, Jonathan Corbet wrote:
> > +
> > +These tags are:
> > +
> > +From: The original author of the patch. This tag will ensure
> > + that credit is properly given when somebody other than the
> > +
been
used, as in the following patch.
Thanks,
NeilBrown
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
diff .prev/fs/jbd/commit.c ./fs/jbd/commit.c
--- .prev/fs/jbd/commit.c 2008-02-07 10:01:57.0 +1100
+++ ./fs/jbd/commit.c 2008-02-07 10:04:58.0 +1100
@@ -131,6
On Tuesday February 5, [EMAIL PROTECTED] wrote:
>
> I was able to solve the problem, however, like so:
>
> 132c133
> < # CONFIG_PREEMPT_NONE is not set
> ---
> > CONFIG_PREEMPT_NONE=y
> 134,135c135,136
> < CONFIG_PREEMPT=y
> < CONFIG_PREEMPT_BKL=y
> ---
> > # CONFIG_PREEMPT is not set
> > # CONFI
tention from raid1d.
So we create a new function 'flush_pending_writes' to give that attention,
and call it in freeze_array to be sure that we aren't waiting on raid1d.
Thanks to "K.Tanaka" <[EMAIL PROTECTED]> for finding and reporting
this problem.
Cc: "
On Thursday January 17, [EMAIL PROTECTED] wrote:
> On Thu, 17 Jan 2008 16:23:30 +0100 Jiri Slaby <[EMAIL PROTECTED]> wrote:
>
> > On 01/17/2008 11:35 AM, Andrew Morton wrote:
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/
> >
> > still the same md i
On Thursday January 17, [EMAIL PROTECTED] wrote:
>
> On Jan 17 2008 00:43, Karel Zak wrote:
> >>
> >> Seems like a plain bad idea to me. There will be any number of home-made
> >> /proc/mounts parsers and we don't know what they do.
> >
> > So, let's use /proc/mounts_v2 ;-)
>
> Was not it like
On Tuesday January 15, [EMAIL PROTECTED] wrote:
> On Wed, 16 Jan 2008 00:09:31 -0700 "Dan Williams" <[EMAIL PROTECTED]> wrote:
>
> > > heheh.
> > >
> > > it's really easy to reproduce the hang without the patch -- i could
> > > hang the box in under 20 min on 2.6.22+ w/XFS and raid5 on 7x750GB.
>
of rdev->mddev before the drop, and we are safe...
Comments?
NeilBrown
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
### Diffstat output
./drivers/md/md.c | 35 ++-
1 file changed, 26 insertions(+), 9 deletions(-)
diff .prev/drivers/md/md.c ./drivers/md
On Monday January 14, [EMAIL PROTECTED] wrote:
> On Mon, Jan 14, 2008 at 02:21:45PM +1100, Neil Brown wrote:
>
> > Maybe it isn't there any more
> >
> > Once upon a time, when I
> >echo remove > /sys/block/mdX/md/dev-YYY/state
>
> Egads.
On Monday January 14, [EMAIL PROTECTED] wrote:
> On Mon, Jan 14, 2008 at 12:45:31PM +1100, NeilBrown wrote:
> >
> > Due to possible deadlock issues we need to use a schedule work to
> > kobject_del an 'rdev' object from a different thread.
> >
> > A recent change means that kobject_add no longer
On Thursday January 10, [EMAIL PROTECTED] wrote:
> On Thu, Jan 10, 2008 at 03:13:48PM +1100, Neil Brown wrote:
> > > What guarantees that it doesn't happen before we get to callback? AFAICS,
> > > nothing whatsoever...
> >
> > Yes, that's bad isn&
On Sunday January 13, [EMAIL PROTECTED] wrote:
> On Thu, 10 Jan 2008 13:01:34 -0500
> Jeff Layton <[EMAIL PROTECTED]> wrote:
>
> > lockd makes itself freezable, but never calls try_to_freeze(). Have it
> > call try_to_freeze() within the main loop.
> >
> > Signed-off-by: Jeff Layton <[EMAIL PROTE
On Thursday January 10, [EMAIL PROTECTED] wrote:
> This is the seventh patchset to fix the use-after-free problem in lockd
This patch set looks good now. I'm happy to give it a
Reviewed-by: NeilBrown <[EMAIL PROTECTED]>
Two remaining issues that I would like to see address, but don't
n
On Thursday January 10, [EMAIL PROTECTED] wrote:
> On Thu, Jan 10 2008, Chris Mason wrote:
> > On Thu, 10 Jan 2008 09:31:31 +0100
> > Jens Axboe <[EMAIL PROTECTED]> wrote:
> >
> > > On Wed, Jan 09 2008, Alasdair G Kergon wrote:
> > > > Here's the latest version of dm-loop, for comparison.
> > > >
On Tuesday January 8, [EMAIL PROTECTED] wrote:
>
> FWIW, I'm going to go through Arjan's collection and post blow-by-blow
> analysis of some of those suckers. Tonight, probably...
>
> Let's take e.g. http://www.kerneloops.org/raw.php?rawid=2618
Thanks for that analysis.
...
>
> Humm... So we
On Tuesday January 8, [EMAIL PROTECTED] wrote:
> ...and only have lockd exit when the last reference is dropped.
>
> The problem is this:
>
> When a lock that a client is blocking on comes free, lockd does this in
> nlmsvc_grant_blocked():
>
> nlm_async_call(block->b_call, NLMPROC_GRANTED_MS
On Saturday January 5, [EMAIL PROTECTED] wrote:
> @@ -357,7 +375,18 @@ lockd_down(void)
> goto out;
> }
> warned = 0;
> - kthread_stop(nlmsvc_task);
> + if (atomic_sub_return(1, &nlmsvc_ref) != 0)
> + printk(KERN_WARNING "lockd_down: lockd is waiting fo
On Saturday January 5, [EMAIL PROTECTED] wrote:
> Have lockd_up start lockd using kthread_run. With this change,
> lockd_down now blocks until lockd actually exits, so there's no longer
> need for the waitqueue code at the end of lockd_down. This also means
> that only one lockd can be running at a
On Saturday January 5, [EMAIL PROTECTED] wrote:
> Move the initialzation in __svc_create_thread that happens prior to
> thread creation to a new function. Export the function to allow
> services to have better control over the svc_rqst structs.
>
> Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
>
g this pass through handle_stripe so that we can
> issue a linked chain of asynchronous operations.
>
> ---
>
> From: Neil Brown <[EMAIL PROTECTED]>
Technically that should probably be
From: Dan Williams <[EMAIL PROTECTED]>
now, and then I add
Acked-by: NeilBrown
On Saturday December 15, [EMAIL PROTECTED] wrote:
> On Dec 14, 2007 7:26 AM, NeilBrown <[EMAIL PROTECTED]> wrote:
> >
> > Given an fd on a block device, returns a string like
> >
> > /block/sda/sda1
> >
> > which can be used to find related information in /sys.
>
> As pointed out to w
On Sunday December 9, [EMAIL PROTECTED] wrote:
> On Saturday 08 December 2007 01:43:28 Rafael J. Wysocki wrote:
> > On Saturday, 8 of December 2007, Andrew Morton wrote:
> > > On Fri, 07 Dec 2007 17:51:58 -0500
> > > Trond Myklebust <[EMAIL PROTECTED]> wrote:
> > >
> > > >
> > > > On Fri, 2007-12
On Sunday December 9, [EMAIL PROTECTED] wrote:
> I have tried to search through the mailing list and it is not entirely
> clear, but it looks like this has gone from the kernel: not least
> because my driver reports:
>
> drivers/sh/gdrom/gdrom.c:665: error: implicit declaration of function
> 'rq_f
On Tuesday December 4, [EMAIL PROTECTED] wrote:
>
> Hrmpf. It looks like the SCSI layer is a little too trigger happy. Any
> chance you could try and trace where this happens?
in scsi_lib.c, in scsi_request_fn, near the top of the main
while (!blk_queue_plugged(q)) {
loop:
if
On Tuesday December 4, [EMAIL PROTECTED] wrote:
> On Tue, Dec 04, 2007 at 11:14:12AM +1100, Neil Brown wrote:
> > On Tuesday December 4, [EMAIL PROTECTED] wrote:
> > > Neil,
> > >
> > > I just upgraded an ia64 (Altix, 16k page size) test box to 2.6.24-rc3
>
I've been looking at use BIO_RW_FAILFAST in md/raid to improve
handling of some error cases.
This is particularly significant for the DASD driver (s390 specific).
I believe it uses optic fibre to connect to the drives. When one of
these paths is unplugged, IO requests will block until an operato
e NULL deref. Let me know if this fixes
it. I'll read through the offending patch more carefully and make
sure there is nothing else wrong.
NeilBrown
Fix possible NULL dereference in umem.c
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
### Diffstat output
./drivers/block/um
On Thursday November 29, [EMAIL PROTECTED] wrote:
> > http://programming.kicks-ass.net/kernel-patches/foo/
> >
> > bdi-task-dirty.patch
> > bdi-sysfs.patch
> > bdi-min.patch
> > bdi-max.patch
> >
> >
> > Is my current rather experimental stack, I just wrote the max part after
> > having slept on
On Friday November 30, [EMAIL PROTECTED] wrote:
> On Fri, Nov 30, 2007 at 09:07:06AM +1100, Neil Brown wrote:
> >
> > Hi David,
> >
> > On Friday November 30, [EMAIL PROTECTED] wrote:
> > >
> > >
> > > I came across this because I'
Hi David,
On Friday November 30, [EMAIL PROTECTED] wrote:
>
>
> I came across this because I've been making changes to XFS to avoid the
> inode hash, and I've found that I need to remove the inode from the
> dirty list when setting I_WILL_FREE to avoid this race. I can't see
> how this race is
On Tuesday November 13, [EMAIL PROTECTED] wrote:
>
> raid5-fix-unending-write-sequence.patch is in -mm and I believe is
> waiting on an Acked-by from Neil?
>
It seems to have just been sent on to Linus, so it probably will go in
without:
Acked-By: NeilBrown <[EMAIL PROTECTED]>
I'm beginning
On Tuesday November 13, [EMAIL PROTECTED] wrote:
> On Tuesday 13 November 2007 07:08, Mark Lord wrote:
> > Ingo Molnar wrote:
> > ..
> >
> > > This is all QA-101 that _cannot be argued against on a rational basis_,
> > > it's just that these sorts of things have been largely ignored for
> > > years
On Wednesday November 14, [EMAIL PROTECTED] wrote:
> On Wed, Nov 14, 2007 at 09:38:20AM -0800, Randy Dunlap wrote:
> > On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote:
> > > so please stop this "too busy and too noisy" nonsense already. It was
> > > nonsense 10 years ago and it's nonsense tod
On Tuesday November 13, [EMAIL PROTECTED] wrote:
> Remove defconfig ptr comparison to 0
>
> Remove sparse warning: Using plain integer as NULL pointer
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
> ---
>
> diff --git a/fs/lockd/svcshare.c b/fs/lockd/svcshare.c
> index 068886d..98548ad 1
On Tuesday November 13, [EMAIL PROTECTED] wrote:
> Remove defconfig ptr comparison to 0
>
> Remove sparse warning: Using plain integer as NULL pointer
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
> ---
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index d019918..07b38cf 100644
> ---
(CC: trimmed - as Bruce says: separate discussion)
On Monday November 12, [EMAIL PROTECTED] wrote:
> On Tue, Nov 13, 2007 at 09:08:42AM +1100, Neil Brown wrote:
> > Calling nfsd_setuser an extra time does open us up for a very tiny
> > possibility of an ENOMEM at an awkward time.
On Monday November 12, [EMAIL PROTECTED] wrote:
> The following two patches are nfsd bugfixes that I believe are
> appropriate for 2.6.24 and 2.6.23.y.
>
> --b.
>
Both
Reviewed-By: NeilBrown <[EMAIL PROTECTED]>
Calling nfsd_setuser an extra time does open us up for a very tiny
possibility of
On Thursday November 8, [EMAIL PROTECTED] wrote:
>
> Not really a credible difference as the reported difference is between
> two *clients* and the speed of getattr vs lookup would depend on the
> *server*.
Sorry, my bad. I misread your original problem description. It would
appear to be a ser
On Wednesday November 7, [EMAIL PROTECTED] wrote:
> Neil Brown wrote:
> >
> > I would suggest getting a 'tcpdump -s0' trace and seeing (with
> > wireshark) what is different between the various cases.
>
> Thanks Neil for looking into this. Your suggest
On Tuesday November 6, [EMAIL PROTECTED] wrote:
> > On Tue, 6 Nov 2007 14:28:11 +0300 Al Boldi <[EMAIL PROTECTED]> wrote:
> > Al Boldi wrote:
> > > There is a massive (3-18x) slowdown when re-querying a large nfs dir (2k+
> > > entries) using a simple ls -l.
> > >
> > > On 2.6.23 client and server
a91bced31f8fd328d50496 did not get applied
correctly, presumably due to substantial similarities between
handle_stripe5 and handle_stripe6.
This patch (with lots of context) moves the chunk of new code from
handle_stripe6 (where it isn't needed (yet)) to handle_stripe5.
Signed-off-by: Neil Brown &
On Thursday October 25, [EMAIL PROTECTED] wrote:
> On Mon, 22 Oct 2007, Pekka Enberg wrote:
> > On 10/22/07, Hugh Dickins <[EMAIL PROTECTED]> wrote:
> > > Only ramdisk and shmem have been returning AOP_WRITEPAGE_ACTIVATE.
> > > Both of those set BDI_CAP_NO_WRITEBACK. ramdisk never returned it
> >
On Monday October 15, [EMAIL PROTECTED] wrote:
> > Therefore it is best to not have stable single-number naming schemes
> > for any devices on any machines. Why? Because it ensure there will
> > not be any second class citizens.
>
> This is where we disagree. The existence of devices you cannot
ually
works but is not safe. The decision should be based on whether it is
a TCP_LISTEN socket or a TCP_CONNECTED socket.
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
Cc: Adrian Bunk <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Cc: Trond Myklebust
On Monday October 15, [EMAIL PROTECTED] wrote:
>
> This is my objection. Even when enumerating multiple devices of the same
> type
> is tricky, enumerating multiple devices of _different_ types should not be.
> There's a great big type indicator that is being _deliberately_ ignored, and
> la
I didn't do
because I thought you wanted it against a non-mm tree).
I think it was definitely ready for merging in -mm. Possibly not for
mainline just yet.
NeilBrown
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
### Diffstat output
./drivers/md/dm-crypt.c | 30 +++
On Sunday October 14, [EMAIL PROTECTED] wrote:
> On Sunday 14 October 2007 12:46:12 pm Stefan Richter wrote:
> > David Newall wrote:
> > > That is so rude.
>
> When a reply contains as a reply to the first paragraph "you're wrong" with
> no
> elaboration, and as a reply to the second paragraph n
On Tuesday October 9, [EMAIL PROTECTED] wrote:
> Hi Neil.
> >
> >From:The Author, Primary Author, or Authors of the patch.
> > Authors should also provide a Signed-off-by: tag.
> >
> > Purpose: to give credit to authors
> The SCM should include this inf
On Wednesday October 10, [EMAIL PROTECTED] wrote:
> On Tue, Oct 09, 2007 at 10:49:20AM -0600, Jonathan Corbet wrote:
> > Neil Brown <[EMAIL PROTECTED]> wrote:
> > > > + (b) Any problems, concerns, or questions relating to the patch have
> > > > been
On Monday October 8, [EMAIL PROTECTED] wrote:
I find it is always good to know *why* we have the tags. That
information is a useful complement to what they mean, and can guide
people in adding them.
So below I present some "Purposes", YetAnotherTag, and a comment on
the RSO.
(And I'd like to ad
On Monday September 24, [EMAIL PROTECTED] wrote:
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> Add a new super block flag, that results in the VFS not checking if
> the current process has enough privileges to do an mknod().
>
> If this flag is set, all mounts for this super block will have the
On Friday September 21, [EMAIL PROTECTED] wrote:
> On Thu, 20 Sep 2007 18:27:35 -0700
> Dan Williams <[EMAIL PROTECTED]> wrote:
>
> > Fix a couple bugs and provide documentation for the async_tx api.
> >
> > Neil, please 'ack' patch #3.
> >
> > git://lost.foo-projects.org/~dwillia2/git/iop async
On Wednesday September 12, [EMAIL PROTECTED] wrote:
> On Wednesday 12 September 2007 20:01, Greg KH wrote:
> > On Wed, Sep 12, 2007 at 07:32:07AM +0200, Robert Schwebel wrote:
> > > On Tue, Sep 11, 2007 at 11:43:17AM +0200, Heiko Schocher wrote:
> > > > I have developed a device driver and use the
it aaf68cfbf2241d24d46583423f6bff5c47e088b3 added a bias
to sk_inuse, so this test for an unused socket now fails. So no
sockets gets closed because they are old (they might get closed
if the client closed them).
This bug has existed since 2.6.21-rc1.
Thanks to Wolfgang Walter for finding and repo
On Monday September 10, [EMAIL PROTECTED] wrote:
> On Mon, Sep 10, 2007 at 02:46:32PM -0400, J. Bruce Fields wrote:
> > * This forceful removal will result in ugly /proc output if
> > * somebody holds a file open that got deleted due to a rename.
> > * We could be nicer about the deleted file
On Tuesday September 11, [EMAIL PROTECTED] wrote:
> This oops appeared over night on a box running 2.6.23-rc5 (recent with the
> tcp_input.c fix).
>
> I can't find a similar one reported.
Okay. this is weird.
>
> Mark
>
>
> BUG: unable to handle kernel NULL pointer dereference at virtual
On Tuesday August 28, [EMAIL PROTECTED] wrote:
> Hi,
>
> Brief question about NFSv3 lock recovery to those who might
> know - does Linux implementation (or NLM/NSM protocol)
> properly support the case in which client and server state
> change simultaneously?
If both crash, there is nothing for a
On Monday August 27, [EMAIL PROTECTED] wrote:
> * a bug (AFAICT) in md.c - we open raid components r/w and if it
> fails, it fails. Good for our purposes, but... how about raid0 on read-only
> devices? In any case, we have a ready place to store mode_t, so it's not a
> problem for getting t
On Monday August 27, [EMAIL PROTECTED] wrote:
>
> +/* Reference counting, callback cleanup, etc., all look racy as heck.
> + * And why is cb_set an atomic? */
Agreed so do we really want this code in mainline? is the old
code so bad that this is better?
- cb_set should not be atomic.
- T
On Wednesday August 22, [EMAIL PROTECTED] wrote:
> From: Michael J. Evans <[EMAIL PROTECTED]>
>
> In current release kernels the md module (Software RAID) uses a static array
> (dev_t[128]) to store partition/device info temporarily for autostart.
>
> This patch replaces that static array with a
On Monday August 20, [EMAIL PROTECTED] wrote:
> (cc's to me appreciated)
>
> It would be really, really nice if "umount -f" against a hung NFS
> mount actually worked on Linux. As much as I hate Solaris, I
> consider it the gold standard in this case: If I say
> "umount -f /mount/that/is/hung" it
1 - 100 of 483 matches
Mail list logo
