On 4/5/21 9:54 PM, Pierre-Louis Bossart wrote:
static const struct acpi_device_id acp3x_audio_acpi_match[] = {
{ "AMDI5682", (unsigned long)&acp3x_5682},
{ "AMDI1015", (unsigned long)&acp3x_1015},
+ { "AMDP1015", (unsigned long)&acp3x_1015p},
This isn't a valid ACPI I
On 3/30/21 9:57 PM, Pierre-Louis Bossart wrote:
On 3/30/21 10:35 AM, Mark Brown wrote:
On Tue, Mar 30, 2021 at 09:12:11PM +0530, Mukunda,Vijendar wrote:
On 3/30/21 7:52 PM, Pierre-Louis Bossart wrote:
static const struct acpi_device_id acp3x_audio_acpi_match[] = {
{ "AMD
On 3/30/21 7:52 PM, Pierre-Louis Bossart wrote:
static const struct acpi_device_id acp3x_audio_acpi_match[] = {
{ "AMDI5682", (unsigned long)&acp3x_5682},
{ "AMDI1015", (unsigned long)&acp3x_1015},
+ { "AMDP1015", (unsigned long)&acp3x_1015p},
This isn't a valid ACPI ID. A
On 3/29/21 8:20 PM, YueHaibing wrote:
While ACPI is not set, make W=1 warns:
sound/soc/amd/acp-da7219-max98357a.c:684:28: warning: ‘cz_rt5682_card’ defined
but not used [-Wunused-variable]
static struct snd_soc_card cz_rt5682_card = {
^~
sound/soc/a
On 3/26/21 10:14 PM, Arnd Bergmann wrote:
On Fri, Mar 26, 2021 at 5:44 PM Vijendar Mukunda
wrote:
Fix ACPI dependency kernel warning produced by powerpc
allyesconfig.
sound/soc/amd/acp-da7219-max98357a.c:684:28: warning:
'cz_rt5682_card' defined but not used [-Wunused-variable]
sound/soc/
On 3/19/21 7:10 AM, Vijendar Mukunda wrote:
update SPDX license for acp machine driver.
Signed-off-by: Vijendar Mukunda
---
sound/soc/amd/acp-da7219-max98357a.c | 29 +
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/sound/soc/amd/acp-da7219-max9
On 3/23/21 11:13 AM, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) produced this warning:
sound/soc/amd/acp-da7219-max98357a.c:684:28: warning: 'cz_rt5682_card' defined
but not used [-Wunused-variable]
684 | static stru
On 18/03/21 6:32 pm, Mark Brown wrote:
On Thu, Mar 18, 2021 at 02:03:47AM +0530, Vijendar Mukunda wrote:
make W=1 ARCH=x86_64 error:
acp3x-rt5682-max9836.c:(.text+0x840): multiple definition of
`soc_is_rltk_max';
sound/soc/amd/acp-da7219-max98357a.o:acp-da7219-max98357a.c:
(.text+0xd00):first
On 18/03/21 6:30 pm, Mark Brown wrote:
On Thu, Mar 18, 2021 at 02:03:46AM +0530, Vijendar Mukunda wrote:
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -1,27 +1,8 @@
-/*
- * Machine driver for AMD ACP Audio engine using DA7219 & MAX98357 codec
- *
- * Copyright 2017 Advanced Micro Devices, Inc
On 15/03/21 9:30 pm, Pierre-Louis Bossart wrote:
+static int rt5682_clk_enable(struct snd_pcm_substream *substream)
+{
+ int ret;
+ struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+
+ /*
+ * Set wclk to 48000 because the rate constraint of this driver is
+
On 07/07/20 9:05 pm, Randy Dunlap wrote:
On 7/7/20 7:17 AM, Mark Brown wrote:
On Tue, 7 Jul 2020 16:16:41 +0530, Vijendar Mukunda wrote:
Add ACPI dependency for evaluating DMIC hardware
runtime.
Applied to
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.o
On 07/07/20 11:38 am, Randy Dunlap wrote:
On 7/6/20 11:15 PM, Mukunda,Vijendar wrote:
On 07/07/20 11:14 am, Randy Dunlap wrote:
On 7/6/20 6:53 PM, Andrew Morton wrote:
The mm-of-the-moment snapshot 2020-07-06-18-53 has been uploaded to
https://nam11
On 07/07/20 11:14 am, Randy Dunlap wrote:
On 7/6/20 6:53 PM, Andrew Morton wrote:
The mm-of-the-moment snapshot 2020-07-06-18-53 has been uploaded to
https://nam11.safelinks.protection.outlook.com/?url=http:%2F%2Fwww.ozlabs.org%2F~akpm%2Fmmotm%2F&data=02%7C01%7CVijendar.Mukunda%40amd.co
On 05/12/18 4:12 AM, Yu Zhao wrote:
> AMD platform device acp_audio_dma can only be created by parent PCI
> device driver (drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c). Pass struct
> device of the parent to snd_pcm_lib_preallocate_pages() so
> dma_alloc_coherent() can use correct dma_ops. Otherwise,
On 05/12/18 4:12 AM, Yu Zhao wrote:
> We shouldn't assume CPU physical address we get from page_to_phys()
> is same as DMA address we get from dma_alloc_coherent(). On x86_64,
> we won't run into any problem with the assumption when dma_ops is
> nommu_dma_ops. However, DMA address is IOVA when IO
On 14/11/18 1:06 AM, Mark Brown wrote:
> On Mon, Nov 12, 2018 at 11:04:52AM +0530, Vijendar Mukunda wrote:
>
>> @@ -0,0 +1,655 @@
>> +/*
>> + * ACP 3.0 Register documentation
>> + *
>> + * Copyright (C) 2016 Advanced Micro Devices, Inc.
>
> Please use SPDX headers on new files.
>
Will add SP
Hi Mark,
You have merged 1-3 patch series. Still patch no 4 to 10 remaining.
Could you please take them.
Thanks,
Vijendar
On Tuesday 08 May 2018 10:17 AM, Vijendar Mukunda wrote:
Added pte offset variable in audio_substream_data structure.
Added Stoney related PTE offset macros in acp header f
On Monday 07 May 2018 11:57 AM, Mukunda,Vijendar wrote:
On Wednesday 02 May 2018 02:19 AM, Vijendar Mukunda wrote:
Added dma configuration parameters to rtd structure.
Moved dma configuration parameters initialization to
hw_params callback.
Removed hard coding in prepare and trigger
On Wednesday 02 May 2018 02:19 AM, Vijendar Mukunda wrote:
Added dma configuration parameters to rtd structure.
Moved dma configuration parameters initialization to
hw_params callback.
Removed hard coding in prepare and trigger callbacks.
Signed-off-by: Vijendar Mukunda
---
v1->v2 : Fixed cap
On Thursday 03 May 2018 11:13 AM, Daniel Kurtz wrote:
Some checkpatch nits below...
On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda
wrote:
With in ACP, There are three I2S controllers can be
configured/enabled ( I2S SP, I2S MICSP, I2S BT).
Default enabled I2S controller instance is I2S SP.
On Monday 30 April 2018 03:18 AM, Daniel Kurtz wrote:
On Thu, Apr 26, 2018 at 5:16 AM Vijendar Mukunda
wrote:
Added pte offset variable in audio_substream_data structure.
Added Stoney related PTE offset macros in acp header file.
Modified hw_params callback to assign the pte offset value
bas
On Monday 30 April 2018 03:17 AM, Daniel Kurtz wrote:
On Thu, Apr 26, 2018 at 5:16 AM Vijendar Mukunda
wrote:
Added sram bank variable to audio_substream_data structure.
Signed-off-by: Vijendar Mukunda
Move initialization to acp_dma_open(), otherwise this is:
Reviewed-by: Daniel Kurtz
On Monday 30 April 2018 03:19 AM, Daniel Kurtz wrote:
Hi Vijendar,
On Thu, Apr 26, 2018 at 5:14 AM Vijendar Mukunda
wrote:
Added dma configuration parameters to rtd structure.
Moved dma configuration parameters intialization to
hw_params callback.
Removed hard coding in prepare and trigger
On Monday 30 April 2018 03:11 AM, Daniel Kurtz wrote:
Hi Vijendar,
On Thu, Apr 26, 2018 at 5:15 AM Vijendar Mukunda
wrote:
Removed separate byte count variables for playback and capture.
Signed-off-by: Vijendar Mukunda
Reviewed-by: Daniel Kurtz
---
sound/soc/amd/acp-pcm-dma.c |
On Monday 30 April 2018 03:09 AM, Daniel Kurtz wrote:
Hi Vijendar,
On Thu, Apr 26, 2018 at 5:14 AM Vijendar Mukunda
wrote:
Added byte count register offset variables to audio_substream_data
structure. Modified dma pointer callback.
Signed-off-by: Vijendar Mukunda
Please fix the small
On Tuesday 24 April 2018 11:35 AM, Daniel Kurtz wrote:
Hi Vijendar,
On Mon, Apr 23, 2018 at 9:02 PM Vijendar Mukunda
wrote:
Added dma configuration parameters in audio_substream_data
structure. Moved dma configuration parameters initialization
to dma hw params callback.
Removed separate by
On Thursday 19 April 2018 05:57 AM, Daniel Kurtz wrote:
Hi Vijendar,
On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda
wrote:
With in ACP, There are three I2S controllers can be
configured/enabled ( I2S SP, I2S MICSP, I2S BT).
Default enabled I2S controller instance is I2S SP.
This patch pro
On Wednesday 18 April 2018 04:54 PM, Mark Brown wrote:
On Wed, Apr 18, 2018 at 04:34:52PM +0530, Vijendar Mukunda wrote:
When multiple I2S controller instances created,
i2s_instance parameter refers to i2s controller instance value.
You're missing the point here a bit - it's not just the def
On Tuesday 17 April 2018 09:39 PM, Mark Brown wrote:
On Tue, Apr 17, 2018 at 10:29:51AM +0530, Vijendar Mukunda wrote:
+#define I2S_SP_INSTANCE1
+#define I2S_BT_INSTANCE2
This is obviously very specific to the system you're working with and
therefore doesn't
On Tuesday 17 April 2018 04:47 PM, kbuild test robot wrote:
Hi Vijendar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on sound/for-next]
[also build test ERROR on v4.17-rc1 next-20180417]
[cannot apply to asoc/for-next]
[if your patch is applied to the wrong git t
On Tuesday 27 March 2018 04:57 PM, Mark Brown wrote:
On Thu, Mar 22, 2018 at 11:24:43AM +0530, Mukunda,Vijendar wrote:
On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:
You need to mention dependencies between patches when publishing and I
don't seem to have a copy of that
On Thursday 22 March 2018 07:08 AM, Mark Brown wrote:
On Wed, Mar 21, 2018 at 11:15:16AM +0530, Mukunda,Vijendar wrote:
There is a patch dependency .
Below patch not merged yet. We submitted for upstream review.
[PATCH V2] ASoC: dwc: I2S Controller instance param added
You need to mention
On Wednesday 21 March 2018 08:15 AM, Mark Brown wrote:
On Wed, Mar 21, 2018 at 01:30:40PM +1100, Stephen Rothwell wrote:
Caused by commit
363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")
I have used the sound-asoc tree from next-20180320 for today.
Dropped.
On Tuesday 28 November 2017 05:22 PM, Mark Brown wrote:
On Tue, Nov 28, 2017 at 10:13:44AM +0530, Vijendar Mukunda wrote:
- acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type);
+ status = acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type);
+ if (status)
On Friday 24 November 2017 01:41 PM, Guenter Roeck wrote:
On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar
wrote:
On Thursday 23 November 2017 10:59 PM, Mark Brown wrote:
On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote:
On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda
On Thursday 23 November 2017 10:59 PM, Mark Brown wrote:
On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote:
On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda
wrote:
added error checks in acp dma driver
Signed-off-by: Vijendar Mukunda
Signed-off-by: Akshu Agrawal
Signed-off-by:
On Tuesday 21 November 2017 08:38 PM, Deucher, Alexander wrote:
-Original Message-
From: Agrawal, Akshu
Sent: Tuesday, November 21, 2017 1:15 AM
To: Deucher, Alexander; 'Guenter Roeck'; Liam Girdwood; Mukunda,
Vijendar
Cc: Mark Brown; Jaroslav Kysela; Takashi Iwai; alsa-
37 matches
Mail list logo
