Cleanup code and remove the unused arguments
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/ksm_tests.c | 17 +++--
tools/testing/selftests/mm/soft-dirty.c | 4 ++--
.../testing/selftests/mm/split_huge_page_test.c | 4 ++--
tools/testing
Mark the arguments which cannot be removed with __unused attribute.
Signed-off-by: Muhammad Usama Anjum
---
.../selftests/mm/hugetlb_fault_after_madv.c| 4 ++--
.../testing/selftests/mm/hugetlb_madv_vs_map.c | 6 +++---
tools/testing/selftests/mm/pkey-arm64.h| 5 +++--
tools
y the code a bit as well.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/protection_keys.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/testing/selftests/mm/protection_keys.c
b/tools/testing/selftests/mm/protection_keys.c
index 23e
There are functions which have unused arguments for different
architectures. Separate the code for each architecture and move #ifdef
arch outside these functions.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/mseal_test.c | 8 +--
.../selftests/mm
Add -Wunused family of flags and fix all the warnings coming because of
argc and argv. Remove them if they aren't being used entirely. Use
__unused compiler attribute with argc where argv is being used.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/Mak
Revamp how patches are written per same kind of failure
Muhammad Usama Anjum (8):
selftests/mm: Add -Wunreachable-code and fix warnings
selftests/mm: protection_keys: Fix dead code
selftests: kselftest.h: Add __unused macro
selftests/mm: Add -Wunused family of flags
selftests/mm: Remove un
Mark the arguments which cannot be removed with __unused attribute.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/cow.c | 20 ++---
tools/testing/selftests/mm/memfd_secret.c| 4 +--
tools/testing/selftests/mm/pfnmap.c | 2 +-
tools/testing
Add __unused macro instead of using the complete verbose unused compiler
attribute. The raw __attribute__((__unused__)) is quite long and makes
code too much verbose to the kernel developer's taste.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/kselftest.h | 4
1
eclaration
specifier [-Wduplicate-decl-specifier]
static inline __always_inline
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/Makefile| 1 +
tools/testing/selftests/mm/hmm-tests.c | 5 ++---
tools/testing/selftests/mm/pkey_sighandler_tests.c | 2 +-
tools/
Add test cases to test the correctness of PFN ZERO flag of pagemap_scan
ioctl. Test with normal pages backed memory and huge pages backed
memory.
Cc: David Hildenbrand
Signed-off-by: Muhammad Usama Anjum
---
The bug has been fixed [1].
[1] https://lore.kernel.org/all/20250617143532.2375383-1
...
>>>
+
+ free(mem);
>>>
>>>
>>> Shouldn't this be an munmap() ?
>> free() is being used to free memory allocated by memalign().
>
> Oh, I missed that detail.
>
> I'm afraid memalign+free that might not be what you want: there is no
> guarantee that what you are getting hasn't bee
Add test cases to test the correctness of PFN ZERO flag of pagemap_scan
ioctl. Test with normal pages backed memory and huge pages backed
memory.
Cc: David Hildenbrand
Signed-off-by: Muhammad Usama Anjum
---
The bug has been fixed [1].
[1] https://lore.kernel.org/all/20250617143532.2375383-1
On 7/1/25 7:51 PM, David Hildenbrand wrote:
> On 30.06.25 12:24, Muhammad Usama Anjum wrote:
>> Add test cases to test the correctness of PFN ZERO flag of pagemap_scan
>> ioctl. Test with normal pages backed memory and huge pages backed
>> memory.
>
> Just to verify: wo
Add test cases to test the correctness of PFN ZERO flag of pagemap_scan
ioctl. Test with normal pages backed memory and huge pages backed
memory.
Cc: David Hildenbrand
Signed-off-by: Muhammad Usama Anjum
---
The bug has been fixed [1].
[1] https://lore.kernel.org/all/20250617143532.2375383-1
situation to ensure successful compilation and compatibility.
>
> Signed-off-by: Cynthia Huang
> Signed-off-by: Ben Zong-You Xie
Reviewed-by: Muhammad Usama Anjum
> ---
> Changes since v1:
> - Fix the SOB chain
>
> v1 :
> https://lore.kernel.org/all/202505
On 6/20/25 7:55 PM, Chen Linxuan wrote:
> On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum
> wrote:
>>
>> On 6/20/25 8:50 AM, Chen Linxuan wrote:
>>> When running `make kselftest`, the following compilation warning was
>>> encountered:
>
On 6/20/25 8:50 AM, Chen Linxuan wrote:
> When running `make kselftest`, the following compilation warning was
> encountered:
>
> mount-notify_test.c: In function ‘fanotify_rmdir’:
> mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’
> declared with attribute ‘warn_unused_resu
ious
> declaration of ‘__kernel_fsid_t’ with type ‘__kernel_fsid_t’
>81 | } __kernel_fsid_t;
> | ^~~
>
> Signed-off-by: Chen Linxuan
Reviewed-by: Muhammad Usama Anjum
Tested-by: Muhammad Usama Anjum
> ---
> .../selftests/filesystems/mount-notify/mou
ons’ defined but not used
> [-Wunused-variable]
>61 | static const char *versions[7] = {
> |^~~~
>
> Avoid those warnings through attribute((unused)).
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/s
eißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/vDSO/vdso_test_getrandom.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> b/tools/testing/selftest
On 5/2/25 5:40 PM, Thomas Weißschuh wrote:
> vgetrandom_put_state() and the variable ret in kselftest() are never used.
>
> Drop the dead code.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/vDSO/vdso_
On 5/2/25 5:40 PM, Thomas Weißschuh wrote:
> Functions definitions without any argument list produce a warning with
> -Wold-style-definition:
>
> vdso_test_correctness.c:111:13: warning: old-style function definition
> [-Wold-style-definition]
> 111 | static void fill_function_pointers()
>
On 5/2/25 5:40 PM, Thomas Weißschuh wrote:
> Nothing from err.h is used.
>
> Drop the include.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/vDSO/vdso_test_clock_getres.c | 1 -
> 1 file changed, 1 deletion(-)
cha test")
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
>
> ---
> I'm not sure if this is not a general bug in ksft_exit_skip().
> First ksft_xskip is incremented then read back through ksft_test_num() and
> then that result is incremented again.
>
On 5/2/25 5:03 PM, Thomas Weißschuh wrote:
> tclock_gettime() is a wrapper around clock_gettime().
> The first parameter of clock_gettime() is of type "clockid_t",
> not "clock_t".
>
> Use the correct type instead.
>
> Signed-off-by: Thomas Wei
On 5/2/25 5:03 PM, Thomas Weißschuh wrote:
> These functions are never used outside their defining compilation unit and
> can be made static.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/timens/clock_nanosleep.c | 2 +
On 5/2/25 5:03 PM, Thomas Weißschuh wrote:
> The TAP specification requires that the output begins with a header line.
> These headers lines are missing in the timens tests.
>
> Print such a line.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
>
-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/kselftest_harness.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/kselftest_harness.h
> b/tools/te
: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/kselftest_harness.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/kselftest_harness.h
> b/tools/testing/s
oid the issue by marking the functions static.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/kselftest_harness.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing
note: in expansion of macro '__TEST_IMPL'
> 156 | #define TEST(test_name) __TEST_IMPL(test_name, -1)
> | ^~~
> harness-selftest.c:15:1: note: in expansion of macro 'TEST'
>15 | TEST(standalone_pass) {
>
On 4/11/25 2:00 PM, Thomas Weißschuh wrote:
> Add a selftest for the kselftest harness itself so any changes can be
> validated.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Muhammad Usama Anjum
> ---
> MAINTAINERS| 1 +
> to
the description:
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/mm/cow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/cow.c
> b/tools/testing/selftests/mm/cow.c
> index 9446673645eb..f0cb14ea860
Hi,
Thanks for adding to the series Dev Jain. The series looks good. Thanks for
doing
such a series. It helps everyone.
For the series:
Reviewed-by: Muhammad Usama Anjum
On 2/28/25 9:54 PM, Brendan Jackman wrote:
> I never had much luck running mm selftests so I spent a few hours
> d
On 2/8/25 1:14 AM, Tamir Duberstein wrote:
> Move some tests into `bitmap_test_cases` and parameterize
> `test_bitmap_print_buf`. This gives us nicer output in the event of a
> failure.
>
> Signed-off-by: Tamir Duberstein
Reviewed-by: Muhammad Usama Anjum
> ---
> lib
y: Tamir Duberstein
Thanks for the conversion.
Reviewed-by: Muhammad Usama Anjum
> ---
> MAINTAINERS | 2 +-
> arch/m68k/configs/amiga_defconfig | 1 -
> arch/m68k/configs/apollo_defconfig| 1 -
> arch/m68k/configs/atari_defconfig |
On 2/8/25 1:14 AM, Tamir Duberstein wrote:
> This has been unused since commit 3aa56885e516 ("bitmap: replace
> bitmap_{from,to}_u32array") in 2018. Remove it to avoid the need to port
> it to KUnit in this series.
>
> Signed-off-by: Tamir Duberstein
Reviewed
On 1/10/25 5:12 AM, Andrew Morton wrote:
> On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook wrote:
>
>> On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote:
>>> For the all other case, why should we keep argv/argc and mark them unused
>>> as we
On 1/11/25 12:00 AM, David Laight wrote:
> On Thu, 9 Jan 2025 22:38:27 +0500
> Muhammad Usama Anjum wrote:
>
>> Remove the following warnings by removing unused argc and argv
>> parameters:
>> In function ‘main’:
>> warning: unused parameter ‘argc’ [-Wunused
On 1/14/25 10:41 AM, liuye wrote:
> Uninitialized variable: have_outer_privilege.
> Fix it.
Please improve the description. Explain how the current code
is wrong. After that add:
Reviewed-by: Muhammad Usama Anjum
>
> Signed-off-by: liuye
> ---
> tools/testing/self
On 1/9/25 10:42 PM, Kees Cook wrote:
> On Thu, Jan 09, 2025 at 10:38:27PM +0500, Muhammad Usama Anjum wrote:
>> Remove the following warnings by removing unused argc and argv
>> parameters:
>> In function ‘main’:
>> warning: unused parameter ‘argc’ [-Wunused-parameter
)) {
\
| ^~
hugetlb-madvise.c:114:9: note: in expansion of macro ‘validate_free_pages’
114 | validate_free_pages(free_hugepages - NR_HUGE_PAGES);
| ^~~
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/hugetlb-madvise.c | 2 +-
1 file changed, 1
Fix all the found type mismatch warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/thuge-gen.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/mm/thuge-gen.c
b/tools/testing/selftests/mm/thuge-gen.c
index
Add the compiler flags to catch warnings during development.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/mm/Makefile
b/tools/testing/selftests/mm/Makefile
index 63ce39d024bb5
Fix all type mismatch warnings in all uffd-* files.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/uffd-common.c | 6 +++---
tools/testing/selftests/mm/uffd-stress.c | 2 +-
tools/testing/selftests/mm/uffd-unit-tests.c | 6 +++---
3 files changed, 7 insertions(+), 7
Fix type mismatch warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/khugepaged.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/mm/khugepaged.c
b/tools/testing/selftests/mm/khugepaged.c
index 8a4d34cce36b2
Fix variable type mismatch warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/protection_keys.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/mm/protection_keys.c
b/tools/testing/selftests/mm
Fix type mismatch warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/hugetlb-read-hwpoison.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/mm/hugetlb-read-hwpoison.c
b/tools/testing/selftests/mm/hugetlb-read
Fix type mismatch warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/hugepage-vmemmap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/hugepage-vmemmap.c
b/tools/testing/selftests/mm/hugepage-vmemmap.c
index
Fix type mismatch warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/guard-pages.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/mm/guard-pages.c
b/tools/testing/selftests/mm/guard-pages.c
index ece37212a8a2e
Fix following warnings:
- Remove unused variables
- Use __attribute__(unused) with unused variables which aren't being
used and cannot be removed because of function pointer declaration
- Fix type mismatches
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/cow.c
As default_hsize is unsigned, it is always greater than equal to zero.
Remove expression which is checking if it is less than 0.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/hmm-tests.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing
) \
| ~~~^~~
../kselftest_harness.h:152:25: note: in expansion of macro ‘__TEST_IMPL’
152 | #define TEST(test_name) __TEST_IMPL(test_name, -1)
| ^~~
mdwe_test.c:23:1: note: in expansion of macro ‘TEST’
23 | TEST(prctl_flags)
| ^~~~
Signed-off-by: Muhammad Usama Anjum
---
tools
Fix type mismatch warnings in different tests.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/compaction_test.c | 2 +-
tools/testing/selftests/mm/gup_longterm.c | 3 ++-
tools/testing/selftests/mm/hugetlb_dio.c | 2 +-
tools/testing
Fix unused parameter warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/pkey-x86.h | 4 +++-
.../selftests/mm/pkey_sighandler_tests.c | 17 +++--
tools/testing/selftests/mm/protection_keys.c | 18 ++
3 files changed, 24
(int argc, char *argv[])
|~~^~
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/compaction_test.c | 2 +-
tools/testing/selftests/mm/cow.c | 2 +-
tools/testing/selftests/mm/droppable.c | 2 +-
tools/testing
Fix warnings generated by unused parameters.
Signed-off-by: Muhammad Usama Anjum
---
.../selftests/mm/hugetlb_fault_after_madv.c | 4 +-
.../selftests/mm/hugetlb_madv_vs_map.c| 6 +--
tools/testing/selftests/mm/ksm_tests.c| 17 +++---
tools/testing/selftests/mm
27;t being used. When I added them, I found tens of warnings in just
mm suite.
In this series, I'm fixing those warnings. The last check adds the
compiler flags with which the warnings have been caught.
Muhammad Usama Anjum (16):
selftests/mm: remove argc and argv unused parameters
se
Remove unused variable and fix type mismatches.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/mremap_test.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/mm/mremap_test.c
b/tools/testing/selftests/mm
Fix following warnings:
- Remove unused variables and fix following warnings:
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/mseal_test.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/mm/mseal_test.c
b/tools/testing
Fix following warnings caught by compiler:
- There are several type mismatches among different variables.
- Remove unused variable warnings.
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/pagemap_ioctl.c | 108 +++--
tools/testing/selftests/mm/vm_util.c
27;t being used. When I added them, I found tens of warnings in just
mm suite.
In this series, I'm fixing those warnings in a few files. More fixes
would be sent later.
Muhammad Usama Anjum (4):
selftests/mm: thp_settings: remove const from return type
selftests/mm: pagemap_ioctl: Fix t
Remove cost from the return type as it is ignored anyways and generates
the warning:
warning: type qualifiers ignored on function return type
[-Wignored-qualifiers]
Signed-off-by: Muhammad Usama Anjum
---
Optional fixes tag.
Fixes: 00679a183ac6 ("selftests/mm: factor out thp set
27;t being used. When I added them, I found tens of warnings in just
mm suite.
In this series, I'm fixing those warnings in a few files. More fixes
would be sent later.
Muhammad Usama Anjum (4):
selftests/mm: thp_settings: remove const from return type
selftests/mm: pagemap_ioctl: Fix t
On 12/2/24 9:58 AM, zhangjiao2 wrote:
> From: zhang jiao
>
> Delete variables "msg" and "pid" that have never been used.
>
> Signed-off-by: zhang jiao
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/ipc/msgque.c | 2 +-
>
of the result with a single ksft_print_result() which incorporates
> the parameters passed into the test into the output.
>
> Fixes: fae1980347bf ("selftests: hugetlb_dio: fixup check for initial
> conditions to skip in the start")
> Signed-off-by: Mark Brown
Reviewed-by: Muhamm
diff --git a/tools/testing/selftests/kselftest/ktap_helpers.sh
>> b/tools/testing/selftests/kselftest/ktap_helpers.sh
>> index 79a125eb24c2..a4211221ccd6 100644
>> --- a/tools/testing/selftests/kselftest/ktap_helpers.sh
>> +++ b/tools/testing/selftests/kselftest/ktap_helpers.sh
>> @@ -107,5 +107,9 @@ ktap_finished() {
>> }
>> ktap_print_totals() {
>> + if [ "$KTAP_CNT_SKIP" -gt 0 ]; then
>> + echo "# Skipped tests detected. " \
>> + "Consider enabling relevant config options to improve coverage."
>> + fi
>> echo "# Totals: pass:$KTAP_CNT_PASS fail:$KTAP_CNT_FAIL xfail:0
>> xpass:0 skip:$KTAP_CNT_SKIP error:0"
>> }
>
> thanks,
> -- Shuah
>
--
BR,
Muhammad Usama Anjum
s")
> Signed-off-by: guanjing
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/mm/pagemap_ioctl.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c
> b/tools/testing/self
ages after munmap : 100
> ok 3 : Huge pages freed successfully !
> # No. Free pages before allocation : 100
> # No. Free pages after munmap : 100
> ok 4 : Huge pages freed successfully !
> # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Thanks
> Donet
>
>
--
BR,
Muhammad Usama Anjum
only execute if huge pages are free.
Signed-off-by: Muhammad Usama Anjum
---
Before:
TAP version 13
1..4
Bail out! Error opening file
: Read-only file system (30)
# Planned tests != run tests (4 != 0)
# Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
After:
TAP version 13
1..0 # SKIP Unab
el.org
> Cc: linux-kselft...@vger.kernel.org
> Signed-off-by: Mirsad Todorovac
Reviewed-by: Muhammad Usama Anjum
> ---
> v1: initial version.
>
> tools/testing/selftests/x86/syscall_numbering.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
eate_guest_memfd(vm, page_size, flag);
> TEST_ASSERT(fd == -1 && errno == EINVAL,
> "guest_memfd() with flag '0x%lx' should fail with
> EINVAL",
Reviewed-by: Muhammad Usama Anjum
--
BR,
Muhammad Usama Anjum
-generic/unistd.h in
09f7298100ea ("Subject: [PATCH] userfaultfd: register uapi generic syscall
(aarch64)").
[1]
https://lore.kernel.org/all/20240912103151.1520254-1-usama.an...@collabora.com
--
BR,
/Muhammad Usama Anjum
e the child has
> a chance to start doing work.
>
> Fixes: 8c864371b2a1 ("selftests/mm: fix ARM related issue with fork after
> pthread_create")
> Signed-off-by: Edward Liaw
Reviewed-by: Muhammad Usama Anjum
> ---
> tools/testing/selftests/mm/uffd-common.c
)/tools/net/ynl GENS="$(YNL_GENS)" libynl.a
> $(Q)cp $(top_srcdir)/tools/net/ynl/libynl.a $(OUTPUT)/libynl.a
> +
> +EXTRA_CLEAN += \
> + $(top_srcdir)/tools/net/ynl/lib/__pycache__ \
> + $(top_srcdir)/tools/net/ynl/lib/*.[ado]
Reviewed-by: Muhammad Usama Anjum
--
BR,
Muhammad Usama Anjum
kdirty.c
> @@ -280,6 +280,7 @@ static void test_uffdio_copy(void)
> dst = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE|MAP_ANON, -1, 0);
> if (dst == MAP_FAILED) {
> ksft_test_result_fail("mmap() failed\n");
> + free(src);
> return;
> }
>
--
BR,
Muhammad Usama Anjum
Result with this patch
> ===
> # RUN hmm2.hmm2_device_private.double_map ...
> #OK hmm2.hmm2_device_private.double_map
> ok 53 hmm2.hmm2_device_private.double_map
>
> Signed-off-by: Donet Tom
Please add Fixes-by tag. Other than this
On 9/23/24 9:02 PM, Shuah Khan wrote:
> On 9/22/24 23:35, Muhammad Usama Anjum wrote:
>> ...
>>
>>>> grep -rnIF "#define __NR_userfaultfd"
>>>> tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd
>>>> 282
>
he correct number of this syscall on x86_64 is 323. Fix the header
to asm/unistd.h.
Fixes: a5c6bc590094 ("selftests/mm: remove local __NR_* definitions")
Signed-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/pagemap_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
he best course of
> action.
> We might have other NR_ defines in these two files that are causing
> problems
> for tests and tools that we haven't uncovered yet.
Added authors of these patches.
>
> thanks,
> -- Shuah
--
BR,
Muhammad Usama Anjum
On 9/18/24 10:46 AM, Muhammad Usama Anjum wrote:
> On 9/17/24 6:56 AM, Shuah Khan wrote:
>> On 9/16/24 00:32, Muhammad Usama Anjum wrote:
>>> On 9/12/24 8:44 PM, Shuah Khan wrote:
>>>> On 9/12/24 04:31, Muhammad Usama Anjum wrote:
>>>>> The valu
On 9/17/24 6:56 AM, Shuah Khan wrote:
> On 9/16/24 00:32, Muhammad Usama Anjum wrote:
>> On 9/12/24 8:44 PM, Shuah Khan wrote:
>>> On 9/12/24 04:31, Muhammad Usama Anjum wrote:
>>>> The value of __NR_userfaultfd was changed to 282 when
>>>> asm-generic/u
On 9/12/24 10:28 PM, Shuah Khan wrote:
> On 9/12/24 10:10, Shuah Khan wrote:
>> On 9/12/24 04:31, Muhammad Usama Anjum wrote:
>>> The userfaultfd is enabled in the config fragment of mm selftest suite.
>>> It must always be present. If it isn't present, we should t
On 9/12/24 8:44 PM, Shuah Khan wrote:
> On 9/12/24 04:31, Muhammad Usama Anjum wrote:
>> The value of __NR_userfaultfd was changed to 282 when
>> asm-generic/unistd.h was included. It makes the test to fail every time
>> as the correct number of this syscall on x86_64 is 323.
On 9/14/24 3:33 AM, Jeff Xu wrote:
> On Mon, Aug 19, 2024 at 3:05 AM Muhammad Usama Anjum
> wrote:
>>
>> On 8/14/24 3:29 AM, Jeff Xu wrote:
>>> Hi Muhammad
>>>
>>> On Fri, Aug 9, 2024 at 1:25 AM Muhammad Usama Anjum
>>> wrote:
>>>&g
The userfaultfd is enabled in the config fragment of mm selftest suite.
It must always be present. If it isn't present, we should throw error
and not just skip. This would have helped us catch the test breakage.
Adding this now to catch the future breakages.
Signed-off-by: Muhammad Usama
ned-off-by: Muhammad Usama Anjum
---
tools/testing/selftests/mm/pagemap_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c
b/tools/testing/selftests/mm/pagemap_ioctl.c
index fc90af2a97b80..bcc73b4e805c6 100644
--- a/tools/testing
ftest.h:74:9: error: impossible constraint in ‘asm’
>74 | __asm__ __volatile__ ("cpuid\n\t"
> \
> | ^~~
> cat_test.c:306:17: note: in expansion of macro ‘__cpuid_count’
> 306 | __cpuid_count(0x10, 2, eax, ebx,
ignature are ignored.
>
> Kernel: Linux 5.15
> Dashboard link: https://syzkaller.appspot.com/bug?extid=412c9ae97b4338c5187e
>
> ---
> [1] I expect the commit to be present in:
>
> 1. linux-5.15.y branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
--
BR,
Muhammad Usama Anjum
es with
> the same signature are ignored.
>
> Kernel: Linux 5.15
> Dashboard link: https://syzkaller.appspot.com/bug?extid=412c9ae97b4338c5187e
>
> ---
> [1] I expect the commit to be present in:
>
> 1. linux-5.15.y branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
--
BR,
Muhammad Usama Anjum
pfid is being set to tcon->crfid.fid and they are copied in each other
multiple times. Remove the memcopy between same pointers - memory
locations.
Addresses-Coverity: ("Overlapped copy")
Fixes: 9e81e8ff74b9 ("cifs: return cached_fid from open_shroot")
Signed-off-b
On Wed, 2021-04-14 at 14:00 +0200, Aurélien Aptel wrote:
> Muhammad Usama Anjum writes:
> > pfid is being set to tcon->crfid.fid and they are copied in each other
> > multiple times. Remove the memcopy between same pointers.
> >
> > Addresses-Coverity: ("Overla
pfid is being set to tcon->crfid.fid and they are copied in each other
multiple times. Remove the memcopy between same pointers.
Addresses-Coverity: ("Overlapped copy")
Fixes: 9e81e8ff74b9 ("cifs: return cached_fid from open_shroot")
Signed-off-by: Muhammad Usama Anju
ndef_symbol()")
Signed-off-by: Muhammad Usama Anjum
---
Only build has been tested.
tools/objtool/elf.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index d08f5f3670f8..17ee265a6c6b 100644
--- a/tools/objtool/
ASN.1 TPM2 key format for
the blobs")
Signed-off-by: Muhammad Usama Anjum
---
This is only build tested.
security/keys/trusted-keys/trusted_tpm2.c | 37 +++
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/security/keys/trusted-keys/trusted_tpm2.c
b/securi
If btusb_mtk_submit_wmt_recv_urb returns error, wc should be freed and
then error should be returned to prevent memory leak.
Addresses-Coverity: ("Prevent memory leak")
Fixes: 4cbb375e997d ("Bluetooth: btusb: Fixed too many in-token issue for
Mediatek Chip.")
Signed-off-by:
Reminder!
On Mon, 2021-03-29 at 09:24 +0200, Juergen Gross wrote:
> On 26.03.21 19:14, Muhammad Usama Anjum wrote:
> > Correct enum pci_channel_io_normal should be used instead of putting
> > integer value 1.
> >
> > Fix following smatch warnings:
> > drivers/
ret variable is not being set if get_capacity returns 0 in very first
try. It should be initialized with 0 for this case.
Addresses-Coverity: ("Uninitialized variable")
Fixes: d3c4a43d92 ("block: refactor blk_drop_partitions")
Signed-off-by: Muhammad Usama Anjum
---
fs/b
On Thu, 2021-04-08 at 17:13 +, scan-ad...@coverity.com wrote:
> ** CID 1503714:(DEADCODE)
> /drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: 367 in wpa_set_auth_algs()
> /drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: 357 in wpa_set_auth_algs()
>
>
> _
nlh is being checked for validtity two times when it is dereferenced in
this function. Check for validity again when updating the flags through
nlh pointer to make the dereferencing safe.
CC:
Addresses-Coverity: ("NULL pointer dereference")
Signed-off-by: Muhammad Usama Anjum
---
1 - 100 of 150 matches
Mail list logo
