Re: [RFC PATCH v3 0/2] scheduler: expose the topology of clusters and add cluster scheduler

2021-01-11 Thread Morten Rasmussen
On Fri, Jan 08, 2021 at 12:22:41PM -0800, Tim Chen wrote: > > > On 1/8/21 7:12 AM, Morten Rasmussen wrote: > > On Thu, Jan 07, 2021 at 03:16:47PM -0800, Tim Chen wrote: > >> On 1/6/21 12:30 AM, Barry Song wrote: > >>> ARM64 server chip Kunpeng 920 has 6

Re: [RFC PATCH v3 0/2] scheduler: expose the topology of clusters and add cluster scheduler

2021-01-08 Thread Morten Rasmussen
On Thu, Jan 07, 2021 at 03:16:47PM -0800, Tim Chen wrote: > On 1/6/21 12:30 AM, Barry Song wrote: > > ARM64 server chip Kunpeng 920 has 6 clusters in each NUMA node, and each > > cluster has 4 cpus. All clusters share L3 cache data while each cluster > > has local L3 tag. On the other hand, each cl

Re: [PATCH] sched: Add schedutil overview

2020-12-18 Thread Morten Rasmussen
the typo in the original sum (u_cfs -> u_clamp). > (also, does this need a word about runnable rt tasks => goto max?) What is actually the intended policy there? I thought it was goto max unless rt was clamped, but if I read the code correctly in schedutil_cpu_util() the current policy is only goto max if uclamp isn't in use at all, including cfs. The write-up looks good to me. Reviewed-by: Morten Rasmussen Morten

Re: [RFC] Documentation/scheduler/schedutil.txt

2020-11-20 Thread Morten Rasmussen
Hi Peter, Looks like a nice summary to me. On Fri, Nov 20, 2020 at 08:55:27AM +0100, Peter Zijlstra wrote: > Hi, > > I was recently asked to explain how schedutil works, the below write-up > is the result of that and I figured we might as well stick it in the > tree. > > Not as a patch for easy

Re: [PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model

2020-11-05 Thread Morten Rasmussen
On Thu, Nov 05, 2020 at 10:09:05AM +, Lukasz Luba wrote: > > > On 11/5/20 9:18 AM, Morten Rasmussen wrote: > > On Tue, Nov 03, 2020 at 09:05:57AM +, Lukasz Luba wrote: > > > @@ -79,7 +82,8 @@ struct em_data_callback { > > > struct em_perf_domain *em

Re: [PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model

2020-11-05 Thread Morten Rasmussen
On Tue, Nov 03, 2020 at 09:05:57AM +, Lukasz Luba wrote: > @@ -79,7 +82,8 @@ struct em_data_callback { > struct em_perf_domain *em_cpu_get(int cpu); > struct em_perf_domain *em_pd_get(struct device *dev); > int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, > -

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Morten Rasmussen
On Mon, Oct 19, 2020 at 02:41:57PM +0100, Jonathan Cameron wrote: > On Mon, 19 Oct 2020 15:10:52 +0200 > Morten Rasmussen wrote: > > > Hi Jonathan, > > > > On Mon, Oct 19, 2020 at 01:32:26PM +0100, Jonathan Cameron wrote: > > > On Mon, 19 Oct 2020 12:35:

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Morten Rasmussen
On Mon, Oct 19, 2020 at 02:50:53PM +0200, Peter Zijlstra wrote: > On Mon, Oct 19, 2020 at 01:32:26PM +0100, Jonathan Cameron wrote: > > On Mon, 19 Oct 2020 12:35:22 +0200 > > Peter Zijlstra wrote: > > > > I'm confused by all of this. The core level is exactly what you seem to > > > want. > > > >

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-19 Thread Morten Rasmussen
Hi Jonathan, On Mon, Oct 19, 2020 at 01:32:26PM +0100, Jonathan Cameron wrote: > On Mon, 19 Oct 2020 12:35:22 +0200 > Peter Zijlstra wrote: > > > On Fri, Oct 16, 2020 at 11:27:02PM +0800, Jonathan Cameron wrote: > > > Both ACPI and DT provide the ability to describe additional layers of > > > to

Re: [PATCH] arm64: dts: sdm845: Add CPU topology

2019-06-06 Thread Morten Rasmussen
On Thu, Jun 06, 2019 at 10:44:58AM +0200, Vincent Guittot wrote: > On Thu, 6 Jun 2019 at 10:34, Dietmar Eggemann > wrote: > > > > On 6/6/19 10:20 AM, Vincent Guittot wrote: > > > On Thu, 6 Jun 2019 at 09:49, Quentin Perret > > > wrote: > > >> > > >> Hi Vincent, > > >> > > >> On Thursday 06 Jun

Re: [PATCH v6 1/7] Documentation: DT: arm: add support for sockets defining package boundaries

2019-05-31 Thread Morten Rasmussen
On Fri, May 31, 2019 at 10:37:43AM +0100, Sudeep Holla wrote: > On Thu, May 30, 2019 at 10:42:54PM +0100, Russell King - ARM Linux admin > wrote: > > On Thu, May 30, 2019 at 12:51:03PM +0100, Morten Rasmussen wrote: > > > On Wed, May 29, 2019 at 07:39:17PM -0400, Andrew F. Da

Re: [PATCH v6 1/7] Documentation: DT: arm: add support for sockets defining package boundaries

2019-05-30 Thread Morten Rasmussen
On Thu, May 30, 2019 at 08:56:03AM -0400, Andrew F. Davis wrote: > On 5/30/19 7:51 AM, Morten Rasmussen wrote: > >On Wed, May 29, 2019 at 07:39:17PM -0400, Andrew F. Davis wrote: > >>On 5/29/19 5:13 PM, Atish Patra wrote: > >>>From: Sudeep Holla > >>> &g

Re: [PATCH v6 1/7] Documentation: DT: arm: add support for sockets defining package boundaries

2019-05-30 Thread Morten Rasmussen
On Wed, May 29, 2019 at 07:39:17PM -0400, Andrew F. Davis wrote: > On 5/29/19 5:13 PM, Atish Patra wrote: > >From: Sudeep Holla > > > >The current ARM DT topology description provides the operating system > >with a topological view of the system that is based on leaf nodes > >representing either c

Re: [RFC PATCH 3/6] sched/dl: Try better placement even for deadline tasks that do not block

2019-05-07 Thread Morten Rasmussen
On Tue, May 07, 2019 at 03:13:40PM +0100, Quentin Perret wrote: > On Monday 06 May 2019 at 06:48:33 (+0200), Luca Abeni wrote: > > @@ -1591,6 +1626,7 @@ select_task_rq_dl(struct task_struct *p, int cpu, int > > sd_flag, int flags) > > > > rcu_read_lock(); > > curr = READ_ONCE(rq->curr);

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-10 Thread Morten Rasmussen
Hi, On Mon, Apr 08, 2019 at 02:45:32PM -0700, Song Liu wrote: > Servers running latency sensitive workload usually aren't fully loaded for > various reasons including disaster readiness. The machines running our > interactive workloads (referred as main workload) have a lot of spare CPU > cycle

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-03-07 Thread Morten Rasmussen
On Tue, Feb 26, 2019 at 07:53:58PM +0100, Peter Zijlstra wrote: > On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > > Added sysfs package_threads, package_threads_list > > > > Added this attribute to show threads siblings in a package. > > Exactly same as "core_siblings above",

Re: [PATCH 05/14] cpu topology: Export die_id

2019-03-07 Thread Morten Rasmussen
Hi Len, On Tue, Feb 26, 2019 at 01:20:03AM -0500, Len Brown wrote: > From: Len Brown > > Export die_id in cpu topology, for the benefit of hardware that > has multiple-die/package. > > Signed-off-by: Len Brown > Cc: linux-...@vger.kernel.org > --- > Documentation/cputopology.txt | 6 ++

[tip:sched/core] sched/fair: Add over-utilization/tipping point indicator

2018-12-11 Thread tip-bot for Morten Rasmussen
Commit-ID: 2802bf3cd936fe2c8033a696d375a4d9d3974de4 Gitweb: https://git.kernel.org/tip/2802bf3cd936fe2c8033a696d375a4d9d3974de4 Author: Morten Rasmussen AuthorDate: Mon, 3 Dec 2018 09:56:25 + Committer: Ingo Molnar CommitDate: Tue, 11 Dec 2018 15:17:01 +0100 sched/fair: Add over

Re: [RFT PATCH v1 0/4] Unify CPU topology across ARM64 & RISC-V

2018-12-07 Thread Morten Rasmussen
Hi, On Thu, Nov 29, 2018 at 03:28:16PM -0800, Atish Patra wrote: > The cpu-map DT entry in ARM64 can describe the CPU topology in > much better way compared to other existing approaches. RISC-V can > easily adopt this binding to represent it's own CPU topology. > Thus, both cpu-map DT binding and

Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT

2018-11-05 Thread Morten Rasmussen
On Mon, Nov 05, 2018 at 10:10:34AM +0100, Vincent Guittot wrote: > On Fri, 2 Nov 2018 at 16:36, Dietmar Eggemann > wrote: > > > > On 10/26/18 6:11 PM, Vincent Guittot wrote: > > > The current implementation of load tracking invariance scales the > > > contribution with current frequency and uarch

Re: [PATCH 1/4] sched/topology: SD_ASYM_CPUCAPACITY flag detection

2018-09-11 Thread Morten Rasmussen
On Mon, Sep 10, 2018 at 10:21:11AM +0200, Ingo Molnar wrote: > > * Morten Rasmussen wrote: > > > The SD_ASYM_CPUCAPACITY sched_domain flag is supposed to mark the > > sched_domain in the hierarchy where all cpu capacities are visible for > > any cpu's point of

[tip:sched/core] sched/core: Disable SD_PREFER_SIBLING on asymmetric CPU capacity domains

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: 9c63e84db29bcf584040931ad97c2edd11e35f6c Gitweb: https://git.kernel.org/tip/9c63e84db29bcf584040931ad97c2edd11e35f6c Author: Morten Rasmussen AuthorDate: Wed, 4 Jul 2018 11:17:50 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:54 +0200 sched/core: Disable

[tip:sched/core] sched/fair: Consider misfit tasks when load-balancing

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: cad68e552e7774b68ae6a2c5fedb792936098b72 Gitweb: https://git.kernel.org/tip/cad68e552e7774b68ae6a2c5fedb792936098b72 Author: Morten Rasmussen AuthorDate: Wed, 4 Jul 2018 11:17:42 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:50 +0200 sched/fair: Consider

[tip:sched/core] sched/fair: Add 'group_misfit_task' load-balance type

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: 3b1baa6496e6b7ad016342a9d256bdfb072ce902 Gitweb: https://git.kernel.org/tip/3b1baa6496e6b7ad016342a9d256bdfb072ce902 Author: Morten Rasmussen AuthorDate: Wed, 4 Jul 2018 11:17:40 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:49 +0200 sched/fair: Add

[tip:sched/core] sched/fair: Add sched_group per-CPU max capacity

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: e3d6d0cb66f2351cbfd09fbae04eb9804afe9577 Gitweb: https://git.kernel.org/tip/e3d6d0cb66f2351cbfd09fbae04eb9804afe9577 Author: Morten Rasmussen AuthorDate: Wed, 4 Jul 2018 11:17:41 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:49 +0200 sched/fair: Add

[tip:sched/core] sched/topology: Add static_key for asymmetric CPU capacity optimizations

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: df054e8445a4011e3d693c2268129c0456108663 Gitweb: https://git.kernel.org/tip/df054e8445a4011e3d693c2268129c0456108663 Author: Morten Rasmussen AuthorDate: Wed, 4 Jul 2018 11:17:39 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:48 +0200 sched/topology: Add

[tip:sched/core] sched/topology, arch/arm: Rebuild sched_domain hierarchy when CPU capacity changes

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: e1799a80a4f5a463f252b7325da8bb66dfd55471 Gitweb: https://git.kernel.org/tip/e1799a80a4f5a463f252b7325da8bb66dfd55471 Author: Morten Rasmussen AuthorDate: Fri, 20 Jul 2018 14:32:34 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:48 +0200 sched/topology, arch

[tip:sched/core] sched/topology, drivers/base/arch_topology: Rebuild the sched_domain hierarchy when capacities change

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: bb1fbdd3c3fd12b612c7d8cdf13bd6bfeebdefa3 Gitweb: https://git.kernel.org/tip/bb1fbdd3c3fd12b612c7d8cdf13bd6bfeebdefa3 Author: Morten Rasmussen AuthorDate: Fri, 20 Jul 2018 14:32:32 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:47 +0200 sched/topology

[tip:sched/core] sched/topology, arch/arm64: Rebuild the sched_domain hierarchy when the CPU capacity changes

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: 3ba09df4b8b6e3f01ed6381e8fb890840fd0bca3 Gitweb: https://git.kernel.org/tip/3ba09df4b8b6e3f01ed6381e8fb890840fd0bca3 Author: Morten Rasmussen AuthorDate: Fri, 20 Jul 2018 14:32:33 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:47 +0200 sched/topology, arch

[tip:sched/core] sched/topology: Add SD_ASYM_CPUCAPACITY flag detection

2018-09-10 Thread tip-bot for Morten Rasmussen
Commit-ID: 05484e0984487d42e97c417cbb0697fa9d16e7e9 Gitweb: https://git.kernel.org/tip/05484e0984487d42e97c417cbb0697fa9d16e7e9 Author: Morten Rasmussen AuthorDate: Fri, 20 Jul 2018 14:32:31 +0100 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 11:05:45 +0200 sched/topology: Add

Re: [PATCHv4 01/12] sched: Add static_key for asymmetric cpu capacity optimizations

2018-08-02 Thread Morten Rasmussen
On Tue, Jul 31, 2018 at 12:59:16PM +0200, Peter Zijlstra wrote: > > Combined with that SD_ASYM.. rework I ended up with the below. > > Holler if you want it changed :-) Looks good to me. Thanks, Morten

Re: [PATCHv4 00/12] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems

2018-07-31 Thread Morten Rasmussen
On Tue, Jul 31, 2018 at 01:10:49PM +0100, Valentin Schneider wrote: > Hi Peter, > > On 31/07/18 13:00, Peter Zijlstra wrote: > > > > > > Aside from the first patch, which I posted the change on, I've picked up > > until 10. I think that other SD_ASYM patch-set replaces 11 and 12, > > right? > >

Re: [PATCH 1/4] sched/topology: SD_ASYM_CPUCAPACITY flag detection

2018-07-24 Thread Morten Rasmussen
On Mon, Jul 23, 2018 at 05:07:50PM +0100, Qais Yousef wrote: > On 23/07/18 16:27, Morten Rasmussen wrote: > >It does increase the cost of things like hotplug slightly and > >repartitioning of root_domains a slightly but I don't see how we can > >avoid it if we want gen

Re: [PATCH 1/4] sched/topology: SD_ASYM_CPUCAPACITY flag detection

2018-07-23 Thread Morten Rasmussen
On Mon, Jul 23, 2018 at 02:25:34PM +0100, Qais Yousef wrote: > Hi Morten > > On 20/07/18 14:32, Morten Rasmussen wrote: > >The SD_ASYM_CPUCAPACITY sched_domain flag is supposed to mark the > >sched_domain in the hierarchy where all cpu capacities are visible for > >

Re: [PATCHv4 11/12] sched/core: Disable SD_ASYM_CPUCAPACITY for root_domains without asymmetry

2018-07-20 Thread Morten Rasmussen
On Thu, Jul 05, 2018 at 04:03:11PM +0100, Quentin Perret wrote: > On Thursday 05 Jul 2018 at 15:13:49 (+0100), Morten Rasmussen wrote: > > 3. Detecting the flag in generic kernel/sched/* code means that all > > architectures will pay the for the overhead when building

[PATCH 2/4] drivers/base/arch_topology: Rebuild sched_domain hierarchy when capacities change

2018-07-20 Thread Morten Rasmussen
the sched_domain hierarchy whenever the reported per-cpu capacity (arch_scale_cpu_capacity()) changes. This patch ensure that a full sched_domain rebuild happens when cpu capacity changes occur. cc: Greg Kroah-Hartman Signed-off-by: Morten Rasmussen --- drivers/base/arch_topology.c | 26

[PATCH 0/4] sched/topology: Set SD_ASYM_CPUCAPACITY flag automatically

2018-07-20 Thread Morten Rasmussen
thout knowledge about the cpusets. Rather than exposing cpusets to architecture code this patch set moves the responsibility for setting the flag to generic topology code which is simpler and make the code architecture agnostic. Morten Rasmussen (4): sched/topology: SD_ASYM_CPUCAPACITY flag dete

[PATCH 3/4] arch/arm64: Rebuild sched_domain hierarchy when cpu capacity changes

2018-07-20 Thread Morten Rasmussen
to implement arch_update_cpu_topology() which isn't yet implemented for arm64. This patch points the arm64 implementation to arch_topology driver to ensure that full hierarchy rebuild happens when needed. cc: Catalin Marinas cc: Will Deacon Signed-off-by: Morten Rasmussen --- arch/

[PATCH 1/4] sched/topology: SD_ASYM_CPUCAPACITY flag detection

2018-07-20 Thread Morten Rasmussen
sible for is to implement arch_scale_cpu_capacity() and force a full rebuild of the sched_domain hierarchy if capacities are updated, e.g. later in the boot process when cpufreq has initialized. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- include/linux/sched/topology.h

[PATCH 4/4] arch/arm: Rebuild sched_domain hierarchy when cpu capacity changes

2018-07-20 Thread Morten Rasmussen
to implement arch_update_cpu_topology() which isn't yet implemented for arm. This patch points the arm implementation to arch_topology driver to ensure that full hierarchy rebuild happens when needed. cc: Russell King Signed-off-by: Morten Rasmussen --- arch/arm/include/asm/topology.

Re: arm: v4.18-rc5 with cpuidle on TC2 (A7 boot) spectre v2 issue

2018-07-20 Thread Morten Rasmussen
On Thu, Jul 19, 2018 at 02:32:22PM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 19, 2018 at 11:01:10AM +0100, Russell King - ARM Linux wrote: > > On Thu, Jul 19, 2018 at 11:42:50AM +0200, Dietmar Eggemann wrote: > > > Hi, > > > > > > running v4.18-rc5 (plus still missing "power: vexpress:

Re: arm: v4.18-rc5 with cpuidle on TC2 (A7 boot) spectre v2 issue

2018-07-19 Thread Morten Rasmussen
On Thu, Jul 19, 2018 at 11:01:10AM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 19, 2018 at 11:42:50AM +0200, Dietmar Eggemann wrote: > > Hi, > > > > running v4.18-rc5 (plus still missing "power: vexpress: fix corruption in > > notifier registration", otherwise I get this rcu_sched stall i

Re: [PATCHv4 00/12] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems

2018-07-09 Thread Morten Rasmussen
On Fri, Jul 06, 2018 at 12:18:27PM +0200, Vincent Guittot wrote: > Hi Morten, > > On Wed, 4 Jul 2018 at 12:18, Morten Rasmussen > wrote: > > > > On asymmetric cpu capacity systems (e.g. Arm big.LITTLE) it is crucial > > for performance that cpu intensive task

Re: [PATCHv4 12/12] sched/core: Disable SD_PREFER_SIBLING on asymmetric cpu capacity domains

2018-07-06 Thread Morten Rasmussen
On Fri, Jul 06, 2018 at 12:18:17PM +0200, Vincent Guittot wrote: > On Wed, 4 Jul 2018 at 12:18, Morten Rasmussen > wrote: > > > > The 'prefer sibling' sched_domain flag is intended to encourage > > spreading tasks to sibling sched_domain to take advantage o

Re: [PATCHv4 11/12] sched/core: Disable SD_ASYM_CPUCAPACITY for root_domains without asymmetry

2018-07-05 Thread Morten Rasmussen
On Thu, Jul 05, 2018 at 02:31:43PM +0100, Quentin Perret wrote: > Hi Morten, > > On Wednesday 04 Jul 2018 at 11:17:49 (+0100), Morten Rasmussen wrote: > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > > index 71330e0e41db..29c186961345 100644 > > --

Re: [PATCHv3 0/9] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems

2018-07-04 Thread Morten Rasmussen
Hi, On Tue, Jul 03, 2018 at 02:28:28AM +, Gaku Inami wrote: > Hi, > > > -Original Message- > > From: Morten Rasmussen > > Sent: Wednesday, June 20, 2018 6:06 PM > > To: pet...@infradead.org; mi...@redhat.com > > Cc: valentin.schnei.

[PATCHv4 02/12] sched/fair: Add group_misfit_task load-balance type

2018-07-04 Thread Morten Rasmussen
sched_groups for misfit tasks, each cpu is responsible for tracking misfit tasks themselves and update the rq->misfit_task flag. This means checking task utilization when tasks are scheduled and on sched_tick. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sc

[PATCHv4 00/12] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems

2018-07-04 Thread Morten Rasmussen
domain->overload renaming - Changed type of root_domain->overload to int - Wrapped accesses of rq->rd->overload with READ/WRITE_ONCE - v1 Tested-by: Gaku Inami Chris Redpath (1): sched/fair: Don't move tasks to lower capacity cpus unless necessary Morten Rasmussen (6): sched: Add st

[PATCHv4 03/12] sched: Add sched_group per-cpu max capacity

2018-07-04 Thread Morten Rasmussen
pacities (e.g. big.LITTLE). cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 24 kernel/sched/sched.h| 1 + kernel/sched/topology.c | 2 ++ 3 files changed, 23 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fa

[PATCHv4 05/12] sched/fair: Kick nohz balance if rq->misfit_task_load

2018-07-04 Thread Morten Rasmussen
Kernel - see [1]. [1]: https://lists.linaro.org/pipermail/eas-dev/2016-September/000551.html cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.

[PATCHv4 12/12] sched/core: Disable SD_PREFER_SIBLING on asymmetric cpu capacity domains

2018-07-04 Thread Morten Rasmussen
e sched_domain level immediately below SD_ASYM_CPUCAPACITY. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/topology.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.

[PATCHv4 04/12] sched/fair: Consider misfit tasks when load-balancing

2018-07-04 Thread Morten Rasmussen
cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 51 +-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 09ede4321a3d..6e885d92fad2 100644 --- a/kernel/sch

[PATCHv4 09/12] sched/fair: Set rq->rd->overload when misfit

2018-07-04 Thread Morten Rasmussen
p is flagged as having a misfit task. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 6 -- kernel/sched/sched.h | 6 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c

[PATCHv4 10/12] sched/fair: Don't move tasks to lower capacity cpus unless necessary

2018-07-04 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index de84f5a9a65a..06beefa02420 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8793,6 +8793,17 @@ static struct rq *find_busiest_queue

[PATCHv4 08/12] sched: Wrap rq->rd->overload accesses with READ/WRITE_ONCE

2018-07-04 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 6 +++--- kernel/sched/sched.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ee26eeb188ef..d0641ba7bea1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8428,8

[PATCHv4 06/12] sched/fair: Change prefer_sibling type to bool

2018-07-04 Thread Morten Rasmussen
From: Valentin Schneider This variable is entirely local to update_sd_lb_stats, so we can safely change its type and slightly clean up its initialisation. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 6

[PATCHv4 11/12] sched/core: Disable SD_ASYM_CPUCAPACITY for root_domains without asymmetry

2018-07-04 Thread Morten Rasmussen
lling arch_scale_cpu_capacity() directly as rq->cpu_capacity_orig hasn't been set yet early in the boot process. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/topology.c | 20 1 file changed, 20 insertions(+) diff --git a/kernel/sched/topolo

[PATCHv4 01/12] sched: Add static_key for asymmetric cpu capacity optimizations

2018-07-04 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 3 +++ kernel/sched/sched.h| 1 + kernel/sched/topology.c | 19 +++ 3 files changed, 23 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 321cd5dcf2e8..85fb7e8ff5c8 100644 --- a/kernel/sched/fair.c

[PATCHv4 07/12] sched: Change root_domain->overload type to int

2018-07-04 Thread Morten Rasmussen
pact any struct layout and can be assigned to the root_domain field. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/sched.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/sched.h b/kernel

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-07-02 Thread Morten Rasmussen
On Thu, Jun 28, 2018 at 07:16:46PM +0200, Dietmar Eggemann wrote: > On 06/28/2018 10:48 AM, Morten Rasmussen wrote: > >On Wed, Jun 27, 2018 at 05:41:22PM +0200, Dietmar Eggemann wrote: > >>On 06/22/2018 04:36 PM, Morten Rasmussen wrote: > >>>On Fri, Jun 22, 2018 at 09

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-28 Thread Morten Rasmussen
On Wed, Jun 27, 2018 at 05:41:22PM +0200, Dietmar Eggemann wrote: > On 06/22/2018 04:36 PM, Morten Rasmussen wrote: > >On Fri, Jun 22, 2018 at 09:22:22AM +0100, Quentin Perret wrote: > >>Hi Morten, > >> > >>On Wednesday 20 Jun 2018 at 10:05:41 (+0100), Morte

Re: [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-22 Thread Morten Rasmussen
On Fri, Jun 22, 2018 at 09:22:22AM +0100, Quentin Perret wrote: > Hi Morten, > > On Wednesday 20 Jun 2018 at 10:05:41 (+0100), Morten Rasmussen wrote: > > +static void update_asym_cpucapacity(int cpu) > > +{ > > + int enable = false; > > + > > + rcu_read

[PATCHv3 2/9] sched/fair: Add group_misfit_task load-balance type

2018-06-20 Thread Morten Rasmussen
sched_groups for misfit tasks, each cpu is responsible for tracking misfit tasks themselves and update the rq->misfit_task flag. This means checking task utilization when tasks are scheduled and on sched_tick. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sc

[PATCHv3 3/9] sched: Add sched_group per-cpu max capacity

2018-06-20 Thread Morten Rasmussen
pacities (e.g. big.LITTLE). cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 24 kernel/sched/sched.h| 1 + kernel/sched/topology.c | 2 ++ 3 files changed, 23 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fa

[PATCHv3 5/9] sched/fair: Kick nohz balance if rq->misfit_task

2018-06-20 Thread Morten Rasmussen
Kernel - see [1]. [1]: https://lists.linaro.org/pipermail/eas-dev/2016-September/000551.html cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.

[PATCHv3 4/9] sched/fair: Consider misfit tasks when load-balancing

2018-06-20 Thread Morten Rasmussen
cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 51 +-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6af3354e9e26..11f3efa299ca 100644 --- a/kernel/sch

[PATCHv3 8/9] sched/fair: Set sd->overload when misfit

2018-06-20 Thread Morten Rasmussen
p is flagged as having a misfit task. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 6 -- kernel/sched/sched.h | 6 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c

[PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations

2018-06-20 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 3 +++ kernel/sched/sched.h| 1 + kernel/sched/topology.c | 18 ++ 3 files changed, 22 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e497c05aab7f..6116d1b7e441 100644 --- a/kernel/sched/fair.c

[PATCHv3 9/9] sched/fair: Don't move tasks to lower capacity cpus unless necessary

2018-06-20 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index aac7b9155bc4..5d612d3906d5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8796,6 +8796,17 @@ static struct rq *find_busiest_queue

[PATCHv3 7/9] sched: Wrap rq->rd->overload accesses with READ/WRITE_ONCE

2018-06-20 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 6 +++--- kernel/sched/sched.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 545fa3600894..9dd147c71dd0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8431,8

[PATCHv3 0/9] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems

2018-06-20 Thread Morten Rasmussen
- Wrapped accesses of rq->rd->overload with READ/WRITE_ONCE - v1 Tested-by: Gaku Inami Chris Redpath (1): sched/fair: Don't move tasks to lower capacity cpus unless necessary Morten Rasmussen (4): sched: Add static_key for asymmetric cpu capacity optimizations sched/fair: Add grou

[PATCHv3 6/9] sched: Change root_domain->overload type to int

2018-06-20 Thread Morten Rasmussen
From: Valentin Schneider sizeof(_Bool) is implementation defined, so let's just go with 'int' as is done for other structures e.g. sched_domain_shared->has_idle_cores. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen

Re: [PATCH] arm64: topology: Avoid checking numa mask for scheduler MC selection

2018-06-06 Thread Morten Rasmussen
On Wed, Jun 06, 2018 at 09:53:39AM -0500, Jeremy Linton wrote: > On 06/06/2018 09:44 AM, Morten Rasmussen wrote: > >On Tue, Jun 05, 2018 at 02:08:37PM -0500, Jeremy Linton wrote: > >>The numa mask subset check has problems if !CONFIG_NUMA, over hotplug > >>operations

Re: [PATCH] arm64: topology: Avoid checking numa mask for scheduler MC selection

2018-06-06 Thread Morten Rasmussen
On Tue, Jun 05, 2018 at 02:08:37PM -0500, Jeremy Linton wrote: > The numa mask subset check has problems if !CONFIG_NUMA, over hotplug > operations or during early boot. Lets disable the NUMA siblings checks > for the time being, as NUMA in socket machines have LLC's that will > assure that the sch

Re: [PATCH v8 11/13] arm64: topology: enable ACPI/PPTT based CPU topology

2018-05-03 Thread Morten Rasmussen
returned > for all subsequent levels. > > Signed-off-by: Jeremy Linton Acked-by: Morten Rasmussen

Re: [PATCH v8 10/13] arm64: topology: rename cluster_id

2018-05-03 Thread Morten Rasmussen
On Wed, Apr 25, 2018 at 06:31:18PM -0500, Jeremy Linton wrote: > Lets match the name of the arm64 topology field > to the kernel macro that uses it. > > Signed-off-by: Jeremy Linton Acked-by: Morten Rasmussen

Re: [PATCH v8 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-05-03 Thread Morten Rasmussen
e LLC is partitioned between the NUMA nodes. > > Signed-off-by: Jeremy Linton This patch looks good to me. Acked-by: Morten Rasmussen

Re: [PATCH v8 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-05-03 Thread Morten Rasmussen
On Wed, May 02, 2018 at 05:32:54PM -0500, Jeremy Linton wrote: > Hi, > > On 05/02/2018 06:49 AM, Morten Rasmussen wrote: > >On Tue, May 01, 2018 at 03:33:33PM +0100, Sudeep Holla wrote: > >> > >> > >>On 26/04/18 00:31, Jeremy Linton wrote: > >>

Re: [PATCH v8 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-05-02 Thread Morten Rasmussen
On Tue, May 01, 2018 at 03:33:33PM +0100, Sudeep Holla wrote: > > > On 26/04/18 00:31, Jeremy Linton wrote: > > Now that we have an accurate view of the physical topology > > we need to represent it correctly to the scheduler. Generally MC > > should equal the LLC in the system, but there are a n

Re: [PATCH] sched: support dynamiQ cluster

2018-04-13 Thread Morten Rasmussen
On Thu, Apr 12, 2018 at 08:22:11PM +0200, Peter Zijlstra wrote: > On Tue, Apr 10, 2018 at 02:19:50PM +0100, Morten Rasmussen wrote: > > As said above, I see your point about completion time might suffer in > > some cases for low utilization tasks, but I don't see how

Re: [PATCH] sched: support dynamiQ cluster

2018-04-10 Thread Morten Rasmussen
On Mon, Apr 09, 2018 at 09:34:00AM +0200, Vincent Guittot wrote: > Hi Morten, > > On 6 April 2018 at 14:58, Morten Rasmussen wrote: > > On Thu, Apr 05, 2018 at 06:22:48PM +0200, Vincent Guittot wrote: > >> Hi Morten, > >> > >> On 5 April 2018 at 17:46

Re: [PATCH] sched: support dynamiQ cluster

2018-04-06 Thread Morten Rasmussen
On Thu, Apr 05, 2018 at 06:22:48PM +0200, Vincent Guittot wrote: > Hi Morten, > > On 5 April 2018 at 17:46, Morten Rasmussen wrote: > > On Wed, Apr 04, 2018 at 03:43:17PM +0200, Vincent Guittot wrote: > >> On 4 April 2018 at 12:44, Valentin Schneider > >> wrot

Re: [PATCH] sched: support dynamiQ cluster

2018-04-05 Thread Morten Rasmussen
On Wed, Apr 04, 2018 at 03:43:17PM +0200, Vincent Guittot wrote: > On 4 April 2018 at 12:44, Valentin Schneider > wrote: > > Hi, > > > > On 03/04/18 13:17, Vincent Guittot wrote: > >> Hi Valentin, > >> > > [...] > >>> > >>> I believe ASYM_PACKING behaves better here because the workload is only >

Re: [PATCH] sched: support dynamiQ cluster

2018-03-29 Thread Morten Rasmussen
On Wed, Mar 28, 2018 at 09:46:55AM +0200, Vincent Guittot wrote: > Arm DynamiQ system can integrate cores with different micro architecture > or max OPP under the same DSU so we can have cores with different compute > capacity at the LLC (which was not the case with legacy big/LITTLE > architecture

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Morten Rasmussen
On Thu, Mar 22, 2018 at 09:27:43AM -0700, Joel Fernandes wrote: > Hi, > > On Tue, Mar 20, 2018 at 2:43 AM, Dietmar Eggemann > wrote: > > > > From: Quentin Perret > > > > In case an energy model is available, waking tasks are re-routed into a > > new energy-aware placement algorithm. The eligible

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Morten Rasmussen
On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: > On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi > wrote: > > [...] > > > >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int > >> prev_cpu, int sd_flag, int wake_f > >> break; > >>

Re: [RFC PATCH 4/6] sched/fair: Introduce an energy estimation helper function

2018-03-21 Thread Morten Rasmussen
On Wed, Mar 21, 2018 at 04:15:13PM +0100, Juri Lelli wrote: > On 21/03/18 13:55, Quentin Perret wrote: > > On Wednesday 21 Mar 2018 at 13:59:25 (+0100), Juri Lelli wrote: > > > On 21/03/18 12:26, Patrick Bellasi wrote: > > > > On 21-Mar 10:04, Juri Lelli wrote: > > [...] > > > > > > > + /* > >

Re: [PATCHv2 0/7] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems

2018-03-20 Thread Morten Rasmussen
Hi, On Tue, Mar 20, 2018 at 05:30:00AM +, Gaku Inami wrote: > Hi > > > -Original Message- > > From: Morten Rasmussen [mailto:morten.rasmus...@arm.com] > > Sent: Thursday, March 15, 2018 11:47 PM > > To: pet...@infradead.org; mi...@redhat.com >

[PATCHv2 0/7] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems

2018-03-15 Thread Morten Rasmussen
to make sense no benefit has been proven. - Dropped root_domain->overload renaming - Changed type of root_domain->overload to int - Wrapped accesses of rq->rd->overload with READ/WRITE_ONCE - v1 Tested-by: Gaku Inami Morten Rasmussen (3): sched: Add static_key for asymmetric cpu capacit

[PATCHv2 3/7] sched/fair: Consider misfit tasks when load-balancing

2018-03-15 Thread Morten Rasmussen
go Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1e06c722bc2e..496062860733 100644 --- a/kernel/sched/fair.

[PATCHv2 2/7] sched/fair: Add group_misfit_task load-balance type

2018-03-15 Thread Morten Rasmussen
sched_groups for misfit tasks, each cpu is responsible for tracking misfit tasks themselves and update the rq->misfit_task flag. This means checking task utilization when tasks are scheduled and on sched_tick. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sc

[PATCHv2 1/7] sched: Add static_key for asymmetric cpu capacity optimizations

2018-03-15 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 3 +++ kernel/sched/sched.h| 1 + kernel/sched/topology.c | 9 + 3 files changed, 13 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 3582117e1580..e4ce572113a9 100644 --- a/kernel/sched/fair.c +++ b/kernel

[PATCHv2 5/7] sched: Change root_domain->overload type to int

2018-03-15 Thread Morten Rasmussen
From: Valentin Schneider sizeof(_Bool) is implementation defined, so let's just go with 'int' as is done for other structures e.g. sched_domain_shared->has_idle_cores. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen

[PATCHv2 7/7] sched/fair: Set sd->overload when misfit

2018-03-15 Thread Morten Rasmussen
p is flagged as having a misfit task. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 6 -- kernel/sched/sched.h | 6 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c

[PATCHv2 4/7] sched/fair: Kick nohz balance if rq->misfit_task

2018-03-15 Thread Morten Rasmussen
Kernel - see [1]. [1]: https://lists.linaro.org/pipermail/eas-dev/2016-September/000551.html cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Valentin Schneider Signed-off-by: Morten Rasmussen --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.

[PATCHv2 6/7] sched: Wrap rq->rd->overload accesses with READ/WRITE_ONCE

2018-03-15 Thread Morten Rasmussen
: Morten Rasmussen --- kernel/sched/fair.c | 6 +++--- kernel/sched/sched.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index fe4824a37302..4e79ec8760be 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8220,8

Re: [PATCH v7 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-03-14 Thread Morten Rasmussen
On Wed, Mar 07, 2018 at 10:19:50AM -0600, Jeremy Linton wrote: > Hi, > > On 03/07/2018 07:06 AM, Morten Rasmussen wrote: > >On Tue, Mar 06, 2018 at 04:22:18PM -0600, Jeremy Linton wrote: > >>>>>>To do this correctly, we should really base that on the cache &g

Re: [PATCH v7 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-03-14 Thread Morten Rasmussen
On Thu, Mar 08, 2018 at 09:41:17PM +0100, Brice Goglin wrote: > > > Is there a good reason for diverging instead of adjusting the > > core_sibling mask? On x86 the core_siblings mask is defined by the last > > level cache span so they don't have this issue. > > No. core_siblings is defined as th

Re: [PATCH v7 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-03-07 Thread Morten Rasmussen
On Tue, Mar 06, 2018 at 04:22:18PM -0600, Jeremy Linton wrote: > To do this correctly, we should really base that on the cache > topology immediately below the NUMA node (for NUMA in socket) >> or below > the physical package for normal NUMA configurations. > >>> > >>>That means we wou

Re: [PATCH v7 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-03-06 Thread Morten Rasmussen
On Tue, Feb 27, 2018 at 02:18:47PM -0600, Jeremy Linton wrote: > Hi, > > > First, thanks for taking a look at this. > > On 03/01/2018 09:52 AM, Morten Rasmussen wrote: > >Hi Jeremy, > > > >On Wed, Feb 28, 2018 at 04:06:19PM -0600, Jeremy Linton wrote: >

  1   2   3   4   5   6   7   8   9   >