RE: [PATCH net-next v3 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

Hello Paolo, Thank you for the review comments. > > Add selftest case to check the send and receive throughput. > > Supported link modes between local NIC driver and partner are varied. > > Then send and receive throughput is captured and verified. Test uses > > iperf3 tool. > > > > Signed-off-by

RE: [PATCH net-next v3 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

Hello Paolo, Thank you for the review comments. > > Add selftest file for the link layer tests of a NIC driver. > > Test for auto-negotiation is added. > > Add LinkConfig class for changing link layer configs. > > Selftest makes use of ksft modules and ethtool. > > Include selftest file in the Ma

RE: [PATCH net-next v2 2/3] selftests: nic_basic_tests: Add selftest case for speed and duplex state checks

Hi Willem, Thanks for the review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Mohan Prasad J wrote: > > Add selftest case for testing the speed and duplex state of local NIC > > driver and the partner based on the supported link mod

RE: [PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest file for basic tests of NIC

Hello Andrew, Thank you for the suggestion. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > > Since you have batteries included python: > > > > > > ethtool --json enp2s0 > > > [sudo] password for andrew: > > > [ { > > > "ifname": "enp2

RE: [PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest file for basic tests of NIC

Hi Andrew, Thank you for the review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Sep 17, 2024 at 08:04:07AM +0530, Mohan Prasad J wrote: > > Add selftest file to test basic features of a NIC driver. > > Tests for link modes,

RE: [PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest file for basic tests of NIC

Hi Andrew, Thanks for the review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > +def verify_link_up(ifname: str) -> None: > > +"""Verify whether the link is up""" > > +with open(f"/sys/class/net/{ifname}/operstate", "r") as

RE: [PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest file for basic tests of NIC

Hello Andrew, Thanks for the review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Sep 17, 2024 at 08:04:07AM +0530, Mohan Prasad J wrote: > > Add selftest file to test basic features of a NIC driver. > > Tests for link modes,

RE: [PATCH net-next 0/3] lan743x: This series of patches are for lan743x driver testing

Hello Andrew, Thank you very much for the feedback and the brief explanation. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Sep 06, 2024 at 06:45:53AM +, mohan.pra...@microchip.com > wrote: > > Hello Andrew, > > > > Thank you for y

RE: [PATCH net-next 3/3] selftests: lan743x: Add testcase to check throughput of lan743x

Hi Brett, Thank you for the review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 9/3/2024 3:15 PM, Mohan Prasad J wrote: > > Caution: This message originated from an External Source. Use proper > caution when opening attachments,

RE: [PATCH net-next 1/3] selftests: lan743x: Add testfile for lan743x network driver

Hi Brett, Thank you for the review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 9/3/2024 3:15 PM, Mohan Prasad J wrote: > > Caution: This message originated from an External Source. Use proper > caution when opening attachments,

RE: [PATCH net-next 2/3] selftests: lan743x: Add testcase to check speed and duplex state of lan743x

Hi Brett, Thank you for the review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 9/3/2024 3:15 PM, Mohan Prasad J wrote: > > Caution: This message originated from an External Source. Use proper > caution when opening attachments,

RE: [PATCH net-next 0/3] lan743x: This series of patches are for lan743x driver testing

Hello Andrew, Thank you for your review comments. > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Wed, Sep 04, 2024 at 03:45:46AM +0530, Mohan Prasad J wrote: > > This series of patches are for testing the lan743x network driver. > > Testing