[PATCH] backlight: Add TI LMU backlight driver

2017-03-19 Thread Milo Kim
Lindgren Signed-off-by: Milo Kim --- .../bindings/leds/backlight/ti-lmu-backlight.txt | 65 ++ drivers/video/backlight/Kconfig| 7 + drivers/video/backlight/Makefile | 3 + drivers/video/backlight/ti-lmu-backlight-core.c| 655

[PATCH 2/2] regulator: lm363x: Use generic DT property name for external control pins

2017-02-28 Thread Milo Kim
Vpos and Vneg LDOs can be enabled or disabled by external GPIOs. Use general DT property 'enable-gpios' for this usage. Two enable pins are differentiable by selecting the index number. Signed-off-by: Milo Kim --- drivers/regulator/lm363x-regulator.c | 4 ++-- 1 file changed, 2 insert

[PATCH 1/2] Documentation: dt-bindings: Use generic property for hardware enable pins

2017-02-28 Thread Milo Kim
With index usages, device specific properties can be replaced with generic one. Vpos is index 0 and Vneg is index 1. DT examples are added as well. Signed-off-by: Milo Kim --- .../bindings/regulator/lm363x-regulator.txt| 78 +- 1 file changed, 76 insertions(+), 2

[PATCH 2/2] mfd: add TI LMU driver

2017-02-27 Thread Milo Kim
m363x regulator driver is already upstreamed. Acked-by: Lee Jones Signed-off-by: Milo Kim --- drivers/mfd/Kconfig | 12 ++ drivers/mfd/Makefile| 2 + drivers/mfd/ti-lmu.c| 259 + include/linux/mf

[PATCH 1/2] Documentation: dt-bindings: mfd: add TI LMU device binding information

2017-02-27 Thread Milo Kim
This patch describes overall binding for TI LMU MFD devices. Acked-by: Lee Jones Acked-by: Rob Herring Signed-off-by: Milo Kim --- Documentation/devicetree/bindings/mfd/ti-lmu.txt | 243 +++ 1 file changed, 243 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v3 0/2] Support TI LMU devices

2017-02-27 Thread Milo Kim
ox x This patch-set includes only MFD part. Other subsystem drivers will be sent separately. ti-lmu-backlight: Backlight subsystem ti-lmu-fault-monitor: Misc driver leds-lm3633: LED subsystem Updates from v2: Submit acked patches to get merged quickly. Milo

Re: [PATCH resend v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-09 Thread Milo Kim
On 01/10/2017 12:27 PM, Shawn Guo wrote: On Wed, Jan 04, 2017 at 04:04:36PM +0900, Milo Kim wrote: Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree

Re: [PATCH v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
On 01/04/2017 01:55 PM, Milo Kim wrote: Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/boot/dts

[PATCH resend v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/boot/dts/Makefile | 1 + arch

[PATCH v4 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2017-01-03 Thread Milo Kim
add the vendor prefix. Use generic node name for the backlight panel. Sort alphabetically for the pinctrl nodes. Remove unnecessary pinmux of HDMI CEC. v3: Specify the dtbs for i.MX6 build. v2: Fix DT node for regulator, phy-reset-gpios and iomuxc node. Milo Kim (3): ARM: dts: imx6

[PATCH v4 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-03 Thread Milo Kim
lt-in eMMC storage. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 255 + 1 file changed, 255 insertions(+) create mode 100644 arch/arm/boot/dts/imx6qdl-savageboard.dtsi diff --git a/arch/arm/boot/d

[PATCH v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/boot/dts/Makefile | 1 + arch

[PATCH v4 3/3] ARM: dts: imx6: Support Savageboard quad

2017-01-03 Thread Milo Kim
Use common board file and support SATA interface additionally. Specify the dtb file for i.MX6 build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-savageboard.dts | 55 + 2 files

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 04:44 PM, Shawn Guo wrote: On Mon, Jan 02, 2017 at 04:31:07PM +0900, Milo Kim wrote: On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an un

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 04:41 PM, Shawn Guo wrote: On Mon, Jan 02, 2017 at 04:31:07PM +0900, Milo Kim wrote: On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an un

Re: [PATCH v3 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-01 Thread Milo Kim
On 01/02/2017 04:03 PM, Shawn Guo wrote: + model = "Poslab SavageBoard Dual"; + compatible = "poslab,imx6dl-savageboard", "fsl,imx6dl"; It seems that 'poslab' should be added to Documentation/devicetree/bindings/vendor-prefixes.txt Ah, right. Thanks for the review! Best regards,

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an undocumented compatible. AVIC TM097TDH02 panel is compatible with Hannstar HSD100PXN1, so I reuse it. It's the same rule as the usage of

Re: [PATCH 5/5] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation

2016-12-17 Thread Milo Kim
Hi Luis, On 12/17/2016 01:14 AM, Luis R. Rodriguez wrote: Milo if sysfs is used can't the old userspace be mapped to use the new sysfs interface through a wrapper of some sort ? What exactly would be needed to ensure old userspace will not break? LP5521 and LP5523 have two ways to load hex cod

Re: [PATCH v2 0/8] power: supply: tps65217: Support USB charger feature

2016-12-17 Thread Milo Kim
On 12/18/2016 01:24 AM, Sebastian Reichel wrote: patches look fine, but these two patches must be reordered to fix bisectability. Otherwise after patch 1 the thread is not properly killed during driver removal. Thanks for your guidelines. The v3 patchset has been sent. Best regards, Milo

[PATCH v3 1/7] power: supply: tps65217: Use 'poll_task' on unloading the module

2016-12-17 Thread Milo Kim
Use the task_struct variable for running polling thread. If polling task is activated, then use it to stop running thread. This is a preceding step of supporting two interrupts of TPS65217 charger, so checking single IRQ number is not appropriate when the module is removed. Signed-off-by: Milo

[PATCH v3 5/7] power: supply: tps65217: Use generic name for power supply property

2016-12-17 Thread Milo Kim
Replace 'ac_props' with 'charger_props'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.

[PATCH v3 7/7] power: supply: tps65217: Use generic charger name

2016-12-17 Thread Milo Kim
"tps65217-charger" is more appropriate name because the driver supports not only AC but also USB charger. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/tps65217_charger.c

[PATCH v3 6/7] power: supply: tps65217: Use generic name for get_property()

2016-12-17 Thread Milo Kim
Rename it as tps65217_charger_get_property(). Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 79afecafd945

[PATCH v3 4/7] power: supply: tps65217: Use generic name for power supply structure

2016-12-17 Thread Milo Kim
Replace 'ac' of tps65217_charger structure with 'psy'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps6

[PATCH v3 0/7] power: supply: tps65217: Support USB charger feature

2016-12-17 Thread Milo Kim
structure v3: Reorder the patches to avoid bisection issue v2: Regenerate the patchset for better code review Milo Kim (7): power: supply: tps65217: Use 'poll_task' on unloading the module power: supply: tps65217: Support USB charger interrupt power: supply: tps65217: Use generi

[PATCH v3 3/7] power: supply: tps65217: Use generic name for charger online

2016-12-17 Thread Milo Kim
This driver supports AC and USB chargers. Generic name is preferred. Replace 'ac_online' with 'online'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

[PATCH v3 2/7] power: supply: tps65217: Support USB charger interrupt

2016-12-17 Thread Milo Kim
cases, enable charging operation. Interrupt request: If an interrupt number is invalid, then use legacy polling thread. Otherwise, create IRQ threads to handle AC and USB charger event. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 52

Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism

2016-12-13 Thread Milo Kim
Hi Jacek, On 12/13/2016 06:44 PM, Jacek Anaszewski wrote: Could you please verify if leds-lp55xx-common.c driver really needs a custom firmware loading fallback mechanism? Thanks for sharing this. The lp55xx-common uses this mechanism to load and run LED effect manually, so this could be a m

Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts

2016-12-12 Thread Milo Kim
On 12/13/2016 02:25 AM, Rob Herring wrote: On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: Interrupt numbers are from the datasheet, so no need to keep them in the ABI. Use the number in the DT file. I don't see the purpose of ripping this out. The headers have always bee

Re: [PATCH] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-12 Thread Milo Kim
On 12/13/2016 12:49 AM, Maxime Ripard wrote: Hi, On Fri, Dec 09, 2016 at 10:47:58AM +0900, Milo Kim wrote: The commit 10efbf5f1633 introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim checkpatch reports an error on this one (commit format), p

[PATCH resend] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-12 Thread Milo Kim
The commit 10efbf5f1633 ("ARM: dts: sun8i: Add dts file for NanoPi M1 SBC") introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/Make

[PATCH v2 2/8] power: supply: tps65217: Use 'poll_task' on unloading the module

2016-12-08 Thread Milo Kim
TPS65217 has two interrupt numbers so checking single IRQ number is not appropriate when the module is removed. Use the task_struct variable for running polling thread. If polling task is activated, then use it to stop running thread. Signed-off-by: Milo Kim --- drivers/power/supply

[PATCH v2 7/8] power: supply: tps65217: Use generic name for get_property()

2016-12-08 Thread Milo Kim
Rename it as tps65217_charger_get_property(). Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 79afeca..63c5556

[PATCH v2 5/8] power: supply: tps65217: Use generic name for power supply structure

2016-12-08 Thread Milo Kim
Replace 'ac' of tps65217_charger structure with 'psy'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps6

[PATCH v2 0/8] power: supply: tps65217: Support USB charger feature

2016-12-08 Thread Milo Kim
structure v2: Regenerate the patchset for better code review Milo Kim (8): power: supply: tps65217: Support USB charger interrupt power: supply: tps65217: Use 'poll_task' on unloading the module power: supply: tps65217: Remove IRQ data from driver data power: supply: tps65217: U

[PATCH v2 8/8] power: supply: tps65217: Use generic charger name

2016-12-08 Thread Milo Kim
"tps65217-charger" is more appropriate name because the driver supports not only AC but also USB charger. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/tps65217_charger.c

[PATCH v2 1/8] power: supply: tps65217: Support USB charger interrupt

2016-12-08 Thread Milo Kim
threads to handle AC and USB charger event. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 47 +++-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c

[PATCH v2 4/8] power: supply: tps65217: Use generic name for charger online

2016-12-08 Thread Milo Kim
This driver supports AC and USB chargers. Generic name is preferred. Replace 'ac_online' with 'online'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

[PATCH v2 3/8] power: supply: tps65217: Remove IRQ data from driver data

2016-12-08 Thread Milo Kim
IRQ number is only used on requesting the interrupt, so no need to keep it inside the driver data. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply

[PATCH v2 6/8] power: supply: tps65217: Use generic name for power supply property

2016-12-08 Thread Milo Kim
Replace 'ac_props' with 'charger_props'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 5da

[PATCH 4/4] dt-bindings: input: Specify the interrupt number of TPS65217 power button

2016-12-08 Thread Milo Kim
Specify the power button interrupt number which is from the datasheet. Signed-off-by: Milo Kim --- Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt

[PATCH 3/4] dt-bindings: power/supply: Update TPS65217 properties

2016-12-08 Thread Milo Kim
Add interrupt specifiers for USB and AC charger input. Interrupt numbers are from the datasheet. Fix wrong property for compatible string. Signed-off-by: Milo Kim --- .../devicetree/bindings/power/supply/tps65217_charger.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts

2016-12-08 Thread Milo Kim
Interrupt numbers are from the datasheet, so no need to keep them in the ABI. Use the number in the DT file. Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 8 +++- include/dt-bindings/mfd/tps65217.h| 26 -- 2 files changed, 3

[PATCH 1/4] ARM: dts: am335x: Fix the interrupt name of TPS65217

2016-12-08 Thread Milo Kim
Use 'interrupt-names' for getting the charger interrupt number. Fixes: 1934e89a769b ("ARM: dts: am335x: Add the charger interrupt") Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

[PATCH 0/4] dt-bindings: mfd: Update TPS65217 interrupts

2016-12-08 Thread Milo Kim
This patch-set fixes wrong property name and uses TPS65217 HW interrupt number from the datasheet instead of the DT ABI. DT bindings are also updated. Milo Kim (4): ARM: dts: am335x: Fix the interrupt name of TPS65217 dt-bindings: mfd: Remove TPS65217 interrupts dt-bindings: power/supply

[PATCH] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-08 Thread Milo Kim
The commit 10efbf5f1633 introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index cccdbcb..4cbdf6f 100644

[PATCH v3 2/3] ARM: dts: imx6: Support Savageboard dual

2016-12-08 Thread Milo Kim
Common savageboard DT file is used for board support. Specify this dtb file for i.MX6Q build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6dl-savageboard.dts | 50 2 files changed, 51 insertions(+) create

[PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2016-12-08 Thread Milo Kim
output simultaneously. * Pinmux eMMC, ethernet, HDMI, I2C, power button, PWM, SD card and UART. * Others Enable ethernet, UART1 debug, USB host, USDHC3 for microSD card and USDHC4 for built-in eMMC storage. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 262

[PATCH v3 3/3] ARM: dts: imx6: Support Savageboard quad

2016-12-08 Thread Milo Kim
Use common board file and support SATA interface additionally. Specify this dtb file for i.MX6 build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-savageboard.dts | 54 + 2 files changed, 55 insertions

[PATCH v3 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2016-12-08 Thread Milo Kim
. v2: Fix DT node for regulator, phy-reset-gpios and iomuxc node. Milo Kim (3): ARM: dts: imx6: Add Savageboard common file ARM: dts: imx6: Support Savageboard dual ARM: dts: imx6: Support Savageboard quad arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/imx6dl

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

2016-12-06 Thread Milo Kim
On 12/06/2016 11:00 PM, Maxime Ripard wrote: No, we need a recent U-Boot in order to boot, and such a uboot will setup the memory node anyway. Got it. Thanks! Please just ignore my patches. Best regards, Milo

Re: [PATCH v2 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2016-12-06 Thread Milo Kim
On 12/06/2016 06:42 PM, Fabio Estevam wrote: You missed to add imx6q-savageboard.dtb and imx6dl-savageboard.dtb entries into arch/arm/boot/dts/Makefile Oh, I didn't notice because I build the dtbs manually. Thanks for catching this. And do you think other patches look OK? Best regards, Milo

Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

2016-12-05 Thread Milo Kim
On 12/05/2016 05:09 PM, Maxime Ripard wrote: On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote: The board has DDR3 512MB. This patch helps scanning the memory and adding memblock through the DT. Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 + 1 file

Re: [PATCH 1/3] ARM: dts: imx6: Add Savageboard common file

2016-12-05 Thread Milo Kim
On 12/05/2016 08:36 PM, Fabio Estevam wrote: On Sun, Dec 4, 2016 at 11:07 PM, Milo Kim wrote: + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + +

[PATCH v2 3/3] ARM: dts: imx6: Support Savageboard quad

2016-12-05 Thread Milo Kim
Use common board file and support SATA interface additionally. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6q-savageboard.dts | 54 + 1 file changed, 54 insertions(+) create mode 100644 arch/arm/boot/dts/imx6q-savageboard.dts diff --git a/arch/arm/boot/dts

[PATCH v2 2/3] ARM: dts: imx6: Support Savageboard dual

2016-12-05 Thread Milo Kim
Common savageboard DT file is used for board support. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6dl-savageboard.dts | 50 1 file changed, 50 insertions(+) create mode 100644 arch/arm/boot/dts/imx6dl-savageboard.dts diff --git a/arch/arm/boot/dts/imx6dl

[PATCH v2 1/3] ARM: dts: imx6: Add Savageboard common file

2016-12-05 Thread Milo Kim
output simultaneously. * Pinmux eMMC, ethernet, HDMI, I2C, power button, PWM, SD card and UART. * Others Enable ethernet, UART1 debug, USB host, USDHC3 for microSD card and USDHC4 for built-in eMMC storage. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 262

[PATCH v2 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2016-12-05 Thread Milo Kim
-reset-gpios and iomuxc node. Milo Kim (3): ARM: dts: imx6: Add Savageboard common file ARM: dts: imx6: Support Savageboard dual ARM: dts: imx6: Support Savageboard quad arch/arm/boot/dts/imx6dl-savageboard.dts | 50 ++ arch/arm/boot/dts/imx6q-savageboard.dts| 54 ++ arch/arm

[PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1

2016-12-04 Thread Milo Kim
The board has DDR3 512MB. This patch helps scanning the memory and adding memblock through the DT. Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3

[PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo

2016-12-04 Thread Milo Kim
The board has DDR3 256MB. This patch helps scanning the memory and adding memblock through the DT. Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i

[PATCH 2/3] ARM: dts: imx6: Support Savageboard dual

2016-12-04 Thread Milo Kim
Common savageboard DT file is used for board support. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6dl-savageboard.dts | 50 1 file changed, 50 insertions(+) create mode 100644 arch/arm/boot/dts/imx6dl-savageboard.dts diff --git a/arch/arm/boot/dts/imx6dl

[PATCH 1/3] ARM: dts: imx6: Add Savageboard common file

2016-12-04 Thread Milo Kim
USDHC4 for built-in eMMC storage. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 271 + 1 file changed, 271 insertions(+) create mode 100644 arch/arm/boot/dts/imx6qdl-savageboard.dtsi diff --git a/arch/arm/boot/dts/imx6qdl-savageboard.dtsi

[PATCH 3/3] ARM: dts: imx6: Support Savageboard quad

2016-12-04 Thread Milo Kim
Use common board file and support SATA interface additionally. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6q-savageboard.dts | 54 + 1 file changed, 54 insertions(+) create mode 100644 arch/arm/boot/dts/imx6q-savageboard.dts diff --git a/arch/arm/boot/dts

[PATCH 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2016-12-04 Thread Milo Kim
settings are used so no issue to bring-up the system - MIPI DSI, CSI Patches are tested on the Savageboard quad but the dual version should work because the only difference between dual and quad is SATA support. More information in http://www.savageboard.org Milo Kim (3): ARM: dts: imx6: Add

Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources

2016-11-23 Thread Milo Kim
On 11/23/2016 08:51 PM, Arnd Bergmann wrote: Ah, the numbers come from the data sheet. Please just remove the header then, there is no need to keep them as an ABI, in particular when the driver doesn't even include that header today. Got it. What matters here is the binding documentation in D

Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data

2016-11-23 Thread Milo Kim
On 11/23/2016 01:58 AM, Sebastian Reichel wrote: On Tue, Nov 22, 2016 at 05:51:07PM +0100, Sebastian Reichel wrote: > On Tue, Nov 15, 2016 at 10:18:52PM +0900, Milo Kim wrote: > > IRQ number is only used on requesting the interrupt, so no need to keep > > it inside the drive

Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources

2016-11-23 Thread Milo Kim
On 11/23/2016 12:57 AM, Lee Jones wrote: pwrbutton { > - interrupts = ; > + interrupts = ; Push button or power button? According to the datasheet, push button interrupt is correct. http://www.ti.com/lit/ds/symlink/tps65217.pdf This is used for a power butt

[PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources

2016-11-21 Thread Milo Kim
AC and USB interrupts are related with external power input. PB interrupt means push button pressed or released event. Use better human readable definitions. Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++-- include/dt-bindings/mfd/tps65217.h| 6 +++--- 2

Re: [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts

2016-11-21 Thread Milo Kim
On 11/19/2016 12:10 AM, Tony Lindgren wrote: +#define TPS65217_IRQ_USB 0 > > +#define TPS65217_IRQ_AC 1 > > +#define TPS65217_IRQ_PB 2 > > What are "AC" and "PB". Seeing as these are meant to be "human > readable", let's make them more human friendly. Good idea.

[PATCH 3/5] power: supply: tps65217: Support USB charger interrupt

2016-11-15 Thread Milo Kim
. In both cases, enable charging operation. Cc: Enric Balletbo i Serra Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 52 +++-- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers

[PATCH 5/5] power: supply: tps65217: Use generic name for power supply structures

2016-11-15 Thread Milo Kim
AC and USB charger are supported, so generic names are preferred. ac in tps65217_charger -> psy tps65217_ac_props -> tps65217_charger_props tps65217_ac_get_property -> tps65217_charger_get_property tps65217-ac -> tps65217-charger Cc: Enric Balletbo i Serra Signed-off-

[PATCH 0/5] power: supply: tps65217: Support USB charger feature

2016-11-15 Thread Milo Kim
TPS65217 device supports two charger inputs - AC and USB. Currently, only AC charger is supported. This patch-set adds USB charger feature. Tested on Beaglebone black. Milo Kim (5): power: supply: tps65217: Move IRQ related operation into single function power: supply: tps65217: Remove

[PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data

2016-11-15 Thread Milo Kim
IRQ number is only used on requesting the interrupt, so no need to keep it inside the driver data. In case of polling, poll_task is valid only when polling thread is activated. Cc: Enric Balletbo i Serra Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 18

[PATCH 1/5] power: supply: tps65217: Move IRQ related operation into single function

2016-11-15 Thread Milo Kim
TPS65217 charger driver handles the charger interrupt through the IRQ or polling. Both cases can be requested in single function. Cc: Enric Balletbo i Serra Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 70 ++--- 1 file changed, 38 insertions

[PATCH 4/5] power: supply: tps65217: Use generic name for charger online

2016-11-15 Thread Milo Kim
This driver supports AC and USB chargers. Generic name is preferred. ac_online -> online prev_ac_online -> prev_online Cc: Enric Balletbo i Serra Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 16 1 file changed, 8 insertions(+), 8 del

[PATCH 0/5] mfd: tps65217: Improve the IRQ domain feature

2016-11-15 Thread Milo Kim
TPS65217 can be built as a module, this patch-set includes the error fix and rework the interrupt handler. Additionally, TPS65217 INT pin is registered as a system wakeup source. Milo Kim (5): mfd: tps65217: Fix page fault on unloading modules mfd: tps65217: Specify the IRQ name mfd

[PATCH 4/5] mfd: tps65217: Make an interrupt handler simpler

2016-11-15 Thread Milo Kim
button status change interrupt ACI: AC power status change interrupt USBI: USB power status change interrupt x:Not used Signed-off-by: Milo Kim --- drivers/mfd/tps65217.c | 44 +--- include/linux/mfd/tps65217.h | 1 + 2 files changed, 10 inserti

[PATCH 1/5] mfd: tps65217: Fix page fault on unloading modules

2016-11-15 Thread Milo Kim
l+0x0/0x1c) [ 72.776725] Code: e5944000 e1540006 0a1b e594300c (e593c004) [ 72.783181] ---[ end trace 0278ec325f4689b8 ]--- Fixes: 6556bdacf646 ("mfd: tps65217: Add support for IRQs") Signed-off-by: Milo Kim --- drivers/mfd/tps65217.c | 19 +++ 1 file changed, 19 inserti

[PATCH 5/5] mfd: tps65217: Support an interrupt pin as the system wakeup

2016-11-15 Thread Milo Kim
TPS65217 INT pin is used for the system wakeup from suspend mode. This patch enables push button or charger input event as a wakeup source. Signed-off-by: Milo Kim --- drivers/mfd/tps65217.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c

[PATCH 2/5] mfd: tps65217: Specify the IRQ name

2016-11-15 Thread Milo Kim
-charger 185: 0 tps65217 2 Edge tps65217_pwrbutton Signed-off-by: Milo Kim --- drivers/mfd/tps65217.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c index df2e775..77fb812 100644 --- a/drivers/mfd/tps65217.c +++ b/drivers/mfd

[PATCH 3/5] mfd: tps65217: Update register interrupt mask bits instead of writing operation

2016-11-15 Thread Milo Kim
TPS65217 interrupt register includes read/writeable mask bits with read-only status bits. (bit 4, 5, 6 are R/W, bit 0, 1, 2 are RO) And reserved bit is not required. Register update operation is preferred for disabling all interrupts during the device initialisation. Signed-off-by: Milo Kim

[PATCH v2 2/8] ARM: dts: tps65217: Add the charger device

2016-10-28 Thread Milo Kim
Support the charger driver and disable it by default. Signed-off-by: Milo Kim --- arch/arm/boot/dts/tps65217.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi index 27935f8..8f77d0d 100644 --- a/arch/arm/boot/dts

[PATCH v2 8/8] mfd: tps65217: Fix mismatched interrupt number

2016-10-28 Thread Milo Kim
pt when it is probed. According to the TPS65217 register map[**], USB interrupt is the LSB. This patch defines synchronized IRQ value. [*] include/dt-bindings/mfd/tps65217.h [**] http://www.ti.com/lit/ds/symlink/tps65217.pdf Signed-off-by: Milo Kim --- include/linux/mfd/tps65217.h | 11 +

[PATCH v2 6/8] ARM: dts: am335x: Add the charger interrupt

2016-10-28 Thread Milo Kim
This enables the charger driver gets corresponding IRQ number by using platform_get_irq_byname() helper. Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot

[PATCH v2 7/8] ARM: dts: am335x: Add the power button interrupt

2016-10-28 Thread Milo Kim
This enables the power button driver gets corresponding IRQ number by using platform_get_irq(). Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x

[PATCH v2 4/8] ARM: dts: am335x: Support the PMIC interrupt

2016-10-28 Thread Milo Kim
AM335x bone based boards have the PMIC interrupt named NMI which is connected to TPS65217 device. AM335x main interrupt controller provides it and the number is 7. Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch

[PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts

2016-10-28 Thread Milo Kim
TPS65217 supports three interrupt sources. This patch enables assigning each IRQ number in the charger and power button node. Then corresponding IRQ will be requested by each driver. Signed-off-by: Milo Kim --- include/dt-bindings/mfd/tps65217.h | 26 ++ 1 file changed

[PATCH v2 3/8] ARM: dts: tps65217: Add the power button device

2016-10-28 Thread Milo Kim
Support the power button driver and disable it by default. Signed-off-by: Milo Kim --- arch/arm/boot/dts/tps65217.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi index 8f77d0d..02de56b 100644 --- a/arch/arm/boot/dts

[PATCH v2 1/8] ARM: dts: tps65217: Specify the interrupt controller

2016-10-28 Thread Milo Kim
-pwrbutton.c Signed-off-by: Milo Kim --- arch/arm/boot/dts/tps65217.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi index a632724..27935f8 100644 --- a/arch/arm/boot/dts/tps65217.dtsi +++ b/arch/arm/boot/dts/tps65217

[PATCH v2 0/8] Support TPS65217 PMIC interrupt in DT

2016-10-28 Thread Milo Kim
Use #defines instead of enum type for interrupt numbers Milo Kim (8): ARM: dts: tps65217: Specify the interrupt controller ARM: dts: tps65217: Add the charger device ARM: dts: tps65217: Add the power button device ARM: dts: am335x: Support the PMIC interrupt dt-bindings: mfd: Provide

[PATCH v2 2/3] ARM: dts: sun8i: Use the common file in NanoPi NEO SBC

2016-10-28 Thread Milo Kim
NanoPi common dtsi supports all components of NEO SBC, so just include it. Cc: James Pettigrew Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 79 +-- 1 file changed, 1 insertion(+), 78 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-h3

[PATCH v2 1/3] ARM: dts: sun8i: Add common dtsi file for NanoPi SBCs

2016-10-28 Thread Milo Kim
This patch provides a common file for NanoPi M1 and Neo SBC. Those have common features below. * UART0 * 2 LEDs * USB host (EHCI3, OHCI3) and PHY * MicroSD * GPIO key switch Cc: James Pettigrew Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3-nanopi.dtsi | 144

[PATCH v2 3/3] ARM: dts: sun8i: Add dts file for NanoPi M1 SBC

2016-10-28 Thread Milo Kim
NanoPi M1 is the Allwinner H3 based board. This patch enables UART for debug console, LEDs, GPIO key switch, 3 USB host ports, a micro SD slot and related power and pin controls by using NanoPi common dtsi file. Cc: James Pettigrew Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3-nanopi

[PATCH v2 0/3] ARM: dts: sun8i: Support NanoPi SBCs

2016-10-28 Thread Milo Kim
NanoPi M1 and NEO have common features, so duplicate properties can be moved into new dtsi file. v2: Add James's copyrights in NanoPi common dtsi file Milo Kim (3): ARM: dts: sun8i: Add common dtsi file for NanoPi SBCs ARM: dts: sun8i: Use the common file in NanoPi NEO SBC ARM

[PATCH v2 2/4] ARM: dts: sun8i: Add SPI controller node in H3

2016-10-27 Thread Milo Kim
H3 SPI subsystem is almost same as A31 SPI except buffer size, so those DT properties are reusable. Cc: Maxime Ripard Cc: Chen-Yu Tsai Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm

[PATCH v2 4/4] spi: sun6i: Support Allwinner H3 SPI controller

2016-10-27 Thread Milo Kim
, 'fifo_depth' instead of fixed value to support both SPI controllers. Cc: Mark Brown Cc: Maxime Ripard Cc: Chen-Yu Tsai Signed-off-by: Milo Kim --- drivers/spi/spi-sun6i.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-sun6i.c

[PATCH v2 3/4] spi: sun6i: Add binding for Allwinner H3 SPI controller

2016-10-27 Thread Milo Kim
H3 SPI has same architecture as A31 except FIFO capacity. To configure the buffer size separately, compatible property should be different. Optional DMA specifiers and example are added. Acked-by: Maxime Ripard Cc: Mark Brown Cc: Rob Herring Cc: Chen-Yu Tsai Signed-off-by: Milo Kim

[PATCH v2 1/4] ARM: dts: sun8i: Add SPI pinctrl node in H3

2016-10-27 Thread Milo Kim
H3 supports two SPI controllers. Four pins (MOSI, MISO, SCLK, SS) are configured through the pinctrl subsystem. Cc: Maxime Ripard Cc: Chen-Yu Tsai Signed-off-by: Milo Kim --- arch/arm/boot/dts/sun8i-h3.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v2 0/4] Support H3 SPI controller

2016-10-27 Thread Milo Kim
(warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]) Milo Kim (4): ARM: dts: sun8i: Add SPI pinctrl node in H3 ARM: dts: sun8i: Add SPI controller node in H3 spi: sun6i: Add binding for Allwinner H3 SPI controller spi: sun6i: Support Allwinner H3 SPI

Re: [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number

2016-10-27 Thread Milo Kim
On 10/26/2016 10:56 PM, Lee Jones wrote: diff --git a/include/linux/mfd/tps65217.h b/include/linux/mfd/tps65217.h > index 4ccda89..75a3a5f 100644 > --- a/include/linux/mfd/tps65217.h > +++ b/include/linux/mfd/tps65217.h > @@ -235,9 +235,9 @@ struct tps65217_bl_pdata { > }; > > enum tps65217_irq

  1   2   3   4   >