ret;
>
> - if (ret > VHOST_SCSI_PREALLOC_SGLS) {
> + if (cnt > VHOST_SCSI_PREALLOC_SGLS) {
> pr_err("Max inline_sg_cnt is %u\n", VHOST_SCSI_PREALLOC_SGLS);
> return -EINVAL;
> }
Thanks.
Reviewed-by: Mike Christie
Dropping netdev because this is a storage patch.
On 5/5/25 5:09 PM, Sasha Levin wrote:
> From: Mike Christie
>
> [ Upstream commit 891b99eab0f89dbe08d216f4ab71acbeaf7a3102 ]
>
> This has us return queue full if we can't allocate a page during the
> copy operation so
On 4/7/25 3:17 AM, Michael S. Tsirkin wrote:
> On Fri, Mar 28, 2025 at 06:02:48PM +0800, Cindy Lu wrote:
>> Abstract vhost worker operations (create/stop/wakeup) into an ops
>> structure to prepare for kthread mode support.
>>
>> Signed-off-by: Cindy Lu
>
> I worry about the overhead of indirect
On 4/8/25 4:45 AM, Cindy Lu wrote:
> On Tue, Apr 8, 2025 at 12:06 AM Mike Christie
> wrote:
>>
>> On 4/7/25 3:17 AM, Michael S. Tsirkin wrote:
>>> On Fri, Mar 28, 2025 at 06:02:48PM +0800, Cindy Lu wrote:
>>>> Abstract vhost worker operations (create/sto
On 3/28/25 5:02 AM, Cindy Lu wrote:
> +static int vhost_kthread_worker_create(struct vhost_worker *worker,
> +struct vhost_dev *dev, const char *name)
> +{
> + struct task_struct *task;
> + u32 id;
> + int ret;
> +
> + task = kthread_create(vhost_
, store the log
> buffer during the submission path and log it in the completion or error
> handling path.
>
> For Asynchronous Notifications, only the submission path is involved.
>
> Suggested-by: Joao Martins
> Signed-off-by: Dongli Zhang
>
Reviewed-by: Mike Christie
nt
> VHOST_SET_FEATURES/VHOST_SCSI_SET_ENDPOINT.
> - Encapsulate the one-time on-demand per-cmd log buffer alloc/copy in a
> helper, as suggested by Mike.
Reviewed-by: Mike Christie
-off-by: Dongli Zhang
Reviewed-by: Mike Christie
-off-by: Dongli Zhang
Reviewed-by: Mike Christie
On 3/17/25 7:04 PM, Dongli Zhang wrote:
> @@ -1390,6 +1424,24 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct
> vhost_virtqueue *vq)
> goto err;
> }
>
> + if (unlikely(vq_log && log_num)) {
> + if (!cmd->tvc_log)
> +
() may reset it only
> after certain condition checks.
>
> Suggested-by: Joao Martins
> Signed-off-by: Dongli Zhang
Reviewed-by: Mike Christie
MM is QEMU. The vq->log_base is from QEMU userpace and can be
> reclaimed via gfree(). As a result, this causes invalid memory writes to
> QEMU userspace.
>
> The control queue path has the same issue.
>
> Signed-off-by: Dongli Zhang
> ---
Reviewed-by: Mike Christie
e response in a single
> descriptor.
>
> Similar issue in vhost_scsi_send_bad_target() has been fixed in previous
> commit.
>
> Fixes: 3ca51662f818 ("vhost-scsi: Add better resource allocation failure
> handling")
> Signed-off-by: Dongli Zhang
Reviewed-by: Mike Christie
queue.
>
> Fixes: 664ed90e621c ("vhost/scsi: Set VIRTIO_F_ANY_LAYOUT +
> VIRTIO_F_VERSION_1 feature bits")
> Signed-off-by: Dongli Zhang
Reviewed-by: Mike Christie
On 2/7/25 12:41 PM, Dongli Zhang wrote:
> @@ -378,6 +384,11 @@ static void vhost_scsi_release_tmf_res(struct
> vhost_scsi_tmf *tmf)
> {
> struct vhost_scsi_inflight *inflight = tmf->inflight;
>
> + if (tmf->tmf_log_num) {
> + kfree(tmf->tmf_log);
> + tmf->tmf_l
On 2/7/25 12:41 PM, Dongli Zhang wrote:
> The vhost-scsi I/O queue uses vhost_scsi_cmd. Pre-allocate the log buffer
> during vhost_scsi_cmd allocation, and free it when vhost_scsi_cmd is
> reclaimed.
>
> The cached log buffer will be uses in upcoming patches to log write
> descriptors for the I/O
MU that can toggle the
inherit owner bit so I could test both modes.
Tested-by: Mike Christie
On 12/30/24 6:43 AM, Cindy Lu wrote:
> The vhost_scsi VHOST_NEW_WORKER requires the inherit_owner
> setting to be true. So we need to implement a check for this.
>
> Signed-off-by: Cindy Lu
> ---
> drivers/vhost/scsi.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/vho
On 1/17/25 10:50 AM, Mike Christie wrote:
>> You are welcome. There is another bug I was about to report, but I'm not
>> sure whether I should create a new thread. I feel that the original design
>> of dynamically allocating new vs_tpgs in vhost_scsi_set_endpoint is not
&g
equest.
>
I saw that while reviewing the code. Here is my patch. I just added a new
goto, because we don't need to do the undepend since we never did any
depend calls.
>From 0474c5d41968095ea911d48159e4f6a129f1a862 Mon Sep 17 00:00:00 2001
From: Mike Christie
Date: Wed, 15 Jan 2025 19:0
On 1/14/25 1:40 AM, 张浩然 wrote:
> After reevaluating the PoC, I realized that my initial claim was incorrect.
> The target WWN in the second vhost_scsi_set_endpoint() call is not the same
> as in the first one. Below is my targetcli status:
>
> o- vhost . [
On 1/14/25 5:26 AM, Michael S. Tsirkin wrote:
>
> Wanna post the patch, Mike?
>
Yeah, I'll send a patch.
On 1/12/25 11:35 AM, michael.chris...@oracle.com wrote:
> So I think to fix the issue, we would want to:
>
> 1. move the
>
> memcpy(vs_tpg, vs->vs_tpg, len);
>
> to the end of the function after we do the vhost_scsi_flush. This will
> be more complicated than the current memcpy though. We will w
On 11/5/24 1:25 AM, Cindy Lu wrote:
> +static int vhost_attach_cgroups(struct vhost_dev *dev)
> +{
> + struct vhost_worker *worker;
> + unsigned long i;
> + int ret;
> +
> + /*
> + * Free the default worker we created and cleanup workers userspace
> + * created but couldn'
On 11/5/24 3:39 AM, Jason Wang wrote:
> On Tue, Nov 5, 2024 at 3:28 PM Cindy Lu wrote:
>>
>> Add a new UAPI to enable setting the vhost device to task mode.
>> The userspace application can use VHOST_SET_INHERIT_FROM_OWNER
>> to configure the mode if necessary.
>> This setting must be applied befo
On 11/5/24 1:25 AM, Cindy Lu wrote:
> The vhost_scsi VHOST_NEW_WORKER requires the inherit_owner
> setting to be true. So we need to implement a check for this.
>
> Signed-off-by: Cindy Lu
> ---
> drivers/vhost/scsi.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/vhost/s
On 10/3/24 8:58 PM, Cindy Lu wrote:
> Add back the previously removed vhost_worker function to support the kthread
> and rename it vhost_run_work_kthread_list.
>
> The old function vhost_worker was change to support task in
> commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads")
> chan
On 10/3/24 8:58 PM, Cindy Lu wrote:
> +static void vhost_workers_free(struct vhost_dev *dev)
> +{
> + if (enforce_inherit_owner)
> + vhost_workers_free_task(dev);
> + else
> + vhost_workers_free_kthread(dev);
> +}
With patch 7, userspace could change enforce_inherit
On 10/3/24 8:58 PM, Cindy Lu wrote:
> +static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev)
> +{
> + if (enforce_inherit_owner)
> + return vhost_worker_create_task(dev);
> + else
> + return vhost_worker_create_kthread(dev);
> +}
The reason we are i
On 10/3/24 8:58 PM, Cindy Lu wrote:
> Add a new UAPI to support setting the vhost device to
> use task mode. The user space application needs to use
> VHOST_SET_INHERIT_FROM_OWNER to set the mode.
> This setting must be set before VHOST_SET_OWNER is set.
>
> Signed-off-by: Cindy Lu
> ---
> drive
On 9/10/24 2:41 AM, Michael S. Tsirkin wrote:
> On Mon, Sep 09, 2024 at 10:00:38AM +0800, Cindy Lu wrote:
>> In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"),
>> vhost removed the support for the kthread API. However, there are
>> still situations where there is a request to use
On 9/10/24 10:45 PM, Jason Wang wrote:
>>> It depends on how we define "secure". There's plenty of users of
>>> kthread and if I was not wrong, mike may still need to fix some bugs.
>>>
>>
>> which bugs?
>
> https://lore.kernel.org/all/06369c2c-c363-4def-9ce0-f018a9e10...@oracle.com/T/
The SIGKIL
On 8/16/24 1:17 PM, Michael S. Tsirkin wrote:
> On Fri, Aug 16, 2024 at 11:10:32AM -0700, Sean Christopherson wrote:
>> On Fri, Aug 16, 2024, syzbot wrote:
On Wed, May 29, 2024, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:9b62e02e6336
On 5/1/24 2:50 AM, Hillf Danton wrote:
> On Wed, 1 May 2024 02:01:20 -0400 Michael S. Tsirkin
>>
>> and then it failed testing.
>>
> So did my patch [1] but then the reason was spotted [2,3]
>
> [1] https://lore.kernel.org/lkml/20240430110209.4310-1-hdan...@sina.com/
> [2] https://lore.kernel.org
On 4/30/24 7:15 PM, Hillf Danton wrote:
> On Tue, Apr 30, 2024 at 11:23:04AM -0500, Mike Christie wrote:
>> On 4/30/24 8:05 AM, Edward Adam Davis wrote:
>>> static int vhost_task_fn(void *data)
>>> {
>>> struct vhost_task *vtsk = data;
>>> @@
On 4/30/24 8:05 AM, Edward Adam Davis wrote:
> static int vhost_task_fn(void *data)
> {
> struct vhost_task *vtsk = data;
> @@ -51,7 +51,7 @@ static int vhost_task_fn(void *data)
> schedule();
> }
>
> - mutex_lock(&vtsk->exit_mutex);
> + mutex_lock(&exi
se/bus.c:673
>>> driver_register+0x23a/0x320 drivers/base/driver.c:246
>>> virtio_scsi_init+0x65/0xe0 drivers/scsi/virtio_scsi.c:1083
>>> do_one_initcall+0x248/0x880 init/main.c:1238
>>> do_initcall_level+0x157/0x210 init/main.c:1300
>>> do_initcalls+
On 1/10/24 9:09 PM, Jason Wang wrote:
> On Thu, Jan 11, 2024 at 4:40 AM Steve Sistare
> wrote:
>>
>> To pass ownership of a live vdpa device to a new process, the user
>> suspends the device, calls VHOST_NEW_OWNER to change the mm, and calls
>> VHOST_IOTLB_REMAP to change the user virtual address
On 12/8/23 3:24 AM, Tobias Huschle wrote:
> On Thu, Dec 07, 2023 at 01:48:40AM -0500, Michael S. Tsirkin wrote:
>> On Thu, Dec 07, 2023 at 07:22:12AM +0100, Tobias Huschle wrote:
>>> 3. vhost looping endlessly, waiting for kworker to be scheduled
>>>
>>> I dug a little deeper on what the vhost is d
On 4/6/21 8:24 PM, Wenchao Hao wrote:
> iscsi_sw_tcp_host_get_param() would access struct iscsi_session, while
> struct iscsi_session might be freed by session destroy flow in
> iscsi_free_session(). This commit fix this condition by freeing session
> after host has already been removed.
>
> Signe
gt; https://urldefense.com/v3/__https://lore.kernel.org/r/20210325093248.284678-1-gulam.mohamed@oracle.com__;!!GqivPVa7Brio!Jiqrc6pu3EgrquzpG-KpNQkNebwKUgctkE0MN1MloQ2y5Y4OVOkKN0yCr2_W_CX2oRet$
>
> Reviewed-by: Mike Christie
There was a mistake in my review of this patch. It will also req
On 3/26/21 7:31 AM, Maurizio Lombardi wrote:
>
>
> Dne 23. 03. 21 v 3:58 Lv Yunlong napsal(a):
>> In transport_free_session, se_nacl is got from se_sess
>> with the initial reference. If se_nacl->acl_sess_list is
>> empty, se_nacl->dynamic_stop is set to true. Then the first
>> target_put_nacl(se
On 3/25/21 2:48 AM, lyl2...@mail.ustc.edu.cn wrote:
>
>
>
>> -原始邮件-
>> 发件人: michael.chris...@oracle.com
>> 发送时间: 2021-03-24 00:28:35 (星期三)
>> 收件人: "Lv Yunlong" , martin.peter...@oracle.com
>> 抄送: linux-s...@vger.kernel.org, target-de...@vger.kernel.org,
>> linux-kernel@vger.kernel.org
>
On 1/7/21 9:48 AM, Gulam Mohamed wrote:
> Hi Michael,
>
> As per your suggestions in below mail, I have completed the
> suggested changes and tested them. Can you please review and let me know your
> comments? Here is the patch:
>
> Description
> ===
> 1. This Kernel panic
On 1/13/21 11:59 AM, Bodo Stroesser wrote:
> On 12.01.21 19:36, Mike Christie wrote:
>> On 12/18/20 8:15 AM, Bodo Stroesser wrote:
>>> tcmu calls uio_unregister_device from tcmu_destroy_device.
>>> After that uio will never call tcmu_release for this device.
>>
On 12/18/20 8:15 AM, Bodo Stroesser wrote:
> tcmu calls uio_unregister_device from tcmu_destroy_device.
> After that uio will never call tcmu_release for this device.
> If userspace still had the uio device open and / or mmap'ed
> during uio_unregister_device, tcmu_release will not be called and
>
destroy_vq_cmds;
}
Reviewed-by: Mike Christie
gt; return conn;
>
> release_conn_ref:
> - put_device(&conn->dev);
> + device_unregister(&conn->dev);
> + put_device(&session->dev);
> + return NULL;
> release_parent_ref:
> put_device(&session->dev);
> free_conn:
>
Reviewed-by: Mike Christie
+2790,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
>
> return 0;
>
> +free_tmf_thread:
> + destroy_workqueue(qedi->tmf_thread);
> free_cid_que:
> qedi_release_cid_que(qedi);
> free_uio:
>
Reviewed-by: Mike Christie
On 11/30/20 11:52 AM, Paolo Bonzini wrote:
> On 30/11/20 18:38, Sasha Levin wrote:
>>> I am not aware of any public CI being done _at all_ done on vhost-scsi, by
>>> CKI or everyone else. So autoselection should be done only on subsystems
>>> that have very high coverage in CI.
>>
>> Where can I
On 10/8/20 12:11 PM, Mike Christie wrote:
> On 9/25/20 1:41 PM, ldun...@suse.com wrote:
>> From: Lee Duncan
>>
>> iSCSI NOPs are sometimes "lost", mistakenly sent to the
>> user-land iscsid daemon instead of handled in the kernel,
>> as they should be,
On 9/25/20 1:41 PM, ldun...@suse.com wrote:
> From: Lee Duncan
>
> iSCSI NOPs are sometimes "lost", mistakenly sent to the
> user-land iscsid daemon instead of handled in the kernel,
> as they should be, resulting in a message from the daemon like:
>
>> iscsid: Got nop in, but kernel supports no
uot;)
>
> To: linux-s...@vger.kernel.org
> Cc: Mike Christie
> Signed-off-by: John Donnelly
> ---
> drivers/target/target_core_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_user.c
> b/drivers/target/targe
_set_fnode;
> }
>
> idx = ev->u.set_flashnode.flashnode_idx;
>
Reviewed-by: Mike Christie
On 6/11/20 5:07 AM, Bob Liu wrote:
This patch enable setting cpu affinity through "cpumask" for below
scsi/iscsi workqueues, so as to get better isolation.
- scsi_wq_*
- scsi_tmf_*
- iscsi_q_xx
- iscsi_eh
Signed-off-by: Bob Liu
---
drivers/scsi/hosts.c| 4 ++--
drivers/scsi/l
> This version ensures the initiator name is also printed on the same
> message in transport_lookup_tmr_lun for consistency.
>
Reviewed-by: Mike Christie
ut
the other NON_EXISTENT_LUN instace in transport_lookup_tmr_lun. I just
thought we would want/need the same info there.
>
>
>
>
>
>
>
>
>
> On Sat, May 16, 2020 at 9:50 AM Mike Christie wrote:
>>
>> On 5/13/20 11:01 PM, Lance Digby wrote:
>
On 5/13/20 11:01 PM, Lance Digby wrote:
> The NON_EXISTENT_LUN error can be written without an error condition
> on the initiator responsible. Adding the initiatorname to this message
> will reduce the effort required to fix this when many initiators are
> supported by a target.
>
> Signed-off-b
On 5/11/20 8:19 AM, syzbot wrote:
> syzbot has bisected this bug to:
>
> commit 2da22da573481cc4837e246d0eee4d518b3f715e
> Author: Mike Christie
> Date: Tue Aug 13 16:39:52 2019 +
>
> nbd: fix zero cmd timeout handling v2
>
> bisection log: https://syzkall
On 10/22/2019 06:24 AM, Michal Hocko wrote:
> On Mon 21-10-19 16:41:37, Mike Christie wrote:
>> There are several storage drivers like dm-multipath, iscsi, tcmu-runner,
>> amd nbd that have userspace components that can run in the IO path. For
>> example, iscsi and nbd's
abc2a360
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11712c0560
>
> The bug was bisected to:
>
> commit e9e006f5fcf2bab59149cb38a48a4817c1b538b4
> Author: Mike Christie
> Date: Sun Aug 4 19:10:06 2019 +
>
> nbd: fix max number of supported devs
&g
On 09/11/2019 03:40 AM, Martin Raiber wrote:
> On 10.09.2019 10:35 Damien Le Moal wrote:
>> Mike,
>>
>> On 2019/09/09 19:26, Mike Christie wrote:
>>> Forgot to cc linux-mm.
>>>
>>> On 09/09/2019 11:28 AM, Mike Christie wrote:
>>>> There a
On 09/10/2019 05:00 AM, Kirill A. Shutemov wrote:
> On Mon, Sep 09, 2019 at 11:28:04AM -0500, Mike Christie wrote:
>> There are several storage drivers like dm-multipath, iscsi, and nbd that
>> have userspace components that can run in the IO path. For example,
>> iscsi and nb
Josef had ackd my patch for the same thing here:
https://www.spinics.net/lists/linux-block/msg43800.html
so maybe Jens will pick that up with the rest of the set Josef had acked:
https://www.spinics.net/lists/linux-block/msg43809.html
to make it easier.
On 08/14/2019 08:27 PM, sunke (E) wrote:
On 01/11/2019 11:31 PM, Kangjie Lu wrote:
> When match_int fails, "arg" is left uninitialized and may contain random
> value, thus should not be used.
> The fix checks if match_int fails, and if so, returns its error code.
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/target/target_core_rd.c | 1
On 12/26/2018 12:48 AM, Kangjie Lu wrote:
> When match_int fails, "arg" is left uninitialized and may contain random
> value, thus should not be used.
> The fix checks if match_int fails, and if so, break.
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/target/target_core_rd.c | 3 ++-
> 1 file ch
in Discovery Session, rejecting.\n", opcode);
> iscsit_add_reject(conn, ISCSI_REASON_PROTOCOL_ERROR,
> buffer);
> - return;
> + break;
> }
>
> ret = iscsi_target_rx_opcode(conn, buffer);
> if (ret < 0)
> - return;
> + break;
> }
> +
> + kfree(buffer);
> }
>
> int iscsi_target_rx_thread(void *arg)
>
Ok.
Reviewed-by: Mike Christie
ccing Maurizio because he was working on the same issue.
On 08/22/2018 12:37 PM, Laura Abbott wrote:
> Fedora got a bug report of a crash with iSCSI:
>
> kernel BUG at include/linux/scatterlist.h:143!
> ...
> RIP: 0010:iscsit_do_crypto_hash_buf+0x154/0x180 [iscsi_target_mod]
> ...
> Call Trace:
On 07/06/2018 08:28 PM, Xiubo Li wrote:
> On 2018/7/7 2:23, Mike Christie wrote:
>> On 07/05/2018 09:57 PM, xiu...@redhat.com wrote:
>>> static irqreturn_t uio_interrupt(int irq, void *dev_id)
>>> {
>>> struct uio_device *idev = (struct uio_devic
On 07/06/2018 08:47 PM, Xiubo Li wrote:
> On 2018/7/7 2:58, Mike Christie wrote:
>> On 07/05/2018 09:57 PM, xiu...@redhat.com wrote:
>>> void uio_event_notify(struct uio_info *info)
>>> {
>>> -struct uio_device *idev = info->uio_dev;
>>>
On 07/05/2018 09:57 PM, xiu...@redhat.com wrote:
> void uio_event_notify(struct uio_info *info)
> {
> - struct uio_device *idev = info->uio_dev;
> + struct uio_device *idev;
> +
> + if (!info)
> + return;
> +
> + idev = info->uio_dev;
>
For this one too, I am not su
On 07/05/2018 09:57 PM, xiu...@redhat.com wrote:
> static irqreturn_t uio_interrupt(int irq, void *dev_id)
> {
> struct uio_device *idev = (struct uio_device *)dev_id;
> - irqreturn_t ret = idev->info->handler(irq, idev->info);
> + irqreturn_t ret;
> +
> + mutex_lock(&idev->info
Hi Hamish,
I am hitting a regression with your patch:
commit a93e7b331568227500186a465fee3c2cb5dffd1f
Author: Hamish Martin
Date: Mon May 14 13:32:23 2018 +1200
uio: Prevent device destruction while fds are open
The problem is the addition of spin_lock_irqsave in uio_write. This
leads to
"
>
> -DEFINE_MUTEX(device_mutex);
> -LIST_HEAD(device_list);
> +static DEFINE_MUTEX(device_mutex);
> +static LIST_HEAD(device_list);
> static DEFINE_IDR(devices_idr);
>
> static struct se_hba *lun0_hba;
>
My fault. Thanks.
Reviewed-by: Mike Christie
On 06/13/2017 07:16 PM, Mike Christie wrote:
> On 06/13/2017 09:01 AM, Greg KH wrote:
>> > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote:
>>> >> It looks like there might be 2 issues with the uio_device allocation, or
>>> >> it
>&
On 06/13/2017 09:01 AM, Greg KH wrote:
> On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote:
>> It looks like there might be 2 issues with the uio_device allocation, or it
>> looks like we are leaking the device for possibly a specific type of device
>> case that
did not see any type of device like this
though.
If this is a bug, this patch, made over Linus's tree, fixes the problems by
just allocating the uio_device with the uio_info struct since they need to be
allocated/freed/accessed at the same times.
Signed-off-by: Mike Christie
---
drivers/t
On 05/04/2017 09:51 PM, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> The fifo type waiter list will hold the udevs who are waiting for the
> blocks from the data global pool. The unmap thread will try to feed the
> first udevs in waiter list, if the global free blocks available are
>
On 05/30/2017 11:58 PM, Nicholas A. Bellinger wrote:
> Hey MNC,
>
> On Fri, 2017-05-26 at 22:14 -0500, Mike Christie wrote:
>> Thanks for the patch.
>>
>
> Btw, after running DATERA's internal longevity and scale tests across
> ~20 racks on v4.1.y with this
Thanks for the patch.
On 05/26/2017 12:32 AM, Nicholas A. Bellinger wrote:
>
> - state = iscsi_target_sk_state_check(sk);
> - write_unlock_bh(&sk->sk_callback_lock);
> -
> - pr_debug("iscsi_target_sk_state_change: state: %d\n", state);
> + orig_state_change(sk);
>
> -
t; how many iovs is needed before insert it to cmd area.
>
> Signed-off-by: Xiubo Li
Looks ok to me. Thanks.
Acked-by: Mike Christie
On 04/30/2017 06:29 AM, Xiubo Li wrote:
> [...]
>>> +static struct page *tcmu_try_get_block_page(struct tcmu_dev *udev,
>>> uint32_t dbi)
>>> +{
>>> +struct page *page;
>>> +int ret;
>>> +
>>> +mutex_lock(&udev->cmdr_lock);
>>> +page = tcmu_get_block_page(udev, dbi);
>>> +if (li
On 04/30/2017 05:22 AM, Xiubo Li wrote:
> On 2017年04月30日 13:48, Mike Christie wrote:
>> On 04/26/2017 01:25 AM, lixi...@cmss.chinamobile.com wrote:
>>> for_each_sg(data_sg, sg, data_nents, i) {
>>> @@ -275,22 +371,26 @@ static void alloc_and_scatter_data_are
On 04/26/2017 01:25 AM, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> For each target there will be one ring, when the target number
> grows larger and larger, it could eventually runs out of the
> system memories.
>
> In this patch for each target ring, currently for the cmd area
> t
On 04/26/2017 01:25 AM, lixi...@cmss.chinamobile.com wrote:
> for_each_sg(data_sg, sg, data_nents, i) {
> @@ -275,22 +371,26 @@ static void alloc_and_scatter_data_area(struct tcmu_dev
> *udev,
> from = kmap_atomic(sg_page(sg)) + sg->offset;
> while (sg_remaining >
On 02/27/2017 07:22 PM, Xiubo Li wrote:
> Hi Mike
>
> Thanks verrry much for your work and test cases.
>
>
> From: Xiubo Li
>
> Currently for the TCMU, the ring buffer size is fixed to 64K cmd
> area + 1M data area, and this will be bottlenecks for high iops.
>>> Hi Xiubo, thank
On 02/22/2017 02:32 PM, Andy Grover wrote:
> On 02/17/2017 01:24 AM, lixi...@cmss.chinamobile.com wrote:
>> > From: Xiubo Li
>> >
>> > Currently for the TCMU, the ring buffer size is fixed to 64K cmd
>> > area + 1M data area, and this will be bottlenecks for high iops.
> Hi Xiubo, thanks for your
On 01/03/2017 02:46 AM, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> This is another use-after-free bug, the crash Call Trace is like:
> [ 368.909498] RIP: 0010:[] []
> memcpy+0x16/0x110
> ..
> [ 368.909547] Call Trace:
> [ 368.909550] [] ?gather_data_area+0x109/0x180
> [ 36
sertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 01bff8ea28d8..81384a2562e7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6448,10 +6448,10 @@ S:Maintained
> F: drivers/firmware/iscsi_ibft*
>
> ISCSI
> -M: Mike Christie
&g
Adding Steven and adi-buildroot-devel list.
On 09/04/2016 12:12 PM, kbuild test robot wrote:
> Hi Mike,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 9ca581b50dab6103183396852cc08e440fcda18e
> commit:
On 08/03/2016 07:30 PM, Shaun Tancheff wrote:
> On Wed, Aug 3, 2016 at 6:47 PM, Mike Christie wrote:
>> On 08/03/2016 05:33 PM, Ross Zwisler wrote:
>>> On Sun, Jun 5, 2016 at 1:32 PM, wrote:
>>>> From: Mike Christie
>>>>
>>>> The r
On 08/03/2016 05:33 PM, Ross Zwisler wrote:
> On Sun, Jun 5, 2016 at 1:32 PM, wrote:
>> From: Mike Christie
>>
>> The req operation REQ_OP is separated from the rq_flag_bits
>> definition. This converts the block layer drivers to
>> use req_op to get the op from
On 08/03/2016 11:25 AM, Ross Zwisler wrote:
> run fstests generic/008 at 2016-08-03 09:54:56
> page:ea0017af04c0 count:3 mapcount:0 mapping:8805eb059200 index:0x0
> flags: 0x3fff802828(uptodate|lru|private|writeback)
> page dumped because: VM_BUG_ON_PAGE(!PageLocked(page))
> page->mem_
On 06/06/2016 01:46 AM, Hannes Reinecke wrote:
> On 06/05/2016 09:32 PM, mchri...@redhat.com wrote:
>> From: Mike Christie
>>
>> Separate the op from the rq_flag_bits and have the target layer
>> set/get the bio using bio_set_op_attrs/bio_op.
>>
>> Signed-of
On 05/04/2016 12:58 PM, Jeff Moyer wrote:
> Mike Christie writes:
>
>> On 05/03/2016 03:44 PM, Jeff Moyer wrote:
>>> Hi, Mike,
>>>
>>> That git tree doesn't seem to exist. I did manage to apply your patch
>>> set on top of next-20160415, tho
On 05/03/2016 03:44 PM, Jeff Moyer wrote:
> mchri...@redhat.com writes:
>
>> The following patches begin to cleanup the request->cmd_flags and
>> bio->bi_rw mess. We currently use cmd_flags to specify the operation,
>> attributes and state of the request. For bi_rw we use it for similar
>> info an
On 04/15/2016 05:50 AM, Juergen Gross wrote:
> On 15/04/16 12:40, mchri...@redhat.com wrote:
>> From: Mike Christie
>>
>> The last patch added a REQ_OP_FLUSH for request_fn drivers
>> and the next patch renames REQ_FLUSH to REQ_PREFLUSH which
>> will be used by
On 03/22/2016 02:01 PM, Jens Axboe wrote:
> On 03/22/2016 12:59 PM, Christoph Hellwig wrote:
>> On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote:
>>> Some of the flags that we want to use from the make_request_fn path
>>> are now larger than 32-bit, so change the functions involved to
>>>
On 02/29/2016 11:13 AM, Christoph Hellwig wrote:
> Any reason you've dropped my ACK for the previous version?
Sorry. I think I accidentally dropped it when I rebased back over to
linux-next. It looks like it only got stuck on the first patch. I will
fix that up on the resend for those kbuild error
On 02/15/2016 12:26 PM, Chris Leech wrote:
> On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote:
>> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote:
>>> The scsi_transport_iscsi module already uses the ida_simple
>>> routines for managing the target ID, if requested to do
>>> so. T
1 - 100 of 173 matches
Mail list logo
