RE: [PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED

2020-11-04 Thread Michael.Wu
Hi Wolfram, > Thanks for the detailed explanation! Okay, then what you do looks > correct to me (from a high level perspective without really knowing the > HW): when RX is full, you first send the state WRITE_REQUESTED when > there is no other transfer on-going. Then you send WRITE_RECEIVED > imme

Recall: [PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED

2020-11-04 Thread Michael.Wu
Michael.Wu(吳忠益) would like to recall the message, "[PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED".

RE: [PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED

2020-11-04 Thread Michael.Wu
Hi Wolfram, > > dev->status can be used to record the current state, especially Designware > > I2C controller has no interrupts to identify a write-request. This patch > > Just double-checking: the designware HW does not raise an interrupt when > its own address + RW bit has been received? Not e

RE: [PATCH v3] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once

2020-10-28 Thread Michael.Wu
Hi, > On 10/23/20 8:40 AM, Michael Wu wrote: > > If some bits were cleared by i2c_dw_read_clear_intrbits_slave() in > > i2c_dw_isr_slave() and not handled immediately, those cleared bits would > > not be shown again by later i2c_dw_read_clear_intrbits_slave(). They > > therefore were forgotten to

Recall: [PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED

2020-10-15 Thread Michael.Wu
Michael.Wu(吳忠益) would like to recall the message, "[PATCH 2/2] i2c: designware: slave should do WRITE_REQUESTED before WRITE_RECEIVED".

Recall: [PATCH 1/2] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once

2020-10-15 Thread Michael.Wu
Michael.Wu(吳忠益) would like to recall the message, "[PATCH 1/2] i2c: designware: call i2c_dw_read_clear_intrbits_slave() once".

RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

2020-10-14 Thread Michael.Wu
On 10/14/20 6:53 PM, jarkko.nik...@linux.intel.com wrote: > Thanks for the patch. I was thinking this too after your report but > haven't found actually time to look at implementing it. > > But what I was thinking it is probably good to have two patches. First > patch that changes only i2c_dw_read

RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

2020-10-14 Thread Michael.Wu
On 10/14/20 4:53 PM, andriy.shevche...@linux.intel.com wrote: > > Wondering if you compile this at all... I'm very sorry that I did not compile it because I only have ARM SoC with my linux 4.9.170, but I've verified the logic of this patch in my linux. I'll correct these two syntax errors in ne

RE: [PATCH] gpiolib: fix incorrect IRQ requesting of an active-low lineevent

2019-07-05 Thread Michael.Wu
: Friday, July 05, 2019 5:33 PM To: Michael.Wu(吳忠益) Cc: Linus Walleij; linux-gpio; LKML; mvp.kut...@gmail.com Subject: Re: [PATCH] gpiolib: fix incorrect IRQ requesting of an active-low lineevent pt., 5 lip 2019 o 11:30 Michael Wu napisał(a): > > When a pin is active-low, logical trigger edg