Re: wake_wide mechanism clarification

2017-08-02 Thread Michael Wang
Hi, Joel On 07/29/2017 10:13 AM, Joel Fernandes wrote: > +Michael Wang on his current email address (old one bounced). (my > reply was to Mike Galbraith but I also meant to CC Michael Wang for > the discussion). Thanks Just back from vacation and saw this long long discussion... I t

[ Linux 4.4 stable ] missing 'printk: set may_schedule for some of console_trylock() callers'

2017-07-25 Thread Michael Wang
there any plan on backport it in future? Regards, Michael Wang

Re: [PATCH] md: return 0 instead of error in rdev_attr_show()

2017-04-11 Thread Michael Wang
We found the upstream fix, sorry for the noise... Regards, Michael Wang On 04/11/2017 12:14 PM, Michael Wang wrote: > > sysfs_kf_read() expect the show() callback return the dumped > length, while rdev_attr_show() can return the error which lead > into overflow: > > BUG

[PATCH] md: return 0 instead of error in rdev_attr_show()

2017-04-11 Thread Michael Wang
Oops: 0003 [#1] SMP [snip] Call Trace: [] ? sysfs_kf_read+0x80/0xb0 [] kernfs_fop_read+0xab/0x160 [] __vfs_read+0x28/0xd0 [] vfs_read+0x86/0x130 [] SyS_read+0x46/0xa0 [] entry_SYSCALL_64_fastpath+0x12/0x6a Simply return 0 in case of error solved the problem. Signed-off-by: Michael

Re: [RFC PATCH] raid1: reset 'bi_next' before reuse the bio

2017-04-05 Thread Michael Wang
gt; sync_request_write() to submit a write request to it. Make sense, while still have concerns regarding the design: * in this case since the read_disk already abandoned, is it fine to keep r1_bio->read_disk recording the faulty device index? * we assign the 'end_sync_write' to

[RFC PATCH] raid1: reset 'bi_next' before reuse the bio

2017-04-04 Thread Michael Wang
7;t reset the 'bi_next' after bio is done inside request, we hit the BUG like that. This patch simply reset the bi_next before we reuse it. Signed-off-by: Michael Wang --- drivers/md/raid1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/raid1.c b/

Re: [RFC PATCH] blk: reset 'bi_next' when bio is done inside request

2017-04-04 Thread Michael Wang
On 04/04/2017 02:24 PM, Michael Wang wrote: > On 04/04/2017 12:23 PM, Michael Wang wrote: > [snip] >>> add something like >>> if (wbio->bi_next) >>> printk("bi_next!= NULL i=%d read_disk=%d bi_end_io=%pf\n", >>> i, r1_bi

Re: [RFC PATCH] blk: reset 'bi_next' when bio is done inside request

2017-04-04 Thread Michael Wang
On 04/04/2017 12:23 PM, Michael Wang wrote: [snip] >> add something like >> if (wbio->bi_next) >> printk("bi_next!= NULL i=%d read_disk=%d bi_end_io=%pf\n", >> i, r1_bio->read_disk, wbio->bi_end_io); >> >> that might help narr

Re: [RFC PATCH] blk: reset 'bi_next' when bio is done inside request

2017-04-04 Thread Michael Wang
On 04/04/2017 11:37 AM, NeilBrown wrote: > On Tue, Apr 04 2017, Michael Wang wrote: [snip] >>> >>> If sync_request_write() is using a bio that has already been used, it >>> should call bio_reset() and fill in the details again. >>> However I don't

Re: [RFC PATCH] blk: reset 'bi_next' when bio is done inside request

2017-04-04 Thread Michael Wang
Hi, Neil On 04/03/2017 11:25 PM, NeilBrown wrote: > On Mon, Apr 03 2017, Michael Wang wrote: > >> blk_attempt_plug_merge() try to merge bio into request and chain them >> by 'bi_next', while after the bio is done inside request, we forgot to >> reset the 'b

[RFC PATCH] blk: reset 'bi_next' when bio is done inside request

2017-04-03 Thread Michael Wang
t' this can no longer happen. Signed-off-by: Michael Wang --- block/blk-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 43b7d06..91223b2 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2619,8 +2619,10 @@ bool blk_u

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-12-23 Thread Michael Wang
e'd like to ask are we still planning to have this fix in upstream? Regards, Michael Wang On 07/11/2016 04:10 PM, Lars Ellenberg wrote: > For a long time, generic_make_request() converts recursion into > iteration by queuing recursive arguments on current->bio_list. > > This

[BUG] block: bdi_register_owner() failure cause NULL pointer dereference

2016-09-29 Thread Michael Wang
isk), disk->minors, NULL, exact_match, exact_lock, disk); to prevent the following NULL pointer dereference and hard lockup? Regards, Michael Wang Sep 29 09:53:28 st401b-3 systemd[1]: Starting Update UTMP about System Runlevel Changes... Sep 29 09:53:28 st401b-3 ntpd[4970]: Listen and drop on 1 v6wi

Re: [PATCH RESEND] infiniband:core:Add needed error path in cm_init_av_by_path

2015-12-17 Thread Michael Wang
On 12/16/2015 07:16 PM, Jason Gunthorpe wrote: > On Wed, Dec 16, 2015 at 11:26:39AM +0100, Michael Wang wrote: [snip] >> >> I've rechecked the ib_init_ah_from_path() again, and found it >> still set IB_AH_GRH when the GID cache missing, but

Re: [PATCH RESEND] infiniband:core:Add needed error path in cm_init_av_by_path

2015-12-16 Thread Michael Wang
On 12/15/2015 06:30 PM, Jason Gunthorpe wrote: > On Tue, Dec 15, 2015 at 05:38:34PM +0100, Michael Wang wrote: >> The hop_limit is only suggest that the package allowed to be >> routed, not have to, correct? > > If the hop limit is >= 2 (?) then the GRH is mandatory. T

Re: [PATCH RESEND] infiniband:core:Add needed error path in cm_init_av_by_path

2015-12-15 Thread Michael Wang
at if the transport don't require GRH? eg inside the same subnet? The hop_limit is only suggest that the package allowed to be routed, not have to, correct? Regards, Michael Wang > + if (ret) > + return ret; > + > av->timeout = path->packet_life_ti

Re: [PATCH] infiniband:core:Add needed error path in cm_init_av_by_path

2015-12-07 Thread Michael Wang
found in the GID table, but such connections > would fail later on when creating a QP, right? Me too think this need a reconsider, to me the current logical don't really care the missing gid in cache when initializing AV, I'm not sure if it's necessary to fail all the following path for

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-03 Thread Michael Wang
gs, additional annotations or specific page > alloc API. However, this has its own drawbacks in terms of code > complexity (potentially outside mm/kmemleak.c) and overhead. Thanks for the very nice explain :-) I used to thought overhead is the only concern, missing the point regardi

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
On 12/02/2015 03:13 PM, Borislav Petkov wrote: > On Wed, Dec 02, 2015 at 03:09:18PM +0100, Michael Wang wrote: >> This tool will help improve the kernel, AFAIK it's already made it's >> best, if you got any idea on how to make it even better that would be >> grea

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
On 12/02/2015 02:59 PM, Borislav Petkov wrote: > On Wed, Dec 02, 2015 at 02:48:47PM +0100, Michael Wang wrote: >> I'm not sure why amd-iommu use get_page not kmalloc to initialize the >> pointer table, but if it's necessary then the conflict will be there, >>

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
On 12/02/2015 02:40 PM, Borislav Petkov wrote: > On Wed, Dec 02, 2015 at 02:18:44PM +0100, Michael Wang wrote: [snip] > >> Yeah, but it would be better to solve it, otherwise whoever saw this >> report will need to go into the amd-iommu, make sure it's not a real >

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
Hi, Borislav On 12/02/2015 02:13 PM, Borislav Petkov wrote: > On Wed, Dec 02, 2015 at 02:01:55PM +0100, Michael Wang wrote: >> Yeah.. it's a little complicated since we have our own kernel tree and this >> won't be a problem for us, but we really prefer to help fix it in

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
On 12/02/2015 01:56 PM, Joerg Roedel wrote: > On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote: >> It's not my work or your work... it's a defect in the module and maintainer >> should take responsibility on fixing it, correct? > > No, its a false posi

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
On 12/02/2015 01:53 PM, Borislav Petkov wrote: > On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote: >> It's not my work or your work... it's a defect in the module and maintainer >> should take responsibility on fixing it, correct? > > Well, you said &q

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
On 12/02/2015 12:51 PM, Joerg Roedel wrote: > On Wed, Dec 02, 2015 at 12:38:03PM +0100, Michael Wang wrote: >> Joerg, this is really a tiny fix, would you mind to merge it into some >> of your cleanup patch and testing them together? we are not in hurry, >> just want to mak

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
On 12/02/2015 12:31 PM, Catalin Marinas wrote: > On 2 December 2015 at 10:56, Michael Wang wrote: [snip] > > I could copy your description but I don't currently have a way (nor > time) to test the patch. If you plan to test it anyway, please feel > free to include my dif

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
, or will you pick this patch? > > My preference (from a kmemleak perspective) is to tell kmemleak about > the irq_lookup_table. Untested: I'm fine with both solution, will leave the decision to maintainer :-) BTW, could you please send a formal patch with descriptions? Regards, M

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-12-02 Thread Michael Wang
Hi, Joerg On 11/25/2015 04:14 PM, Michael Wang wrote: > On 11/25/2015 04:08 PM, Joerg Roedel wrote: [snip] >>> This is caused by the 'irq_lookup_table' was allocated with >>> __get_free_pages() which won't create kmemleak object, thus it's &

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-11-25 Thread Michael Wang
On 11/25/2015 04:08 PM, Joerg Roedel wrote: > On Fri, Nov 20, 2015 at 12:33:50PM +0100, Michael Wang wrote: >> The kmemleak testing on 3.18.24 show: >> >> unreferenced object 0x880233ff9010 (size 16): >> comm "swapper/0", pid 1, jiffies 4294937440 (a

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-11-25 Thread Michael Wang
Hi, Joery On 11/20/2015 12:33 PM, Michael Wang wrote: > The kmemleak testing on 3.18.24 show: > > unreferenced object 0x880233ff9010 (size 16): > comm "swapper/0", pid 1, jiffies 4294937440 (age 2010.490s) > hex dump (first 16 bytes): > 0a 0a 00 00 20 00 0

Re: nfnetlink warnings

2015-11-23 Thread Michael Wang
On 11/23/2015 11:32 AM, Borislav Petkov wrote: > On Mon, Nov 23, 2015 at 11:20:18AM +0100, Michael Wang wrote: >> Who want to do that would take responsibility to make an else branch at >> that time, but reserve the branch at this moment sounds unnecessary, and >> no

Re: nfnetlink warnings

2015-11-23 Thread Michael Wang
On 11/23/2015 10:54 AM, Borislav Petkov wrote: > Hi Michael, > > On Mon, Nov 23, 2015 at 10:49:34AM +0100, Michael Wang wrote: >> Why not just initialized it as NULL, or mark it as uninitialized_var()? > > because I'd like us to save us the redundant NULL initializati

Re: nfnetlink warnings

2015-11-23 Thread Michael Wang
Hi, Borislav Why not just initialized it as NULL, or mark it as uninitialized_var()? Regards, Michael Wang On 11/23/2015 10:36 AM, Borislav Petkov wrote: > Hey, > > so I keep getting those since recently: > > net/netfilter/nfnetlink_queue.c:519:19: warning: ‘nfnl_

Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-11-20 Thread Michael Wang
On 11/20/2015 12:33 PM, Michael Wang wrote: > The kmemleak testing on 3.18.24 show: > > unreferenced object 0x880233ff9010 (size 16): > comm "swapper/0", pid 1, jiffies 4294937440 (age 2010.490s) > hex dump (first 16 bytes): > 0a 0a 00 00 20 00 0

[RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak

2015-11-20 Thread Michael Wang
ncing 'irq_remap_table' in kmemleak scan. The 'irq_remap_table' won't be freed after initialized, doesn't make sense to check it's leaking. This patch mark the 'irq_remap_table' object as 'gray' to stop the 'false positives' report

[RFC PATCH] iommu/amd: make kmemleak ignore the 'irq_remap_table' object

2015-11-20 Thread Michael Wang
erencing in kmemleak scanning. The 'irq_remap_table' allocated won't be freed after initialized, doesn't make sense to let kmemleak scan it. This patch mark the 'irq_remap_table' object as 'ignored' to stop the 'false positives' report. Signed-of

Re: [PATCH RFC v2] Documentation/infiniband: Add docs for rdma-helpers

2015-05-19 Thread Michael Wang
attribution. The definition is far more detailed and accurate, it's already good enough according to my understanding, should benefit the developer a lot ;-) Regards, Michael Wang > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH RFC v2] Documentation/infiniband: Add docs for rdma-helpers

2015-05-18 Thread Michael Wang
any guidelines on how to write the header of inline func for kdoc? > > Just because I want to move this along versus waiting for another > respin, I'm going to copy and paste these into those locations and clean > up the changelog when I integrate this patch. Got it, if there is any

Re: [PATCH RFC v2] Documentation/infiniband: Add docs for rdma-helpers

2015-05-18 Thread Michael Wang
e :-) I'll put the highlights and changelog under '---' in next version, is it looks like this? Subject: [PATCH RFC v3] Documentation/infiniband: Add docs for rdma-helpers This is the following patch for: https://lkml.org/lkml/2015/5/5/417 which try to document the settled

[PATCH RFC v2] Documentation/infiniband: Add docs for rdma-helpers

2015-05-18 Thread Michael Wang
, please don't be hesitate to point out the issues, any suggestions to improve or complete the description are very welcomed ;-) Signed-off-by: Michael Wang --- Documentation/infiniband/rdma_helpers.txt | 79 +++ 1 file changed, 79 insertions(+) create mode 1

Re: [PATCH RFC] Documentation/infiniband: Add docs for rdma-helpers

2015-05-15 Thread Michael Wang
on creating address vector, but I can understand the concept. > > This helper is true when the address family of this queue pair is of the > Ethernet (RoCE) variety. Sounds good, will be merged in next version :-) Regards, Michael Wang > > -- To unsubscribe from this list:

Re: [PATCH RFC] Documentation/infiniband: Add docs for rdma-helpers

2015-05-15 Thread Michael Wang
e give some description related to connection below in the long description. > [snip] >> Shall we put this long description into USAGE? Here maybe list >> all the helpers to give some quick overview with a brief >> description, what's your opinion? > > Given how we

Re: [PATCH RFC] Documentation/infiniband: Add docs for rdma-helpers

2015-05-15 Thread Michael Wang
+Infiniband address handler format is special in ethernet fabric, >> use >>> +the helper to verify whether the port is using ethernet format or >> not. >> >> This helper is true when the address of the specific connection is of >> the Ethernet (RoCE)

Re: [PATCH RFC] Documentation/infiniband: Add docs for rdma-helpers

2015-05-15 Thread Michael Wang
ated features. > Management Datagrams (MAD) are a required part of the InfiniBand > specification and are supported on all InfiniBand devices. A slightly > extended version are also supported on OPA interfaces. > > I would drop all instances of "use the helper to verify...&

Re: [PATCH RFC] Documentation/infiniband: Add docs for rdma-helpers

2015-05-15 Thread Michael Wang
On 05/13/2015 05:59 PM, Jason Gunthorpe wrote: > On Wed, May 13, 2015 at 03:24:32PM +0200, Michael Wang wrote: >> This is the following patch for: >> https://lkml.org/lkml/2015/5/5/417 >> which try to document the settled rdma_cap_XX(). >> >> Highlights:

[PATCH RFC] Documentation/infiniband: Add docs for rdma-helpers

2015-05-13 Thread Michael Wang
ption are very welcomed ;-) Signed-off-by: Michael Wang --- Documentation/infiniband/rdma_helpers.txt | 76 +++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/infiniband/rdma_helpers.txt diff --git a/Documentation/infiniband/rdma_helpers.t

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-13 Thread Michael Wang
e work up an incremental patch to address the kdocs issue. > I've picked up the v8 patchset, and there is no need to respin it, but I > would like to have that kdoc patch before the 4.2 merge window opens. Sure, now these helpers are settled down, it's time for document, I'll

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Michael Wang
ranch with it > included up to my github repo sometime today. Got it :-) Regards, Michael Wang > >> About the Bug, if it was not introduced in this series, maybe including the >> fix in next series would be better? >> >> Regards, >> Michael Wang >> >>&g

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Michael Wang
Agree, it sounds more reasonable to include the fix in the series introduced it :-P > > > For the rest of the series. > > Reviewed-by: Ira Weiny > Tested-by: Ira Weiny > -- Limited to mlx4, qib, and OPA (with additional patches.) Thanks for the review and testing :-)

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Michael Wang
asking to merge the #15~23, and want to reserve the changelog meanwhile reply the cover of prev version (I'm still confused on that...), I've replied but get no respond yet. I can make a v9 to merge the #15~#23 if that could benefit the maintainability, please let me know your opinio

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-05 Thread Michael Wang
On 05/05/2015 04:16 PM, Or Gerlitz wrote: > On 5/5/2015 3:50 PM, Michael Wang wrote: >> Since v7: >>* Thanks to Doug, Ira, Devesh for the testing:-) >>* Thanks for the comments from or, Doug, Ira, Jason:-) >> Please remind me if anything missed:-P >&g

[PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-05 Thread Michael Wang
hive.com/linux-rdma@vger.kernel.org/msg23339.html Doug: https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23418.html https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html Jason: https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23425.h

[PATCH v8 02/23] IB/Verbs: Implement raw management helpers

2015-05-05 Thread Michael Wang
Add raw helpers: rdma_protocol_ib rdma_protocol_iboe rdma_protocol_iwarp rdma_ib_or_iboe (transition, clean up later) To help us detect which technology the port supported. Signed-off-by: Michael Wang --- include/rdma/ib_verbs.h | 22 ++ 1

[PATCH v8 11/23] IB/Verbs: Reform route related part in IB-core cma

2015-05-05 Thread Michael Wang
Use raw management helpers to reform route related part in IB-core cma. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 31 --- drivers/infiniband/core/ucma.c | 25 ++--- 2 files changed, 14 insertions(+), 42 deletions(-) diff

[PATCH v8 03/23] IB/Verbs: Reform IB-core mad/agent/user_mad

2015-05-05 Thread Michael Wang
Use raw management helpers to reform IB-core mad/agent/user_mad. Signed-off-by: Michael Wang --- drivers/infiniband/core/agent.c| 2 +- drivers/infiniband/core/mad.c | 43 +++--- drivers/infiniband/core/user_mad.c | 26 --- 3 files

[PATCH v8 05/23] IB/Verbs: Reform IB-core sa_query

2015-05-05 Thread Michael Wang
Use raw management helpers to reform IB-core sa_query. Signed-off-by: Michael Wang --- drivers/infiniband/core/sa_query.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c

[PATCH v8 10/23] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-05-05 Thread Michael Wang
Use raw management helpers to reform cm related part in IB-core cma/ucm. Few checks focus on the device cm type rather than the port capability, directly pass port 1 works currently, but can't support mixing cm type device in future. Signed-off-by: Michael Wang --- drivers/infiniband

[PATCH v8 09/23] IB/Verbs: Reform IB-core verbs

2015-05-05 Thread Michael Wang
Use raw management helpers to reform IB-core verbs Signed-off-by: Michael Wang --- drivers/infiniband/core/verbs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index f93eb8d..7dd2f51 100644 --- a

[PATCH v8 08/23] IB/Verbs: Reform IB-ulp xprtrdma

2015-05-05 Thread Michael Wang
Use raw management helpers to reform IB-ulp xprtrdma. Signed-off-by: Michael Wang --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 +-- net/sunrpc/xprtrdma/svc_rdma_transport.c | 45 +--- 2 files changed, 20 insertions(+), 29 deletions(-) diff --git a/net/sunrpc

[PATCH v8 04/23] IB/Verbs: Reform IB-core cm

2015-05-05 Thread Michael Wang
Use raw management helpers to reform IB-core cm. Signed-off-by: Michael Wang --- drivers/infiniband/core/cm.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index e28a494..add5e484 100644

[PATCH v8 12/23] IB/Verbs: Reform mcast related part in IB-core cma

2015-05-05 Thread Michael Wang
Use raw management helpers to reform mcast related part in IB-core cma. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 56 ++- 1 file changed, 18 insertions(+), 38 deletions(-) diff --git a/drivers/infiniband/core/cma.c b/drivers

[PATCH v8 13/23] IB/Verbs: Reform cma_acquire_dev()

2015-05-05 Thread Michael Wang
Reform cma_acquire_dev() with management helpers, introduce cma_validate_port() to make the code more clean. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 68 +-- 1 file changed, 40 insertions(+), 28 deletions(-) diff --git a/drivers

[PATCH v8 15/23] IB/Verbs: Use management helper rdma_cap_ib_mad()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_ib_mad() to help us check if the port of an IB device support Infiniband Management Datagrams. Signed-off-by: Michael Wang --- drivers/infiniband/core/mad.c | 6 +++--- drivers/infiniband/core/user_mad.c | 6 +++--- include/rdma/ib_verbs.h| 15

[PATCH v8 14/23] IB/Verbs: Reform rest part in IB-core cma

2015-05-05 Thread Michael Wang
Use raw management helpers to reform rest part in IB-core cma. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 3fb3458

[PATCH v8 22/23] IB/Verbs: Use management helper rdma_cap_af_ib()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 2 +- include/rdma/ib_verbs.h | 15 +++ 2 files changed, 16 insertions(+), 1 deletion(-) diff

[PATCH v8 21/23] IB/Verbs: Use management helper rdma_cap_read_multi_sge()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_read_multi_sge() to help us check if the port of an IB device support RDMA Read Multiple Scatter-Gather Entries. Signed-off-by: Michael Wang --- include/rdma/ib_verbs.h | 16 net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 ++-- 2 files

[PATCH v8 23/23] IB/Verbs: Use management helper rdma_cap_eth_ah()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_eth_ah() to help us check if the port of an IB device support Ethernet Address Handler. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/sa_query.c | 2 +- drivers/infiniband/core/verbs.c| 4 ++-- include/rdma

[PATCH v8 20/23] IB/Verbs: Use management helper rdma_cap_ib_mcast()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_ib_mcast() to help us check if the port of an IB device support Infiniband Multicast. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 6 +++--- drivers/infiniband/core/multicast.c | 6 +++--- include/rdma/ib_verbs.h | 15

[PATCH v8 19/23] IB/Verbs: Use management helper rdma_cap_ib_sa()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administration. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 4 ++-- drivers/infiniband/core/sa_query.c | 10 +- drivers/infiniband/core/ucma.c | 2

[PATCH v8 16/23] IB/Verbs: Use management helper rdma_cap_ib_smi()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_ib_smi() to help us check if the port of an IB device support Infiniband Subnet Management Interface. Signed-off-by: Michael Wang --- drivers/infiniband/core/agent.c | 2 +- drivers/infiniband/core/mad.c | 2 +- include/rdma/ib_verbs.h | 15

[PATCH v8 18/23] IB/Verbs: Use management helper rdma_cap_iw_cm()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_iw_cm() to help us check if the port of an IB device support IWARP Communication Manager. Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 14 +++--- include/rdma/ib_verbs.h | 15 +++ 2 files changed, 22 insertions(+), 7

[PATCH v8 17/23] IB/Verbs: Use management helper rdma_cap_ib_cm()

2015-05-05 Thread Michael Wang
Introduce helper rdma_cap_ib_cm() to help us check if the port of an IB device support Infiniband Communication Manager. Signed-off-by: Michael Wang --- drivers/infiniband/core/cm.c | 6 +++--- drivers/infiniband/core/cma.c | 19 +-- drivers/infiniband/core/ucm.c | 2

[PATCH v8 07/23] IB/Verbs: Reform IB-ulp ipoib

2015-05-05 Thread Michael Wang
Use raw management helpers to reform IB-ulp ipoib. Signed-off-by: Michael Wang --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c

[PATCH v8 06/23] IB/Verbs: Reform IB-core multicast

2015-05-05 Thread Michael Wang
Use raw management helpers to reform IB-core multicast. Signed-off-by: Michael Wang --- drivers/infiniband/core/multicast.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/core/multicast.c b/drivers/infiniband/core/multicast.c index fa17b55

[PATCH v8 01/23] IB/Verbs: Implement new callback query_protocol()

2015-05-05 Thread Michael Wang
IB qib IB_CA IB IB IB Signed-off-by: Michael Wang --- drivers/infiniband/core/device.c | 1 + drivers/infiniband/hw/amso1100/c2_provider.c | 7 +++ drivers/infiniband/hw/cxgb3/iwch_provider.c | 7 +++ drivers

Re: [PATCH v7 00/23] IB/Verbs: IB Management Helpers

2015-05-04 Thread Michael Wang
On 05/01/2015 08:34 AM, ira.weiny wrote: > On Tue, Apr 28, 2015 at 05:10:00PM +0200, Michael Wang wrote: >> Since v6: >> * Thanks to Ira, Devesh for the review and testing :-) >> * Thanks for the comments from Sean, Tom, Jason, Doug, Devesh, Ira, >> Liran :-) P

Re: [PATCH v7 00/23] IB/Verbs: IB Management Helpers

2015-04-30 Thread Michael Wang
On 04/29/2015 06:28 PM, Doug Ledford wrote: > On Tue, 2015-04-28 at 17:10 +0200, Michael Wang wrote: >> Since v6: >> * Thanks to Ira, Devesh for the review and testing :-) >> * Thanks for the comments from Sean, Tom, Jason, Doug, Devesh, Ira, >> Liran :-) P

Re: [PATCH v7 04/23] IB/Verbs: Reform IB-core cm

2015-04-30 Thread Michael Wang
ast version to be applied could merge all the cap_XX into one, after all, it's more focus on the description rather than logical, separate cap_XX won't help easier the review anyway. Regards, Michael Wang > > Or. > -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH v7 04/23] IB/Verbs: Reform IB-core cm

2015-04-29 Thread Michael Wang
Hi, Or On 04/28/2015 09:02 PM, Or Gerlitz wrote: > On Tue, Apr 28, 2015 at 6:10 PM, Michael Wang > wrote: >> Use raw management helpers to reform IB-core cm. >> >> Cc: Hal Rosenstock >> Cc: Steve Wise >> Cc: Tom Talpey >> Cc: Jason Gunthorpe &g

[PATCH v7 08/23] IB/Verbs: Reform IB-ulp xprtrdma

2015-04-28 Thread Michael Wang
Use raw management helpers to reform IB-ulp xprtrdma. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 +-- net/sunrpc/xprtrdma

[PATCH v7 05/23] IB/Verbs: Reform IB-core sa_query

2015-04-28 Thread Michael Wang
Use raw management helpers to reform IB-core sa_query. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/sa_query.c | 30 +- 1 file changed

[PATCH v7 06/23] IB/Verbs: Reform IB-core multicast

2015-04-28 Thread Michael Wang
Use raw management helpers to reform IB-core multicast. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/multicast.c | 12 +++- 1 file changed, 3 insertions

[PATCH v7 02/23] IB/Verbs: Implement raw management helpers

2015-04-28 Thread Michael Wang
Signed-off-by: Michael Wang --- include/rdma/ib_verbs.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 080f204..acdba60 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1752,6 +1752,28

[PATCH v7 10/23] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-28 Thread Michael Wang
Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 81 +-- drivers/infiniband/core/ucm.c | 3 +- 2 files changed, 26 insertions(+), 58 deletions(-) diff --git a/drivers/infin

[PATCH v7 03/23] IB/Verbs: Reform IB-core mad/agent/user_mad

2015-04-28 Thread Michael Wang
Use raw management helpers to reform IB-core mad/agent/user_mad. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/agent.c| 2 +- drivers/infiniband/core/mad.c

[PATCH v7 11/23] IB/Verbs: Reform route related part in IB-core cma

2015-04-28 Thread Michael Wang
Use raw management helpers to reform route related part in IB-core cma. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 31

[PATCH v7 13/23] IB/Verbs: Reform cma_acquire_dev()

2015-04-28 Thread Michael Wang
Reform cma_acquire_dev() with management helpers, introduce cma_validate_port() to make the code more clean. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c

[PATCH v7 07/23] IB/Verbs: Reform IB-ulp ipoib

2015-04-28 Thread Michael Wang
Use raw management helpers to reform IB-ulp ipoib. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 15 --- 1 file changed, 8

[PATCH v7 14/23] IB/Verbs: Reform rest part in IB-core cma

2015-04-28 Thread Michael Wang
Use raw management helpers to reform rest part in IB-core cma. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 20 +--- 1 file changed, 9

[PATCH v7 17/23] IB/Verbs: Use management helper cap_ib_cm()

2015-04-28 Thread Michael Wang
Introduce helper cap_ib_cm() to help us check if the port of an IB device support Infiniband Communication Manager. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core

[PATCH v7 15/23] IB/Verbs: Use management helper cap_ib_mad()

2015-04-28 Thread Michael Wang
Introduce helper cap_ib_mad() to help us check if the port of an IB device support Infiniband Management Datagrams. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core

[PATCH v7 20/23] IB/Verbs: Use management helper cap_ib_mcast()

2015-04-28 Thread Michael Wang
Introduce helper cap_ib_mcast() to help us check if the port of an IB device support Infiniband Multicast. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c

[PATCH v7 19/23] IB/Verbs: Use management helper cap_ib_sa()

2015-04-28 Thread Michael Wang
Introduce helper cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administration. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core

[PATCH v7 12/23] IB/Verbs: Reform mcast related part in IB-core cma

2015-04-28 Thread Michael Wang
Use raw management helpers to reform mcast related part in IB-core cma. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c | 56

[PATCH v7 18/23] IB/Verbs: Use management helper cap_iw_cm()

2015-04-28 Thread Michael Wang
Introduce helper cap_iw_cm() to help us check if the port of an IB device support IWARP Communication Manager. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c

[PATCH v7 22/23] IB/Verbs: Use management helper cap_af_ib()

2015-04-28 Thread Michael Wang
Introduce helper cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c

[PATCH v7 21/23] IB/Verbs: Use management helper cap_read_multi_sge()

2015-04-28 Thread Michael Wang
Introduce helper cap_read_multi_sge() to help us check if the port of an IB device support RDMA Read Multiple Scatter-Gather Entries. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- include

[PATCH v7 23/23] IB/Verbs: Use management helper cap_eth_ah()

2015-04-28 Thread Michael Wang
Introduce helper cap_eth_ah() to help us check if the port of an IB device support Ethernet Address Handler. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/cma.c

[PATCH v7 09/23] IB/Verbs: Reform IB-core verbs

2015-04-28 Thread Michael Wang
Use raw management helpers to reform IB-core verbs Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband/core/verbs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH v7 16/23] IB/Verbs: Use management helper cap_ib_smi()

2015-04-28 Thread Michael Wang
Introduce helper cap_ib_smi() to help us check if the port of an IB device support Infiniband Subnet Management Interface. Cc: Hal Rosenstock Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- drivers/infiniband

  1   2   3   4   5   6   7   8   9   >