[tip:perf/core] tools lib traceevent: Add UL suffix to MISSING_EVENTS

Commit-ID: 6d36ce261614fbac3557cc58ba6a33424944c8a2 Gitweb: https://git.kernel.org/tip/6d36ce261614fbac3557cc58ba6a33424944c8a2 Author: Michael Sartain AuthorDate: Thu, 11 Jan 2018 19:47:49 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:22:49 -0300 tools lib

[tip:perf/core] tools lib traceevent: Fix bad force_token escape sequence

Commit-ID: 952a99ccfa9db2f9a32810fc9c0084f532dd871a Gitweb: https://git.kernel.org/tip/952a99ccfa9db2f9a32810fc9c0084f532dd871a Author: Michael Sartain AuthorDate: Thu, 11 Jan 2018 19:47:42 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:21:39 -0300 tools lib

[PATCH v2 2/4] trace-cmd: Fix NULL pointer being passed to memcpy

Signed-off-by: Michael Sartain --- trace-output.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/trace-output.c b/trace-output.c index bfe6331..bbb1637 100644 --- a/trace-output.c +++ b/trace-output.c @@ -929,7 +929,11 @@ tracecmd_add_option(struct tracecmd_output

[PATCH v2 0/4] trace-cmd: Fixes for four minor bugs

Thanks Steve. -Mike v2: check malloc size, use UL suffix, and unsigned parameter Michael Sartain (4): trace-cmd: Fix incorrect malloc size arg: *item instead of item trace-cmd: Fix NULL pointer being passed to memcpy trace-cmd: Add UL suffix to MISSING_EVENTS since ints shouldn'

[PATCH v2 1/4] trace-cmd: Fix incorrect malloc size arg: *item instead of item

Signed-off-by: Michael Sartain --- trace-dialog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-dialog.c b/trace-dialog.c index b5776cc..87e597a 100644 --- a/trace-dialog.c +++ b/trace-dialog.c @@ -97,7 +97,7 @@ static void push_cursor(GdkCursor *cursor

[PATCH v2 3/4] trace-cmd: Add UL suffix to MISSING_EVENTS since ints shouldn't be left shifted by 31

Signed-off-by: Michael Sartain --- kbuffer-parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kbuffer-parse.c b/kbuffer-parse.c index 4e6e95e..593d0ab 100644 --- a/kbuffer-parse.c +++ b/kbuffer-parse.c @@ -24,8 +24,8 @@ #include "kbuffer.h"

[PATCH v2 4/4] trace-cmd: Use unsigned values in Hsieh's trace_hash fast hash function

Signed-off-by: Michael Sartain --- trace-hash-local.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/trace-hash-local.h b/trace-hash-local.h index b2a1002..7c822a8 100644 --- a/trace-hash-local.h +++ b/trace-hash-local.h @@ -20,9 +20,9 @@ #ifndef _TRACE_HASH_LOCAL_H

Re: [PATCH 2/5] trace-cmd: Fix NULL pointer being passed to memcpy

On Mon, Oct 09, 2017 at 06:24:32PM -0400, Steven Rostedt wrote: > On Sat, 12 Aug 2017 11:30:44 -0600 > Michael Sartain wrote: > > > Signed-off-by: Michael Sartain > > --- > > trace-output.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [PATCH 0/5] trace-cmd: Fixes for four small bugs plus minor cleanup

Ping? Were there any concerns with these or things needed to be done before they could be merged? Thanks. On Sat, Aug 12, 2017, at 11:30 AM, Michael Sartain wrote: > Thanks much. > -Mike > > --- > > Michael Sartain (5): > trace-cmd: Fix incorrect malloc size arg:

[PATCH 4/5] trace-cmd: Use unsigned values in Hsieh's trace_hash fast hash function

and filling high bits with 1s, which is different than the original algorithm. Signed-off-by: Michael Sartain --- trace-hash-local.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/trace-hash-local.h b/trace-hash-local.h index b2a1002..b3f9b06 100644 --- a/trace-hash

[PATCH 1/5] trace-cmd: Fix incorrect malloc size arg: *item instead of item

Signed-off-by: Michael Sartain --- trace-dialog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-dialog.c b/trace-dialog.c index b5776cc..87e597a 100644 --- a/trace-dialog.c +++ b/trace-dialog.c @@ -97,7 +97,7 @@ static void push_cursor(GdkCursor *cursor

[PATCH 3/5] trace-cmd: Add ULL suffix to MISSING_EVENTS since ints shouldn't be left shifted by 31

Signed-off-by: Michael Sartain --- kbuffer-parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kbuffer-parse.c b/kbuffer-parse.c index 4e6e95e..dde642c 100644 --- a/kbuffer-parse.c +++ b/kbuffer-parse.c @@ -24,8 +24,8 @@ #include "kbuffer.h"

[PATCH 5/5] trace-cmd: Remove unused view_width variable

Signed-off-by: Michael Sartain --- trace-graph.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/trace-graph.c b/trace-graph.c index 1db342f..2c49549 100644 --- a/trace-graph.c +++ b/trace-graph.c @@ -1263,7 +1263,6 @@ static void draw_info_box(struct graph_info *ginfo, const gchar *buffer

[PATCH 0/5] trace-cmd: Fixes for four small bugs plus minor cleanup

Thanks much. -Mike --- Michael Sartain (5): trace-cmd: Fix incorrect malloc size arg: *item instead of item trace-cmd: Fix NULL pointer being passed to memcpy trace-cmd: Add ULL suffix to MISSING_EVENTS since ints shouldn't be left shifted by 31 trace-cmd: Use unsigned valu

[PATCH 2/5] trace-cmd: Fix NULL pointer being passed to memcpy

Signed-off-by: Michael Sartain --- trace-output.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/trace-output.c b/trace-output.c index bfe6331..84b21b0 100644 --- a/trace-output.c +++ b/trace-output.c @@ -929,7 +929,11 @@ tracecmd_add_option(struct tracecmd_output

[PATCH v2] tracing: Add saved_tgids file to show cached pid to tgid mappings

ed_tgids 1048 1048 1047 1047 7 7 1049 1047 1054 1047 1053 1047 Let userspace apps reading binary buffer know tgid's. [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1434654.html Reviewed-by: Joel Fernandes Signed-off-by: Michael Sartain --- [v2] Don'

Re: [PATCH] tracing: Add saved_tgids file to show cached pid to tgid mappings

On Fri, Jun 30, 2017 at 05:50:57PM -0400, Steven Rostedt wrote: > On Fri, 30 Jun 2017 11:17:50 -0600 > Michael Sartain wrote: > > > Export the cached pid / tgid mappings to userspace. This allows user > > apps to translate the pids from a trace to their respec

[PATCH] tracing: Add saved_tgids file to show cached pid to tgid mappings

1053 1047 [ Impact: let userspace apps reading binary buffer know tgid's ] Signed-off-by: Michael Sartain --- kernel/trace/trace.c | 60 +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trac

Re: [PATCH v3 4/6] Fix read / write data offsets in read / write loops

On Wed, Jun 21, 2017 at 09:29:14AM -0400, Steven Rostedt wrote: > On Wed, 14 Jun 2017 18:27:59 -0600 > Michael Sartain wrote: > > > The tot variable in __do_write and do_read is incremented with the amount > > read > > / written, but subsequent times through the loo

[PATCH v3 2/6] Fix unsigned return values being error checked as negative

types. Signed-off-by: Michael Sartain --- trace-input.c | 179 -- trace-msg.c | 5 +- 2 files changed, 78 insertions(+), 106 deletions(-) diff --git a/trace-input.c b/trace-input.c index e676c85..89ddcf5 100644 --- a/trace-input.c +++ b

[PATCH v3 6/6] Fix cases where string literals were passed as string format args

Signed-off-by: Michael Sartain --- trace-capture.c | 12 ++-- trace-dialog.c | 4 ++-- trace-filter.c | 10 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/trace-capture.c b/trace-capture.c index 1acfe44..4e1392e 100644 --- a/trace-capture.c +++ b/trace

[PATCH v3 1/6] Fix bad force_token escape sequence

Signed-off-by: Michael Sartain --- event-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/event-parse.c b/event-parse.c index 3217131..61f48c1 100644 --- a/event-parse.c +++ b/event-parse.c @@ -1093,7 +1093,7 @@ static enum event_type __read_token(char **tok

[PATCH v3 4/6] Fix read / write data offsets in read / write loops

The tot variable in __do_write and do_read is incremented with the amount read / written, but subsequent times through the loop the calls continue to use the original data pointer. Signed-off-by: Michael Sartain --- trace-cmd-local.h | 2 +- trace-input.c | 2 +- 2 files changed, 2

[PATCH v3 3/6] Handle EINTR signal interrupts for read, write, open calls

Read/write/open calls weren't handling EINTR in trace-input.c This patch uses the standard GNU C TEMP_FAILURE_RETRY macro to handle EINTR return values, and updates read/write calls in trace-msg.c to match. Signed-off-by: Michael Sartain --- trace-cmd-local.h | 2 +- trace-input.c

[PATCH v3 5/6] Fix function prototypes for __vwarning, __vpr_stat, and __vdie

They were declared: (const char *fmt, ...) but implemented as: (const char *fmt, va_list ap) Signed-off-by: Michael Sartain --- event-utils.h | 4 ++-- parse-utils.c | 2 ++ trace-local.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/event-utils.h b/event-utils.h

[PATCH v3 0/6] trace-cmd: escape sequence, EINTR, error checking bug fixes

This patch adds fixes to trace-cmd for return value checking, EINTR handling, function prototypes, and data offsets to initial patch escape sequence fix [1]. Thanks much. -Mike v2->v3: Fix attachments (aka learn how to use Mutt) v1->v2: Add five related bug fix patches Michael Sart

[PATCH v2 0/6] trace-cmd: escape sequence, EINTR, error checking bug fixes

This patch adds fixes to trace-cmd for return value checking, EINTR handling, function prototypes, and data offsets to initial patch escape sequence fix [1]. Please holler with any feedback. Thanks much. -Mike v1->v2: Add five related bug fix patches Michael Sartain (6): Fix

[PATCH] trace-cmd: Fix bad force_token escape sequence

Removes extra backslash in format string Signed-off-by: Michael Sartain --- event-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/event-parse.c b/event-parse.c index 3217131..61f48c1 100644 --- a/event-parse.c +++ b/event-parse.c @@ -1093,7 +1093,7 @@ static enum