Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2019-01-12 Thread Michael Niewöhner
Hi again, On Sat, 2019-01-12 at 10:52 +0100, Michael Niewöhner wrote: > Hi Mimi, > > On Fri, 2019-01-11 at 10:40 -0500, Mimi Zohar wrote: > > Hi Michael, > > > > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > > > > > Well, there

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2019-01-12 Thread Michael Niewöhner
Hi Mimi, On Fri, 2019-01-11 at 10:40 -0500, Mimi Zohar wrote: > Hi Michael, > > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > > > Well, there are at least two implementations I know of: > > For my Lenovo X260 I can choose between Infineon TPM 1.2

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-10 Thread Michael Niewöhner
On Thu, 2019-01-10 at 19:28 +0200, Jarkko Sakkinen wrote: > On Fri, Jan 04, 2019 at 04:28:24PM +0100, Michael Niewöhner wrote: > > root@debian:~# tpm2_pcrlist > > ERROR:tcti:src/util/io.c:102:write_all() failed to write to fd 3: Operation > > not > > permitted > &

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-10 Thread Michael Niewöhner
On Thu, 2019-01-10 at 19:19 +0200, Jarkko Sakkinen wrote: > On Thu, Jan 03, 2019 at 04:47:31PM +0100, Michael Niewöhner wrote: > > On Thu, 2019-01-03 at 17:04 +0200, Jarkko Sakkinen wrote: > > > On Thu, Jan 03, 2019 at 02:38:11PM +0100, Michael Niewöhner wrote: > > > &g

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-04 Thread Michael Niewöhner
On Fri, 2019-01-04 at 16:28 +0100, Michael Niewöhner wrote: > On Fri, 2019-01-04 at 12:58 +0100, Michael Niewöhner wrote: > > On Thu, 2019-01-03 at 16:47 +0100, Michael Niewöhner wrote: > > > On Thu, 2019-01-03 at 17:04 +0200, Jarkko Sakkinen wrote: > > > > On Thu, Ja

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-04 Thread Michael Niewöhner
On Fri, 2019-01-04 at 12:58 +0100, Michael Niewöhner wrote: > On Thu, 2019-01-03 at 16:47 +0100, Michael Niewöhner wrote: > > On Thu, 2019-01-03 at 17:04 +0200, Jarkko Sakkinen wrote: > > > On Thu, Jan 03, 2019 at 02:38:11PM +0100, Michael Niewöhner wrote: > > > > On

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-04 Thread Michael Niewöhner
On Thu, 2019-01-03 at 16:47 +0100, Michael Niewöhner wrote: > On Thu, 2019-01-03 at 17:04 +0200, Jarkko Sakkinen wrote: > > On Thu, Jan 03, 2019 at 02:38:11PM +0100, Michael Niewöhner wrote: > > > On Thu, 2019-01-03 at 15:27 +0200, Jarkko Sakkinen wrote: > > > > On S

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-03 Thread Michael Niewöhner
On Thu, 2019-01-03 at 17:04 +0200, Jarkko Sakkinen wrote: > On Thu, Jan 03, 2019 at 02:38:11PM +0100, Michael Niewöhner wrote: > > On Thu, 2019-01-03 at 15:27 +0200, Jarkko Sakkinen wrote: > > > On Sun, Dec 23, 2018 at 12:55:12PM +0100, Michael Niewöhner wrote: > > > >

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-03 Thread Michael Niewöhner
On Thu, 2019-01-03 at 15:41 +0200, Jarkko Sakkinen wrote: > On Sun, Dec 16, 2018 at 02:32:38PM +0100, Michael Niewöhner wrote: > > > dmesg cold boot with tpm_tis.interrupts=0 tpm_tis.force=1: > > -- > &g

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-03 Thread Michael Niewöhner
On Thu, 2019-01-03 at 15:27 +0200, Jarkko Sakkinen wrote: > On Sun, Dec 23, 2018 at 12:55:12PM +0100, Michael Niewöhner wrote: > > There is another issue but I don't know if both are related. Maybe that's > > just a > > timing issue... > > > > root@deb

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-01 Thread Michael Niewöhner
On Tue, 2019-01-01 at 11:38 -0500, Mimi Zohar wrote: > On Tue, 2019-01-01 at 17:15 +0100, Michael Niewöhner wrote: > > On Mon, 2018-12-31 at 16:17 -0500, Mimi Zohar wrote: > > > On Sun, 2018-12-30 at 14:22 +0100, Michael Niewöhner wrote: > > > > > > > >

Re: tpm_tis TPM2.0 not detected on cold boot

2019-01-01 Thread Michael Niewöhner
On Mon, 2018-12-31 at 16:17 -0500, Mimi Zohar wrote: > On Sun, 2018-12-30 at 14:22 +0100, Michael Niewöhner wrote: > > > > difference is that on a cold boot, the TPM takes longer to initialize. > > > > Well, as I said. Waiting for 10, 20 or even 60 seconds in the bo

Re: tpm_tis TPM2.0 not detected on cold boot

2018-12-30 Thread Michael Niewöhner
On Sat, 2018-12-29 at 22:33 -0500, Mimi Zohar wrote: > On Tue, 2018-12-25 at 14:55 +0100, Michael Niewöhner wrote: > > On Sun, 2018-12-23 at 12:55 +0100, Michael Niewöhner wrote: > > > Hi Mimi, > > > > > > On Sat, 2018-12-22 at 17:53 -0500, Mimi Zohar wrote:

Re: tpm_tis TPM2.0 not detected on cold boot

2018-12-25 Thread Michael Niewöhner
On Sun, 2018-12-23 at 12:55 +0100, Michael Niewöhner wrote: > Hi Mimi, > > On Sat, 2018-12-22 at 17:53 -0500, Mimi Zohar wrote: > > On Sat, 2018-12-22 at 14:47 +0100, Michael Niewöhner wrote: > > > > > When I remove the timeout and boot directly to the linux kernel

Re: tpm_tis TPM2.0 not detected on cold boot

2018-12-23 Thread Michael Niewöhner
Hi Mimi, On Sat, 2018-12-22 at 17:53 -0500, Mimi Zohar wrote: > On Sat, 2018-12-22 at 14:47 +0100, Michael Niewöhner wrote: > > > When I remove the timeout and boot directly to the linux kernel, I get that > > "2314 TPM-self test error" since it has not finished,

Re: tpm_tis TPM2.0 not detected on cold boot

2018-12-22 Thread Michael Niewöhner
Hi all, On Sun, 2018-12-16 at 14:32 +0100, Michael Niewöhner wrote: > Hi again, > > after my UEFI firmware mod/hack to flash the newest available Nuvoton firmware > to the NCPT650 the selftest error went away. Since then the TPM worked without > any further problems, at least aft

tpm_tis TPM2.0 not detected on cold boot

2018-12-16 Thread Michael Niewöhner
Hi again, after my UEFI firmware mod/hack to flash the newest available Nuvoton firmware to the NCPT650 the selftest error went away. Since then the TPM worked without any further problems, at least after warm reboots. What I didn't notice before is that it does NOT work after a cold (re)boot. Th

Re: [PATCH] Allow hwrng to initialize crng.

2018-12-15 Thread Michael Niewöhner
On Sat, 2018-12-15 at 18:11 +0100, Michael Niewöhner wrote: > On Thu, 2018-12-13 at 12:50 +0800, Louis Collard wrote: > > On Sun, Nov 18, 2018 at 4:15 AM Michael Niewöhner > > wrote: > > > > > > Hi Louis, > > > > > > On Wed, 2018-09-26 at 11:

Re: [PATCH] Allow hwrng to initialize crng.

2018-12-15 Thread Michael Niewöhner
On Thu, 2018-12-13 at 12:50 +0800, Louis Collard wrote: > On Sun, Nov 18, 2018 at 4:15 AM Michael Niewöhner > wrote: > > > > Hi Louis, > > > > On Wed, 2018-09-26 at 11:24 +0800, Louis Collard wrote: > > > Some systems, for example embedded systems, do no

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-26 Thread Michael Niewöhner
Hi again, after some experiments I finally found a solution... There seems to be a bug in TPM2.0 firmware version (1.3.1.0) included in Lenovos UEFI image but they do not provide an update. I have extracted the firmware version 1.3.2.8 from Dell's XPS15 TPM2.0 firmware update and used this to rep

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-25 Thread Michael Niewöhner
Hi, On Mon, 2018-11-19 at 15:49 +0200, Jarkko Sakkinen wrote: > On Sun, Nov 18, 2018 at 03:10:06PM +0100, Michael Niewöhner wrote: > > On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > > > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > &

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-18 Thread Michael Niewöhner
On Sun, 2018-11-18 at 10:18 +0200, Jarkko Sakkinen wrote: > On Fri, Nov 16, 2018 at 10:06:28PM +0100, Michael Niewöhner wrote: > > On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > > > Hi all, > > > > > > I tried that patch mentioned by Mimi

Re: [PATCH] Allow hwrng to initialize crng.

2018-11-17 Thread Michael Niewöhner
Hi Louis, On Wed, 2018-09-26 at 11:24 +0800, Louis Collard wrote: > Some systems, for example embedded systems, do not generate > enough entropy on boot through interrupts, and boot may be blocked for > several minutes waiting for a call to getrandom to complete. > > Currently, random data is rea

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-16 Thread Michael Niewöhner
On Wed, 2018-11-14 at 21:46 +0100, Michael Niewöhner wrote: > Hi all, > > I tried that patch mentioned by Mimi but it does not change anything for me. > > Then I did some more tests with different kernel configs and finally got TPM > working by > a) compiling TPM as modules

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-14 Thread Michael Niewöhner
Hi all, I tried that patch mentioned by Mimi but it does not change anything for me. Then I did some more tests with different kernel configs and finally got TPM working by a) compiling TPM as modules and rmmod tpm* and re-modprobe tpm_tis. (initramfs) dmesg | grep -i tpm [0.00] efi: AC

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 21:34 +0100, Michael Niewöhner wrote: > On Sun, 2018-11-11 at 12:29 -0800, James Bottomley wrote: > > On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > > > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > > > > [...] &

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 12:29 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 21:09 +0100, Michael Niewöhner wrote: > > On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > > [...] > > > Well, I still think the ACPI setup is incorrect. What's in > &g

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > [...] > > > However, this makes me wonder about yours: > > > > > > > [0.003517] ACPI: TPM2 0x9E490ED8 34 (v03 LENOVO &g

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi Mimi, On Sun, 2018-11-11 at 13:33 -0500, Mimi Zohar wrote: > On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > > Hi all, > > > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton > > while it works in TPM 1.2 mode (I ca

Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi James, On Sun, 2018-11-11 at 10:24 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 18:55 +0100, Michael Niewöhner wrote: > > Hi all, > > > > Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / > > tpm_i2c_nuvoton while it works in TPM 1.2 mode (I

[BUG] Nuvoton NCPT650 TPM 2.0 mode not working

2018-11-11 Thread Michael Niewöhner
Hi all, Nuvoton NCPT650 does not work in TPM 2.0 mode with tpm_tis / tpm_i2c_nuvoton while it works in TPM 1.2 mode (I can reflash it via UEFI setup). Kernel version is 4.19.1 Kernel config: $ cat .config | egrep 'TCG|TPM|CRB|_TIS' CONFIG_TCG_TPM=y CONFIG_HW_RANDOM_TPM=y CONFIG_TCG_TIS_CORE=y CO

Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-10-18 Thread Michael Niewöhner
Hi, On Mon, 2016-10-17 at 15:21 +0530, Vivek Gautam wrote: > > On 10/17/2016 01:38 PM, Felipe Balbi wrote: > > Hi, > > > > Michael Niewöhner writes: > > > Hi Felipe, > > > On Fri, 2016-10-07 at 22:26 +0200, Michael Niewöhner wrote: > > > >

Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-10-16 Thread Michael Niewöhner
Hi Felipe, On Fri, 2016-10-07 at 22:26 +0200, Michael Niewöhner wrote: > Hi Felipe, > > On Fr, 2016-10-07 at 10:42 +0300, Felipe Balbi wrote: > > Hi, > > > > Michael Niewöhner writes: > > > > > > > > > > > The clocks are same acro

Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-10-07 Thread Michael Niewöhner
Hi Felipe, On Fr, 2016-10-07 at 10:42 +0300, Felipe Balbi wrote: > Hi, > > Michael Niewöhner writes: > > > > > > > > The clocks are same across working/non-working. > > > Is it possible to bisect the commit that's causing hang for 4.8x ? > >

Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-10-06 Thread Michael Niewöhner
Hi Vivek, On Di, 2016-10-04 at 17:32 +0530, Vivek Gautam wrote: > Hi Michael, > > > On Tue, Oct 4, 2016 at 4:28 PM, Michael Niewöhner > wrote: > > > > > > > > > > > > > > > > > > > > > > > > >

Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-10-03 Thread Michael Niewöhner
Hi, On Di, 2016-09-20 at 23:12 +0200, Michael Niewöhner wrote: > > > Hi guys, > > > > > > > > > > > > > Hi All > > >   > > > Adding Vivek Gautam. > > >   > &g

Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-09-20 Thread Michael Niewöhner
Hi guys, On Di, 2016-08-30 at 10:32 +0530, Anand Moon wrote: > Hi All > > Adding Vivek Gautam. > > On 29 August 2016 at 16:35, Michael Niewöhner > wrote: > > > > Hi Mathias, > > On Mo, 2016-08-29 at 13:59 +0300, Mathias Nyman wrote: > > >

Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-08-29 Thread Michael Niewöhner
Hi Mathias, On Mo, 2016-08-29 at 13:59 +0300, Mathias Nyman wrote: > On 29.08.2016 10:28, Felipe Balbi wrote: > > > > > > Hi, > > > > Michael Niewöhner writes: > > > > > > [1.] One line summary of the problem: > > > DWC3 USB 3.

PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

2016-08-28 Thread Michael Niewöhner
[1.] One line summary of the problem: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422 [2.] Full description of the problem/report: No usb 3.0 devices are being detected when attached while USB 2.0 devices work on the same port. USB 3.0 works after applying patches [9.1] and [9.2], but see

Re: [PATCH 1/2] regulator: act8865: add restart handler for act8846

2015-05-14 Thread Michael Niewöhner
I reworked the patch and here it is ;-) The act8846 provides means to reset the system when used as main pmic. This patch adds a restart handler for power cycling the regulator thus resetting the board / soc when system-power-controller in dts is set. This can be useful for example if there is no

Re: [PATCH 1/2] regulator: act8865: add restart handler for act8846

2015-05-12 Thread Michael Niewöhner
Hi Heiko, thanks, I’ll rework the patch and the description on Thursday ;-) Am 12.05.2015 um 22:22 schrieb Heiko Stuebner : > Hi Michael, > > Am Montag, 11. Mai 2015, 22:54:11 schrieb Michael Niewöhner: >> Rebooting radxa rock which uses act8846 results in kernel pa

Re: [PATCH 2/2] ARM: dts: rockchip: add system-power-controller toact8846

2015-05-12 Thread Michael Niewöhner
I agree on relicensing to gpl2/x11. Michael > Am 11.05.2015 um 23:58 schrieb Heiko Stuebner : > > Am Montag, 11. Mai 2015, 22:57:21 schrieb Michael Niewöhner: >> Add system-power-controller to act8846 in rk3188-radxarock.dts in addition >> to the act8846 patch fixing th

[PATCH 2/2] ARM: dts: rockchip: add system-power-controller to act8846

2015-05-11 Thread Michael Niewöhner
Add system-power-controller to act8846 in rk3188-radxarock.dts in addition to the act8846 patch fixing the reboot kernel panic Signed-off-by: Michael Niewoehner --- arch/arm/boot/dts/rk3188-radxarock.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts

[PATCH 1/2] regulator: act8865: add restart handler for act8846

2015-05-11 Thread Michael Niewöhner
Rebooting radxa rock which uses act8846 results in kernel panic because the bootloader doesn't readjust frequency or voltage for cpu correctly. This workaround power cycles the act8846 at restart to reset the board. Signed-off-by: Michael Niewoehner --- drivers/regulator/act8865-regulator.c | 43