[PATCH] rseq/selftests: fix name clash with rseq UAPI header

2025-04-05 Thread Michael Jeanson
c967d3c ("rseq/selftests: Ensure the rseq ABI TLS is actually 1024 bytes") Reported-by: Mark Brown Signed-off-by: Michael Jeanson Reviewed-by: Mathieu Desnoyers --- tools/testing/selftests/rseq/rseq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testin

Re: [PATCH] rseq/selftests: ensure the rseq abi TLS is actually 1024 bytes

2025-03-18 Thread Michael Jeanson
On 2025-03-18 10:01, Mark Brown wrote: On Tue, Mar 11, 2025 at 03:21:45PM -0400, Michael Jeanson wrote: Adding the aligned(1024) attribute to the definition of __rseq_abi did not increase its size to 1024, for this attribute to impact the size of __rseq_abi it would need to be added to the

[PATCH] rseq/selftests: ensure the rseq abi TLS is actually 1024 bytes

2025-03-11 Thread Michael Jeanson
to ensure registration will succeed with future extended ABI. Use a union with a dummy member to ensure we allocate 1024 bytes. Signed-off-by: Michael Jeanson Reviewed-by: Mathieu Desnoyers --- tools/testing/selftests/rseq/rseq.c | 21 - 1 file changed, 16 insertions(+), 5 deletion

Re: [RFC PATCH 0/6] [RFC] Faultable tracepoints (v2)

2021-02-24 Thread Michael Jeanson
[ Adding Mathieu Desnoyers in CC ] On 2021-02-23 21 h 16, Steven Rostedt wrote: On Thu, 18 Feb 2021 17:21:19 -0500 Michael Jeanson wrote: This series only implements the tracepoint infrastructure required to allow tracers to handle page faults. Modifying each tracer to handle those page

[RFC PATCH 5/6] tracing: convert sys_enter/exit to faultable tracepoints

2021-02-18 Thread Michael Jeanson
Convert the definition of the system call enter/exit tracepoints to faultable tracepoints now that all upstream tracers handle it. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc: Alexei

[RFC PATCH 6/6] tracing: use Tasks Trace RCU instead of SRCU for rcuidle tracepoints

2021-02-18 Thread Michael Jeanson
all places where tracing is prohibited. Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin

[RFC PATCH 2/6] tracing: ftrace: add support for faultable tracepoints

2021-02-18 Thread Michael Jeanson
code. This change does not yet allow ftrace to take page faults per se within its probe, but allows its existing probes to connect to faultable tracepoints. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter

[RFC PATCH 4/6] tracing: perf: add support for faultable tracepoints

2021-02-18 Thread Michael Jeanson
. This change does not yet allow perf to take page faults per se within its probe, but allows its existing probes to connect to faultable tracepoints. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra

[RFC PATCH 3/6] tracing: bpf-trace: add support for faultable tracepoints

2021-02-18 Thread Michael Jeanson
change does not yet allow bpf to take page faults per se within its probe, but allows its existing probes to connect to faultable tracepoints. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc

[RFC PATCH 1/6] tracing: introduce faultable tracepoints (v2)

2021-02-18 Thread Michael Jeanson
synchronize read-side marshalling of the registered probes with respect to faultable probes unregistration and teardown. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc

[RFC PATCH 0/6] [RFC] Faultable tracepoints (v2)

2021-02-18 Thread Michael Jeanson
.kernel.org Mathieu Desnoyers (1): tracing: use Tasks Trace RCU instead of SRCU for rcuidle tracepoints Michael Jeanson (5): tracing: introduce faultable tracepoints (v2) tracing: ftrace: add support for faultable tracepoints tracing: bpf-trace: add support for faultable tracepoints

[RFC PATCH 1/6] tracing: introduce sleepable tracepoints

2020-10-23 Thread Michael Jeanson
synchronize read-side marshalling of the registered probes with respect to sleepable probes unregistration and teardown. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc

[RFC PATCH 6/6] tracing: use sched-RCU instead of SRCU for rcuidle tracepoints

2020-10-23 Thread Michael Jeanson
need to ensure RCU is watching. Therefore, simply use sched-RCU like normal tracepoints for rcuidle tracepoints. Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar

[RFC PATCH 5/6] tracing: convert sys_enter/exit to sleepable tracepoints

2020-10-23 Thread Michael Jeanson
Convert the definition of the system call enter/exit tracepoints to sleepable tracepoints now that all upstream tracers handle it. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc: Alexei

[RFC PATCH 3/6] tracing: bpf-trace: add support for sleepable tracepoints

2020-10-23 Thread Michael Jeanson
change does not yet allow bpf to take page faults per se within its probe, but allows its existing probes to connect to sleepable tracepoints. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra Cc

[RFC PATCH 0/6] Sleepable tracepoints

2020-10-23 Thread Michael Jeanson
SRCU for rcuidle tracepoints Michael Jeanson (5): tracing: introduce sleepable tracepoints tracing: ftrace: add support for sleepable tracepoints tracing: bpf-trace: add support for sleepable tracepoints tracing: perf: add support for sleepable tracepoints tracing: convert sys_enter/exit to

[RFC PATCH 4/6] tracing: perf: add support for sleepable tracepoints

2020-10-23 Thread Michael Jeanson
. This change does not yet allow perf to take page faults per se within its probe, but allows its existing probes to connect to sleepable tracepoints. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter Zijlstra

[RFC PATCH 2/6] tracing: ftrace: add support for sleepable tracepoints

2020-10-23 Thread Michael Jeanson
code. This change does not yet allow ftrace to take page faults per se within its probe, but allows its existing probes to connect to sleepable tracepoints. Co-developed-by: Mathieu Desnoyers Signed-off-by: Mathieu Desnoyers Signed-off-by: Michael Jeanson Cc: Steven Rostedt (VMware) Cc: Peter

Re: [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes

2020-09-23 Thread Michael Jeanson
On 2020-09-23 14 h 46, David Ahern wrote: On 9/23/20 11:03 AM, Michael Jeanson wrote: On 2020-09-23 12 h 04, Michael Jeanson wrote: It should work without asymmetric routing; adding the return route to the second vrf as I mentioned above fixes the FRAG_NEEDED problem. It should work for TTL as

Re: [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes

2020-09-23 Thread Michael Jeanson
On 2020-09-23 12 h 04, Michael Jeanson wrote: It should work without asymmetric routing; adding the return route to the second vrf as I mentioned above fixes the FRAG_NEEDED problem. It should work for TTL as well. Adding a second pass on the tests with the return through r2 is fine, but add a

Re: [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes

2020-09-23 Thread Michael Jeanson
On 2020-09-22 21 h 59, David Ahern wrote: On 9/22/20 7:52 AM, Michael Jeanson wrote: the test setup is bad. You have r1 dropping the MTU in VRF red, but not telling VRF red how to send back the ICMP. e.g., for IPv4 add: ip -netns r1 ro add vrf red 172.16.1.0/24 dev blue do the same for

Re: [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes

2020-09-22 Thread Michael Jeanson
- On 21 Sep, 2020, at 15:33, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Sep 21, 2020, at 3:11 PM, David Ahern dsah...@gmail.com wrote: > >> On 9/21/20 12:44 PM, Mathieu Desnoyers wrote: >>> - On Sep 21, 2020, at 2:36 PM, David Ahern dsah...@gmail.com wrote: >>> >

Re: [PATCH 1/3] selftests: Add VRF icmp error route lookup test

2020-08-14 Thread Michael Jeanson
- On 13 Aug, 2020, at 19:13, David Ahern dsah...@gmail.com wrote: ... >> +ipv6_ping() >> +{ >> +log_section "IPv6: VRF ICMP error route lookup ping" >> + >> +setup >> + >> +# verify connectivity >> +if ! check_connectivity6; then >> +echo "Error: Basic connectivity

[PATCH] selftests: Add VRF icmp error route lookup test

2020-08-06 Thread Michael Jeanson
check that a ttl expired error is received. [This may be flaky, I'm open to suggestions of a more robust approch.] The second test runs traceroute from h1 to h2 and parses the output to check for a hop on r1. Signed-off-by: Michael Jeanson Cc: David Ahern Cc: David S. Miller Cc