On 29.08.2018 10:55, Linus Walleij wrote:
On Mon, Aug 13, 2018 at 3:53 PM wrote:
From: Michael Hennerich
This fixes:
[BUG] gpio: gpio-adp5588: A possible sleep-in-atomic-context bug
in adp5588_gpio_write()
[BUG] gpio: gpio-adp5588: A possible sleep-in-atomic
On 11.08.2018 04:03, Jia-Ju Bai wrote:
The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.16 are:
[FUNC] mutex_lock_nested
drivers/gpio/gpio-adp5588.c, 113: mutex_lock_nested in
adp5588_gpio_direction_input
drivers/gpio/gpio-adp5588.c, 224: ad
On 18.04.2018 21:25, Hernán Gonzalez wrote:
On Sun, Apr 15, 2018 at 12:31 PM, Jonathan Cameron wrote:
On Fri, 13 Apr 2018 13:36:46 -0300
Hernán Gonzalez wrote:
This allows the driver to be probed and removed as a module powering it
down on remove().
Signed-off-by: Hernán Gonzalez
---
dri
On 17.04.2018 16:32, Peter Rosin wrote:
Use the new probe style for i2c drivers.
Signed-off-by: Peter Rosin
Thanks Peter,
Don't know why i2c needs a new probe style to save one function parameter...
But this patch looks otherwise good to me.
Acked-by: Michael Hennerich
---
driver
On 26.01.2018 15:55, Aishwarya Pant wrote:
Add documentation for sysfs interface of adp8860 series backlight
devices by reading through code and git commits.
Signed-off-by: Aishwarya Pant
Acked-by: Michael Hennerich
---
.../ABI/testing/sysfs-class-backlight-adp8860 | 54
On 26.01.2018 15:54, Aishwarya Pant wrote:
Add documentation for sysfs interface of adp5520/adp5501 analog devices
backlight driver by reading code and looking through git commit logs.
Signed-off-by: Aishwarya Pant
Acked-by: Michael Hennerich
---
.../ABI/testing/sysfs-class-backlight
On 27.01.2018 15:20, SF Markus Elfring wrote:
From: Markus Elfring
Date: Sat, 27 Jan 2018 15:15:52 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Acked-by: Michael
On 14.09.2017 15:50, Stefan Popa wrote:
SPI host drivers can use DMA to transfer data, so the buffer should be properly
allocated.
Keeping it on the stack could cause an undefined behavior.
The dedicated reset function solves this issue.
Signed-off-by: Stefan Popa
Acked-by: Michael
On 07.06.2017 12:57, Daniel Thompson wrote:
On 21/05/17 23:09, Wolfram Sang wrote:
include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.
Signed-off-by: Wolfram Sang
Acked-by: Daniel Thompson
Acked-by: Michael Hennerich
---
arch/blackfin
On 12.04.2017 18:53, Peter Rosin wrote:
On 2017-04-12 10:26, Linus Walleij wrote:
On Tue, Apr 11, 2017 at 2:16 PM, wrote:
From: Michael Hennerich
This patch adds support for the Analog Devices / Linear Technology
LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches.
The LTC4306
On 06.04.2017 22:03, Peter Rosin wrote:
On 2017-04-06 13:31, Michael Hennerich wrote:
On 06.04.2017 10:39, Peter Rosin wrote:
Hi Peter,
again - thanks for your review.
Comments below.
+static const struct regmap_config ltc4306_regmap_config = {
+ .reg_bits = 8,
+ .val_bits = 8
On 10.04.2017 22:04, Linus Walleij wrote:
On Wed, Apr 5, 2017 at 3:07 PM, wrote:
From: Michael Hennerich
This patch adds support for the Analog Devices / Linear Technology
LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches.
The LTC4306 optionally provides two general purpose
for review.
Cheers,
peda
On 2017-04-05 15:07, michael.henner...@analog.com wrote:
From: Michael Hennerich
This patch adds support for the Analog Devices / Linear Technology
LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches.
The LTC4306 optionally provides two general purpose input/output p
On 04.04.2017 11:28, Peter Rosin wrote:
*snip* *snip*
+static int ltc4306_gpio_get(struct gpio_chip *chip, unsigned int offset)
+{
+ struct ltc4306 *data = gpiochip_get_data(chip);
+ int ret = 0;
+
+ if (gpiochip_line_is_open_drain(chip, offset) ||
+ (data->regs[LTC_
On 04.04.2017 14:26, Mark Brown wrote:
On Tue, Apr 04, 2017 at 10:28:23AM +0200, Michael Hennerich wrote:
A question came up, regarding whether it's recommended to mix regmap_i2c and
plain i2c_smbus or direct adapter transfers.
In this specific case for the i2c MUX portion we need to
Hi Mark,
During the discussion here: https://lkml.org/lkml/2017/4/4/76
A question came up, regarding whether it's recommended to mix regmap_i2c
and plain i2c_smbus or direct adapter transfers.
In this specific case for the i2c MUX portion we need to avoid double
locks, and therefore use un-l
From: Michael Hennerich
This patch adds support for the Analog Devices / Linear Technology
LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches.
The LTC4306 optionally provides two general purpose input/output pins
(GPIOs) that can be configured as logic inputs, opendrain outputs or
push
On 03.04.2017 16:20, Peter Rosin wrote:
On 2017-04-03 15:36, Michael Hennerich wrote:
On 03.04.2017 14:03, Peter Rosin wrote:
On 2017-03-31 17:29, Peter Rosin wrote:
Hi!
Sorry for my incremental reviewing...
Another incremental...
On 2017-03-29 12:15, michael.henner...@analog.com wrote
On 03.04.2017 14:03, Peter Rosin wrote:
On 2017-03-31 17:29, Peter Rosin wrote:
Hi!
Sorry for my incremental reviewing...
Another incremental...
On 2017-03-29 12:15, michael.henner...@analog.com wrote:
+
+ /* Now create an adapter for each channel */
+ for (num = 0; num < data
On 23.03.2017 12:05, Lars-Peter Clausen wrote:
Sorry - I missed some of this review feedback ...
+
+static int ltc2497_wait_conv(struct ltc2497_st *st)
+{
+ s64 time_elapsed;
+
+ time_elapsed = ktime_ms_delta(ktime_get(), st->time_prev);
+
+ if (time_elapsed < LTC2497_CONVERSI
On 24.03.2017 09:01, Peter Rosin wrote:
On 2017-03-23 15:22, michael.henner...@analog.com wrote:
From: Michael Hennerich
This patch adds support for the Analog Devices / Linear Technology
LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches.
The LTC4306 optionally provides two general
On 23.03.2017 12:28, Peter Meerwald-Stadler wrote:
On Thu, 23 Mar 2017, michael.henner...@analog.com wrote:
From: Michael Hennerich
comments below
Hi Peter,
Thanks for the review -
comments inline.
Signed-off-by: Michael Hennerich
---
.../devicetree/bindings/iio/adc/ltc2497.txt
not trigger, but was not correct
regardless).
Fixes: 381f688eee3d ("Input: ad7879 - use more devm interfaces")
Signed-off-by: Dmitry Torokhov
Acked-by: Michael Hennerich
---
drivers/input/touchscreen/ad7879-i2c.c | 9 ++---
drivers/input/touchscreen/ad7879-spi.c | 7 +-
On 28.02.2017 23:08, Dmitry Torokhov wrote:
We have switched the driver to use generic device properties API, so there
is no need to check for presence of DT node before trying parse properties.
Signed-off-by: Dmitry Torokhov
Acked-by: Michael Hennerich
---
drivers/input/touchscreen
more devm interfaces")
Signed-off-by: Dmitry Torokhov
Acked-by: Michael Hennerich
---
drivers/input/touchscreen/ad7879-spi.c | 2 --
drivers/input/touchscreen/ad7879.c | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/ad7879-spi.c
b/drivers/in
On 28.02.2017 23:08, Dmitry Torokhov wrote:
Instead of manipulating capabilities bits of input device directly, let's
use input_set_capability() API.
Also, stop setting ABS_X/Y bits explicitly as input_set_abs_params() does
this for us.
Signed-off-by: Dmitry Torokhov
Acked-by: Mi
On 18.02.2017 00:31, Dmitry Torokhov wrote:
Instead of rolling our own infrastructure to provide uniform access to I2C
and SPI buses, let's switch to using regmap.
Signed-off-by: Dmitry Torokhov
---
Michael,
I am a bit (actually a lot) confused how this driver was working with SPI
and Blackfi
On 09.07.2016 00:19, Alexey Khoroshilov wrote:
If adp5520_bl_setup() fails, sysfs group left unremoved.
By the way, fix overcomplicated assignement of error code.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
Acked-by: Michael Hennerich
On 06/02/2016 12:06 PM, Colin King wrote:
From: Colin Ian King
The check on reg is off-by-one, it should be >= rather than >. Fix
this to stop an out-of-bounds write to st->channel_modes[reg].
Signed-off-by: Colin Ian King
Acked-by: Michael Hennerich
---
drivers/iio/dac/ad559
On 05/17/2016 11:58 PM, Heinrich Schuchardt wrote:
If DEBUG is defined, a superfluous closing brace
is introduced.
Signed-off-by: Heinrich Schuchardt
Acked-by: Michael Hennerich
---
drivers/net/ieee802154/adf7242.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net
On 04/07/2016 01:16 PM, Sudip Mukherjee wrote:
If the firmware upload or the firmware verification fails then we
printed the error message and exited but we missed releasing the
firmware.
Signed-off-by: Sudip Mukherjee
Acked-by: Michael Hennerich
---
drivers/net/ieee802154/adf7242.c | 2
On 02/22/2016 03:07 PM, Laxman Dewangan wrote:
Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from error path.
Also remove the need of driver callback .remove.
Signed-off-by: Laxman Dewangan
Acked-by: Michael Hennerich
Cc: Michael Hennerich
On 02/22/2016 03:07 PM, Laxman Dewangan wrote:
Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from remove callback.
Signed-off-by: Laxman Dewangan
Acked-by: Michael Hennerich
Cc: Michael Hennerich
---
drivers/gpio/gpio-adp5588.c | 4
On 11/19/2015 09:22 AM, Michael Hennerich wrote:
On 11/18/2015 05:16 PM, Dan Bogdan Nechita wrote:
Currently writing the attributes with "echo" will result in comparing:
"enabled\n" with "enabled\0" and attribute is always set to false.
Use the sysfs_streq() inst
example, if the
users test if the return value of regulator_set_current_limit() is 0.
Fix it by making ad5398_write_reg() return 0 on success.
Signed-off-by: Axel Lin
Acked-by: Michael Hennerich
---
drivers/regulator/ad5398.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
, the only exception
being GPIO capabilities, which can not be activated through device
tree currently.
Acked-by: Rob Herring
Signed-off-by: Stefan Agner
Acked-by: Michael Hennerich
---
Changes since v2:
- do not free driver data and irq on remove (since we are using devm now)
Changes since v1
the two axis.
Signed-off-by: Stefan Agner
Acked-by: Michael Hennerich
---
Changes since v2:
- (none)
Changes since v1:
- Keep axis swapped by default when using platform data
drivers/input/touchscreen/ad7879.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/
On 01/26/2016 04:04 AM, Stefan Agner wrote:
The measurements read from the controller which are temporary stored
in conversion_data, are interpreted wrong. The first measurement X+
contains the Y position, and the second measurement Y+ the X position
(see also Table 11 Register Table in the data
On 01/26/2016 04:04 AM, Stefan Agner wrote:
Add device tree support for the I2C variant of AD7879 (AD7879-1). This
allows to specify the touchscreen controller as a I2C client node.
Most of the options available as platform data are also available as
device tree properties. Exporting the GPIO is
sage.
Signed-off-by: Arnd Bergmann
Acked-by: Michael Hennerich
Fixes: 6be3a5a9cd91 ("backlight: adp88x0: Fix uninitialized variable use")
---
Sorry for missing this third hunk the first time around.
diff --git a/drivers/video/backlight/adp8860_bl.c
b/drivers/video/backlight/a
e to avoid having to fix every
bug twice.
Signed-off-by: Arnd Bergmann
Acked-by: Michael Hennerich
diff --git a/drivers/video/backlight/adp8860_bl.c
b/drivers/video/backlight/adp8860_bl.c
index 98ffe71e8af2..f0d4c0324580 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/ba
-then-NUL as equivalent string terminations.
Signed-off-by: Dan Bogdan Nechita
Acked-by: Michael Hennerich
---
drivers/misc/ad525x_dpot.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
index 15e8807..4230e6a 100644
--
On 07/17/2015 10:46 AM, Jacek Anaszewski wrote:
From: Andrew Lunn
Now the core implements the work queue, remove it from the driver.
Signed-off-by: Andrew Lunn
Acked-by: Michael Hennerich
Cc: Michael Hennerich
---
drivers/leds/leds-adp5520.c | 22 +++---
1 file
On 10/07/2014 09:30 AM, Pramod Gurav wrote:
This change introduces a label to call cancel_delayed_work_sync in
failure path.
Cc: Michael Hennerich
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
The interrupt triggers the work queue. adp5588_setup() enable
On 02/06/2014 09:17 AM, Jingoo Han wrote:
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han
Acked-by: Michael Hennerich
---
drivers/video/backlight/adp8870_bl.c |4 +---
1 file changed, 1 insertion
: warning: no previous prototype for
‘ad_dpot_add_files’ [-Wmissing-prototypes]
drivers/misc/ad525x_dpot.c:669:13: warning: no previous prototype for
‘ad_dpot_remove_files’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria
Acked-by: Michael Hennerich
---
drivers/misc/ad525x_dpot.c |4
Acked-by: Michael Hennerich
---
drivers/video/backlight/adp8860_bl.c | 2 +-
drivers/video/backlight/adp8870_bl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/adp8860_bl.c
b/drivers/video/backlight/adp8860_bl.c
index 6bb72c0..a77c9ca 100644
: Michael Hennerich
---
drivers/mfd/adp5520.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index 210dd03..6b40e0c 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -36,6 +36,7 @@ struct adp5520_chip
On 10/08/2012 04:09 PM, Wei Yongjun wrote:
From: Wei Yongjun
Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
Acked-by: Michael Hennerich
49 matches
Mail list logo
