Re: [PATCH net-next v3 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-15 Thread Maxime Chevallier
> > On Sat, 12 Jul 2025 18:54:38 +0200 > > Andrew Lunn wrote: > > > > > > +static int nsim_mdio_read(struct mii_bus *bus, int phy_addr, int > > > > reg_num) > > > > +{ > > > > + return 0; > > > > +} > > > > + > > > > +static int nsim_mdio_write(struct mii_bus *bus, int phy_addr, int > >

Re: [PATCH net-next v3 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-14 Thread Maxime Chevallier
On Sat, 12 Jul 2025 18:54:38 +0200 Andrew Lunn wrote: > > +static int nsim_mdio_read(struct mii_bus *bus, int phy_addr, int reg_num) > > +{ > > + return 0; > > +} > > + > > +static int nsim_mdio_write(struct mii_bus *bus, int phy_addr, int reg_num, > > + u16 val) > > +{ > >

Re: [PATCH net-next v3 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-14 Thread Maxime Chevallier
On Fri, 11 Jul 2025 16:55:41 -0700 Jakub Kicinski wrote: > On Thu, 10 Jul 2025 08:22:45 +0200 Maxime Chevallier wrote: > > @@ -1098,6 +1101,10 @@ static int __init nsim_module_init(void) > > { > > int err; > > > > + err = nsim_phy_drv_register(); > &

Re: [PATCH net-next v3 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim

2025-07-14 Thread Maxime Chevallier
Hi Jakub, On Fri, 11 Jul 2025 16:58:13 -0700 Jakub Kicinski wrote: > On Thu, 10 Jul 2025 08:22:47 +0200 Maxime Chevallier wrote: > > +set -o pipefail > > + > > +# Check simple PHY addition and listing > > + > > +# Parent == 0 means that the PHY&#x

[PATCH net-next v3 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim

2025-07-09 Thread Maxime Chevallier
n multiple netdevsim instances - A Filtered DUMP command listing all PHYs on a netdevsim Introduce some helpers to create netdevsim PHYs, and a new test file. Signed-off-by: Maxime Chevallier --- .../selftests/drivers/net/netdevsim/config| 1 + .../drivers/net/netdevsim/ethtool-common

[PATCH net-next v3 2/3] selftests: ethtool: Drop the unused old_netdevs variable

2025-07-09 Thread Maxime Chevallier
old_netdevs is unused in ethtool-common.sh. Only the UDP tunnels test uses that variable, but it maintains it locally. Signed-off-by: Maxime Chevallier --- .../testing/selftests/drivers/net/netdevsim/ethtool-common.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools

[PATCH net-next v3 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-09 Thread Maxime Chevallier
--show-phys ethX". Signed-off-by: Maxime Chevallier --- drivers/net/Kconfig | 1 + drivers/net/netdevsim/Makefile| 4 + drivers/net/netdevsim/dev.c | 2 + drivers/net/netdevsim/netdev.c| 8 + drivers/net/netdevsim/netdevsim.h | 25 ++ dri

[PATCH net-next v3 0/3] netdevsim: add support for PHY devices

2025-07-09 Thread Maxime Chevallier
ck on the shell scripts V1: https://lore.kernel.org/netdev/20250702082806.706973-1-maxime.chevall...@bootlin.com/ Maxime Chevallier (3): net: netdevsim: Add PHY support in netdevsim selftests: ethtool: Drop the unused old_netdevs variable selftests: ethtool: Introduce ethernet PHY selftes

Re: [PATCH net-next v2 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-09 Thread Maxime Chevallier
On Tue, 8 Jul 2025 13:55:28 +0200 Maxime Chevallier wrote: > With the introduction of phy_link_topology, we have the ability to keep > track of PHY devices that sit behind a net_device. While we still can > only attach one single PHY to a netdev, we can look at all these PHYs > thr

Re: [PATCH net-next v2 0/3] netdevsim: add support for PHY devices

2025-07-09 Thread Maxime Chevallier
On Tue, 8 Jul 2025 13:55:53 -0700 Jakub Kicinski wrote: > On Tue, 8 Jul 2025 13:55:27 +0200 Maxime Chevallier wrote: > > Here's a V2 for the netdevsim PHY support, including a bugfix for > > NETDEVSIM=m as well as a round of shellcheck cleanups for > > ethtool-phy.sh.

Re: [PATCH net-next 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-08 Thread Maxime Chevallier
Hi Andrew, On Tue, 8 Jul 2025 16:01:06 +0200 Andrew Lunn wrote: > > +static int nsim_phy_state_link_set(void *data, u64 val) > > +{ > > + struct nsim_phy_device *ns_phy = (struct nsim_phy_device *)data; > > + > > + ns_phy->link = !!val; > > + > > + phy_trigger_machine(ns_phy->phy); > > + >

[PATCH net-next v2 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim

2025-07-08 Thread Maxime Chevallier
n multiple netdevsim instances - A Filtered DUMP command listing all PHYs on a netdevsim Introduce some helpers to create netdevsim PHYs, and a new test file. Signed-off-by: Maxime Chevallier --- I couldn't get rid of some shellcheck messages, mostly becase ethtool-common.sh fails

[PATCH net-next v2 2/3] selftests: ethtool: Drop the unused old_netdevs variable

2025-07-08 Thread Maxime Chevallier
old_netdevs is unused in ethtool-common.sh. Only the UDP tunnels test uses that variable, but it maintains it locally. Signed-off-by: Maxime Chevallier --- .../testing/selftests/drivers/net/netdevsim/ethtool-common.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools

[PATCH net-next v2 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-08 Thread Maxime Chevallier
--show-phys ethX". Signed-off-by: Maxime Chevallier --- drivers/net/netdevsim/Makefile| 4 + drivers/net/netdevsim/dev.c | 2 + drivers/net/netdevsim/netdev.c| 8 + drivers/net/netdevsim/netdevsim.h | 25 ++ drivers/net/netdevsim/phy.c | 398

[PATCH net-next v2 0/3] netdevsim: add support for PHY devices

2025-07-08 Thread Maxime Chevallier
an be extended in the future for phylib testing as well. V1: https://lore.kernel.org/netdev/20250702082806.706973-1-maxime.chevall...@bootlin.com/ Maxime Chevallier (3): net: netdevsim: Add PHY support in netdevsim selftests: ethtool: Drop the unused old_netdevs variable selftests: et

Re: [PATCH net-next 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim

2025-07-04 Thread Maxime Chevallier
On Fri, 4 Jul 2025 14:20:19 +0100 Simon Horman wrote: > On Wed, Jul 02, 2025 at 10:28:05AM +0200, Maxime Chevallier wrote: > > Now that netdevsim supports PHY device simulation, we can start writing > > some tests to cover a little bit all PHY-related ethtool commands. > >

Re: [PATCH net-next 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-04 Thread Maxime Chevallier
Hi Simon, On Fri, 4 Jul 2025 13:43:36 +0100 Simon Horman wrote: > On Wed, Jul 02, 2025 at 10:28:03AM +0200, Maxime Chevallier wrote: > > With the introduction of phy_link_topology, we have the ability to keep > > track of PHY devices that sit behind a net_device. While we sti

[PATCH net-next 0/3] netdevsim: add support for PHY devices

2025-07-02 Thread Maxime Chevallier
ability for the ethtool netlink PHY commands, but this could also potentially be a stepping stone for some basic phylib tests ? Thanks, Maxime Maxime Chevallier (3): net: netdevsim: Add PHY support in netdevsim selftests: ethtool: Drop the unused old_netdevs variable selftests: ethtool: Introdu

[PATCH net-next 1/3] net: netdevsim: Add PHY support in netdevsim

2025-07-02 Thread Maxime Chevallier
--show-phys ethX". Signed-off-by: Maxime Chevallier --- drivers/net/netdevsim/Makefile| 4 + drivers/net/netdevsim/dev.c | 2 + drivers/net/netdevsim/netdev.c| 3 + drivers/net/netdevsim/netdevsim.h | 14 ++ drivers/net/netdevsim/phy.c | 387

[PATCH net-next 2/3] selftests: ethtool: Drop the unused old_netdevs variable

2025-07-02 Thread Maxime Chevallier
old_netdevs is unused in ethtool-common.sh. Only the UDP tunnels test uses that variable, but it maintains it locally. Signed-off-by: Maxime Chevallier --- .../testing/selftests/drivers/net/netdevsim/ethtool-common.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools

[PATCH net-next 3/3] selftests: ethtool: Introduce ethernet PHY selftests on netdevsim

2025-07-02 Thread Maxime Chevallier
n multiple netdevsim instances - A Filtered DUMP command listing all PHYs on a netdevsim Introduce some helpers to create netdevsim PHYs, and a new test file. Signed-off-by: Maxime Chevallier --- .../selftests/drivers/net/netdevsim/config| 1 + .../drivers/net/netdevsim/ethtool-common

Re: [PATCH bpf-next] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-09 Thread Maxime Chevallier
Hi Alexis, On Mon, 09 Sep 2024 22:02:07 +0200 Alexis Lothoré (eBPF Foundation) wrote: > test_xdp_features.sh is a shell script allowing to test that xdp features > advertised by an interface are indeed delivered. The test works by starting > two instance of the same program, both attaching speci

[PATCH v5 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2021-04-01 Thread Maxime Chevallier
implemented with support for PAL and NTSC autodetection. Signed-off-by: Maxime Chevallier --- v1 -> v2: Set the media entity type to decoder, and implement the s_std/g_std ops V2 ->V3 : Fix coding-style issues, and remove the use of the bulk API for regulators. Make the driver select the

[PATCH v5 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix

2021-04-01 Thread Maxime Chevallier
Add prefix for Techwell, Inc. Acked-by: Rob Herring Signed-off-by: Maxime Chevallier --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings

[PATCH v5 0/3] media: i2c: Introduce driver for the TW9900 decoder

2021-04-01 Thread Maxime Chevallier
he notable addition of the querystd ops for standard detection. Any feedback is appreciated, Thanks, Maxime Maxime Chevallier (3): dt-bindings: vendor-prefixes: Add techwell vendor prefix media: dt-bindings: media: i2c: Add bindings for TW9900 media: i2c: Introduce a driver for the Techw

[PATCH v5 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900

2021-04-01 Thread Maxime Chevallier
+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Techwell TW9900 NTSC/PAL/SECAM video decoder + +maintainers: + - Maxime Chevallier + +description: + The tw9900 is a multi-standard video decoder, supporting NTSC, PAL and SECAM + standards with auto-detection features.

Re: [PATCH v4 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2021-03-11 Thread Maxime Chevallier
Hi Hans, and thanks for the review. On Thu, 4 Mar 2021 16:37:53 +0100 Hans Verkuil wrote: >Hi Maxime, > >Some more code review comments: > >> +static int tw9900_set_fmt(struct v4l2_subdev *sd, >> + struct v4l2_subdev_pad_config *cfg, >> + struct v4l2_su

[PATCH v4 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2021-02-19 Thread Maxime Chevallier
The Techwell video decoder supports PAL, NTSC and SECAM input formats, and outputs a BT.656 signal. This commit adds support for this device, with basic support for NTSC and PAL, along with brightness and contrast controls. Signed-off-by: Maxime Chevallier --- v1 -> v2: Set the media ent

[PATCH v4 0/3] media: i2c: Introduce driver for the TW9900 decoder

2021-02-19 Thread Maxime Chevallier
ong with a binding example validation error. Any feedback is appreciated, Thanks, Maxime Maxime Chevallier (3): dt-bindings: vendor-prefixes: Add techwell vendor prefix media: dt-bindings: media: i2c: Add bindings for TW9900 media: i2c: Introduce a driver for the Techwell TW99

[PATCH v4 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900

2021-02-19 Thread Maxime Chevallier
aml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/tw9900.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Techwell TW9900 NTSC/PAL/SECAM video decoder + +maintainers: + - Maxime

[PATCH v4 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix

2021-02-19 Thread Maxime Chevallier
Add prefix for Techwell, Inc. Acked-by: Rob Herring Signed-off-by: Maxime Chevallier --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings

[PATCH net-next v2 2/2] net: mvneta: Implement mqprio support

2021-02-16 Thread Maxime Chevallier
Implement a basic MQPrio support, inserting rules in RX that translate the TC to prio mapping into vlan prio to queues. The TX logic stays the same as when we don't offload the qdisc. Signed-off-by: Maxime Chevallier --- V2 : Fixed the reverse xmas tree, as per Andrew's review.

[PATCH net-next v2 0/2] net: mvneta: implement basic MQPrio support

2021-02-16 Thread Maxime Chevallier
left to be dealt with. The second patch implements the MQPrio offloading for the receive path. Changes in V2 : - Add a Fixes tag for the first patch - Fix some warnings and the xmas tree in the second patch Thanks, Maxime Maxime Chevallier (2): net: mvneta: Remove per-cpu queue mapping for A

[PATCH net-next v2 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-16 Thread Maxime Chevallier
the CPUs in the system, both in the init path and in the cpu_hotplug path. Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 SoC") Signed-off-by: Maxime Chevallier --- V2: Added Fixes tag, as per Pali's review drivers/net/ethernet/marvell/mvneta.c | 9 -

Re: [PATCH net-next 2/2] net: mvneta: Implement mqprio support

2021-02-15 Thread Maxime Chevallier
Hi Andrew, On Sat, 13 Feb 2021 20:45:25 +0100 Andrew Lunn wrote: >On Fri, Feb 12, 2021 at 04:12:20PM +0100, Maxime Chevallier wrote: >> +static void mvneta_setup_rx_prio_map(struct mvneta_port *pp) >> +{ >> +int i; >> +u32 val = 0; > >Hi Maxime >

Re: [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-15 Thread Maxime Chevallier
arking >this commit with Fixes line? E.g.: > >Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 > SoC") Yes you're correct, I'll add that to the V2 ! Thanks for the review, Maxime -- Maxime Chevallier, Bootlin Embedded Linux and kernel engineering https://bootlin.com

[PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-12 Thread Maxime Chevallier
the CPUs in the system, both in the init path and in the cpu_hotplug path. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvneta.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell

[PATCH net-next 2/2] net: mvneta: Implement mqprio support

2021-02-12 Thread Maxime Chevallier
Implement a basic MQPrio support, inserting rules in RX that translate the TC to prio mapping into vlan prio to queues. The TX logic stays the same as when we don't offload the qdisc. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvneta.c | 65 +

[PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support

2021-02-12 Thread Maxime Chevallier
ements the MQPrio offloading for the receive path. Thanks ! Maxime Maxime Chevallier (2): net: mvneta: Remove per-cpu queue mapping for Armada 3700 net: mvneta: Implement mqprio support drivers/net/ethernet/marvell/mvneta.c | 74 ++- 1 file changed, 73 insertions(+),

[PATCH v5 3/3] arm64: dts: rockchip: Add the camera interface description of the PX30

2020-12-29 Thread Maxime Chevallier
The PX30 has a camera interface, supporting CSI2 and BT656 modes. Add a DT description for this interface. Signed-off-by: Maxime Chevallier --- V3 : Renamed the controlled V4: Fixed the clock names v5: No change arch/arm64/boot/dts/rockchip/px30.dtsi | 12 1 file changed, 12

[PATCH v5 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-12-29 Thread Maxime Chevallier
ng" mode of the controller, which is a double-buffering mechanism. Signed-off-by: Maxime Chevallier --- V3: - renamed the driver - Took Hans, Robin and Ezequiel's reviews into account - Implemented the ouble-buffering mode v4: - Took Ezequiel's reviews into account - Reworked

[PATCH v5 1/3] media: dt-bindings: media: Document Rockchip VIP bindings

2020-12-29 Thread Maxime Chevallier
Add a documentation for the Rockchip Camera Interface controller binding. This controller can be found on platforms such as the PX30 or the RK3288, the PX30 being the only platform supported so far. Signed-off-by: Maxime Chevallier --- v3: Renamed the controller to "vip" v4: fixed t

[PATCH v5 0/3] media: rockchip: Introduce driver for Rockchip's camera interface

2020-12-29 Thread Maxime Chevallier
test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Total for rk_vip device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 0 Once again, any review is welcome :) Thanks a lot, Maxime Maxime Chevallier (3): media: dt-bindings: media: Document Rockchip VIP bindings

[PATCH v3 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix

2020-12-22 Thread Maxime Chevallier
Add prefix for Techwell, Inc. Acked-by: Rob Herring Signed-off-by: Maxime Chevallier --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings

[PATCH v3 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2020-12-22 Thread Maxime Chevallier
The Techwell video decoder supports PAL, NTSC and SECAM input formats, and outputs a BT.656 signal. This commit adds support for this device, with basic support for NTSC and PAL, along with brightness and contrast controls. Signed-off-by: Maxime Chevallier --- v1 -> v2: Set the media ent

[PATCH v3 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900

2020-12-22 Thread Maxime Chevallier
OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/tw9900.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Techwell TW9900 NTSC/PAL/SECAM video decoder + +maintainers: + - Maxime Chevallier + +description: + The tw9900 is a multi-standard video

[PATCH v3 0/3] media: i2c: Introduce driver for the TW9900 decoder

2020-12-22 Thread Maxime Chevallier
fixes the example binding. Any feedback is appreciated, Thanks, Maxime Maxime Chevallier (3): dt-bindings: vendor-prefixes: Add techwell vendor prefix media: dt-bindings: media: i2c: Add bindings for TW9900 media: i2c: Introduce a driver for the Techwell TW9900 decoder .../devicetree/bind

[PATCH v4 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-12-08 Thread Maxime Chevallier
ng" mode of the controller, which is a double-buffering mechanism. Signed-off-by: Maxime Chevallier --- V3: - renamed the driver - Took Hans, Robin and Ezequiel's reviews into account - Implemented the ouble-buffering mode v4: - Took Ezequiel's reviews into account - Reworked

[PATCH v4 3/3] arm64: dts: rockchip: Add the camera interface description of the PX30

2020-12-08 Thread Maxime Chevallier
The PX30 has a camera interface, supporting CSI2 and BT656 modes. Add a DT description for this interface. Signed-off-by: Maxime Chevallier --- V3 : Renamed the controlled V4: Fixed the clock names arch/arm64/boot/dts/rockchip/px30.dtsi | 12 1 file changed, 12 insertions

[PATCH v4 1/3] media: dt-bindings: media: Document Rockchip VIP bindings

2020-12-08 Thread Maxime Chevallier
Add a documentation for the Rockchip Camera Interface controller binding. This controller can be found on platforms such as the PX30 or the RK3288, the PX30 being the only platform supported so far. Signed-off-by: Maxime Chevallier --- v3: Renmed the controller to "vip" v4: fixed t

[PATCH v4 0/3] media: rockchip: Introduce driver for Rockchip's camera interface

2020-12-08 Thread Maxime Chevallier
ased on a BSP driver, and I'm not fully familiar with the media and V4L2 frameworks, so I guess some review is still needed. On top of the previous series, this series addresses most of the reviews by Ezequiel (Thanks again), and was tested on a PX30 chip. Maxime Maxime Chevallier (3): media

Re: [PATCH v3 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-11-22 Thread Maxime Chevallier
gt;> + struct vb2_v4l2_buffer *vb_done) >> +{ >> + vb2_set_plane_payload(&vb_done->vb2_buf, 0, >> + stream->pixm.plane_fmt[0].sizeimage); >> + vb_done->vb2_buf.timestamp = ktime_get_ns(); > >

[PATCH v2 0/3] media: i2c: Introduce driver for the TW9900 decoder

2020-11-13 Thread Maxime Chevallier
and changed the media entity type from sensor to decoder following Hans' review. Any feedback is appreciated, Thanks, Maxime Maxime Chevallier (3): dt-bindings: vendor-prefixes: Add techwell vendor prefix media: dt-bindings: media: i2c: Add bindings for TW9900 media: i2c: Introduce a dri

[PATCH v2 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2020-11-13 Thread Maxime Chevallier
The Techwell video decoder supports PAL, NTSC and SECAM input formats, and outputs a BT.656 signal. This commit adds support for this device, with basic support for NTSC and PAL, along with brightness and contrast controls. Signed-off-by: Maxime Chevallier --- v1 -> v2: Set the media ent

[PATCH v2 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900

2020-11-13 Thread Maxime Chevallier
id: http://devicetree.org/schemas/media/i2c/tw9900.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Techwell TW9900 NTSC/PAL/SECAM video decoder + +maintainers: + - Maxime Chevallier + +description: + The tw9900 is a multi-standard video decoder, supporting NTSC, PAL a

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix

2020-11-13 Thread Maxime Chevallier
Add prefix for Techwell, Inc. Acked-by: Rob Herring Signed-off-by: Maxime Chevallier --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings

Re: [PATCH 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2020-10-09 Thread Maxime Chevallier
Hi Hans, On Fri, 25 Sep 2020 14:52:25 +0200 Hans Verkuil wrote: >Hi Maxime, > >Some comments below, this driver needs to be changed: Thanks for the review ! >On 18/09/2020 16:24, Maxime Chevallier wrote: >> The Techwell video decoder supports PAL, NTSC and SECAM input forma

[PATCH v3 1/3] media: dt-bindings: media: Document Rockchip VIP bindings

2020-09-22 Thread Maxime Chevallier
Add a documentation for the Rockchip Camera Interface controller binding. This controller can be found on platforms such as the PX30 or the RK3288, the PX30 being the only platform supported so far. Signed-off-by: Maxime Chevallier --- V3 : - renamed the controller .../bindings/media

[PATCH v3 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-09-22 Thread Maxime Chevallier
ng" mode of the controller, which is a double-buffering mechanism. Signed-off-by: Maxime Chevallier --- V3: - renamed the driver - Took Hans, Robin and Ezequiel's reviews into account - Implemented the ouble-buffering mode drivers/media/platform/Kconfig| 13 + driv

[PATCH v3 3/3] arm64: dts: rockchip: Add the camera interface description of the PX30

2020-09-22 Thread Maxime Chevallier
The PX30 has a camera interface, supporting CSI2 and BT656 modes. Add a DT description for this interface. Signed-off-by: Maxime Chevallier --- V3: Renamed the driver arch/arm64/boot/dts/rockchip/px30.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH v3 0/3] media: rockchip: Introduce driver for Rockchip's camera interface

2020-09-22 Thread Maxime Chevallier
on a BSP driver, and I'm not fully familiar with the media and V4L2 frameworks, so I guess some review is still needed. This new series adds some stability fixes, and introduces the double-buffering frame handling, giving better performances. Thanks to everyone who reviewed the first t

[PATCH 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix

2020-09-18 Thread Maxime Chevallier
Add prefix for Techwell, Inc. Signed-off-by: Maxime Chevallier --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

[PATCH 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2020-09-18 Thread Maxime Chevallier
. Signed-off-by: Maxime Chevallier --- drivers/media/i2c/Kconfig | 9 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/tw9900.c | 671 + 3 files changed, 681 insertions(+) create mode 100644 drivers/media/i2c/tw9900.c diff --git a/drivers/media/i2c/Kconfig

[PATCH 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900

2020-09-18 Thread Maxime Chevallier
w9900.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Techwell TW9900 NTSC/PAL/SECAM video decoder + +maintainers: + - Maxime Chevallier + +description: + The tw9900 is a multi-standard video decoder, supporting NTSC, PAL and SECAM + standards with auto-detection fea

[PATCH 0/3] media: Add support for the Techwell TW9900 video decoder

2020-09-18 Thread Maxime Chevallier
d contrast. Thanks, Maxime Maxime Chevallier (3): dt-bindings: vendor-prefixes: Add techwell vendor prefix media: dt-bindings: media: i2c: Add bindings for TW9900 media: i2c: Introduce a driver for the Techwell TW9900 decoder .../devicetree/bindings/media/i2c/tw9900.yaml | 59 ++ .../devicetre

Re: [PATCH v2 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-07-09 Thread Maxime Chevallier
i, 29 May 2020 at 10:05, Maxime Chevallier > wrote: >> >> Introduce a driver for the camera interface on some Rockchip platforms. >> >> This controller supports CSI2, Parallel and BT656 interfaces, but for >> now only the parallel interface could be tested, hence it&#x

Re: [PATCH 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-05-31 Thread Maxime Chevallier
tainer) > >A quick review below... > >On 03/04/2020 16:21, Maxime Chevallier wrote: >> Introduce a driver for the camera interface on some Rockchip platforms. >> >> This controller supports CSI2, Parallel and BT656 interfaces, but for >> now only the parallel interf

[PATCH v2 0/3] media: rockchip: Introduce driver for the camera interface on PX30

2020-05-29 Thread Maxime Chevallier
rs for more suitable ones - Rebased on 5.7-rc7 Maxime Chevallier (3): media: dt-bindings: media: Document Rockchip CIF bindings media: rockchip: Introduce driver for Rockhip's camera interface arm64: dts: rockchip: Add the camera interface description of the PX30 .../binding

[PATCH v2 3/3] arm64: dts: rockchip: Add the camera interface description of the PX30

2020-05-29 Thread Maxime Chevallier
The PX30 has a camera interface, supporting CSI2, BT656 and Parallel modes. Add a DT description for this interface. Signed-off-by: Maxime Chevallier --- Changes since V1: - Updated the clock and reset names - Reordered the properties to have clocks and resets bundled together arch/arm64

[PATCH v2 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-05-29 Thread Maxime Chevallier
doesn't support cropping nor scaling, and is only designed with one sensor being attached to it a any time. Signed-off-by: Maxime Chevallier --- Changes since V1 : - Convert to the bulk APIs for clocks and resets - remove useless references to priv data - Move around some init functio

[PATCH v2 1/3] media: dt-bindings: media: Document Rockchip CIF bindings

2020-05-29 Thread Maxime Chevallier
Add a documentation for the Rockchip Camera Interface controller binding. This controller can be found on platforms such as the PX30 or the RK3288, the PX30 being the only platform supported so far. Signed-off-by: Maxime Chevallier --- Changes since V1 - Updated the clock and reset names

[PATCH net] net: mvpp2: Don't check for 3 consecutive Idle frames for 10G links

2019-07-19 Thread Maxime Chevallier
PPv2's XLGMAC can wait for 3 idle frames before triggering a link up event. This can cause the link to be stuck low when there's traffic on the interface, so disable this feature. Fixes: 4bb043262878 ("net: mvpp2: phylink support") Signed-off-by: Maxime Chevallier ---

[PATCH net-next 0/2] net: mvpp2: Add classification based on the ETHER flow

2019-07-05 Thread Maxime Chevallier
_FLOW enum value and the relevant classifier flow entries. Thanks, Maxime Maxime Chevallier (2): net: mvpp2: cls: Report an error for unsupported flow types net: mvpp2: cls: Add support for ETHER_FLOW drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 6 ++ 1 file changed, 6 inser

[PATCH net-next 2/2] net: mvpp2: cls: Add support for ETHER_FLOW

2019-07-05 Thread Maxime Chevallier
e corresponding entries in the classifier. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c index 6c088c903

[PATCH net-next 1/2] net: mvpp2: cls: Report an error for unsupported flow types

2019-07-05 Thread Maxime Chevallier
Add a missing check to detect flow types that we don't support, so that user can be informed of this. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls

Re: [PATCH] driver core: platform: Allow using a dedicated dma_mask for platform_device

2019-07-01 Thread Maxime Chevallier
Hi Christoph, On Fri, 28 Jun 2019 08:59:46 -0700 Christoph Hellwig wrote: >I'd much rather bite the bullet and make dev->dma_mask a scalar >instead of a pointer. The pointer causes way to much boiler plate code, >and the semantics are way to subtile. I agree that this the real solution, it jus

[PATCH] driver core: platform: Allow using a dedicated dma_mask for platform_device

2019-06-28 Thread Maxime Chevallier
T. Suggested-by: Russell King Signed-off-by: Maxime Chevallier --- Hi everyone, This patch, if suitable, would require a lot of testing to detect drivers that rely on the streaming mask being the same as the coherent mask. Thanks, Maxime drivers/base/platform.c | 17 + drive

[PATCH net-next v2] net: ethtool: Allow parsing ETHER_FLOW types when using flow_rule

2019-06-27 Thread Maxime Chevallier
vlan tag are also possible, but they are specified using the special FLOW_EXT flag. Signed-off-by: Maxime Chevallier --- V2 : Add src and dst mac address parsing, as suggested by Pablo. net/core/ethtool.c | 24 1 file changed, 24 insertions(+) diff --git a/net/core

Re: [PATCH net-next] net: ethtool: Allow parsing ETHER_FLOW types when using flow_rule

2019-06-26 Thread Maxime Chevallier
Hi Pablo, On Wed, 26 Jun 2019 10:58:46 +0200 Pablo Neira Ayuso wrote: >On Wed, Jun 26, 2019 at 10:44:03AM +0200, Maxime Chevallier wrote: >> When parsing an ethtool_rx_flow_spec, users can specify an ethernet flow >> which could contain matches based on the ethernet header, suc

[PATCH net-next] net: ethtool: Allow parsing ETHER_FLOW types when using flow_rule

2019-06-26 Thread Maxime Chevallier
FLOW_EXT and FLOW_MAC_EXT flags. Signed-off-by: Maxime Chevallier --- net/core/ethtool.c | 12 1 file changed, 12 insertions(+) diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 4d1011b2e24f..01ceba556341 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -2883,6

Re: [PATCH net v2] net: mvpp2: prs: Don't override the sign bit in SRAM parser shift

2019-06-25 Thread Maxime Chevallier
Hello David, On Thu, 20 Jun 2019 11:42:45 +0200 Maxime Chevallier wrote: >The Header Parser allows identifying various fields in the packet >headers, used for various kind of filtering and classification >steps. > >This is a re-entrant process, where the offset in the packet hea

[PATCH net v2] net: mvpp2: prs: Don't override the sign bit in SRAM parser shift

2019-06-20 Thread Maxime Chevallier
rvell Armada 375 network unit") Suggested-by: Alan Winkowski Signed-off-by: Maxime Chevallier --- V2 : Fix a typo in the commit log, reported by Sergei. drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mar

[PATCH net] net: mvpp2: prs: Don't override the sign bit in SRAM parser shift

2019-06-19 Thread Maxime Chevallier
rvell Armada 375 network unit") Suggested-by: Alan Winkowski Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c b/drivers/net/ethernet/mar

Re: [PATCH] net: mvpp2: cls: Add pmap to fs dump

2019-06-18 Thread Maxime Chevallier
Hello Nathan, On Tue, 18 Jun 2019 09:09:10 -0700 Nathan Huckleberry wrote: >There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops' >Added a usage consistent with other fops to dump pmap >to userspace. Thanks for sending a fix. Besides the typo preventing your patch from compiling, you should

[PATCH net-next 4/4] net: mvpp2: cls: Add steering based on vlan Id and priority.

2019-06-18 Thread Maxime Chevallier
e key. This commit adds the vlan priotity as a compatible HEK field for tagged traffic, meaning that we limit the possibility of extracting this field only to the flows that contain tagged traffic. Signed-off-by: Maxime Chevallier --- .../net/ethernet/marvell/mvpp2/mvpp2_cls.c

[PATCH net-next 0/4] net: mvpp2: cls: Allow steering based on vlan tag

2019-06-18 Thread Maxime Chevallier
bytes, such as the vlan tag which is 12 bits wide, or the priority which is 3 bits wide. Finally, patch 4 adds support for steering based on both vlan id and priority, extracted from the outermost tag. Maxime Chevallier (4): net: mvpp2: cls: Use a dedicated lu_type for the RSS lookup net: mvpp2

[PATCH net-next 2/4] net: mvpp2: cls: Only select applicable flows of classification offload

2019-06-18 Thread Maxime Chevallier
we want to insert it into. As an example, classifying on VLAN tag can only be done on flows used for tagged traffic. This commit makes sure we don't insert rules in flows we aren't compatible with. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 3 +

[PATCH net-next 3/4] net: mvpp2: cls: right-justify the C2 TCAM keys

2019-06-18 Thread Maxime Chevallier
s. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c index 7cd9d6da0319..c4c467f5f

[PATCH net-next 1/4] net: mvpp2: cls: Use a dedicated lu_type for the RSS lookup

2019-06-18 Thread Maxime Chevallier
make sure the RSS match doesn't interfere with other classification lookups, hence we use a dedicated lookup_type for it. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 4 ++-- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 5 + 2 files changed, 7

[PATCH net v2] net: ethtool: Allow matching on vlan DEI bit

2019-06-12 Thread Maxime Chevallier
f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator") Reported-by: Michał Mirosław Signed-off-by: Maxime Chevallier --- V1 -> V2: Use "DEI" instead of the old name "CFI", as suggested by Toshiaki. Perform endianness swap on the constan

[PATCH net] net: ethtool: Allow matching on vlan CFI bit

2019-06-11 Thread Maxime Chevallier
_flow_spec to flow_rule structure translator") Reported-by: Michał Mirosław Signed-off-by: Maxime Chevallier --- Hi all, Although this prevents information to be silently discarded when parsing an ethtool_flow_spec, this information doesn't seem to be used by any driver that converts

[PATCH net 2/2] net: mvpp2: prs: Use the correct helpers when removing all VID filters

2019-06-11 Thread Maxime Chevallier
g for VLAN filtering") Suggested-by: Yuri Chipchev Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c b/drivers/net/ethernet/marvell/mvpp2/m

[PATCH net 0/2] net: mvpp2: prs: Fixes for VID filtering

2019-06-11 Thread Maxime Chevallier
cond patch makes so that we don't invalidate the wrong TCAM entries when clearing the whole whitelist. Maxime Chevallier (2): net: mvpp2: prs: Fix parser range for VID filtering net: mvpp2: prs: Use the correct helpers when removing all VID filters .../net/ethernet/marvell/mvpp2/mvpp

[PATCH net 1/2] net: mvpp2: prs: Fix parser range for VID filtering

2019-06-11 Thread Maxime Chevallier
the whitelist from all ports of the same PPv2 instance. Fixes: 56beda3db602 ("net: mvpp2: Add hardware offloading for VLAN filtering") Suggested-by: Yuri Chipchev Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 17 - 1 file

Re: [PATCH net 1/2] net: mvpp2: prs: Fix parser range for VID filtering

2019-06-10 Thread Maxime Chevallier
Hello David, On Mon, 10 Jun 2019 09:23:00 -0700 (PDT) David Miller wrote: >Please start providing proper header postings with each and every patch >series, explaining at a high level what the patch series is doing, how >it is doing it, and why it is doing it that way. Sure, I'll resend with a p

[PATCH net 1/2] net: mvpp2: prs: Fix parser range for VID filtering

2019-06-10 Thread Maxime Chevallier
the whitelist from all ports of the same PPv2 instance. Fixes: 56beda3db602 ("net: mvpp2: Add hardware offloading for VLAN filtering") Suggested-by: Yuri Chipchev Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 17 - 1 file

[PATCH net 2/2] net: mvpp2: prs: Use the correct helpers when removing all VID filters

2019-06-10 Thread Maxime Chevallier
g for VLAN filtering") Suggested-by: Yuri Chipchev Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c b/drivers/net/ethernet/marvell/mvpp2/m

[PATCH net-next 3/3] net: mvpp2: Add support for more ethtool counters

2019-06-10 Thread Maxime Chevallier
Besides the MIB counters, some other useful counters can be exposed to the user. This commit adds support for : - Per-port counters, that indicate FIFO drops and classifier drops, - Per-rxq counters, - Per-txq counters Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2

[PATCH net-next 1/3] net: mvpp2: Only clear the stat counters at port init

2019-06-10 Thread Maxime Chevallier
ch as when reconfiguring the interface mode with the PHY. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/mar

[PATCH net-next 2/3] net: mvpp2: Rename mvpp2_ethtool_counters to mvpp2_ethtool_mib_counters

2019-06-10 Thread Maxime Chevallier
Since we'll be adding support for other kind of internal counters, make clear that the currently supported counters are the MIB counters. Signed-off-by: Maxime Chevallier --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 21 ++- 1 file changed, 11 insertions(+), 10 dele

  1   2   3   >