Re: [PATCH v2 01/14] dt-bindings: remoteproc: Add TI PRUSS bindings

2019-02-15 Thread Matthijs van Duin
ce tree appropriately (typically by having u-boot apply an overlay to the DT), and I don't think anyone views this as unduly burdensome? Matthijs

[PATCH] pty: fix O_CLOEXEC for TIOCGPTPEER

2018-07-19 Thread Matthijs van Duin
It was being ignored because the flags were not passed to fd allocation. Fixes: 54ebbfb16034 ("tty: add TIOCGPTPEER ioctl") Signed-off-by: Matthijs van Duin --- drivers/tty/pty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/pty.c b/drivers/tty/p

Re: [PATCH 3.18 00/39] 3.18.53-stable review

2017-05-11 Thread Matthijs van Duin
On Thu, May 11, 2017 at 02:16:07PM -0700, Guenter Roeck wrote: > arch/arm/mach-omap2/omap-headsmp.S:60: Error: bad instruction `badr > r0,hyp_boot' > > I see "badr" used in later kernels, but not in v3.18. Does this possibly > require some secondary patches ? It was introduced in kernel 4.2 by

Re: [RFC 1/1] drivers: i2c: omap: Add slave support

2016-10-16 Thread Matthijs van Duin
ter-only and slave-only peripherals on the same bus just to avoid the horrible race conditions: https://e2e.ti.com/support/arm/sitara_arm/f/791/p/514961/1990938#1990938 On 14 October 2016 at 10:57, Ravikumar wrote: > > On Monday 29 August 2016 09:13 AM, Matthijs van Duin wrote: >> its

Re: [PATCHv2] of: Add generic handling for ePAPR 1.1 fail-sss states

2016-09-12 Thread Matthijs van Duin
gory are necessarily idled. There's no reason they wouldn't be. The hwmod infrastructure generally tries to access the sysconfig register located in the IP block address space itself. If you try to do that with a peripheral that's efused out you'll get a bus error. Matthijs

Re: L3 error handling (was: Re: [4.8.0-rc1] am335x-evm boot failure: n_tty_receive_buf_common: "Unable to handle kernel paging request..")

2016-09-10 Thread Matthijs van Duin
On Sat, Sep 10, 2016 at 04:46:49PM +0200, Matthijs van Duin wrote: > It probably doesn't help that the L3 interconnect registers on the > am335x aren't documented in the TRM. See below for its list of > components, target IDs, address mapping, and L3 error irq routing &g

L3 error handling (was: Re: [4.8.0-rc1] am335x-evm boot failure: n_tty_receive_buf_common: "Unable to handle kernel paging request..")

2016-09-10 Thread Matthijs van Duin
rfectly innocent process getting killed with a SIGBUS. Needless to say, this is just... wrong. Matthijs

Re: [PATCH] ARM: dts: omap3-gta04: reduce panel backlight PWM frequency to 83Hz

2016-09-10 Thread Matthijs van Duin
to having encountered dimmed LED lighting that was flickering obnoxiously for me while noone else noticed this.) Matthijs

Re: [PATCH] ARM: dts: omap3-gta04: reduce panel backlight PWM frequency to 83Hz

2016-09-09 Thread Matthijs van Duin
match == -2 output on period-1 cycles, off 1 cycle match == -1 output freezes Hope this helps Matthijs

Re: [PATCHv2] of: Add generic handling for ePAPR 1.1 fail-sss states

2016-09-09 Thread Matthijs van Duin
e alternative, by reusing the existing exception mechanism to trap synchronous aborts, but e.g. the Cortex-A15 seems to use async aborts for *every* bus error, which makes things just very awful. Matthijs

Re: [4.8.0-rc1] am335x-evm boot failure: n_tty_receive_buf_common: "Unable to handle kernel paging request.."

2016-09-09 Thread Matthijs van Duin
omap_l3_noc doesn't even support am335x currently. Matthijs

Re: [4.8.0-rc1] am335x-evm boot failure: n_tty_receive_buf_common: "Unable to handle kernel paging request.."

2016-09-09 Thread Matthijs van Duin
to continue after a bus error in a driver (inside local_irq_disable even), but I wouldn't be inclined to take any later errors seriously. See also the "4.8 crash on BeagleBone" thread on linux-omap. Matthijs

Re: [RFC 1/1] drivers: i2c: omap: Add slave support

2016-08-28 Thread Matthijs van Duin
, but this filter is implemented by sampling the bus requiring two consecutive samples to agree. Two small glitches with just the right timing would therefore suffice. Rather unlikely for random noise, but having lots of signals on your pcb that ultimately derive from the same clock source probably makes the odds a lot more favorable. Matthijs

Re: [RFC 1/1] drivers: i2c: omap: Add slave support

2016-08-27 Thread Matthijs van Duin
s (including the completely bizarre behaviour of its innocuous-looking irq registers) would be quite non-trivial to figure out without putting in a similar effort. Matthijs

Re: [RFC 1/1] drivers: i2c: omap: Add slave support

2016-08-27 Thread Matthijs van Duin
tions on using slave mode and details on the peripheral actually behaves: http://e2e.ti.com/support/arm/sitara_arm/f/791/p/514961/1959417#1959417 Matthijs

Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()

2016-08-27 Thread Matthijs van Duin
> [8.842806] OF: ERROR: Bad of_node_put() on /encoder/ports/port@1/endpoint > [8.843014] [] (omapdss_of_find_source_for_first_ep [omapdss]) I can confirm that reverting 2ab9f5879162 fixes this regression, tested on omap5-uevm. Matthijs

Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()

2016-08-27 Thread Matthijs van Duin
reverted, although preferably in its entirety obviously. of_get_next_parent already drops a ref on its argument, so of_node_put was never "missing" here. Matthijs

Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery

2016-08-24 Thread Matthijs van Duin
pull-down current while pin is held high: 40-200 uA 1.8V mode, pull-up current while pin is held low: 60-200 uA 3.3V mode, pull-up current while pin is held low: 10-290 uA Note the worst-case equivalent pull-up resistance in 3.3V mode is 330 kOhm, eleven times higher than in 1.8V mode. Matthijs

Re: [PATCH v2 2/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency

2016-05-04 Thread Matthijs van Duin
On 3 May 2016 at 18:43, Tony Lindgren wrote: > Does a fixed divider calculation of input * (32768 / 27e6) make sense > here too as pointed out earlier by Matthijs for the ti81xx? That was an actual fractional divider, i.e. the output clock would be exactly that ratio of the input clock,

Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask

2015-12-01 Thread Matthijs van Duin
t if you're feeling really enthausiastic about putting in effort to allow inputs to be disabled while staying clear of the erratum, I think you can detect at runtime which I/O supplies are 3.3V by inspecting this register: #define CTRL_CQDETECT_STATUS0x48140e00 Matthijs -- To unsubscrib

Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask

2015-12-01 Thread Matthijs van Duin
t 19 set to correct values after ROM mucked them up, see advisory 2.1.88), so all that needs to be done is avoid touching them. Are the power savings from disabling unnecessary inputs significant enough to spend any headache on it? Matthijs -- To unsubscribe from this list: send the line "u

Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask

2015-12-01 Thread Matthijs van Duin
On 2 December 2015 at 00:38, Tony Lindgren wrote: > - pinctrl-single,function-mask = > <0x300ff>; > + pinctrl-single,function-mask = > <0x707ff>; Reminder that silicon revision 2.1 and older require input enabled (bit 1

Re: [PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx

2015-12-01 Thread Matthijs van Duin
ings there. (More likely it exists as a separate bit to allow it to stay enabled even if the module isn't, for wakeup on debounced inputs.) Matthijs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3] crypto: omap-aes: Add support for GCM mode

2015-09-20 Thread Matthijs van Duin
On 15 September 2015 at 15:28, Lokesh Vutla wrote: > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -293,6 +293,7 @@ config CRYPTO_DEV_OMAP_AES > depends on ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP2PLUS > select CRYPTO_AES > select CRYPTO_BLKCIPHER > +

Re: runtime check for omap-aes bus access permission (was: Re: 3.13-rc3 (commit 7ce93f3) breaks Nokia N900 DT boot)

2015-06-01 Thread Matthijs van Duin
On 1 June 2015 at 22:52, Tony Lindgren wrote: > OK that must be the case I've seen then. Probably that happens > when a device is not clocked. It happens for any interconnect error reported as a result of instruction fetch, but that is itself not a very common occurrence and obviously doesn't app

Re: runtime check for omap-aes bus access permission (was: Re: 3.13-rc3 (commit 7ce93f3) breaks Nokia N900 DT boot)

2015-06-01 Thread Matthijs van Duin
On 1 June 2015 at 19:58, Tony Lindgren wrote: > I think these kernels are missing the configuration for l3-noc > driver? Yup. Since I'm pretty sure I have all the necessary info I was hoping look into that... somewhere in my copious spare time... > I tried it on omap4 that has l3-noc configured,

Re: runtime check for omap-aes bus access permission (was: Re: 3.13-rc3 (commit 7ce93f3) breaks Nokia N900 DT boot)

2015-05-30 Thread Matthijs van Duin
On 29 May 2015 at 17:50, Tony Lindgren wrote: > I believe some TI kernels use strongly-ordered mappings, mainline > kernel does not. Which kernel version are you using? Normally I periodically rebuild based on Robert C Nelson's -bone kernel (but with heavily customized config). I also tried a pla

Re: runtime check for omap-aes bus access permission (was: Re: 3.13-rc3 (commit 7ce93f3) breaks Nokia N900 DT boot)

2015-05-28 Thread Matthijs van Duin
On 29 May 2015 at 02:58, Matthijs van Duin wrote: > It is only guaranteed to happen immediately (before the next > instruction is executed) if the error occurs before the posting-point > of the write. However, in that case the error is reported in-band to > the cpu, resulting in a

Re: runtime check for omap-aes bus access permission (was: Re: 3.13-rc3 (commit 7ce93f3) breaks Nokia N900 DT boot)

2015-05-28 Thread Matthijs van Duin
On 29 May 2015 at 00:24, Tony Lindgren wrote: > Hmm I believe the interrupt happens immediately trying to access an > invalid device. But maybe I'm thinking about just errors if a device > is not powered or clocked. It is only guaranteed to happen immediately (before the next instruction is execu

Re: runtime check for omap-aes bus access permission (was: Re: 3.13-rc3 (commit 7ce93f3) breaks Nokia N900 DT boot)

2015-05-28 Thread Matthijs van Duin
se in this particular case. Also, presumably interconnect error reporting is unavailable on HS devices given the fact that all interconnect registers seemed to be inaccessible? Matthijs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-19 Thread Matthijs van Duin
ollow what the TI tree is doing > in case some other revisions of the hardware use it. Another idea would be to check if it's nonzero and if so, yell loudly in the kernel log that they should mail the linux-omap list ;-) Matthijs -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-16 Thread Matthijs van Duin
some more googling (apparently da850 has SATA -- Primus doesn't). Matthijs On 16 March 2015 at 17:49, Tony Lindgren wrote: > * Matthijs van Duin [150314 14:04]: >> On 13 March 2015 at 20:30, Tony Lindgren wrote: >> > Hmm OK have to check that. It could also be that dm81

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-14 Thread Matthijs van Duin
x/am1xxx with odd final digit, also da830/da828) Matthijs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-13 Thread Matthijs van Duin
Given that the documentation mentions the actual phy used, it may be worth mentioning this also in the driver? i.e. that it's not a "dm816x phy" but a "SR70LX Synopsys USB 2.0 OTG nanoPHY" (in contrast to the dm814x and am335x which use a phy TI made themselves) USB is one of the few subsystems o

Re: [RFC] Does PHY UTMI data width belong to DWC2 or PHY binding?

2013-10-22 Thread Matthijs Kooijman
while the actual 8 or 16 supported by the PHY would make sense as property of a phy. Note sure if this is really useful in practice as well, or if just setting the actual width to use on dwc2 makes more sense... Gr. Matthijs signature.asc Description: Digital signature

Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params

2013-07-11 Thread Matthijs Kooijman
On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote: > From: Julien Delacou > > This fix uses 'value' parameter as it should be instead > of hardcoded -1. Woops! > Signed-off-by: Julien Delacou > Acked-by: Paul Zimmerman Reviewed-by: Matthijs Kooijma

Re: [PATCH] kbuild: Don't assume dts files live in arch/*/boot/dts

2013-05-18 Thread Matthijs Kooijman
Hi Michal, On Wed, May 08, 2013 at 08:50:49AM -0600, Stephen Warren wrote: > On 05/08/2013 04:59 AM, Matthijs Kooijman wrote: > > In commit b40b25ff (kbuild: always run gcc -E on *.dts, remove cmd_dtc_cpp), > > dts building was changed to always use the C preprocessor. This mea

Re: [PATCH] kbuild: Don't assume dts files live in arch/*/boot/dts

2013-05-08 Thread Matthijs Kooijman
Hey Stephen, On Wed, May 08, 2013 at 08:50:49AM -0600, Stephen Warren wrote: > On 05/08/2013 04:59 AM, Matthijs Kooijman wrote: > > ... > > The commit referenced above tried to fix this by passing arch/*/boot/dts > > as an include path to dtc. However, for mips, the .dts file

[PATCH] kbuild: Don't assume dts files live in arch/*/boot/dts

2013-05-08 Thread Matthijs Kooijman
behaviour wrt includes. For most .dts files, this path is just the same as the previous hardcoded arch/*/boot/dts path. This was tested on a mips (rt3052) and an arm (bcm2835) target. Signed-off-by: Matthijs Kooijman --- scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] staging: dwc2: use devm_ioremap_resource()

2013-05-02 Thread Matthijs Kooijman
igned-off-by: Laurent Navet > --- > drivers/staging/dwc2/pci.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Patch looks good, I had a bit-for-bit identical patch in my queue here as well :-) Reviewed-by: Matthijs Kooijman Gr. Matthijs > diff --git a/

[PATCH v4] checkpatch: check block comments outside of net

2013-04-10 Thread Matthijs Kooijman
problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Signed-off-by: Matthijs Kooijman --- v2: change the error message for consistency add a comment v3: allow /** as well v4: allow /*{2,} as well convert to

[PATCH v3] checkpatch: check block comments outside of net

2013-04-10 Thread Matthijs Kooijman
problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Signed-off-by: Matthijs Kooijman --- v2: change the error message for consistency add a comment v3: allow /*{2,} as well convert to CHK I've also al

[PATCH] checkpatch: Don't suggest clean scripts when all related errors are suppressed

2013-04-10 Thread Matthijs Kooijman
rrors were actually emitted as well. Signed-off-by: Matthijs Kooijman --- scripts/checkpatch.pl | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 64021da..532c41b 100755 --- a/scripts/checkpatch.pl +++

[PATCH] checkpatch: Only warn for empty lines before closing braces by themselves

2013-04-10 Thread Matthijs Kooijman
; + +} total: 0 errors, 0 warnings, 1 checks, 9 lines checked Signed-off-by: Matthijs Kooijman --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 532c41b..f962c30 100755 --- a/scripts/checkpatch.pl +

Re: [PATCH] checkpatch: Check block comments outside of net

2013-04-09 Thread Matthijs Kooijman
don't really care about this and thus don't know the answer? :-) > Please make it a --strict (CHK) only test for now. Ok. Gr. Matthijs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

[PATCH] checkpatch: Check block comments outside of net

2013-04-09 Thread Matthijs Kooijman
+ +/** WARNING: block comments put the leading /* on a separate line + +/ total: 0 errors, 5 warnings, 25 lines checked Signed-off-by: Matthijs Kooijman --- Note that this patch rejects /** comments, since those are not mentioned in Codingstyle. They are used in

[PATCH v2] checkpatch: Check block comments outside of net

2013-04-09 Thread Matthijs Kooijman
: block comments put the leading /* on a separate line + +/ total: 0 errors, 5 warnings, 25 lines checked Signed-off-by: Matthijs Kooijman --- scripts/checkpatch.pl | 16 1 file changed, 12 insertions(+), 4 deletions(-) Note that this patch rejects

[PATCH] fix the toshiba_acpi write_lcd return value

2007-01-04 Thread Matthijs van Otterdijk
the write_lcd function in toshiba_acpi returns 0 on success since the big ACPI patch merged in 2.6.20-rc2. It should return count. Signed-off-by: Matthijs van Otterdijk <[EMAIL PROTECTED]> --- drivers/acpi/toshiba_acpi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: Linux 2.6.19

2006-12-02 Thread Matthijs
ix memory hotplug build with NUMA=n > > Yasuyuki Kozakai (6): > [NETFILTER]: ip6_tables: fixed conflicted optname for getsockopt > [IPV6] IP6TUNNEL: Delete all tunnel device when unloading module. > [IPV6] IP6TUNNEL: Add missing nf_reset() on input path. >