Hi,
sorry, just want to bump this a bit - I really do have no idea whom to
ping with this, so please forward me!
Best regards and a nice start into 2017 - the year of linux on the
Desktop!
Matthias
On 29-12-2016 17:58:29, Matthias Beyer wrote:
> Hi,
>
> I experience a weird behavi
issue is new for me because of the
upgrade to Linux kernel 4.9 or whether it is also present in 4.8
kernels!
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
signature.asc
Description: PGP signature
On 06-09-2016 12:00:37, Jes Sorensen wrote:
> Matthias Beyer writes:
> > This patchset fixes some errors and warnings reported by checkpatch.pl.
> >
> > Matthias Beyer (5):
> > drivers: staging: rtl8723au: core: Fix checkpatch.pl errors
> > drivers: staging: r
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index
This patch fixes the "space prohibited between function name and open
parenthesis '('" warning from checkpatch.pl
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 10 +-
1 file changed, 5 insertions(+),
As ether_addr_equal returns a bool, we can simply use the return value
to set the variable.
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
As the if statement breaks/continues the loop, the else block is not
useful and can be omitted.
Signed-off-by: Matthias Beyer
Signed-off-by: Manuel Messner
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff
This patch fixes the ERRORs which are reported from the checkpatch.pl
script for this file.
Signed-off-by: Matthias Beyer
---
drivers/staging/rtl8723au/core/rtw_mlme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
b
This patchset fixes some errors and warnings reported by checkpatch.pl.
Matthias Beyer (5):
drivers: staging: rtl8723au: core: Fix checkpatch.pl errors
drivers: staging: rtl8723au: core: simplify if-break-else
drivers: staging: rtl8723au: core: Refactor pointless branching
drivers
This patch removes the pointless `else if` test.
Signed-off-by: Matthias Beyer
Reported-by: David Binderman
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
b/drivers
Re-sending as
On 01-09-2016 17:54:47, Greg KH wrote:
> There is no patch here :(
8<
As reported by David Binderman, this test is useless as of
if (a < 3) {
/* ... */
} else if (a >= 3) {
/* ... */
}
so this patch removes the second check.
Matth
Pinging here as nobody responded yet.
Maybe this was overlooked.
On 23-08-2016 21:44:16, Matthias Beyer wrote:
> As reported by David Binderman, this test is useless as of
>
> if (a < 3) {
> /* ... */
> } else if (a >= 3) {
> /* ... */
> }
This patch removes the pointless `else if` test.
Signed-off-by: Matthias Beyer
Reported-by: David Binderman
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
b/drivers
As reported by David Binderman, this test is useless as of
if (a < 3) {
/* ... */
} else if (a >= 3) {
/* ... */
}
so this patch removes the second check.
Matthias Beyer (1):
drivers: staging: rtl8723au: hal: Remove pointless test
drivers/staging/rtl8723
Signed-off-by: Matthias Beyer
---
drivers/staging/android/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
index 64d8c87..4ce0ac6 100644
--- a/drivers/staging/android/TODO
+++ b/drivers/staging/android/TODO
@@ -1,5 +1,4 @@
TODO
re, though, whether such a patch would be welcome.
Either way, I propose to remove the TODO note on checkpatch cleanup
with the attached patch.
Matthias Beyer (1):
Remove checkpatch.pl cleanups todo
drivers/staging/android/TODO | 1 -
1 file changed, 1 deletion(-)
--
2.9.1
>
> Yes, stretch_amount2 was not used on Polaris.
>
>
> Patch was Reviewed-by: Rex Zhu
>
>
> Thanks.
>
>
> Best Regards
>
> Rex
>
> ____
> From: Matthias Beyer
> Sent: Friday, July 1, 2016 12:38:49 AM
> To
Signed-off-by: Matthias Beyer
---
drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
index 64ee78f
Hi,
after reading your email, I created this patch.
**Please note all**: I'm getting into kernel dev right now (again), so I don't
even know how to test-compile this patch, let alone testing it.
You're more than welcome to teach me things.
Matthias Beyer (1):
drivers
Reviewed-by: tags, but I would like to apply
them on my kernel source copy first, just to re-check them!
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgpepb1gMwEFg.pgp
Description: PGP signature
:
> This is a patch to the Bcmchar.c file that fixes a space before comma warning
> found by checkpatch.pl.
> Signed-off-by: Jack Wilson
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgp27YGzssRv6.pgp
Description: PGP signature
o contact me directly if you get stuck with it!
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgpCf8pAlQnaS.pgp
Description: PGP signature
Hi Pieter,
as far as I know, this driver was removed from the source tree. Please
update your local copy of the kernel.
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
On 02-12-2014 18:25:49, Pieter Waegeman wrote:
> ---
> d
n Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgpgABAhNBRlO.pgp
Description: PGP signature
guess this some effort... I can barely
remember that one time was on the linuxnewbies ML and one or two times
here.
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgpWjLBXCQcuF.pgp
Description: PGP signature
Reviewed-by: Matthias Beyer
On 15-09-2014 21:16:15, Martin Kelly wrote:
> Cleanup whitespace and comments in Ioctl.h in a few ways:
> - > 80 character cleanup
> - Comment clarification
> - More consistent vertical alignment
>
> Signed-off-by: Martin Kelly
> ---
>
Reviewed-by: Matthias Beyer
On 06-09-2014 01:59:37, Omar Sandoval wrote:
> Fix checkpatch.pl "Alignment should match open parenthesis".
>
> Signed-off-by: Omar Sandoval
> ---
> drivers/staging/bcm/sort.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
Reviewed-by: Matthias Beyer
On 31-08-2014 12:24:50, Anh Le wrote:
> Fixed a C99 comment issue in InterfaceMisc.h.
>
> Signed-off-by: Anh Le
> ---
> drivers/staging/bcm/InterfaceMisc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/sta
ackets from
> + * different queues, if free descriptors are available on target.
> + * @Adapter: Pointer to the Adapter structure.
> + *
> + * Returns: None.
> + */
> VOID transmit_packets(struct bcm_mini_adapter *Adapter)
> {
> UINT uiPrevTotalCount = 0;
> --
> 1.9.1
>
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Reviewed-by: Matthias Beyer
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgpzQHbl7gRA5.pgp
Description: PGP signature
ed = 0;
> PUCHAR pcBuffer = (PUCHAR)pBuffer; /* char
> pointer to take care of odd byte cases. */
> +
> uiNumBytes -= (EEPROM_CALPARAM_START -
> uiOffset);
> ulBytesTobeSkipped += (EEPROM_CALPARAM_START -
> uiOffset);
> uiOffset += (EEPROM_CALPARAM_START - uiOffset);
> @@ -2455,6 +2459,7 @@ static int BcmGetFlashCSInfo(struct bcm_mini_adapter
> *Adapter)
> #endif
>
> unsigned int uiFlashLayoutMajorVersion;
> +
> Adapter->uiFlashLayoutMinorVersion = 0;
> Adapter->uiFlashLayoutMajorVersion = 0;
> Adapter->ulFlashControlSectionStart = FLASH_CS_INFO_START_ADDR;
> @@ -4319,6 +4324,7 @@ static int ReadISOSignature(struct bcm_mini_adapter
> *Adapter, enum bcm_flash2x_s
> static int ReadISOPriority(struct bcm_mini_adapter *Adapter, enum
> bcm_flash2x_section_val iso)
> {
> unsigned int ISOPri = STATUS_FAILURE;
> +
> if (IsSectionWritable(Adapter, iso)) {
> if (ReadISOSignature(Adapter, iso) == ISO_IMAGE_MAGIC_NUMBER) {
> BcmFlash2xBulkRead(Adapter,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Looks good.
Reviewed-by: Matthias Beyer
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgpCIJ6zN6ZXV.pgp
Description: PGP signature
Hi,
I want to add that my suspend is broken too. And I don't know if this has
any to do with the reported issues.
On 29-03-2014 12:15:35, Matthias Beyer wrote:
> Hi,
>
> I got this error with 3.13.7, which I just installed:
>
> ---
>
> Mär 29 11:53:05 fu kernel: BU
nd trace
> 9ee5bcb02f264a08 ]---
>
> The bug does not seem to hurt things much but...
>
> TIA
> Ed Tomlinson
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
pgpswSg4OOQWM.pgp
Description: PGP signature
Hi,
Greg-KHs email bot tells me to send this message to a ML. It suggests
to send it to this list or kernelnewb...@nl.linux.org, but the latter
results in a failure notice. So I send this email to this list.
On 03-12-2013 16:16:42, Matthias Beyer wrote:
> Hi,
>
> First: I'm rea
Replaced spaces by tabs for proc_reapurbnonblock() function.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 71dc5d7..6a2e567 100644
--- a
Replaced spaces by tabs for proc_control_compat() function.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 6a2e567..d15aa51 100644
To fit the 80-cols convention, this patch moves the arguments (the
second and third one) for driver->unlocked_ioctl() onto a new line.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/devio.
Reindented the switch-block.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 56
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index dd8701b..9761a27 100644
--- a
, which
needs a reindent after adding the braces.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index d15aa51..dd8701b 100644
--- a/drivers/usb/core/devio.c
ve not to apply 5/6 and 6/6 from the origin patch series
(I would be confused if it still works)!
Btw: If you are stressed out by me sending coding style fixes, I wouldn't take
it wrong if you would redirect me to a submaintainer or so!
Best regards!
Matthias Beyer (5):
drivers: usb: core
Added braces around switch statement as the styleguide tells us.
Indented the switch-block for it and split a function call
(driver->unlocked_ioctl() on line 1876) arguments to several lines to
fit the 80-column convention.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c |
Whitespace fixes, including:
- Whitespace after if-keyword
- Spaces to Tabs
Other coding style fixes:
- Added braces for if-else blocks where missing
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 40 +---
1 file changed, 21 insertions(+), 19
Whitespace fixes, including:
- Whitespace after if-keyword
- Spaces to Tabs
Other coding style fixes:
- Added braces for if-else blocks where missing
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 39 ---
1 file changed, 20 insertions(+), 19
Signed-off-by: Matthias Beyer
---
drivers/usb/core/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/file.c b/drivers/usb/core/file.c
index 903c7ef..3bdfbf8 100644
--- a/drivers/usb/core/file.c
+++ b/drivers/usb/core/file.c
@@ -27,7 +27,7 @@
static
Added braces around switch statement as the styleguide tells us.
Indented the switch-block for it and split a function call
(driver->unlocked_ioctl() on line 1876) arguments to several lines to
fit the 80-column convention.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c |
moved else keyword of if-else construct to closing braces.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/devio.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 215d882..adbdea3 100644
--- a/drivers/usb
Signed-off-by: Matthias Beyer
---
drivers/usb/core/hub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index e5fdf4b..5e9fc21 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -2488,7 +2488,7
not fix all ERROR messages from the scripts/checkpatch.pl script, as
I don't know what to do with "do not use assignments in if-condition" messages.
Matthias Beyer (6):
drivers: usb: core: {file,hub,sysfs,usb}.c: Whitespace fixes
drivers: usb: core: file.c: moved asterisk t
including:
- removing of trailing whitespace
- removing spaces before array indexing (foo [] to foo[])
- reindention of a switch-case block
- spaces to tabs
Signed-off-by: Matthias Beyer
---
drivers/usb/core/file.c | 6 +--
drivers/usb/core/hub.c | 111
de effects!
Suggested by j...@perches.com
Signed-off-by: Matthias Beyer
---
drivers/usb/core/hcd.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index bbd182a..e9e1b33 100644
--- a/drivers/usb/core/hcd.c
+++ b/driver
ithout
errors. Checkpatch script gives me some warnings, which are remaining warnings
of the file, I didn't introduce them!
Best regards!
Matthias Beyer (5):
drivers: usb: core: hcd: moved asterix to variable
drivers: usb: core: hcd: Whitespace fixes
drivers: usb: core: hcd: replaced C99 //
Signed-off-by: Matthias Beyer
---
drivers/usb/core/hcd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 3a2667c..5d13d6c 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1120,18 +1120,18
instead of type
Signed-off-by: Matthias Beyer
---
drivers/usb/core/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index d6a8d23..9036794 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2818,7 +2818,7
including
- spaces to tabs
- removing spaces before array indexing (foo [] to foo[])
- adding spaces around unary operator (foo? 1 : 0 to foo ? 1 : 0)
- removed trailing whitespace
Signed-off-by: Matthias Beyer
---
drivers/usb/core/hcd.c | 56
Put else keyword on same line as closing brace from if statement, added
{ } braces as the styleguide says.
Signed-off-by: Matthias Beyer
---
drivers/usb/core/hcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index
Signed-off-by: Matthias Beyer
---
drivers/usb/core/hcd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 0f3e5a0..3a2667c 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -428,7 +428,7
55 matches
Mail list logo
