Re: [PATCH v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE

* Ian Abbott [2017-11-20 10:46:36 +]: On 20/11/17 10:29, Ian Abbott wrote: On 20/11/17 07:50, Jesse Chan wrote: This change resolves a new compile-time warning when built as a loadable module: WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi/drivers/ni_atmio.o see i

[PATCH] staging: comedi: ni_atmio: fix license warning.

() in drivers/staging/comedi//drivers/ni_atmio.o see include/linux/module.h for more information. No longer present after change. Signed-off-by: Matthew Giassa --- drivers/staging/comedi/drivers/ni_atmio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_atmio

Re: [PATCH] staging: wlan-ng: resolve sparse endianness error.

* Greg KH [2017-11-03 12:49:46 +0100]: On Tue, Oct 24, 2017 at 11:06:18PM -0700, Matthew Giassa wrote: Adding le16_to_cpu conversion in prism2sta.c, to resolve outstanding sparse errors as noted in the current TODO in staging-next. Original error: CHECK drivers/staging//wlan-ng

[PATCH] staging: wlan-ng: resolve sparse endianness error.

types) drivers/staging//wlan-ng/prism2sta.c:1450:29:expected unsigned short [unsigned] [usertype] link_status_new drivers/staging//wlan-ng/prism2sta.c:1450:29:got restricted __le16 [usertype] linkstatus Sparse error no longer present after change. Signed-off-by: Matthew Giassa --- drivers

Re: [PATCH] staging: irda: resolve sparse errors due to implicit pci_power_t casts

* Greg KH [2017-10-18 16:12:16 +0200]: On Thu, Oct 05, 2017 at 04:38:23PM -0700, Matthew Giassa wrote: Explicitly casting pci_power_t types to resolve sparse warnings (shown below). Also fixing a related logging bug where pci_power_t is cast to unsigned (can be negative, i.e. PCI_POWER_ERROR

[PATCH] staging: rtlwifi: remove duplicated macros in comments

Removing a comment that duplicates definitions for pci_power_t enumeration, and pointing to the relevant header file (current comment is also missing PCI_POWER_ERROR). Signed-off-by: Matthew Giassa --- drivers/staging/rtlwifi/pci.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions

[PATCH] staging: irda: resolve sparse errors due to implicit pci_power_t casts

pci_power_t [usertype] current_state drivers/staging/irda/drivers//vlsi_ir.c:1748:29:got int [signed] [usertype] event Warnings no longer present. Signed-off-by: Matthew Giassa --- drivers/staging/irda/drivers/vlsi_ir.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH] staging: wlan-ng: resolve sparse Endianness issue.

] [usertype] link_status_new drivers/staging//wlan-ng/prism2sta.c:1450:29:got restricted __le16 [usertype] linkstatus Error no longer present. Signed-off-by: Matthew Giassa --- drivers/staging/wlan-ng/prism2sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

* Matthew Giassa [2017-05-12 05:57:44 -0700]: * Greg KH [2017-05-12 11:30:08 +0200]: On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: +#defineREG_INT_MIG_8723B 0x0304 /* Interrupt Migration */ +#defineREG_BCNQ_DESA_8723B 0x0308

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

* Greg KH [2017-05-12 11:30:08 +0200]: On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: +#defineREG_INT_MIG_8723B 0x0304 /* Interrupt Migration */ +#defineREG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address

[PATCH 1/4] staging: rtl8723bs: checkpatch - remove multiple blank lines

Resolving checkpatch issue: CHECK: Please don't use multiple blank lines All instances resolved. --- drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_spec.h b/drivers/staging/rtl8723bs/include/rtl

[PATCH 3/4] staging: rtl8723bs: checkpatch - fix typos in comments

Resolving checkpatch issue: CHECK: 'Regsiter' may be misspelled - perhaps 'Register'? CHECK: 'Interrup' may be misspelled - perhaps 'Interrupt'? All instances resolved. --- drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) di

[PATCH 2/4] staging: rtl8723bs: checkpatch - remove mixed spaces/hard-tabs

Resolving checkpatch issue: WARNING: please, no space before tabs All instances resolved. --- drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 30 +++ 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_spec.h b/driver

[PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

Resolving checkpatch issue: WARNING: line over 80 characters Consolidated indentation so local blocks of macros are column-aligned. Slight slight change to make indentation more readable, assuming a 8-space hard-tab indentation style. --- drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 262 ++

[PATCH 0/4] staging: rtl8723bs: resolve checkpatch issues

This set of patches resolves a large number of non-functional issues reported by checkpatch for the following header: drivers/staging/rtl8723bs/include/rtl8723b_spec.h *Typos in comments *Indentation consistency (original code not formatted for 8-wide hard-tabs) and 80+ column width lines. *Mul

[PATCH] staging: android: ion: Resolve minor indentation issue.

, +unsigned long size) Signed-off-by: Matthew Giassa --- drivers/staging/android/ion/ion_carveout_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion

Re: [PATCH 0/3] staging: ccree: resolve checkpatch issues.

* Matthew Giassa [2017-05-06 15:46:53 -0700]: Included is a set of small fixes to resolve all outstanding checkpatch warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic (training whitespace and 80+ character comment), and the other is functional (macro argument previously not

[PATCH 2/3] staging: ccree: resolve columns over 80 chars in cc_hal.h

Modified comment to resolve 80+ characters warning from checkpatch. ie: WARNING: line over 80 characters Warnings no longer present after change. Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 3/3] staging: ccree: resolve possible macro issue in cc_hal.h

Wrapping "offset" in macro definition to resolve checkpatch issue, ie: CHECK: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 5 +++-- 1 file changed, 3 insertions(+)

[PATCH 0/3] staging: ccree: resolve checkpatch issues.

Included is a set of small fixes to resolve all outstanding checkpatch warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic (training whitespace and 80+ character comment), and the other is functional (macro argument previously not wrapped in parentheses).

[PATCH 1/3] staging: ccree: resolve training whitespace in cc_hal.h

Removing trailing newlines reported by checkpatch.pl. ie: ERROR: trailing whitespace (lines 3, 7, 12). Warnings no longer present after change. Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

* Dan Carpenter [2017-03-21 15:55:52 +0300]: On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: Resolving 2 checkpatch warnings generated due to: CHECK: spaces preferred around that '-' Signed-off-by: Matthew Giassa --- drivers/staging/vt6656/rf.c | 6 +++--- 1 file

[PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

Resolving 2 checkpatch warnings generated due to: CHECK: spaces preferred around that '-' Signed-off-by: Matthew Giassa --- drivers/staging/vt6656/rf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/

[PATCH] staging: vt6656: rf.c: resolve all checkpatch issues.

These patches address a few outstanding checkpatch warnings/errors in rf.c, mainly due to space/indentation (style) issues. --- drivers/staging/vt6656/rf.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) ---

[PATCH 1/2] staging: vt6656: rf.c: alignment should match open parentheses

Resolving 5 instances of checkpatch error/warning statements generated due to: ERROR: code indent should use tabs where possible CHECK: Alignment should match open parenthesis Signed-off-by: Matthew Giassa --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6 insertions(+), 5

[PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

Removing mixed spaces/hard-tabs used to create a "column alignment" of macro names and macro values. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h

[PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.

Re-aligning function parameters in function prototypes by inserting additional hard-tabs to resolve a checkpatch warning. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010

[PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all checkpatch warnings and errors for the file. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 64

[PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space

Removing trailing white space characters in comments to resolve a checkpatch warning. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010

[PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes

The following patches address all outstanding checkpatch warnings/errors present in drivers/staging/ks7010/ks_wlan_ioctl.h. This change set has been rebased off of the current master (69eea5a4ab9c705496e912b55a9d312325de19e6) as per an earlier request, and the change log formatting has been slight

Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

* Tobin C. Harding [2017-03-15 14:14:08 +1100]: On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote: Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all checkpatch warnings and

[PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space

Removing trailing white space characters in comments to resolve a checkpatch warning. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010

[PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all checkpatch warnings and errors for the file. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 64

[PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

Removing mixed spaces/hard-tabs used to create a "column alignment" of macro names and macro values. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h

[PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.

Re-aligning function parameters in function prototypes by inserting additional hard-tabs to resolve a checkpatch warning. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010

[PATCH 1/2] Formatting updates to remove checkpatch warnings in ks_wlan_ioctl.h.

Implementing some minor formatting changes to remove checkpatch warnings. Removing space-hardtab instances. Removing C++-style line comments in favor of C-style equivalent. Re-aligning function prototype arguments to remove related checkpatch warning. Signed-off-by: Matthew Giassa --- drivers

[PATCH 2/2] Formatting updates to resolve checkpatch errors in ks_wlan_ioctl.h.

Updating macros to be wrapped in parentheses to accomodate checkpatch errors throughout the header. This change, combined with the previous patch, resolves all outstanding warnings/errors produce by checkpatch. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 66

[PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch.

--- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 0aa402d..9f71f01 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks701

[PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors).

--- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 9f71f01..adc935d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks

[PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses.

--- drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 8e62b10..47c8015 100644 --- a/drivers/staging/ks7010/ks_wlan_io

[PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h

Assembling a set of patches to address all outstanding checkpatch issues in staging/drivers/ks7010/ks_wlan_ioctl.h to replace my earlier v2 work which attempted to do all of this in a single patch. This includes wrapping macros with complex values in parentheses, removing extraneous/mixed whitespac

[PATCHv3 2/4] Removing trailing whitespace in comment block.

--- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 47c8015..0aa402d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks

[PATCHv2] Checkpatch fixes for staging/drivers/ks7010.

Wrapping complex macros with parentheses. Adding extra spaces between macros and integer literals. Indentation changes to remove checkpatch warnings. Swapping out C++-style comments with C-style comments. Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 74

Re: [PATCH] staging/ks7010: formatting updates.

* Joe Perches [2017-02-21 10:47:31 -0800]: On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > The first declaration fit nicely on a single line. > The second one indeed has a few spaces instead of TABs in the > continuation

Re: [PATCH] staging/ks7010: formatting updates.

proposed fix be? A combination of spaces and hard-tabs? I don't see checkpatch complaining about it, so that could work too. -- -Matthew Giassa e:

Re: [PATCH] staging/ks7010: formatting updates.

* Geert Uytterhoeven [2017-02-21 08:59:18 +0100]: Hi Geert, On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa wrote: Please pardon the earlier e-mail which was missing the changelog text. This line should be between the "---" and the diffstat below. Thank you. Some additi

[PATCH] staging/ks7010: formatting updates.

Please pardon the earlier e-mail which was missing the changelog text. Wrapping complex macros with parentheses to remove checkpatch errors. Some additional style changes to appease checkpatch. --- drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +- 1 file changed, 41

[PATCH] *Updating complex macros for checkpatch.

Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +- 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 84554b6..00eec18 100644 --- a

[PATCH: KS7010 Update complex macros] *Wrapping complex macros with parentheses. *Formatting changes to comply with checkpatch.

Signed-off-by: Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +- 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 84554b6..00eec18 100644 --- a