[PATCH] mac80211: fix regression where EAPOL frames were sent in plaintext

2020-10-19 Thread Mathy Vanhoef
d") Reported-by: Thomas Deutschmann Tested-by: Christian Hesse Tested-by: Thomas Deutschmann Signed-off-by: Mathy Vanhoef --- net/mac80211/tx.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 8ba10a48d..55b41167a 100644 ---

Re: [Regression 5.9][Bisected 1df2bdba528b] Wifi GTK rekeying fails: Sending of EAPol packages broken

2020-10-17 Thread Mathy Vanhoef
I've managed to reproduce the issue, or at least a related issue. Can you try the draft patch below and see if that fixes it? [PATCH] mac80211: fix regression where EAPOL frames were sent in plaintext When sending EAPOL frames via NL80211 they are treated as injected frames in mac80211. Due to co

Re: [Regression 5.9][Bisected 1df2bdba528b] Wifi GTK rekeying fails: Sending of EAPol packages broken

2020-10-16 Thread Mathy Vanhoef
> I now finished bisecting the kernel and > 1df2bdba528b5a7a30f1b107b6924aa79af5e00e [1] is the first bad commit: > >> commit 1df2bdba528b5a7a30f1b107b6924aa79af5e00e >> Author: Mathy Vanhoef >> Date:   Thu Jul 23 14:01:48 2020 +0400 >> >>     mac80211: never drop injected frames even if normall

[PATCH] brcmfmac: kill URB when request timed out

2014-11-12 Thread Mathy Vanhoef
Kill the submitted URB in brcmf_usb_dl_cmd if the request timed out. This assures the URB is never submitted twice. It also prevents a possible use-after-free of the URB transfer buffer if a timeout occurs. Signed-off-by: Mathy Vanhoef --- For a discussion about this patch and the underlying

Re: [PATCH] brcmfmac: unlink URB when request timed out

2014-11-11 Thread Mathy Vanhoef
On 11/10/2014 04:08 AM, Oliver Neukum wrote: > On Sun, 2014-11-09 at 13:10 -0500, Mathy Vanhoef wrote: >> From: Mathy Vanhoef >> >> Unlink the submitted URB in brcmf_usb_dl_cmd if the request timed out. This >> assures the URB is never submitted twice, preventing a dri

[PATCH] brcmfmac: unlink URB when request timed out

2014-11-09 Thread Mathy Vanhoef
From: Mathy Vanhoef Unlink the submitted URB in brcmf_usb_dl_cmd if the request timed out. This assures the URB is never submitted twice, preventing a driver crash. Signed-off-by: Mathy Vanhoef --- Currently brcmfmac may crash when a USB device is attached (tested with a LG TWFM-B003D). In