Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-20 Thread Martyn Welch
for "RPROC_DETACHED" in k3_m4_rproc_unprepare() function. This driver has been upstream for 9 whole months, it is hard for me to believe this but was just noticed.  Martyn from Collabora should be CC'ed on this, and I will also need the required R-b/T-b tags. Cc: Martyn Welch martyn.

Re: [GIT PULL] remoteproc updates for v6.12

2024-09-25 Thread Martyn Welch
On Tue, 2024-09-24 at 12:31 -0700, Linus Torvalds wrote: > On Mon, 23 Sept 2024 at 21:44, Bjorn Andersson > wrote: > > > > remoteproc updates for v6.12 > > Grr. I didn't immediately notice this new Kconfig warning, so now > it's > in my tree: > >   WARNING: unmet direct dependencies detected fo

Re: [PATCH] remoteproc: k3: Call of_node_put(rmem_np) only once in three functions

2024-09-24 Thread Martyn Welch
s. > Thus call such a function only once instead directly before the > checks. > > This issue was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring reviewed-by: Martyn Welch > --- >  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 6 ++ >

Re: [PATCH] mailbox, remoteproc: omap2+: fix compile testing

2024-09-12 Thread Martyn Welch
bcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for > M4F subsystem") > Signed-off-by: Arnd Bergmann > --- >  drivers/mailbox/Kconfig    |  2 +- >  drivers/mailbox/omap-mailbox.c |  2 +- >  drivers/remoteproc/Kconfig | 10 -- >  3 files changed, 6

[PATCH v4 2/2] iio: light: noa1305: Add support for NOA1305

2019-08-02 Thread Martyn Welch
a1305_id); + +static struct i2c_driver noa1305_driver = { + .driver = { + .name = NOA1305_DRIVER_NAME, + .of_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH v4 1/2] dt-bindings: Add binding document for NOA1305

2019-08-02 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes: v2: Same as v1. v3: Same as v2. v4: Same as v3. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44

[PATCH v3 2/2] iio: light: noa1305: Add support for NOA1305

2019-07-26 Thread Martyn Welch
+}; +MODULE_DEVICE_TABLE(of, noa1305_of_match); + +static const struct i2c_device_id noa1305_ids[] = { + { "noa1305", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, noa1305_id); + +static struct i2c_driver noa1305_driver = { + .driver = { + .name = NOA1305_DRIVER_NAME, + .of_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .remove = noa1305_remove, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH v3 1/2] dt-bindings: Add binding document for NOA1305

2019-07-26 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes: v2: Same as v1. v3: Same as v2. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create

[PATCH v2 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- Changes: v2: Same as v1. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
f_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .remove = noa1305_remove, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
From: Martyn Welch This driver adds the initial support for the ON Semiconductor NOA1305 Ambient Light Sensor. Originally written by Sergei Miroshnichenko. Found here: https://github.com/EmcraftSystems/linux-upstream/commit/196d6cf897e632d2cb82d45484bd7a1bfdd5b6d9 Signed-off-by: Sergei M

[PATCH 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/noa1305.yaml

Re: [PATCH] ARM: dts: am335x: Add support for Bosch Guardian

2019-02-12 Thread Martyn Welch
On Tue, 2019-02-12 at 10:49 -0800, Tony Lindgren wrote: > Hi, > > * Martyn Welch [190211 04:27]: > > The Bosch Guardian is a TI am335x based device. > > > > It's hardware specifications are as follows: > > > > * 256 MB DDR3 memory > >

[PATCH] ARM: dts: am335x: Add support for Bosch Guardian

2019-02-11 Thread Martyn Welch
The Bosch Guardian is a TI am335x based device. It's hardware specifications are as follows: * 256 MB DDR3 memory * 512 MB NAND Flash * USB OTG * RS232 * MicroSD external storage * LCD Display interface Signed-off-by: Martyn Welch --- arch/arm/boot/dts/Makefile

[PATCH v3 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-21 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- Changes in v3: -

[PATCH v3 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2019-01-21 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes in v3: - Add full stop to denote abbreviation. Changes in v2: None Documentation/devicetree/bindings/vendor-prefix

Re: [PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-21 Thread Martyn Welch
Hi Fabio, On Fri, 2019-01-18 at 19:18 -0200, Fabio Estevam wrote: > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin- > > full.dts b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > > new file mode 100644 > > index ..83cdf4fa10c0 > > --- /dev/null > > +++ b/arch/arm

[PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2019-01-18 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes in v2: None Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) di

[PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-18 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- Changes in v2: - Correct

[PATCH 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2018-12-11 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefi

[PATCH 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2018-12-11 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- arch/arm/boot/dt

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Martyn Welch
On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case.  I think "unnecessary" is overly kind, > it does seem to be a

Re: [PATCH] vme: ca91cx42: remove redundant variable i

2018-07-14 Thread Martyn Welch
et-variable] > > Signed-off-by: Colin Ian King Reviewed-by: Martyn Welch > --- > drivers/vme/bridges/vme_ca91cx42.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vme/bridges/vme_ca91cx42.c > b/drivers/vme/bridges/vme_ca91cx42.c > index 5dd

Re: [PATCH] MAINTAINERS: Update E-mail address

2018-07-10 Thread Martyn Welch
On Tue, 2018-07-10 at 16:47 +0200, Peter Senna Tschudin wrote: > Update my E-mail address on MAINTAINERS file. > > Signed-off-by: Peter Senna Tschudin Acked-by: Martyn Welch > --- >  MAINTAINERS | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > di

[PATCH v2] ahci: imx: Handle increased read failures for IMX53 temperature sensor in low frequency mode.

2017-11-13 Thread Martyn Welch
Starkov Signed-off-by: Martyn Welch --- v2: - Correct spelling issues in cover letter. drivers/ata/ahci_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c index 787567e..a58bcc0 100644 --- a/drivers/ata/ahci_imx.c +++ b

[PATCH] staging: VME: Remove PIO2 driver

2017-10-24 Thread Martyn Welch
The PIO2 device is (as far as I know) no longer manufactured. I no longer have access to the device and this seems unlikely to change. The only changes to this driver in a long time have been as a result of API changes else where. Time to remove it... Signed-off-by: Martyn Welch --- drivers

[PATCH] VME: Return -EBUSY when DMA list in use

2017-10-23 Thread Martyn Welch
From: Martyn Welch The VME subsystem currently returns -EBUSY when trying to free a DMA resource that is busy, but returns -EINVAL when trying to free a DMA list that is in use. Switch to returning -EBUSY when trying to free a DMA list that is in use for consistency and correctness. Signed-off

[PATCH] MAINTAINERS: Update VME subsystem tree.

2017-10-23 Thread Martyn Welch
VME Subsystem lists driver-core repository as canonical tree. Greg has stated that char-misc should be used for submissions instead[1]. [1] https://lkml.org/lkml/2017/9/1/486 Signed-off-by: Martyn Welch --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-20 Thread Martyn Welch
On Fri, 2017-10-20 at 14:30 +, Steve Twiss wrote: > Hi Martyn, > > On 19 October 2017 16:52, Martyn Welch wrote: > > > To: Support Opensource; Jean Delvare; Guenter Roeck > > Subject: [PATCH] hwmon: da9052 Increase sample rate when using TSI > > > > Th

[PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-19 Thread Martyn Welch
-by: Martyn Welch --- drivers/hwmon/da9052-hwmon.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hwmon/da9052-hwmon.c b/drivers/hwmon/da9052-hwmon.c index 97a62f5..a973eb6 100644 --- a/drivers/hwmon/da9052-hwmon.c +++ b/drivers/hwmon/da9052-hwmon.c @@ -477,6 +477,11 @@ static

Re: [GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-14 Thread Martyn Welch
On Sat, 2017-10-14 at 14:08 +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 13, 2017 at 10:09:19PM +0100, Martyn Welch wrote: > > The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: > > > > Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) > > &

[GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-13 Thread Martyn Welch
The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.14-rc4 for you to fetch changes up to a75dc630086a6b83d780a7b27d03c4c

[PATCH v2] serial: imx: Correct comment imx_flush_buffer()

2017-10-04 Thread Martyn Welch
The comment in imx_flush_buffer() states that the state of 4 registers are to be saved/restored, then only saves and restores 3 registers. The missing register (UBRC) is read only and thus can't be restored. Update the comment to reflect reality. Signed-off-by: Martyn Welch --- v2: R

Re: [PATCH] serial: imx: Correct comment imx_flush_buffer()

2017-10-04 Thread Martyn Welch
On Tue, 2017-10-03 at 20:27 +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 29, 2017 at 10:22:19AM +0100, Martyn Welch wrote: > > The comment in imx_flush_buffer() states that the state of 4 registers > > are to be saved/restored, then only saves and restores 3 registers. The >

[PATCH] serial: imx: Correct comment imx_flush_buffer()

2017-09-29 Thread Martyn Welch
The comment in imx_flush_buffer() states that the state of 4 registers are to be saved/restored, then only saves and restores 3 registers. The missing register (UBRC) is read only and thus can't be restored. Update the comment to reflect reality. Signed-off-by: Martyn Welch --- driver

[PATCH] serial: imx: Switch setting dma_is_txing from "false" to "0"

2017-09-28 Thread Martyn Welch
The variable "dma_is_txing" is an unsigned int, set as either "0" or "1" in all but one location, where it is instead set to "false". For consistency, set dma_is_txing to "0" in this location too. Signed-off-by: Martyn Welch --- drivers/tty/seri

[PATCH v2] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
. Signed-off-by: Martyn Welch Acked-by: Uwe Kleine-König --- v2: Add missing SoB and Uwe's Acked-by. drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1691ed2..9da109a 100644 --- a/drivers/tty/s

Re: [PATCH] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
On Thu, Sep 28, 2017 at 12:00:19PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 28, 2017 at 10:52:15AM +0100, Martyn Welch wrote: > > The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then > > uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe &g

[PATCH] serial: imx: only set dma_is_rxing when DMA starts

2017-09-28 Thread Martyn Welch
thout enabling DMA. Currently this will result in dma_is_rxing suggesting that DMA is being used for recieving. To avoid these issues, move the setting of dma_is_rxing to start_rx_dma() when appropriate. Signed-off-by: Romain Perier Signed-off-by: Martyn Welch Reviewed-by: Uwe Kleine-König ---

[PATCH] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe the length of the buffer when initialising the scatter gather list. In order to ensure that this stays consistent, use RX_BUF_SIZE in both locations. --- dr

Re: [PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from imx_disable_dma

2017-09-21 Thread Martyn Welch
On Thu, Sep 21, 2017 at 08:20:17PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 21, 2017 at 05:18:12PM +0100, Martyn Welch wrote: > > From: Nandor Han > > > > The CTSC and CTS bits affect operation of the CTS/RTS hardware flow > > control signal (depending on whether

[PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from imx_disable_dma

2017-09-21 Thread Martyn Welch
to imx_port_rts_active() and imx_port_rts_inactive(). This configuration of the CTSC and CTS bits are therefore not needed. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[PATCH v3 0/6] serial: imx: various improvements

2017-09-21 Thread Martyn Welch
During shutdown when a userspace service is disabled (which generates an uart close), we got kernel crashes in the imx serial driver : [ 1257.657423] Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0938000 [ 1257.665122] pgd = ecf2 [ 1257.667838] [f0938000] *pgd=de819811, *pte

[PATCH v3 4/6] serial: imx: unmap sg buffers when DMA channel is released

2017-09-21 Thread Martyn Welch
-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 2fb3210..ed02783 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -357,6 +357,12 @@ static void

[PATCH v3 3/6] serial: imx: Simplify DMA disablement

2017-09-21 Thread Martyn Welch
From: Nandor Han This commits simplify the function imx_disable_dma() by moving the code for disabling RX and TX DMAs to dedicated functions. This is a preparation for the next commit. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial

[PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA starts

2017-09-21 Thread Martyn Welch
thout enabling DMA. Currently this will result in dma_is_rxing suggesting that DMA is being used for recieving. To avoid these issues, move the setting of dma_is_rxing to start_rx_dma() when appropriate. Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 3 +

[PATCH v3 5/6] serial: imx: update the stop rx,tx procedures

2017-09-21 Thread Martyn Welch
isable the interrupts related to that. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/

[PATCH v3 6/6] serial: imx: Fix imx_shutdown procedure

2017-09-21 Thread Martyn Welch
. This disables RX and TX blocks, then it disabled interrupts. In case DMA is enabled, it disables DMA and free corresponding resources. It disables UART port and stop clocks. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 34

Re: [PATCH] staging:vme Fix use BIT macro

2017-09-21 Thread Martyn Welch
On 21 September 2017 at 06:52, Janani Sankara Babu wrote: > This patch is created to solve the following warning shown by the checkpatch > script Warning: Replace all occurences of (1< > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/vme/devices/vme_pio2.h | 6 +++--- > 1 file change

Re: [PATCH v2 3/6] serial: imx: remove CTSC and CTS handling

2017-09-15 Thread Martyn Welch
Hi On Wed, Jul 05, 2017 at 03:38:45PM +0200, Uwe Kleine-König wrote: > Cc += Clemens Gruber + Fabio Estevam > > On Wed, Jul 05, 2017 at 03:07:03PM +0200, Romain Perier wrote: > > From: Nandor Han > > > > CTSC and CTS are not related to DMA and might add > > disruption in some cases. > > > > Si

Re: [PATCH v6 2/2] ARM: dts: imx53: Add GE Healthcare PPD

2017-09-13 Thread Martyn Welch
On Fri, 2017-08-18 at 16:53 +0100, Martyn Welch wrote: > From: Fabien Lahoudere > > PPD is a product from GE Healthcare to monitor vital biometric signals. > > Signed-off-by: Fabien Lahoudere > Signed-off-by: Sebastian Reichel > Signed-off-by: Martyn Welch > Re

[GIT PULL] VME Subsystem patches for 4.13-rc7

2017-09-01 Thread Martyn Welch
The following changes since commit 0f9b011d3321ca1079c7a46c18cb1956fbdb7bcb: driver core: bus: Fix a potential double free (2017-08-31 18:57:30 +0200) are available in the git repository at: https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.13-rc7 for you to fetch changes up to

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

2017-08-30 Thread Martyn Welch
On 26 August 2017 at 08:00, SF Markus Elfring wrote: >>> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const >>> struct pci_device_id *id) >>> master_num--; >>> >>> tsi148_device->flush_image = >>> -kmalloc(sizeof(struct vme_mast

Re: [PATCH 00/14] VME: Adjustments for several function implementations

2017-08-25 Thread Martyn Welch
On Fri, Aug 25, 2017 at 05:41:13PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 25 Aug 2017 13:15:43 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (14): > Delete 11 error messages for a failed memory a

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

2017-08-25 Thread Martyn Welch
On Fri, Aug 25, 2017 at 06:15:08PM +0200, SF Markus Elfring wrote: > @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const > struct pci_device_id *id) > master_num--; > > tsi148_device->flush_image = > - kmalloc(sizeof(struct

[PATCH v6 0/2] Add device tree and associated documentation for GE Healthcare PPD

2017-08-18 Thread Martyn Welch
This series adds the device tree for the GE Healthcare PPD and binding documentation for the ge-achc, as used by the PPD device tree. Fabien Lahoudere (1): ARM: dts: imx53: Add GE Healthcare PPD Martyn Welch (1): dt-bindings: misc: achc: Add device tree binding for GE ACHC Documentation

[PATCH v6 2/2] ARM: dts: imx53: Add GE Healthcare PPD

2017-08-18 Thread Martyn Welch
From: Fabien Lahoudere PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere Signed-off-by: Sebastian Reichel Signed-off-by: Martyn Welch Reviewed-by: Fabio Estevam --- Changes since PATCHv5: https://patchwork.kernel.org/patch/9852327

[PATCH v6 1/2] dt-bindings: misc: achc: Add device tree binding for GE ACHC

2017-08-18 Thread Martyn Welch
Add Device Tree binding document for GE Healthcare USB Management Controller (ACHC). Signed-off-by: Martyn Welch --- Documentation/devicetree/bindings/misc/ge-achc.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/ge

[PATCH v5] ARM: dts: imx53: Add GE Healthcare PPD

2017-07-19 Thread Martyn Welch
From: Fabien Lahoudere PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere Signed-off-by: Sebastian Reichel Signed-off-by: Martyn Welch --- Changes since PATCHv4: https://patchwork.kernel.org/patch/9834733/ - actually remove fsl,mode node

[PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD

2017-07-11 Thread Martyn Welch
From: Fabien Lahoudere PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere Signed-off-by: Sebastian Reichel Signed-off-by: Martyn Welch --- Changes since PATCHv3: https://patchwork.kernel.org/patch/9819017/ - licensing modified

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-03-02 Thread Martyn Welch
On Wed, Mar 01, 2017 at 02:30:31PM +0100, Benjamin Tissoires wrote: > Hi, > > On Feb 28 2017 or thereabouts, Martyn Welch wrote: > > This patch has been sitting on the list for about 2 weeks. Is there > > anything wrong with this patch? > > The only wrong thing with t

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-02-28 Thread Martyn Welch
This patch has been sitting on the list for about 2 weeks. Is there anything wrong with this patch? Thanks, Martyn On Tue, Feb 14, 2017 at 02:17:56PM +, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which i

[PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-02-14 Thread Martyn Welch
ts in a mouse cursor being displayed in Weston. This patch adds a special driver for the device to correct the capabilities reported. Signed-off-by: Martyn Welch --- drivers/hid/Kconfig | 12 +++ drivers/hid/Makefile| 1 + drivers/hid/

Re: VME: devices not removed after commit 050c3d52cc7

2017-01-18 Thread Martyn Welch
On Fri, Jan 13, 2017 at 05:28:37PM +0100, Stefano Babic wrote: > Hi Paul, > > On 13/01/2017 16:39, Paul Gortmaker wrote: > > [Adding Martyn to Cc] > > > > Sorry, I forgot to run get_maintainer before posting :-) > No worries, and sorry for the delay, this ended up in my spam filter :-/ > > [V

Re: [PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get

2017-01-11 Thread Martyn Welch
eger of different size [-Wpointer-to-int-cast] > *pci_base = (dma_addr_t)vme_base + pci_offset; > > Signed-off-by: Augusto Mecking Caringi Acked-By: Martyn Welch > --- > drivers/vme/bridges/vme_ca91cx42.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [PATCH v2] [STYLE]staging:vme:vme_user.c Correct spelling mistakes

2016-11-14 Thread Martyn Welch
On Sun, Nov 13, 2016 at 08:28:34PM -0500, Walt Feasel wrote: > Make spelling corrections for 'correctly' and > 'unregister'. > > Signed-off-by: Walt Feasel Acked-by: Martyn Welch > --- > > Removed the previously submitted U.S. spelling for > &#

Re: [PATCH] vme: fake: mark symbols static where possible

2016-09-23 Thread Martyn Welch
x27;fake_vmewrite32' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xi

Re: [PATCH] vme: fake: fix build for 64-bit dma_addr_t

2016-09-08 Thread Martyn Welch
make this clearer while fixing the warning, I'm adding > a set of helper functions for the type conversion. > > Signed-off-by: Arnd Bergmann Acked-by: Martyn Welch > --- > drivers/vme/bridges/vme_fake.c | 26 ++ > 1 file changed, 18 insertions(+),

Re: [PATCH V4 2/4] Documentation/devicetree/bindings: b850v3_lvds_dp

2016-08-16 Thread Martyn Welch
On 04/08/16 23:36, Peter Senna Tschudin wrote: Devicetree bindings documentation for the GE B850v3 LVDS/DP++ display bridge. Cc: Javier Martinez Canillas Cc: Enric Balletbo i Serra Cc: Philipp Zabel Cc: Rob Herring Cc: Fabio Estevam Signed-off-by: Peter Senna Tschudin Acked-by: Martyn

Re: [PATCH V4 1/4] drm/imx-ldb: Add support to drm-bridge

2016-08-16 Thread Martyn Welch
was necessary to allow the panel ddc code to run only when the imx_ldb is not attached to a bridge. Cc: Enric Balletbo i Serra Cc: Philipp Zabel Cc: Rob Herring Cc: Fabio Estevam Cc: David Airlie Cc: Thierry Reding Cc: Thierry Reding Signed-off-by: Peter Senna Tschudin Acked-by: Martyn

Re: [PATCH v3] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-28 Thread Martyn Welch
On 28/07/16 11:37, Enric Balletbo i Serra wrote: This patch adds and entry to the sysfs to start firmware upload process on the specified device with the requested firmware. The uploading of the firmware needs only to happen once per firmware upgrade, as the firmware is stored in persistent st

Re: [PATCH 2/2] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-07-18 Thread Martyn Welch
Few comments inline On 17/06/16 11:52, Enric Balletbo i Serra wrote: This patch adds and entry to the sysfs to start firmware upload process on the specified device with the requested firmware. The uploading of the firmware needs only to happen once per firmware upgrade, as the firmware is stor

Re: [PATCH] vme: make core vme support explicitly non-modular

2016-07-07 Thread Martyn Welch
, we don't have any ".suppress_bind_attrs" to be concerned about when we drop the ".remove" code from this file. Since module_init was not in use by this code, the init ordering remains unchanged with this commit. Cc: Martyn Welch Cc: Manohar Vanga Cc: Greg Kroah-Hart

[PATCH] vme: Update documentation to match api

2016-06-05 Thread Martyn Welch
The vme_register_driver() api changed in commit 5d6abf379d73 ("staging: vme: make match() driver specific to improve non-VME64x support") but the documentation wasn't updated. Update the documentation to match the API. Signed-off-by: Martyn Welch --- Documentation/vme_api.txt |

Re: [PATCH] staging: vme: fix bare use of 'unsigned'

2016-04-03 Thread Martyn Welch
On 31/03/16 23:53, Clifton Barnes wrote: fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned'' Signed-off-by: Clifton Barnes Acked-by: Martyn Welch Greg: Whilst this patch seems valid and compiles fine, I no longer have access t

[PATCH] Rename "trigger" reset reason "hw watchdog"

2016-02-26 Thread Martyn Welch
;s own hardware watchdog, has been reset because the hardware watchdog has triggered. Renaming to "hw watchdog". Signed-off-by: Martyn Welch --- drivers/watchdog/ziirave_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/wat

Re: [PATCH] USB: cp210x: add IDs for GE B650V3 and B850V3 boards

2016-02-05 Thread Martyn Welch
On 01/02/16 19:57, Akshay Bhat wrote: From: Ken Lin Add USB ID for cp2104/5 devices on GE B650v3 and B850v3 boards. Signed-off-by: Ken Lin Signed-off-by: Akshay Bhat Acked-by: Martyn Welch --- drivers/usb/serial/cp210x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [PATCH 8/9] vme: vme_ca91cx42.c: use to_pci_dev()

2015-12-27 Thread Martyn Welch
On 27/12/15 10:46, Geliang Tang wrote: Use to_pci_dev() instead of open-coding it. Signed-off-by: Geliang Tang Acked-by: Martyn Welch --- drivers/vme/bridges/vme_ca91cx42.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/vme/bridges/vme_ca91cx42

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-16 Thread Martyn Welch
On 11/12/15 09:08, Linus Walleij wrote: On Fri, Dec 4, 2015 at 6:31 PM, Martyn Welch wrote: Select Chromebooks have gpio attached to switches used to cause the firmware to enter alternative modes of operation and/or control other device characteristics (such as write protection on flash

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-07 Thread Martyn Welch
On 07/12/15 17:37, Rob Herring wrote: +Linus W On Fri, Dec 04, 2015 at 05:31:13PM +, Martyn Welch wrote: This patch adds documentation for the gpio-switch binding. This binding provides a mechanism to bind named links to gpio, with the primary purpose of enabling standardised access to

Re: [PATCH 2/3] Add support for monitoring gpio switches

2015-12-05 Thread Martyn Welch
On 04/12/15 18:57, Greg Kroah-Hartman wrote: On Fri, Dec 04, 2015 at 05:31:14PM +, Martyn Welch wrote: Select Chromebooks have gpio attached to switches used to cause the firmware to enter alternative modes of operation and/or control other device characteristics (such as write protection

Add support for monitoring gpio switches

2015-12-04 Thread Martyn Welch
This driver was written to expose a read only interface to a number of gpios on Chromebooks. These gpios are attached to signals which cause the firmware on Chromebooks to enter alternative modes of operation and/or control other device characteristics (such as write protection on flash devices). I

[PATCH 2/3] Add support for monitoring gpio switches

2015-12-04 Thread Martyn Welch
read from user space. This functionality has been generalised to provide support for any device with device tree support which needs to identify a gpio as being used for a specific task. Signed-off-by: Martyn Welch --- drivers/misc/Kconfig | 11 drivers/misc/Makefile | 1

[PATCH 1/3] Device tree binding documentation for gpio-switch

2015-12-04 Thread Martyn Welch
: Martyn Welch --- .../devicetree/bindings/misc/gpio-switch.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/gpio-switch.txt diff --git a/Documentation/devicetree/bindings/misc/gpio-switch.txt b/Documentation

[PATCH 3/3] ARM: dts: Addition of binding for gpio switches on peach-pi

2015-12-04 Thread Martyn Welch
user space. Signed-off-by: Martyn Welch --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 46 +++ 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 49a4f43..2937372 100644 --- a/arch

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-03 Thread Martyn Welch
On 03/12/15 15:08, Rob Herring wrote: On Thu, Dec 3, 2015 at 4:14 AM, Martyn Welch wrote: On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-03 Thread Martyn Welch
On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-02 Thread Martyn Welch
On 02/12/15 18:44, Rob Herring wrote: On Wed, Dec 2, 2015 at 10:49 AM, Martyn Welch wrote: On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel

Re: [PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-02 Thread Martyn Welch
On 02/12/15 15:15, Rob Herring wrote: On Tue, Dec 01, 2015 at 07:12:49PM +, Martyn Welch wrote: This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off

[PATCH v3] Add support for monitoring Chrome OS firmware signals

2015-12-02 Thread Martyn Welch
from user space. Cc: Jeremiah Mahler Signed-off-by: Martyn Welch --- v2: - Added missing call to remove sysfs link. v3: - Correct malloc sizeof() usage. drivers/platform/chrome/Kconfig | 13 +++ drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome

Re: [PATCH v2] Add support for monitoring Chrome OS firmware signals

2015-12-02 Thread Martyn Welch
On 02/12/15 06:08, Jeremiah Mahler wrote: Martyn, On Tue, Dec 01, 2015 at 08:19:46PM +, Martyn Welch wrote: Select Chromebooks have gpio attached to signals used to cause the firmware to enter alternative modes of operation and/or control other device [...] + +static int

Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi

2015-12-02 Thread Martyn Welch
On 01/12/15 23:51, Krzysztof Kozlowski wrote: On 02.12.2015 04:12, Martyn Welch wrote: The peach pi has a GPIO connected to the firmware write protect, developer mode and recovery mode lines. This patch adds the required nodes to the device tree to configure the pinmuxing and allow these to

[PATCH v2] Add support for monitoring Chrome OS firmware signals

2015-12-01 Thread Martyn Welch
from user space. Signed-off-by: Martyn Welch --- v2: - Added missing call to remove sysfs link. drivers/platform/chrome/Kconfig | 13 +++ drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome/chromeos_firmware.c | 166 3 files

Add support for Chrome OS firmware signals

2015-12-01 Thread Martyn Welch
Some Chromebooks have gpio attached to signals used to cause the firmware to enter alternative modes of operation and/or control other device characteristics (such as write protection on flash devices). This patch adds a driver that exposes a read-only interface to allow these signals to be read fr

[PATCH 3/3] Addition of binding for firmware signals on peach-pi

2015-12-01 Thread Martyn Welch
Cc: Kumar Gala Cc: Russell King Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Signed-off-by: Martyn Welch --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 40

[PATCH 2/3] Add support for monitoring Chrome OS firmware signals

2015-12-01 Thread Martyn Welch
from user space. Signed-off-by: Martyn Welch --- drivers/platform/chrome/Kconfig | 13 +++ drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome/chromeos_firmware.c | 156 3 files changed, 170 insertions(+) create mode 100644

[PATCH 1/3] Device tree binding documentation for chromeos-firmware

2015-12-01 Thread Martyn Welch
This patch adds documentation for the chromeos-firmware binding. Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off-by: Martyn Welch --- .../devicetree/bindings/misc/chromeos-firmware.txt | 27 ++ 1

Re: [PATCH] drivers: staging: vme: Fixed code style issues

2015-11-13 Thread Martyn Welch
bracketing from uses of the address operator * Use preferred null return check style Other than that: Acked-by: Martyn Welch Martyn Signed-off-by: Egor Uleyskiy --- drivers/staging/vme/devices/vme_pio2_cntr.c | 2 +- drivers/staging/vme/devices/vme_pio2_core.c | 20

Re: [RFC 0/8] Add support for NVIDIA Tegra XUSB

2015-11-02 Thread Martyn Welch
On 02/11/15 17:27, Andrew Bresticker wrote: Hi Martyn, On Mon, Nov 2, 2015 at 3:55 AM, Martyn Welch wrote: This series is based on commits that can be found in the git tree here: https://github.com/thierryreding/linux/commits/staging/xhci I have included the patches I've used from

Re: [RFC 7/8] Start migrating XUSB away from MFD

2015-11-02 Thread Martyn Welch
On 02/11/15 13:27, Lee Jones wrote: On Mon, 02 Nov 2015, Martyn Welch wrote: On 02/11/15 12:47, Lee Jones wrote: On Mon, 02 Nov 2015, Martyn Welch wrote: Besides, I'm never applying a patch that self confesses to be "hacky in places" into Mainline, ever. As I mentioned befo

  1   2   >